nexthop: Only emit a notification when nexthop is actually deleted
authorIdo Schimmel <idosch@nvidia.com>
Tue, 15 Sep 2020 11:41:02 +0000 (14:41 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Sep 2020 23:31:25 +0000 (16:31 -0700)
commit0695564bb4a24440b38b46bf52465a93a0ca1974
tree4ae4d8377120d3dc037baa5f1ca9c498c825339d
parent80690ec6b595807db9a52ec5b225a2d88033ddb5
nexthop: Only emit a notification when nexthop is actually deleted

Currently, the in-kernel delete notification is emitted from the error
path of nexthop_add() and replace_nexthop(), which can be confusing to
in-kernel listeners as they are not familiar with the nexthop.

Instead, only emit the notification when the nexthop is actually
deleted. The following sub-cases are covered:

1. User space deletes the nexthop
2. The nexthop is deleted by the kernel due to a netdev event (e.g.,
   nexthop device going down)
3. A group is deleted because its last nexthop is being deleted
4. The network namespace of the nexthop device is deleted

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/nexthop.c