drm/i915/gsc: Fix the Driver-FLR completion
authorAlan Previn <alan.previn.teres.alexis@intel.com>
Fri, 24 Feb 2023 00:17:58 +0000 (16:17 -0800)
committerJohn Harrison <John.C.Harrison@Intel.com>
Fri, 3 Mar 2023 01:13:59 +0000 (17:13 -0800)
commit0591bdad58c4b83a286872305e748bfd77d16d28
tree2a9fbc367267b1cade0403c6bf58307eff41fa22
parent3cba09a6ac86ea1d456909626eb2685596c07822
drm/i915/gsc: Fix the Driver-FLR completion

The Driver-FLR flow may inadvertently exit early before the full
completion of the re-init of the internal HW state if we only poll
GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
we need a two-step completion wait-for-completion flow that also
involves GU_CNTL. See the patch and new code comments for detail.
This is new direction from HW architecture folks.

   v2: - Add error message for the teardown timeout (Anshuman)
       - Don't duplicate code in comments (Jani)
   v3: - Add get/put runtime-pm for this function. Though
         not functionally required during unload, its so the uncore
 doesn't complain.
   v4: - Remove the get/put runtime-pm - that was for a prior
         version of this patch (not needed for drm-managed callback).
       - Remove the fixes tag since this is only for MTL and MTL
         still needs force probe (Daniele).
       - Bit 31 of GU_CNTL should be DRIVERFLR instead of
         DRIVERFLR_STATUS (Daniele).

Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Tested-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230224001758.544817-1-alan.previn.teres.alexis@intel.com
drivers/gpu/drm/i915/intel_uncore.c