xfs: push iclog state cleaning into xlog_state_clean_log
authorDave Chinner <dchinner@redhat.com>
Fri, 6 Sep 2019 00:32:52 +0000 (17:32 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 6 Sep 2019 04:36:12 +0000 (21:36 -0700)
commit0383f543d8708ba0738e38c7f530f998256b8190
treebf54b5157458a8562482c1d008ea5f73085b5ebd
parent5e96fa8d2b094c526a57eb4f17396e27010af2db
xfs: push iclog state cleaning into xlog_state_clean_log

xlog_state_clean_log() is only called from one place, and it occurs
when an iclog is transitioning back to ACTIVE. Prior to calling
xlog_state_clean_log, the iclog we are processing has a hard coded
state check to DIRTY so that xlog_state_clean_log() processes it
correctly. We also have a hard coded wakeup after
xlog_state_clean_log() to enfore log force waiters on that iclog
are woken correctly.

Both of these things are operations required to finish processing an
iclog and return it to the ACTIVE state again, so they make little
sense to be separated from the rest of the clean state transition
code.

Hence push these things inside xlog_state_clean_log(), document the
behaviour and rename it xlog_state_clean_iclog() to indicate that
it's being driven by an iclog state change and does the iclog state
change work itself.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_log.c