bus: mhi: host: Drop chan lock before queuing buffers
authorQiang Yu <quic_qianyu@quicinc.com>
Mon, 11 Dec 2023 06:42:52 +0000 (14:42 +0800)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Sat, 16 Dec 2023 05:24:29 +0000 (10:54 +0530)
commit01bd694ac2f682fb8017e16148b928482bc8fa4b
tree1247cd426e4cee168210732d0a2b983ab21ccbd5
parentb89b6a863dd53bc70d8e52d50f9cfaef8ef5e9c9
bus: mhi: host: Drop chan lock before queuing buffers

Ensure read and write locks for the channel are not taken in succession by
dropping the read lock from parse_xfer_event() such that a callback given
to client can potentially queue buffers and acquire the write lock in that
process. Any queueing of buffers should be done without channel read lock
acquired as it can result in multiple locks and a soft lockup.

Cc: <stable@vger.kernel.org> # 5.7
Fixes: 1d3173a3bae7 ("bus: mhi: core: Add support for processing events from client device")
Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Tested-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/1702276972-41296-3-git-send-email-quic_qianyu@quicinc.com
[mani: added fixes tag and cc'ed stable]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/host/main.c