drm/atomic: Print the state every non-blocking commit
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 12:43:01 +0000 (14:43 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 31 Mar 2022 08:19:45 +0000 (10:19 +0200)
commit018ad18f6ab062a198627ec1bd5fd9d797c90238
tree692e2e0f529ced2a40451396f7cd0201d59686ac
parentd049a24b15d8c1c90461933f0526b582a8cdf9b4
drm/atomic: Print the state every non-blocking commit

The DRM_UT_STATE controls whether we're calling
drm_atomic_print_new_state() whenever a new state is committed. However,
that call is made in the drm_mode_atomic_ioctl(), whereas we have
multiple users of the drm_atomic_commit() function in the kernel
(framebuffer emulation, drm_atomic_helper_dirtyfb, etc.).

This leads to multiple states being committed but never actually
displayed even though we asked to have verbose atomic state debugging.

Let's move the call to drm_atomic_print_new_state() to
drm_atomic_commit() to make sure we don't miss any. Non-blocking commits
were never logged though, and it would create too much churn in the logs
to do so, so leave them out for now.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20220328124304.2309418-2-maxime@cerno.tech
drivers/gpu/drm/drm_atomic.c
drivers/gpu/drm/drm_atomic_uapi.c