net: socionext: Fix two sleep-in-atomic-context bugs in ave_rxfifo_reset()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Sat, 15 Sep 2018 04:02:46 +0000 (12:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Sep 2018 02:02:44 +0000 (19:02 -0700)
commit0020f5c807ef67954d9210eea0ba17a6134cdf7d
tree36576ce9cca10d37f4cda781684b39e97d5ef92f
parent5d288b88655d5bea0cf3a42158cb3bf7916587bc
net: socionext: Fix two sleep-in-atomic-context bugs in ave_rxfifo_reset()

The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.17 are:

[FUNC] usleep_range
drivers/net/ethernet/socionext/sni_ave.c, 892:
usleep_range in ave_rxfifo_reset
drivers/net/ethernet/socionext/sni_ave.c, 932:
ave_rxfifo_reset in ave_irq_handler

[FUNC] usleep_range
drivers/net/ethernet/socionext/sni_ave.c, 888:
usleep_range in ave_rxfifo_reset
drivers/net/ethernet/socionext/sni_ave.c, 932:
ave_rxfifo_reset in ave_irq_handler

To fix these bugs, usleep_range() is replaced with udelay().

These bugs are found by my static analysis tool DSAC.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/socionext/sni_ave.c