mm/memory_hotplug: use helper zone_is_zone_device() to simplify the code
[linux-2.6-microblaze.git] / mm / debug_vm_pgtable.c
index 05efe98..1c92269 100644 (file)
@@ -91,7 +91,7 @@ static void __init pte_advanced_tests(struct mm_struct *mm,
                                      unsigned long pfn, unsigned long vaddr,
                                      pgprot_t prot)
 {
-       pte_t pte = pfn_pte(pfn, prot);
+       pte_t pte;
 
        /*
         * Architectures optimize set_pte_at by avoiding TLB flush.
@@ -146,13 +146,14 @@ static void __init pte_savedwrite_tests(unsigned long pfn, pgprot_t prot)
 static void __init pmd_basic_tests(unsigned long pfn, int idx)
 {
        pgprot_t prot = protection_map[idx];
-       pmd_t pmd = pfn_pmd(pfn, prot);
        unsigned long val = idx, *ptr = &val;
+       pmd_t pmd;
 
        if (!has_transparent_hugepage())
                return;
 
        pr_debug("Validating PMD basic (%pGv)\n", ptr);
+       pmd = pfn_pmd(pfn, prot);
 
        /*
         * This test needs to be executed after the given page table entry
@@ -185,14 +186,14 @@ static void __init pmd_advanced_tests(struct mm_struct *mm,
                                      unsigned long pfn, unsigned long vaddr,
                                      pgprot_t prot, pgtable_t pgtable)
 {
-       pmd_t pmd = pfn_pmd(pfn, prot);
+       pmd_t pmd;
 
        if (!has_transparent_hugepage())
                return;
 
        pr_debug("Validating PMD advanced\n");
        /* Align the address wrt HPAGE_PMD_SIZE */
-       vaddr = (vaddr & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE;
+       vaddr &= HPAGE_PMD_MASK;
 
        pgtable_trans_huge_deposit(mm, pmdp, pgtable);
 
@@ -232,9 +233,14 @@ static void __init pmd_advanced_tests(struct mm_struct *mm,
 
 static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot)
 {
-       pmd_t pmd = pfn_pmd(pfn, prot);
+       pmd_t pmd;
+
+       if (!has_transparent_hugepage())
+               return;
 
        pr_debug("Validating PMD leaf\n");
+       pmd = pfn_pmd(pfn, prot);
+
        /*
         * PMD based THP is a leaf entry.
         */
@@ -242,37 +248,18 @@ static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot)
        WARN_ON(!pmd_leaf(pmd));
 }
 
-#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
-static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot)
+static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot)
 {
        pmd_t pmd;
 
-       if (!arch_vmap_pmd_supported(prot))
+       if (!IS_ENABLED(CONFIG_NUMA_BALANCING))
                return;
 
-       pr_debug("Validating PMD huge\n");
-       /*
-        * X86 defined pmd_set_huge() verifies that the given
-        * PMD is not a populated non-leaf entry.
-        */
-       WRITE_ONCE(*pmdp, __pmd(0));
-       WARN_ON(!pmd_set_huge(pmdp, __pfn_to_phys(pfn), prot));
-       WARN_ON(!pmd_clear_huge(pmdp));
-       pmd = READ_ONCE(*pmdp);
-       WARN_ON(!pmd_none(pmd));
-}
-#else /* CONFIG_HAVE_ARCH_HUGE_VMAP */
-static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot) { }
-#endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */
-
-static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot)
-{
-       pmd_t pmd = pfn_pmd(pfn, prot);
-
-       if (!IS_ENABLED(CONFIG_NUMA_BALANCING))
+       if (!has_transparent_hugepage())
                return;
 
        pr_debug("Validating PMD saved write\n");
+       pmd = pfn_pmd(pfn, prot);
        WARN_ON(!pmd_savedwrite(pmd_mk_savedwrite(pmd_clear_savedwrite(pmd))));
        WARN_ON(pmd_savedwrite(pmd_clear_savedwrite(pmd_mk_savedwrite(pmd))));
 }
@@ -281,13 +268,14 @@ static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot)
 static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx)
 {
        pgprot_t prot = protection_map[idx];
-       pud_t pud = pfn_pud(pfn, prot);
        unsigned long val = idx, *ptr = &val;
+       pud_t pud;
 
        if (!has_transparent_hugepage())
                return;
 
        pr_debug("Validating PUD basic (%pGv)\n", ptr);
+       pud = pfn_pud(pfn, prot);
 
        /*
         * This test needs to be executed after the given page table entry
@@ -323,15 +311,16 @@ static void __init pud_advanced_tests(struct mm_struct *mm,
                                      unsigned long pfn, unsigned long vaddr,
                                      pgprot_t prot)
 {
-       pud_t pud = pfn_pud(pfn, prot);
+       pud_t pud;
 
        if (!has_transparent_hugepage())
                return;
 
        pr_debug("Validating PUD advanced\n");
        /* Align the address wrt HPAGE_PUD_SIZE */
-       vaddr = (vaddr & HPAGE_PUD_MASK) + HPAGE_PUD_SIZE;
+       vaddr &= HPAGE_PUD_MASK;
 
+       pud = pfn_pud(pfn, prot);
        set_pud_at(mm, vaddr, pudp, pud);
        pudp_set_wrprotect(mm, vaddr, pudp);
        pud = READ_ONCE(*pudp);
@@ -370,39 +359,19 @@ static void __init pud_advanced_tests(struct mm_struct *mm,
 
 static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot)
 {
-       pud_t pud = pfn_pud(pfn, prot);
+       pud_t pud;
+
+       if (!has_transparent_hugepage())
+               return;
 
        pr_debug("Validating PUD leaf\n");
+       pud = pfn_pud(pfn, prot);
        /*
         * PUD based THP is a leaf entry.
         */
        pud = pud_mkhuge(pud);
        WARN_ON(!pud_leaf(pud));
 }
-
-#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
-static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot)
-{
-       pud_t pud;
-
-       if (!arch_vmap_pud_supported(prot))
-               return;
-
-       pr_debug("Validating PUD huge\n");
-       /*
-        * X86 defined pud_set_huge() verifies that the given
-        * PUD is not a populated non-leaf entry.
-        */
-       WRITE_ONCE(*pudp, __pud(0));
-       WARN_ON(!pud_set_huge(pudp, __pfn_to_phys(pfn), prot));
-       WARN_ON(!pud_clear_huge(pudp));
-       pud = READ_ONCE(*pudp);
-       WARN_ON(!pud_none(pud));
-}
-#else /* !CONFIG_HAVE_ARCH_HUGE_VMAP */
-static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) { }
-#endif /* !CONFIG_HAVE_ARCH_HUGE_VMAP */
-
 #else  /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */
 static void __init pud_basic_tests(struct mm_struct *mm, unsigned long pfn, int idx) { }
 static void __init pud_advanced_tests(struct mm_struct *mm,
@@ -412,9 +381,6 @@ static void __init pud_advanced_tests(struct mm_struct *mm,
 {
 }
 static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot) { }
-static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot)
-{
-}
 #endif /* CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */
 #else  /* !CONFIG_TRANSPARENT_HUGEPAGE */
 static void __init pmd_basic_tests(unsigned long pfn, int idx) { }
@@ -433,14 +399,51 @@ static void __init pud_advanced_tests(struct mm_struct *mm,
 }
 static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot) { }
 static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot) { }
+static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) { }
+#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
+
+#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
 static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot)
 {
+       pmd_t pmd;
+
+       if (!arch_vmap_pmd_supported(prot))
+               return;
+
+       pr_debug("Validating PMD huge\n");
+       /*
+        * X86 defined pmd_set_huge() verifies that the given
+        * PMD is not a populated non-leaf entry.
+        */
+       WRITE_ONCE(*pmdp, __pmd(0));
+       WARN_ON(!pmd_set_huge(pmdp, __pfn_to_phys(pfn), prot));
+       WARN_ON(!pmd_clear_huge(pmdp));
+       pmd = READ_ONCE(*pmdp);
+       WARN_ON(!pmd_none(pmd));
 }
+
 static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot)
 {
+       pud_t pud;
+
+       if (!arch_vmap_pud_supported(prot))
+               return;
+
+       pr_debug("Validating PUD huge\n");
+       /*
+        * X86 defined pud_set_huge() verifies that the given
+        * PUD is not a populated non-leaf entry.
+        */
+       WRITE_ONCE(*pudp, __pud(0));
+       WARN_ON(!pud_set_huge(pudp, __pfn_to_phys(pfn), prot));
+       WARN_ON(!pud_clear_huge(pudp));
+       pud = READ_ONCE(*pudp);
+       WARN_ON(!pud_none(pud));
 }
-static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) { }
-#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
+#else /* !CONFIG_HAVE_ARCH_HUGE_VMAP */
+static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot) { }
+static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) { }
+#endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */
 
 static void __init p4d_basic_tests(unsigned long pfn, pgprot_t prot)
 {
@@ -654,12 +657,16 @@ static void __init pte_protnone_tests(unsigned long pfn, pgprot_t prot)
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 static void __init pmd_protnone_tests(unsigned long pfn, pgprot_t prot)
 {
-       pmd_t pmd = pmd_mkhuge(pfn_pmd(pfn, prot));
+       pmd_t pmd;
 
        if (!IS_ENABLED(CONFIG_NUMA_BALANCING))
                return;
 
+       if (!has_transparent_hugepage())
+               return;
+
        pr_debug("Validating PMD protnone\n");
+       pmd = pmd_mkhuge(pfn_pmd(pfn, prot));
        WARN_ON(!pmd_protnone(pmd));
        WARN_ON(!pmd_present(pmd));
 }
@@ -679,18 +686,26 @@ static void __init pte_devmap_tests(unsigned long pfn, pgprot_t prot)
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 static void __init pmd_devmap_tests(unsigned long pfn, pgprot_t prot)
 {
-       pmd_t pmd = pfn_pmd(pfn, prot);
+       pmd_t pmd;
+
+       if (!has_transparent_hugepage())
+               return;
 
        pr_debug("Validating PMD devmap\n");
+       pmd = pfn_pmd(pfn, prot);
        WARN_ON(!pmd_devmap(pmd_mkdevmap(pmd)));
 }
 
 #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
 static void __init pud_devmap_tests(unsigned long pfn, pgprot_t prot)
 {
-       pud_t pud = pfn_pud(pfn, prot);
+       pud_t pud;
+
+       if (!has_transparent_hugepage())
+               return;
 
        pr_debug("Validating PUD devmap\n");
+       pud = pfn_pud(pfn, prot);
        WARN_ON(!pud_devmap(pud_mkdevmap(pud)));
 }
 #else  /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */
@@ -733,34 +748,42 @@ static void __init pte_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
 {
-       pmd_t pmd = pfn_pmd(pfn, prot);
+       pmd_t pmd;
 
        if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY))
                return;
 
+       if (!has_transparent_hugepage())
+               return;
+
        pr_debug("Validating PMD soft dirty\n");
+       pmd = pfn_pmd(pfn, prot);
        WARN_ON(!pmd_soft_dirty(pmd_mksoft_dirty(pmd)));
        WARN_ON(pmd_soft_dirty(pmd_clear_soft_dirty(pmd)));
 }
 
 static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
 {
-       pmd_t pmd = pfn_pmd(pfn, prot);
+       pmd_t pmd;
 
        if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY) ||
                !IS_ENABLED(CONFIG_ARCH_ENABLE_THP_MIGRATION))
                return;
 
+       if (!has_transparent_hugepage())
+               return;
+
        pr_debug("Validating PMD swap soft dirty\n");
+       pmd = pfn_pmd(pfn, prot);
        WARN_ON(!pmd_swp_soft_dirty(pmd_swp_mksoft_dirty(pmd)));
        WARN_ON(pmd_swp_soft_dirty(pmd_swp_clear_soft_dirty(pmd)));
 }
-#else  /* !CONFIG_ARCH_HAS_PTE_DEVMAP */
+#else  /* !CONFIG_TRANSPARENT_HUGEPAGE */
 static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot) { }
 static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
 {
 }
-#endif /* CONFIG_ARCH_HAS_PTE_DEVMAP */
+#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
 
 static void __init pte_swap_tests(unsigned long pfn, pgprot_t prot)
 {
@@ -780,6 +803,9 @@ static void __init pmd_swap_tests(unsigned long pfn, pgprot_t prot)
        swp_entry_t swp;
        pmd_t pmd;
 
+       if (!has_transparent_hugepage())
+               return;
+
        pr_debug("Validating PMD swap\n");
        pmd = pfn_pmd(pfn, prot);
        swp = __pmd_to_swp_entry(pmd);
@@ -817,17 +843,17 @@ static void __init swap_migration_tests(void)
         * locked, otherwise it stumbles upon a BUG_ON().
         */
        __SetPageLocked(page);
-       swp = make_migration_entry(page, 1);
+       swp = make_writable_migration_entry(page_to_pfn(page));
        WARN_ON(!is_migration_entry(swp));
-       WARN_ON(!is_write_migration_entry(swp));
+       WARN_ON(!is_writable_migration_entry(swp));
 
-       make_migration_entry_read(&swp);
+       swp = make_readable_migration_entry(swp_offset(swp));
        WARN_ON(!is_migration_entry(swp));
-       WARN_ON(is_write_migration_entry(swp));
+       WARN_ON(is_writable_migration_entry(swp));
 
-       swp = make_migration_entry(page, 0);
+       swp = make_readable_migration_entry(page_to_pfn(page));
        WARN_ON(!is_migration_entry(swp));
-       WARN_ON(is_write_migration_entry(swp));
+       WARN_ON(is_writable_migration_entry(swp));
        __ClearPageLocked(page);
        __free_page(page);
 }