Linux 6.9-rc1
[linux-2.6-microblaze.git] / drivers / rtc / rtc-ds1511.c
index 4ac8988..8b087d9 100644 (file)
 #define DS1511_WDS     0x01
 #define DS1511_RAM_MAX 0x100
 
-struct rtc_plat_data {
+struct ds1511_data {
        struct rtc_device *rtc;
        void __iomem *ioaddr;           /* virtual base address */
        int irq;
-       unsigned int irqen;
-       int alrm_sec;
-       int alrm_min;
-       int alrm_hour;
-       int alrm_mday;
        spinlock_t lock;
 };
 
@@ -76,17 +71,17 @@ static DEFINE_SPINLOCK(ds1511_lock);
 static __iomem char *ds1511_base;
 static u32 reg_spacing = 1;
 
-static noinline void rtc_write(uint8_t val, uint32_t reg)
+static void rtc_write(uint8_t val, uint32_t reg)
 {
        writeb(val, ds1511_base + (reg * reg_spacing));
 }
 
-static noinline uint8_t rtc_read(uint32_t reg)
+static uint8_t rtc_read(uint32_t reg)
 {
        return readb(ds1511_base + (reg * reg_spacing));
 }
 
-static inline void rtc_disable_update(void)
+static void rtc_disable_update(void)
 {
        rtc_write((rtc_read(DS1511_CONTROL_B) & ~DS1511_TE), DS1511_CONTROL_B);
 }
@@ -178,94 +173,67 @@ static int ds1511_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm)
        return 0;
 }
 
-/*
- * write the alarm register settings
- *
- * we only have the use to interrupt every second, otherwise
- * known as the update interrupt, or the interrupt if the whole
- * date/hours/mins/secs matches.  the ds1511 has many more
- * permutations, but the kernel doesn't.
- */
-static void ds1511_rtc_update_alarm(struct rtc_plat_data *pdata)
+static void ds1511_rtc_alarm_enable(unsigned int enabled)
 {
-       unsigned long flags;
-
-       spin_lock_irqsave(&pdata->lock, flags);
-       rtc_write(pdata->alrm_mday < 0 ? 0x80 : bin2bcd(pdata->alrm_mday) & 0x3f,
-              DS1511_AM4_DATE);
-       rtc_write(pdata->alrm_hour < 0 ? 0x80 : bin2bcd(pdata->alrm_hour) & 0x3f,
-              DS1511_AM3_HOUR);
-       rtc_write(pdata->alrm_min < 0 ? 0x80 : bin2bcd(pdata->alrm_min) & 0x7f,
-              DS1511_AM2_MIN);
-       rtc_write(pdata->alrm_sec < 0 ? 0x80 : bin2bcd(pdata->alrm_sec) & 0x7f,
-              DS1511_AM1_SEC);
-       rtc_write(rtc_read(DS1511_CONTROL_B) | (pdata->irqen ? DS1511_TIE : 0), DS1511_CONTROL_B);
-       rtc_read(DS1511_CONTROL_A);     /* clear interrupts */
-       spin_unlock_irqrestore(&pdata->lock, flags);
+       rtc_write(rtc_read(DS1511_CONTROL_B) | (enabled ? DS1511_TIE : 0), DS1511_CONTROL_B);
 }
 
 static int ds1511_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 {
-       struct rtc_plat_data *pdata = dev_get_drvdata(dev);
+       struct ds1511_data *ds1511 = dev_get_drvdata(dev);
+       unsigned long flags;
 
-       if (pdata->irq <= 0)
-               return -EINVAL;
+       spin_lock_irqsave(&ds1511->lock, flags);
+       rtc_write(bin2bcd(alrm->time.tm_mday) & 0x3f, DS1511_AM4_DATE);
+       rtc_write(bin2bcd(alrm->time.tm_hour) & 0x3f, DS1511_AM3_HOUR);
+       rtc_write(bin2bcd(alrm->time.tm_min) & 0x7f, DS1511_AM2_MIN);
+       rtc_write(bin2bcd(alrm->time.tm_sec) & 0x7f, DS1511_AM1_SEC);
+       ds1511_rtc_alarm_enable(alrm->enabled);
 
-       pdata->alrm_mday = alrm->time.tm_mday;
-       pdata->alrm_hour = alrm->time.tm_hour;
-       pdata->alrm_min = alrm->time.tm_min;
-       pdata->alrm_sec = alrm->time.tm_sec;
-       if (alrm->enabled)
-               pdata->irqen |= RTC_AF;
+       rtc_read(DS1511_CONTROL_A);     /* clear interrupts */
+       spin_unlock_irqrestore(&ds1511->lock, flags);
 
-       ds1511_rtc_update_alarm(pdata);
        return 0;
 }
 
 static int ds1511_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 {
-       struct rtc_plat_data *pdata = dev_get_drvdata(dev);
-
-       if (pdata->irq <= 0)
-               return -EINVAL;
+       alrm->time.tm_mday = bcd2bin(rtc_read(DS1511_AM4_DATE) & 0x3f);
+       alrm->time.tm_hour = bcd2bin(rtc_read(DS1511_AM3_HOUR) & 0x3f);
+       alrm->time.tm_min = bcd2bin(rtc_read(DS1511_AM2_MIN) & 0x7f);
+       alrm->time.tm_sec = bcd2bin(rtc_read(DS1511_AM1_SEC) & 0x7f);
+       alrm->enabled = !!(rtc_read(DS1511_CONTROL_B) & DS1511_TIE);
 
-       alrm->time.tm_mday = pdata->alrm_mday < 0 ? 0 : pdata->alrm_mday;
-       alrm->time.tm_hour = pdata->alrm_hour < 0 ? 0 : pdata->alrm_hour;
-       alrm->time.tm_min = pdata->alrm_min < 0 ? 0 : pdata->alrm_min;
-       alrm->time.tm_sec = pdata->alrm_sec < 0 ? 0 : pdata->alrm_sec;
-       alrm->enabled = (pdata->irqen & RTC_AF) ? 1 : 0;
        return 0;
 }
 
 static irqreturn_t ds1511_interrupt(int irq, void *dev_id)
 {
        struct platform_device *pdev = dev_id;
-       struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
+       struct ds1511_data *ds1511 = platform_get_drvdata(pdev);
        unsigned long events = 0;
 
-       spin_lock(&pdata->lock);
+       spin_lock(&ds1511->lock);
        /*
         * read and clear interrupt
         */
        if (rtc_read(DS1511_CONTROL_A) & DS1511_IRQF) {
                events = RTC_IRQF | RTC_AF;
-               rtc_update_irq(pdata->rtc, 1, events);
+               rtc_update_irq(ds1511->rtc, 1, events);
        }
-       spin_unlock(&pdata->lock);
+       spin_unlock(&ds1511->lock);
        return events ? IRQ_HANDLED : IRQ_NONE;
 }
 
 static int ds1511_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
 {
-       struct rtc_plat_data *pdata = dev_get_drvdata(dev);
-
-       if (pdata->irq <= 0)
-               return -EINVAL;
-       if (enabled)
-               pdata->irqen |= RTC_AF;
-       else
-               pdata->irqen &= ~RTC_AF;
-       ds1511_rtc_update_alarm(pdata);
+       struct ds1511_data *ds1511 = dev_get_drvdata(dev);
+       unsigned long flags;
+
+       spin_lock_irqsave(&ds1511->lock, flags);
+       ds1511_rtc_alarm_enable(enabled);
+       spin_unlock_irqrestore(&ds1511->lock, flags);
+
        return 0;
 }
 
@@ -303,7 +271,7 @@ static int ds1511_nvram_write(void *priv, unsigned int pos, void *buf,
 
 static int ds1511_rtc_probe(struct platform_device *pdev)
 {
-       struct rtc_plat_data *pdata;
+       struct ds1511_data *ds1511;
        int ret = 0;
        struct nvmem_config ds1511_nvmem_cfg = {
                .name = "ds1511_nvram",
@@ -315,15 +283,15 @@ static int ds1511_rtc_probe(struct platform_device *pdev)
                .priv = &pdev->dev,
        };
 
-       pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
-       if (!pdata)
+       ds1511 = devm_kzalloc(&pdev->dev, sizeof(*ds1511), GFP_KERNEL);
+       if (!ds1511)
                return -ENOMEM;
 
        ds1511_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ds1511_base))
                return PTR_ERR(ds1511_base);
-       pdata->ioaddr = ds1511_base;
-       pdata->irq = platform_get_irq(pdev, 0);
+       ds1511->ioaddr = ds1511_base;
+       ds1511->irq = platform_get_irq(pdev, 0);
 
        /*
         * turn on the clock and the crystal, etc.
@@ -346,35 +314,40 @@ static int ds1511_rtc_probe(struct platform_device *pdev)
        if (rtc_read(DS1511_CONTROL_A) & DS1511_BLF1)
                dev_warn(&pdev->dev, "voltage-low detected.\n");
 
-       spin_lock_init(&pdata->lock);
-       platform_set_drvdata(pdev, pdata);
-
-       pdata->rtc = devm_rtc_allocate_device(&pdev->dev);
-       if (IS_ERR(pdata->rtc))
-               return PTR_ERR(pdata->rtc);
-
-       pdata->rtc->ops = &ds1511_rtc_ops;
+       spin_lock_init(&ds1511->lock);
+       platform_set_drvdata(pdev, ds1511);
 
-       ret = devm_rtc_register_device(pdata->rtc);
-       if (ret)
-               return ret;
+       ds1511->rtc = devm_rtc_allocate_device(&pdev->dev);
+       if (IS_ERR(ds1511->rtc))
+               return PTR_ERR(ds1511->rtc);
 
-       devm_rtc_nvmem_register(pdata->rtc, &ds1511_nvmem_cfg);
+       ds1511->rtc->ops = &ds1511_rtc_ops;
+       ds1511->rtc->range_max = RTC_TIMESTAMP_END_2099;
+       ds1511->rtc->alarm_offset_max = 28 * 24 * 60 * 60 - 1;
 
        /*
         * if the platform has an interrupt in mind for this device,
         * then by all means, set it
         */
-       if (pdata->irq > 0) {
+       if (ds1511->irq > 0) {
                rtc_read(DS1511_CONTROL_A);
-               if (devm_request_irq(&pdev->dev, pdata->irq, ds1511_interrupt,
+               if (devm_request_irq(&pdev->dev, ds1511->irq, ds1511_interrupt,
                        IRQF_SHARED, pdev->name, pdev) < 0) {
 
                        dev_warn(&pdev->dev, "interrupt not available.\n");
-                       pdata->irq = 0;
+                       ds1511->irq = 0;
                }
        }
 
+       if (ds1511->irq == 0)
+               clear_bit(RTC_FEATURE_ALARM, ds1511->rtc->features);
+
+       ret = devm_rtc_register_device(ds1511->rtc);
+       if (ret)
+               return ret;
+
+       devm_rtc_nvmem_register(ds1511->rtc, &ds1511_nvmem_cfg);
+
        return 0;
 }