Merge tag 'rpmsg-v6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc...
[linux-2.6-microblaze.git] / drivers / rpmsg / qcom_glink_native.c
index 115c0a1..01d2805 100644 (file)
@@ -11,7 +11,6 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_irq.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/rpmsg.h>
@@ -78,11 +77,8 @@ struct glink_core_rx_intent {
 /**
  * struct qcom_glink - driver context, relates to one remote subsystem
  * @dev:       reference to the associated struct device
- * @mbox_client: mailbox client
- * @mbox_chan:  mailbox channel
  * @rx_pipe:   pipe object for receive FIFO
  * @tx_pipe:   pipe object for transmit FIFO
- * @irq:       IRQ for signaling incoming events
  * @rx_work:   worker for handling received control messages
  * @rx_lock:   protects the @rx_queue
  * @rx_queue:  queue of received control messages to be processed in @rx_work
@@ -94,18 +90,14 @@ struct glink_core_rx_intent {
  * @intentless:        flag to indicate that there is no intent
  * @tx_avail_notify: Waitqueue for pending tx tasks
  * @sent_read_notify: flag to check cmd sent or not
+ * @abort_tx:  flag indicating that all tx attempts should fail
  */
 struct qcom_glink {
        struct device *dev;
 
-       struct mbox_client mbox_client;
-       struct mbox_chan *mbox_chan;
-
        struct qcom_glink_pipe *rx_pipe;
        struct qcom_glink_pipe *tx_pipe;
 
-       int irq;
-
        struct work_struct rx_work;
        spinlock_t rx_lock;
        struct list_head rx_queue;
@@ -120,6 +112,8 @@ struct qcom_glink {
        bool intentless;
        wait_queue_head_t tx_avail_notify;
        bool sent_read_notify;
+
+       bool abort_tx;
 };
 
 enum {
@@ -189,20 +183,20 @@ struct glink_channel {
 
 static const struct rpmsg_endpoint_ops glink_endpoint_ops;
 
-#define RPM_CMD_VERSION                        0
-#define RPM_CMD_VERSION_ACK            1
-#define RPM_CMD_OPEN                   2
-#define RPM_CMD_CLOSE                  3
-#define RPM_CMD_OPEN_ACK               4
-#define RPM_CMD_INTENT                 5
-#define RPM_CMD_RX_DONE                        6
-#define RPM_CMD_RX_INTENT_REQ          7
-#define RPM_CMD_RX_INTENT_REQ_ACK      8
-#define RPM_CMD_TX_DATA                        9
-#define RPM_CMD_CLOSE_ACK              11
-#define RPM_CMD_TX_DATA_CONT           12
-#define RPM_CMD_READ_NOTIF             13
-#define RPM_CMD_RX_DONE_W_REUSE                14
+#define GLINK_CMD_VERSION              0
+#define GLINK_CMD_VERSION_ACK          1
+#define GLINK_CMD_OPEN                 2
+#define GLINK_CMD_CLOSE                        3
+#define GLINK_CMD_OPEN_ACK             4
+#define GLINK_CMD_INTENT               5
+#define GLINK_CMD_RX_DONE              6
+#define GLINK_CMD_RX_INTENT_REQ                7
+#define GLINK_CMD_RX_INTENT_REQ_ACK    8
+#define GLINK_CMD_TX_DATA              9
+#define GLINK_CMD_CLOSE_ACK            11
+#define GLINK_CMD_TX_DATA_CONT         12
+#define GLINK_CMD_READ_NOTIF           13
+#define GLINK_CMD_RX_DONE_W_REUSE      14
 
 #define GLINK_FEATURE_INTENTLESS       BIT(1)
 
@@ -280,10 +274,10 @@ static size_t qcom_glink_rx_avail(struct qcom_glink *glink)
        return glink->rx_pipe->avail(glink->rx_pipe);
 }
 
-static void qcom_glink_rx_peak(struct qcom_glink *glink,
+static void qcom_glink_rx_peek(struct qcom_glink *glink,
                               void *data, unsigned int offset, size_t count)
 {
-       glink->rx_pipe->peak(glink->rx_pipe, data, offset, count);
+       glink->rx_pipe->peek(glink->rx_pipe, data, offset, count);
 }
 
 static void qcom_glink_rx_advance(struct qcom_glink *glink, size_t count)
@@ -303,18 +297,22 @@ static void qcom_glink_tx_write(struct qcom_glink *glink,
        glink->tx_pipe->write(glink->tx_pipe, hdr, hlen, data, dlen);
 }
 
+static void qcom_glink_tx_kick(struct qcom_glink *glink)
+{
+       glink->tx_pipe->kick(glink->tx_pipe);
+}
+
 static void qcom_glink_send_read_notify(struct qcom_glink *glink)
 {
        struct glink_msg msg;
 
-       msg.cmd = cpu_to_le16(RPM_CMD_READ_NOTIF);
+       msg.cmd = cpu_to_le16(GLINK_CMD_READ_NOTIF);
        msg.param1 = 0;
        msg.param2 = 0;
 
        qcom_glink_tx_write(glink, &msg, sizeof(msg), NULL, 0);
 
-       mbox_send_message(glink->mbox_chan, NULL);
-       mbox_client_txdone(glink->mbox_chan, 0);
+       qcom_glink_tx_kick(glink);
 }
 
 static int qcom_glink_tx(struct qcom_glink *glink,
@@ -331,12 +329,22 @@ static int qcom_glink_tx(struct qcom_glink *glink,
 
        spin_lock_irqsave(&glink->tx_lock, flags);
 
+       if (glink->abort_tx) {
+               ret = -EIO;
+               goto out;
+       }
+
        while (qcom_glink_tx_avail(glink) < tlen) {
                if (!wait) {
                        ret = -EAGAIN;
                        goto out;
                }
 
+               if (glink->abort_tx) {
+                       ret = -EIO;
+                       goto out;
+               }
+
                if (!glink->sent_read_notify) {
                        glink->sent_read_notify = true;
                        qcom_glink_send_read_notify(glink);
@@ -355,9 +363,7 @@ static int qcom_glink_tx(struct qcom_glink *glink,
        }
 
        qcom_glink_tx_write(glink, hdr, hlen, data, dlen);
-
-       mbox_send_message(glink->mbox_chan, NULL);
-       mbox_client_txdone(glink->mbox_chan, 0);
+       qcom_glink_tx_kick(glink);
 
 out:
        spin_unlock_irqrestore(&glink->tx_lock, flags);
@@ -369,7 +375,7 @@ static int qcom_glink_send_version(struct qcom_glink *glink)
 {
        struct glink_msg msg;
 
-       msg.cmd = cpu_to_le16(RPM_CMD_VERSION);
+       msg.cmd = cpu_to_le16(GLINK_CMD_VERSION);
        msg.param1 = cpu_to_le16(GLINK_VERSION_1);
        msg.param2 = cpu_to_le32(glink->features);
 
@@ -380,7 +386,7 @@ static void qcom_glink_send_version_ack(struct qcom_glink *glink)
 {
        struct glink_msg msg;
 
-       msg.cmd = cpu_to_le16(RPM_CMD_VERSION_ACK);
+       msg.cmd = cpu_to_le16(GLINK_CMD_VERSION_ACK);
        msg.param1 = cpu_to_le16(GLINK_VERSION_1);
        msg.param2 = cpu_to_le32(glink->features);
 
@@ -392,7 +398,7 @@ static void qcom_glink_send_open_ack(struct qcom_glink *glink,
 {
        struct glink_msg msg;
 
-       msg.cmd = cpu_to_le16(RPM_CMD_OPEN_ACK);
+       msg.cmd = cpu_to_le16(GLINK_CMD_OPEN_ACK);
        msg.param1 = cpu_to_le16(channel->rcid);
        msg.param2 = cpu_to_le32(0);
 
@@ -417,12 +423,18 @@ static void qcom_glink_handle_intent_req_ack(struct qcom_glink *glink,
        complete(&channel->intent_req_comp);
 }
 
+static void qcom_glink_intent_req_abort(struct glink_channel *channel)
+{
+       channel->intent_req_result = 0;
+       complete(&channel->intent_req_comp);
+}
+
 /**
- * qcom_glink_send_open_req() - send a RPM_CMD_OPEN request to the remote
+ * qcom_glink_send_open_req() - send a GLINK_CMD_OPEN request to the remote
  * @glink: Ptr to the glink edge
  * @channel: Ptr to the channel that the open req is sent
  *
- * Allocates a local channel id and sends a RPM_CMD_OPEN message to the remote.
+ * Allocates a local channel id and sends a GLINK_CMD_OPEN message to the remote.
  * Will return with refcount held, regardless of outcome.
  *
  * Return: 0 on success, negative errno otherwise.
@@ -451,7 +463,7 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink,
 
        channel->lcid = ret;
 
-       req.msg.cmd = cpu_to_le16(RPM_CMD_OPEN);
+       req.msg.cmd = cpu_to_le16(GLINK_CMD_OPEN);
        req.msg.param1 = cpu_to_le16(channel->lcid);
        req.msg.param2 = cpu_to_le32(name_len);
        strcpy(req.name, channel->name);
@@ -476,7 +488,7 @@ static void qcom_glink_send_close_req(struct qcom_glink *glink,
 {
        struct glink_msg req;
 
-       req.cmd = cpu_to_le16(RPM_CMD_CLOSE);
+       req.cmd = cpu_to_le16(GLINK_CMD_CLOSE);
        req.param1 = cpu_to_le16(channel->lcid);
        req.param2 = 0;
 
@@ -488,7 +500,7 @@ static void qcom_glink_send_close_ack(struct qcom_glink *glink,
 {
        struct glink_msg req;
 
-       req.cmd = cpu_to_le16(RPM_CMD_CLOSE_ACK);
+       req.cmd = cpu_to_le16(GLINK_CMD_CLOSE_ACK);
        req.param1 = cpu_to_le16(rcid);
        req.param2 = 0;
 
@@ -519,7 +531,7 @@ static void qcom_glink_rx_done_work(struct work_struct *work)
                iid = intent->id;
                reuse = intent->reuse;
 
-               cmd.id = reuse ? RPM_CMD_RX_DONE_W_REUSE : RPM_CMD_RX_DONE;
+               cmd.id = reuse ? GLINK_CMD_RX_DONE_W_REUSE : GLINK_CMD_RX_DONE;
                cmd.lcid = cid;
                cmd.liid = iid;
 
@@ -631,7 +643,7 @@ static int qcom_glink_send_intent_req_ack(struct qcom_glink *glink,
 {
        struct glink_msg msg;
 
-       msg.cmd = cpu_to_le16(RPM_CMD_RX_INTENT_REQ_ACK);
+       msg.cmd = cpu_to_le16(GLINK_CMD_RX_INTENT_REQ_ACK);
        msg.param1 = cpu_to_le16(channel->lcid);
        msg.param2 = cpu_to_le32(granted);
 
@@ -662,7 +674,7 @@ static int qcom_glink_advertise_intent(struct qcom_glink *glink,
        } __packed;
        struct command cmd;
 
-       cmd.id = cpu_to_le16(RPM_CMD_INTENT);
+       cmd.id = cpu_to_le16(GLINK_CMD_INTENT);
        cmd.lcid = cpu_to_le16(channel->lcid);
        cmd.count = cpu_to_le32(1);
        cmd.size = cpu_to_le32(intent->size);
@@ -796,7 +808,7 @@ static int qcom_glink_rx_defer(struct qcom_glink *glink, size_t extra)
 
        INIT_LIST_HEAD(&dcmd->node);
 
-       qcom_glink_rx_peak(glink, &dcmd->msg, 0, sizeof(dcmd->msg) + extra);
+       qcom_glink_rx_peek(glink, &dcmd->msg, 0, sizeof(dcmd->msg) + extra);
 
        spin_lock(&glink->rx_lock);
        list_add_tail(&dcmd->node, &glink->rx_queue);
@@ -829,7 +841,7 @@ static int qcom_glink_rx_data(struct qcom_glink *glink, size_t avail)
                return -EAGAIN;
        }
 
-       qcom_glink_rx_peak(glink, &hdr, 0, sizeof(hdr));
+       qcom_glink_rx_peek(glink, &hdr, 0, sizeof(hdr));
        chunk_size = le32_to_cpu(hdr.chunk_size);
        left_size = le32_to_cpu(hdr.left_size);
 
@@ -894,7 +906,7 @@ static int qcom_glink_rx_data(struct qcom_glink *glink, size_t avail)
                goto advance_rx;
        }
 
-       qcom_glink_rx_peak(glink, intent->data + intent->offset,
+       qcom_glink_rx_peek(glink, intent->data + intent->offset,
                           sizeof(hdr), chunk_size);
        intent->offset += chunk_size;
 
@@ -954,6 +966,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,
        spin_unlock_irqrestore(&glink->idr_lock, flags);
        if (!channel) {
                dev_err(glink->dev, "intents for non-existing channel\n");
+               qcom_glink_rx_advance(glink, ALIGN(msglen, 8));
                return;
        }
 
@@ -961,7 +974,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,
        if (!msg)
                return;
 
-       qcom_glink_rx_peak(glink, msg, 0, msglen);
+       qcom_glink_rx_peek(glink, msg, 0, msglen);
 
        for (i = 0; i < count; ++i) {
                intent = kzalloc(sizeof(*intent), GFP_ATOMIC);
@@ -1001,9 +1014,8 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
        return 0;
 }
 
-static irqreturn_t qcom_glink_native_intr(int irq, void *data)
+void qcom_glink_native_rx(struct qcom_glink *glink)
 {
-       struct qcom_glink *glink = data;
        struct glink_msg msg;
        unsigned int param1;
        unsigned int param2;
@@ -1019,49 +1031,47 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data)
                if (avail < sizeof(msg))
                        break;
 
-               qcom_glink_rx_peak(glink, &msg, 0, sizeof(msg));
+               qcom_glink_rx_peek(glink, &msg, 0, sizeof(msg));
 
                cmd = le16_to_cpu(msg.cmd);
                param1 = le16_to_cpu(msg.param1);
                param2 = le32_to_cpu(msg.param2);
 
                switch (cmd) {
-               case RPM_CMD_VERSION:
-               case RPM_CMD_VERSION_ACK:
-               case RPM_CMD_CLOSE:
-               case RPM_CMD_CLOSE_ACK:
-               case RPM_CMD_RX_INTENT_REQ:
+               case GLINK_CMD_VERSION:
+               case GLINK_CMD_VERSION_ACK:
+               case GLINK_CMD_CLOSE:
+               case GLINK_CMD_CLOSE_ACK:
+               case GLINK_CMD_RX_INTENT_REQ:
                        ret = qcom_glink_rx_defer(glink, 0);
                        break;
-               case RPM_CMD_OPEN_ACK:
+               case GLINK_CMD_OPEN_ACK:
                        ret = qcom_glink_rx_open_ack(glink, param1);
                        qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8));
                        break;
-               case RPM_CMD_OPEN:
+               case GLINK_CMD_OPEN:
                        ret = qcom_glink_rx_defer(glink, param2);
                        break;
-               case RPM_CMD_TX_DATA:
-               case RPM_CMD_TX_DATA_CONT:
+               case GLINK_CMD_TX_DATA:
+               case GLINK_CMD_TX_DATA_CONT:
                        ret = qcom_glink_rx_data(glink, avail);
                        break;
-               case RPM_CMD_READ_NOTIF:
+               case GLINK_CMD_READ_NOTIF:
                        qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8));
-
-                       mbox_send_message(glink->mbox_chan, NULL);
-                       mbox_client_txdone(glink->mbox_chan, 0);
+                       qcom_glink_tx_kick(glink);
                        break;
-               case RPM_CMD_INTENT:
+               case GLINK_CMD_INTENT:
                        qcom_glink_handle_intent(glink, param1, param2, avail);
                        break;
-               case RPM_CMD_RX_DONE:
+               case GLINK_CMD_RX_DONE:
                        qcom_glink_handle_rx_done(glink, param1, param2, false);
                        qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8));
                        break;
-               case RPM_CMD_RX_DONE_W_REUSE:
+               case GLINK_CMD_RX_DONE_W_REUSE:
                        qcom_glink_handle_rx_done(glink, param1, param2, true);
                        qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8));
                        break;
-               case RPM_CMD_RX_INTENT_REQ_ACK:
+               case GLINK_CMD_RX_INTENT_REQ_ACK:
                        qcom_glink_handle_intent_req_ack(glink, param1, param2);
                        qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8));
                        break;
@@ -1074,9 +1084,8 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data)
                if (ret)
                        break;
        }
-
-       return IRQ_HANDLED;
 }
+EXPORT_SYMBOL(qcom_glink_native_rx);
 
 /* Locally initiated rpmsg_create_ept */
 static struct glink_channel *qcom_glink_create_local(struct qcom_glink *glink,
@@ -1264,7 +1273,7 @@ static int qcom_glink_request_intent(struct qcom_glink *glink,
 
        reinit_completion(&channel->intent_req_comp);
 
-       cmd.id = RPM_CMD_RX_INTENT_REQ;
+       cmd.id = GLINK_CMD_RX_INTENT_REQ;
        cmd.cid = channel->lcid;
        cmd.size = size;
 
@@ -1338,7 +1347,7 @@ static int __qcom_glink_send(struct glink_channel *channel,
                chunk_size = SZ_8K;
                left_size = len - chunk_size;
        }
-       req.msg.cmd = cpu_to_le16(RPM_CMD_TX_DATA);
+       req.msg.cmd = cpu_to_le16(GLINK_CMD_TX_DATA);
        req.msg.param1 = cpu_to_le16(channel->lcid);
        req.msg.param2 = cpu_to_le32(iid);
        req.chunk_size = cpu_to_le32(chunk_size);
@@ -1359,7 +1368,7 @@ static int __qcom_glink_send(struct glink_channel *channel,
                        chunk_size = SZ_8K;
                left_size -= chunk_size;
 
-               req.msg.cmd = cpu_to_le16(RPM_CMD_TX_DATA_CONT);
+               req.msg.cmd = cpu_to_le16(GLINK_CMD_TX_DATA_CONT);
                req.msg.param1 = cpu_to_le16(channel->lcid);
                req.msg.param2 = cpu_to_le32(iid);
                req.chunk_size = cpu_to_le32(chunk_size);
@@ -1446,6 +1455,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
 {
        struct rpmsg_device *rpdev = to_rpmsg_device(dev);
 
+       kfree(rpdev->driver_override);
        kfree(rpdev);
 }
 
@@ -1623,22 +1633,22 @@ static void qcom_glink_work(struct work_struct *work)
                param2 = le32_to_cpu(msg->param2);
 
                switch (cmd) {
-               case RPM_CMD_VERSION:
+               case GLINK_CMD_VERSION:
                        qcom_glink_receive_version(glink, param1, param2);
                        break;
-               case RPM_CMD_VERSION_ACK:
+               case GLINK_CMD_VERSION_ACK:
                        qcom_glink_receive_version_ack(glink, param1, param2);
                        break;
-               case RPM_CMD_OPEN:
+               case GLINK_CMD_OPEN:
                        qcom_glink_rx_open(glink, param1, msg->data);
                        break;
-               case RPM_CMD_CLOSE:
+               case GLINK_CMD_CLOSE:
                        qcom_glink_rx_close(glink, param1);
                        break;
-               case RPM_CMD_CLOSE_ACK:
+               case GLINK_CMD_CLOSE_ACK:
                        qcom_glink_rx_close_ack(glink, param1);
                        break;
-               case RPM_CMD_RX_INTENT_REQ:
+               case GLINK_CMD_RX_INTENT_REQ:
                        qcom_glink_handle_intent_req(glink, param1, param2);
                        break;
                default:
@@ -1689,6 +1699,7 @@ static void qcom_glink_device_release(struct device *dev)
 
        /* Release qcom_glink_alloc_channel() reference */
        kref_put(&channel->refcount, qcom_glink_channel_release);
+       kfree(rpdev->driver_override);
        kfree(rpdev);
 }
 
@@ -1722,7 +1733,6 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
                                           struct qcom_glink_pipe *tx,
                                           bool intentless)
 {
-       int irq;
        int ret;
        struct qcom_glink *glink;
 
@@ -1753,27 +1763,6 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
        if (ret)
                dev_err(dev, "failed to add groups\n");
 
-       glink->mbox_client.dev = dev;
-       glink->mbox_client.knows_txdone = true;
-       glink->mbox_chan = mbox_request_channel(&glink->mbox_client, 0);
-       if (IS_ERR(glink->mbox_chan)) {
-               if (PTR_ERR(glink->mbox_chan) != -EPROBE_DEFER)
-                       dev_err(dev, "failed to acquire IPC channel\n");
-               return ERR_CAST(glink->mbox_chan);
-       }
-
-       irq = of_irq_get(dev->of_node, 0);
-       ret = devm_request_irq(dev, irq,
-                              qcom_glink_native_intr,
-                              IRQF_NO_SUSPEND | IRQF_SHARED,
-                              "glink-native", glink);
-       if (ret) {
-               dev_err(dev, "failed to request IRQ\n");
-               return ERR_PTR(ret);
-       }
-
-       glink->irq = irq;
-
        ret = qcom_glink_send_version(glink);
        if (ret)
                return ERR_PTR(ret);
@@ -1796,12 +1785,24 @@ static int qcom_glink_remove_device(struct device *dev, void *data)
 void qcom_glink_native_remove(struct qcom_glink *glink)
 {
        struct glink_channel *channel;
+       unsigned long flags;
        int cid;
        int ret;
 
-       disable_irq(glink->irq);
        qcom_glink_cancel_rx_work(glink);
 
+       /* Fail all attempts at sending messages */
+       spin_lock_irqsave(&glink->tx_lock, flags);
+       glink->abort_tx = true;
+       wake_up_all(&glink->tx_avail_notify);
+       spin_unlock_irqrestore(&glink->tx_lock, flags);
+
+       /* Abort any senders waiting for intent requests */
+       spin_lock_irqsave(&glink->idr_lock, flags);
+       idr_for_each_entry(&glink->lcids, channel, cid)
+               qcom_glink_intent_req_abort(channel);
+       spin_unlock_irqrestore(&glink->idr_lock, flags);
+
        ret = device_for_each_child(glink->dev, NULL, qcom_glink_remove_device);
        if (ret)
                dev_warn(glink->dev, "Can't remove GLINK devices: %d\n", ret);
@@ -1816,15 +1817,8 @@ void qcom_glink_native_remove(struct qcom_glink *glink)
 
        idr_destroy(&glink->lcids);
        idr_destroy(&glink->rcids);
-       mbox_free_channel(glink->mbox_chan);
 }
 EXPORT_SYMBOL_GPL(qcom_glink_native_remove);
 
-void qcom_glink_native_unregister(struct qcom_glink *glink)
-{
-       device_unregister(glink->dev);
-}
-EXPORT_SYMBOL_GPL(qcom_glink_native_unregister);
-
 MODULE_DESCRIPTION("Qualcomm GLINK driver");
 MODULE_LICENSE("GPL v2");