pwm: sti: Avoid conditional gotos

[linux-2.6-microblaze.git] / drivers / pwm / pwm-lpss.c

diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
index 3444c56..939de93 100644 (file)
--- a/drivers/pwm/pwm-lpss.c
+++ b/drivers/pwm/pwm-lpss.c
@@ -76,7 +76,12 @@ static int pwm_lpss_wait_for_update(struct pwm_device *pwm)
 
 static inline int pwm_lpss_is_updating(struct pwm_device *pwm)
 {
-       return (pwm_lpss_read(pwm) & PWM_SW_UPDATE) ? -EBUSY : 0;
+       if (pwm_lpss_read(pwm) & PWM_SW_UPDATE) {
+               dev_err(pwm->chip->dev, "PWM_SW_UPDATE is still set, skipping update\n");
+               return -EBUSY;
+       }
+
+       return 0;
 }
 
 static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm,