net: dsa: rtl8366: Fix VLAN set-up

[linux-2.6-microblaze.git] / drivers / net / dsa / rtl8366.c

diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
index 2997abe..8f40fbf 100644 (file)
--- a/drivers/net/dsa/rtl8366.c
+++ b/drivers/net/dsa/rtl8366.c
@@ -397,7 +397,7 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port,
        if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
                dev_err(smi->dev, "port is DSA or CPU port\n");
 
-       for (vid = vlan->vid_begin; vid <= vlan->vid_end; ++vid) {
+       for (vid = vlan->vid_begin; vid <= vlan->vid_end; vid++) {
                int pvid_val = 0;
 
                dev_info(smi->dev, "add VLAN %04x\n", vid);
@@ -420,13 +420,13 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port,
                        if (ret < 0)
                                return;
                }
-       }
 
-       ret = rtl8366_set_vlan(smi, port, member, untag, 0);
-       if (ret)
-               dev_err(smi->dev,
-                       "failed to set up VLAN %04x",
-                       vid);
+               ret = rtl8366_set_vlan(smi, vid, member, untag, 0);
+               if (ret)
+                       dev_err(smi->dev,
+                               "failed to set up VLAN %04x",
+                               vid);
+       }
 }
 EXPORT_SYMBOL_GPL(rtl8366_vlan_add);