Merge tag 'lkdtm-next' of https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux...
[linux-2.6-microblaze.git] / drivers / hwtracing / coresight / coresight-etm4x-sysfs.c
index 21687cc..6ea8181 100644 (file)
@@ -22,7 +22,7 @@ static int etm4_set_mode_exclude(struct etmv4_drvdata *drvdata, bool exclude)
         * TRCACATRn.TYPE bit[1:0]: type of comparison
         * the trace unit performs
         */
-       if (BMVAL(config->addr_acc[idx], 0, 1) == ETM_INSTR_ADDR) {
+       if (FIELD_GET(TRCACATRn_TYPE_MASK, config->addr_acc[idx]) == TRCACATRn_TYPE_ADDR) {
                if (idx % 2 != 0)
                        return -EINVAL;
 
@@ -180,12 +180,12 @@ static ssize_t reset_store(struct device *dev,
 
        /* Disable data tracing: do not trace load and store data transfers */
        config->mode &= ~(ETM_MODE_LOAD | ETM_MODE_STORE);
-       config->cfg &= ~(BIT(1) | BIT(2));
+       config->cfg &= ~(TRCCONFIGR_INSTP0_LOAD | TRCCONFIGR_INSTP0_STORE);
 
        /* Disable data value and data address tracing */
        config->mode &= ~(ETM_MODE_DATA_TRACE_ADDR |
                           ETM_MODE_DATA_TRACE_VAL);
-       config->cfg &= ~(BIT(16) | BIT(17));
+       config->cfg &= ~(TRCCONFIGR_DA | TRCCONFIGR_DV);
 
        /* Disable all events tracing */
        config->eventctrl0 = 0x0;
@@ -206,11 +206,11 @@ static ssize_t reset_store(struct device *dev,
         * started state. ARM recommends start-stop logic is set before
         * each trace run.
         */
-       config->vinst_ctrl = BIT(0);
+       config->vinst_ctrl = FIELD_PREP(TRCVICTLR_EVENT_MASK, 0x01);
        if (drvdata->nr_addr_cmp > 0) {
                config->mode |= ETM_MODE_VIEWINST_STARTSTOP;
                /* SSSTATUS, bit[9] */
-               config->vinst_ctrl |= BIT(9);
+               config->vinst_ctrl |= TRCVICTLR_SSSTATUS;
        }
 
        /* No address range filtering for ViewInst */
@@ -304,134 +304,134 @@ static ssize_t mode_store(struct device *dev,
 
        if (drvdata->instrp0 == true) {
                /* start by clearing instruction P0 field */
-               config->cfg  &= ~(BIT(1) | BIT(2));
+               config->cfg  &= ~TRCCONFIGR_INSTP0_LOAD_STORE;
                if (config->mode & ETM_MODE_LOAD)
                        /* 0b01 Trace load instructions as P0 instructions */
-                       config->cfg  |= BIT(1);
+                       config->cfg  |= TRCCONFIGR_INSTP0_LOAD;
                if (config->mode & ETM_MODE_STORE)
                        /* 0b10 Trace store instructions as P0 instructions */
-                       config->cfg  |= BIT(2);
+                       config->cfg  |= TRCCONFIGR_INSTP0_STORE;
                if (config->mode & ETM_MODE_LOAD_STORE)
                        /*
                         * 0b11 Trace load and store instructions
                         * as P0 instructions
                         */
-                       config->cfg  |= BIT(1) | BIT(2);
+                       config->cfg  |= TRCCONFIGR_INSTP0_LOAD_STORE;
        }
 
        /* bit[3], Branch broadcast mode */
        if ((config->mode & ETM_MODE_BB) && (drvdata->trcbb == true))
-               config->cfg |= BIT(3);
+               config->cfg |= TRCCONFIGR_BB;
        else
-               config->cfg &= ~BIT(3);
+               config->cfg &= ~TRCCONFIGR_BB;
 
        /* bit[4], Cycle counting instruction trace bit */
        if ((config->mode & ETMv4_MODE_CYCACC) &&
                (drvdata->trccci == true))
-               config->cfg |= BIT(4);
+               config->cfg |= TRCCONFIGR_CCI;
        else
-               config->cfg &= ~BIT(4);
+               config->cfg &= ~TRCCONFIGR_CCI;
 
        /* bit[6], Context ID tracing bit */
        if ((config->mode & ETMv4_MODE_CTXID) && (drvdata->ctxid_size))
-               config->cfg |= BIT(6);
+               config->cfg |= TRCCONFIGR_CID;
        else
-               config->cfg &= ~BIT(6);
+               config->cfg &= ~TRCCONFIGR_CID;
 
        if ((config->mode & ETM_MODE_VMID) && (drvdata->vmid_size))
-               config->cfg |= BIT(7);
+               config->cfg |= TRCCONFIGR_VMID;
        else
-               config->cfg &= ~BIT(7);
+               config->cfg &= ~TRCCONFIGR_VMID;
 
        /* bits[10:8], Conditional instruction tracing bit */
        mode = ETM_MODE_COND(config->mode);
        if (drvdata->trccond == true) {
-               config->cfg &= ~(BIT(8) | BIT(9) | BIT(10));
-               config->cfg |= mode << 8;
+               config->cfg &= ~TRCCONFIGR_COND_MASK;
+               config->cfg |= mode << __bf_shf(TRCCONFIGR_COND_MASK);
        }
 
        /* bit[11], Global timestamp tracing bit */
        if ((config->mode & ETMv4_MODE_TIMESTAMP) && (drvdata->ts_size))
-               config->cfg |= BIT(11);
+               config->cfg |= TRCCONFIGR_TS;
        else
-               config->cfg &= ~BIT(11);
+               config->cfg &= ~TRCCONFIGR_TS;
 
        /* bit[12], Return stack enable bit */
        if ((config->mode & ETM_MODE_RETURNSTACK) &&
                                        (drvdata->retstack == true))
-               config->cfg |= BIT(12);
+               config->cfg |= TRCCONFIGR_RS;
        else
-               config->cfg &= ~BIT(12);
+               config->cfg &= ~TRCCONFIGR_RS;
 
        /* bits[14:13], Q element enable field */
        mode = ETM_MODE_QELEM(config->mode);
        /* start by clearing QE bits */
-       config->cfg &= ~(BIT(13) | BIT(14));
+       config->cfg &= ~(TRCCONFIGR_QE_W_COUNTS | TRCCONFIGR_QE_WO_COUNTS);
        /*
         * if supported, Q elements with instruction counts are enabled.
         * Always set the low bit for any requested mode. Valid combos are
         * 0b00, 0b01 and 0b11.
         */
        if (mode && drvdata->q_support)
-               config->cfg |= BIT(13);
+               config->cfg |= TRCCONFIGR_QE_W_COUNTS;
        /*
         * if supported, Q elements with and without instruction
         * counts are enabled
         */
        if ((mode & BIT(1)) && (drvdata->q_support & BIT(1)))
-               config->cfg |= BIT(14);
+               config->cfg |= TRCCONFIGR_QE_WO_COUNTS;
 
        /* bit[11], AMBA Trace Bus (ATB) trigger enable bit */
        if ((config->mode & ETM_MODE_ATB_TRIGGER) &&
            (drvdata->atbtrig == true))
-               config->eventctrl1 |= BIT(11);
+               config->eventctrl1 |= TRCEVENTCTL1R_ATB;
        else
-               config->eventctrl1 &= ~BIT(11);
+               config->eventctrl1 &= ~TRCEVENTCTL1R_ATB;
 
        /* bit[12], Low-power state behavior override bit */
        if ((config->mode & ETM_MODE_LPOVERRIDE) &&
            (drvdata->lpoverride == true))
-               config->eventctrl1 |= BIT(12);
+               config->eventctrl1 |= TRCEVENTCTL1R_LPOVERRIDE;
        else
-               config->eventctrl1 &= ~BIT(12);
+               config->eventctrl1 &= ~TRCEVENTCTL1R_LPOVERRIDE;
 
        /* bit[8], Instruction stall bit */
        if ((config->mode & ETM_MODE_ISTALL_EN) && (drvdata->stallctl == true))
-               config->stall_ctrl |= BIT(8);
+               config->stall_ctrl |= TRCSTALLCTLR_ISTALL;
        else
-               config->stall_ctrl &= ~BIT(8);
+               config->stall_ctrl &= ~TRCSTALLCTLR_ISTALL;
 
        /* bit[10], Prioritize instruction trace bit */
        if (config->mode & ETM_MODE_INSTPRIO)
-               config->stall_ctrl |= BIT(10);
+               config->stall_ctrl |= TRCSTALLCTLR_INSTPRIORITY;
        else
-               config->stall_ctrl &= ~BIT(10);
+               config->stall_ctrl &= ~TRCSTALLCTLR_INSTPRIORITY;
 
        /* bit[13], Trace overflow prevention bit */
        if ((config->mode & ETM_MODE_NOOVERFLOW) &&
                (drvdata->nooverflow == true))
-               config->stall_ctrl |= BIT(13);
+               config->stall_ctrl |= TRCSTALLCTLR_NOOVERFLOW;
        else
-               config->stall_ctrl &= ~BIT(13);
+               config->stall_ctrl &= ~TRCSTALLCTLR_NOOVERFLOW;
 
        /* bit[9] Start/stop logic control bit */
        if (config->mode & ETM_MODE_VIEWINST_STARTSTOP)
-               config->vinst_ctrl |= BIT(9);
+               config->vinst_ctrl |= TRCVICTLR_SSSTATUS;
        else
-               config->vinst_ctrl &= ~BIT(9);
+               config->vinst_ctrl &= ~TRCVICTLR_SSSTATUS;
 
        /* bit[10], Whether a trace unit must trace a Reset exception */
        if (config->mode & ETM_MODE_TRACE_RESET)
-               config->vinst_ctrl |= BIT(10);
+               config->vinst_ctrl |= TRCVICTLR_TRCRESET;
        else
-               config->vinst_ctrl &= ~BIT(10);
+               config->vinst_ctrl &= ~TRCVICTLR_TRCRESET;
 
        /* bit[11], Whether a trace unit must trace a system error exception */
        if ((config->mode & ETM_MODE_TRACE_ERR) &&
                (drvdata->trc_error == true))
-               config->vinst_ctrl |= BIT(11);
+               config->vinst_ctrl |= TRCVICTLR_TRCERR;
        else
-               config->vinst_ctrl &= ~BIT(11);
+               config->vinst_ctrl &= ~TRCVICTLR_TRCERR;
 
        if (config->mode & (ETM_MODE_EXCL_KERN | ETM_MODE_EXCL_USER))
                etm4_config_trace_mode(config);
@@ -534,7 +534,7 @@ static ssize_t event_instren_show(struct device *dev,
        struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
        struct etmv4_config *config = &drvdata->config;
 
-       val = BMVAL(config->eventctrl1, 0, 3);
+       val = FIELD_GET(TRCEVENTCTL1R_INSTEN_MASK, config->eventctrl1);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
 
@@ -551,23 +551,28 @@ static ssize_t event_instren_store(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        /* start by clearing all instruction event enable bits */
-       config->eventctrl1 &= ~(BIT(0) | BIT(1) | BIT(2) | BIT(3));
+       config->eventctrl1 &= ~TRCEVENTCTL1R_INSTEN_MASK;
        switch (drvdata->nr_event) {
        case 0x0:
                /* generate Event element for event 1 */
-               config->eventctrl1 |= val & BIT(1);
+               config->eventctrl1 |= val & TRCEVENTCTL1R_INSTEN_1;
                break;
        case 0x1:
                /* generate Event element for event 1 and 2 */
-               config->eventctrl1 |= val & (BIT(0) | BIT(1));
+               config->eventctrl1 |= val & (TRCEVENTCTL1R_INSTEN_0 | TRCEVENTCTL1R_INSTEN_1);
                break;
        case 0x2:
                /* generate Event element for event 1, 2 and 3 */
-               config->eventctrl1 |= val & (BIT(0) | BIT(1) | BIT(2));
+               config->eventctrl1 |= val & (TRCEVENTCTL1R_INSTEN_0 |
+                                            TRCEVENTCTL1R_INSTEN_1 |
+                                            TRCEVENTCTL1R_INSTEN_2);
                break;
        case 0x3:
                /* generate Event element for all 4 events */
-               config->eventctrl1 |= val & 0xF;
+               config->eventctrl1 |= val & (TRCEVENTCTL1R_INSTEN_0 |
+                                            TRCEVENTCTL1R_INSTEN_1 |
+                                            TRCEVENTCTL1R_INSTEN_2 |
+                                            TRCEVENTCTL1R_INSTEN_3);
                break;
        default:
                break;
@@ -702,10 +707,10 @@ static ssize_t bb_ctrl_store(struct device *dev,
         * individual range comparators. If include then at least 1
         * range must be selected.
         */
-       if ((val & BIT(8)) && (BMVAL(val, 0, 7) == 0))
+       if ((val & TRCBBCTLR_MODE) && (FIELD_GET(TRCBBCTLR_RANGE_MASK, val) == 0))
                return -EINVAL;
 
-       config->bb_ctrl = val & GENMASK(8, 0);
+       config->bb_ctrl = val & (TRCBBCTLR_MODE | TRCBBCTLR_RANGE_MASK);
        return size;
 }
 static DEVICE_ATTR_RW(bb_ctrl);
@@ -718,7 +723,7 @@ static ssize_t event_vinst_show(struct device *dev,
        struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
        struct etmv4_config *config = &drvdata->config;
 
-       val = config->vinst_ctrl & ETMv4_EVENT_MASK;
+       val = FIELD_GET(TRCVICTLR_EVENT_MASK, config->vinst_ctrl);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
 
@@ -734,9 +739,9 @@ static ssize_t event_vinst_store(struct device *dev,
                return -EINVAL;
 
        spin_lock(&drvdata->spinlock);
-       val &= ETMv4_EVENT_MASK;
-       config->vinst_ctrl &= ~ETMv4_EVENT_MASK;
-       config->vinst_ctrl |= val;
+       val &= TRCVICTLR_EVENT_MASK >> __bf_shf(TRCVICTLR_EVENT_MASK);
+       config->vinst_ctrl &= ~TRCVICTLR_EVENT_MASK;
+       config->vinst_ctrl |= FIELD_PREP(TRCVICTLR_EVENT_MASK, val);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -750,7 +755,7 @@ static ssize_t s_exlevel_vinst_show(struct device *dev,
        struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
        struct etmv4_config *config = &drvdata->config;
 
-       val = (config->vinst_ctrl & TRCVICTLR_EXLEVEL_S_MASK) >> TRCVICTLR_EXLEVEL_S_SHIFT;
+       val = FIELD_GET(TRCVICTLR_EXLEVEL_S_MASK, config->vinst_ctrl);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
 
@@ -767,10 +772,10 @@ static ssize_t s_exlevel_vinst_store(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        /* clear all EXLEVEL_S bits  */
-       config->vinst_ctrl &= ~(TRCVICTLR_EXLEVEL_S_MASK);
+       config->vinst_ctrl &= ~TRCVICTLR_EXLEVEL_S_MASK;
        /* enable instruction tracing for corresponding exception level */
        val &= drvdata->s_ex_level;
-       config->vinst_ctrl |= (val << TRCVICTLR_EXLEVEL_S_SHIFT);
+       config->vinst_ctrl |= val << __bf_shf(TRCVICTLR_EXLEVEL_S_MASK);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -785,7 +790,7 @@ static ssize_t ns_exlevel_vinst_show(struct device *dev,
        struct etmv4_config *config = &drvdata->config;
 
        /* EXLEVEL_NS, bits[23:20] */
-       val = (config->vinst_ctrl & TRCVICTLR_EXLEVEL_NS_MASK) >> TRCVICTLR_EXLEVEL_NS_SHIFT;
+       val = FIELD_GET(TRCVICTLR_EXLEVEL_NS_MASK, config->vinst_ctrl);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
 
@@ -802,10 +807,10 @@ static ssize_t ns_exlevel_vinst_store(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        /* clear EXLEVEL_NS bits  */
-       config->vinst_ctrl &= ~(TRCVICTLR_EXLEVEL_NS_MASK);
+       config->vinst_ctrl &= ~TRCVICTLR_EXLEVEL_NS_MASK;
        /* enable instruction tracing for corresponding exception level */
        val &= drvdata->ns_ex_level;
-       config->vinst_ctrl |= (val << TRCVICTLR_EXLEVEL_NS_SHIFT);
+       config->vinst_ctrl |= val << __bf_shf(TRCVICTLR_EXLEVEL_NS_MASK);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -858,11 +863,11 @@ static ssize_t addr_instdatatype_show(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
-       val = BMVAL(config->addr_acc[idx], 0, 1);
+       val = FIELD_GET(TRCACATRn_TYPE_MASK, config->addr_acc[idx]);
        len = scnprintf(buf, PAGE_SIZE, "%s\n",
-                       val == ETM_INSTR_ADDR ? "instr" :
-                       (val == ETM_DATA_LOAD_ADDR ? "data_load" :
-                       (val == ETM_DATA_STORE_ADDR ? "data_store" :
+                       val == TRCACATRn_TYPE_ADDR ? "instr" :
+                       (val == TRCACATRn_TYPE_DATA_LOAD_ADDR ? "data_load" :
+                       (val == TRCACATRn_TYPE_DATA_STORE_ADDR ? "data_store" :
                        "data_load_store")));
        spin_unlock(&drvdata->spinlock);
        return len;
@@ -886,7 +891,7 @@ static ssize_t addr_instdatatype_store(struct device *dev,
        idx = config->addr_idx;
        if (!strcmp(str, "instr"))
                /* TYPE, bits[1:0] */
-               config->addr_acc[idx] &= ~(BIT(0) | BIT(1));
+               config->addr_acc[idx] &= ~TRCACATRn_TYPE_MASK;
 
        spin_unlock(&drvdata->spinlock);
        return size;
@@ -1144,7 +1149,7 @@ static ssize_t addr_ctxtype_show(struct device *dev,
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
        /* CONTEXTTYPE, bits[3:2] */
-       val = BMVAL(config->addr_acc[idx], 2, 3);
+       val = FIELD_GET(TRCACATRn_CONTEXTTYPE_MASK, config->addr_acc[idx]);
        len = scnprintf(buf, PAGE_SIZE, "%s\n", val == ETM_CTX_NONE ? "none" :
                        (val == ETM_CTX_CTXID ? "ctxid" :
                        (val == ETM_CTX_VMID ? "vmid" : "all")));
@@ -1170,18 +1175,18 @@ static ssize_t addr_ctxtype_store(struct device *dev,
        idx = config->addr_idx;
        if (!strcmp(str, "none"))
                /* start by clearing context type bits */
-               config->addr_acc[idx] &= ~(BIT(2) | BIT(3));
+               config->addr_acc[idx] &= ~TRCACATRn_CONTEXTTYPE_MASK;
        else if (!strcmp(str, "ctxid")) {
                /* 0b01 The trace unit performs a Context ID */
                if (drvdata->numcidc) {
-                       config->addr_acc[idx] |= BIT(2);
-                       config->addr_acc[idx] &= ~BIT(3);
+                       config->addr_acc[idx] |= TRCACATRn_CONTEXTTYPE_CTXID;
+                       config->addr_acc[idx] &= ~TRCACATRn_CONTEXTTYPE_VMID;
                }
        } else if (!strcmp(str, "vmid")) {
                /* 0b10 The trace unit performs a VMID */
                if (drvdata->numvmidc) {
-                       config->addr_acc[idx] &= ~BIT(2);
-                       config->addr_acc[idx] |= BIT(3);
+                       config->addr_acc[idx] &= ~TRCACATRn_CONTEXTTYPE_CTXID;
+                       config->addr_acc[idx] |= TRCACATRn_CONTEXTTYPE_VMID;
                }
        } else if (!strcmp(str, "all")) {
                /*
@@ -1189,9 +1194,9 @@ static ssize_t addr_ctxtype_store(struct device *dev,
                 * comparison and a VMID
                 */
                if (drvdata->numcidc)
-                       config->addr_acc[idx] |= BIT(2);
+                       config->addr_acc[idx] |= TRCACATRn_CONTEXTTYPE_CTXID;
                if (drvdata->numvmidc)
-                       config->addr_acc[idx] |= BIT(3);
+                       config->addr_acc[idx] |= TRCACATRn_CONTEXTTYPE_VMID;
        }
        spin_unlock(&drvdata->spinlock);
        return size;
@@ -1210,7 +1215,7 @@ static ssize_t addr_context_show(struct device *dev,
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
        /* context ID comparator bits[6:4] */
-       val = BMVAL(config->addr_acc[idx], 4, 6);
+       val = FIELD_GET(TRCACATRn_CONTEXT_MASK, config->addr_acc[idx]);
        spin_unlock(&drvdata->spinlock);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
@@ -1235,8 +1240,8 @@ static ssize_t addr_context_store(struct device *dev,
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
        /* clear context ID comparator bits[6:4] */
-       config->addr_acc[idx] &= ~(BIT(4) | BIT(5) | BIT(6));
-       config->addr_acc[idx] |= (val << 4);
+       config->addr_acc[idx] &= ~TRCACATRn_CONTEXT_MASK;
+       config->addr_acc[idx] |= val << __bf_shf(TRCACATRn_CONTEXT_MASK);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -1253,7 +1258,7 @@ static ssize_t addr_exlevel_s_ns_show(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
-       val = BMVAL(config->addr_acc[idx], 8, 14);
+       val = FIELD_GET(TRCACATRn_EXLEVEL_MASK, config->addr_acc[idx]);
        spin_unlock(&drvdata->spinlock);
        return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
 }
@@ -1270,14 +1275,14 @@ static ssize_t addr_exlevel_s_ns_store(struct device *dev,
        if (kstrtoul(buf, 0, &val))
                return -EINVAL;
 
-       if (val & ~((GENMASK(14, 8) >> 8)))
+       if (val & ~(TRCACATRn_EXLEVEL_MASK >> __bf_shf(TRCACATRn_EXLEVEL_MASK)))
                return -EINVAL;
 
        spin_lock(&drvdata->spinlock);
        idx = config->addr_idx;
        /* clear Exlevel_ns & Exlevel_s bits[14:12, 11:8], bit[15] is res0 */
-       config->addr_acc[idx] &= ~(GENMASK(14, 8));
-       config->addr_acc[idx] |= (val << 8);
+       config->addr_acc[idx] &= ~TRCACATRn_EXLEVEL_MASK;
+       config->addr_acc[idx] |= val << __bf_shf(TRCACATRn_EXLEVEL_MASK);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -1721,8 +1726,11 @@ static ssize_t res_ctrl_store(struct device *dev,
        /* For odd idx pair inversal bit is RES0 */
        if (idx % 2 != 0)
                /* PAIRINV, bit[21] */
-               val &= ~BIT(21);
-       config->res_ctrl[idx] = val & GENMASK(21, 0);
+               val &= ~TRCRSCTLRn_PAIRINV;
+       config->res_ctrl[idx] = val & (TRCRSCTLRn_PAIRINV |
+                                      TRCRSCTLRn_INV |
+                                      TRCRSCTLRn_GROUP_MASK |
+                                      TRCRSCTLRn_SELECT_MASK);
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -1787,9 +1795,9 @@ static ssize_t sshot_ctrl_store(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        idx = config->ss_idx;
-       config->ss_ctrl[idx] = val & GENMASK(24, 0);
+       config->ss_ctrl[idx] = FIELD_PREP(TRCSSCCRn_SAC_ARC_RST_MASK, val);
        /* must clear bit 31 in related status register on programming */
-       config->ss_status[idx] &= ~BIT(31);
+       config->ss_status[idx] &= ~TRCSSCSRn_STATUS;
        spin_unlock(&drvdata->spinlock);
        return size;
 }
@@ -1837,9 +1845,9 @@ static ssize_t sshot_pe_ctrl_store(struct device *dev,
 
        spin_lock(&drvdata->spinlock);
        idx = config->ss_idx;
-       config->ss_pe_cmp[idx] = val & GENMASK(7, 0);
+       config->ss_pe_cmp[idx] = FIELD_PREP(TRCSSPCICRn_PC_MASK, val);
        /* must clear bit 31 in related status register on programming */
-       config->ss_status[idx] &= ~BIT(31);
+       config->ss_status[idx] &= ~TRCSSCSRn_STATUS;
        spin_unlock(&drvdata->spinlock);
        return size;
 }