Merge branch 'for-5.15/amd-sfh' into for-linus
[linux-2.6-microblaze.git] / drivers / hid / amd-sfh-hid / amd_sfh_client.c
index 3589d99..840fd07 100644 (file)
@@ -17,7 +17,6 @@
 #include "amd_sfh_pcie.h"
 #include "amd_sfh_hid.h"
 
-#define AMD_SFH_IDLE_LOOP      200
 
 struct request_list {
        struct hid_device *hid;
@@ -77,6 +76,7 @@ int amd_sfh_get_report(struct hid_device *hid, int report_id, int report_type)
 static void amd_sfh_work(struct work_struct *work)
 {
        struct amdtp_cl_data *cli_data = container_of(work, struct amdtp_cl_data, work.work);
+       struct amd_input_data *in_data = cli_data->in_data;
        struct request_list *req_node;
        u8 current_index, sensor_index;
        u8 report_id, node_type;
@@ -101,13 +101,11 @@ static void amd_sfh_work(struct work_struct *work)
                        pr_err("AMDSFH: Invalid report size\n");
 
        } else if (node_type == HID_INPUT_REPORT) {
-               report_size = get_input_report(sensor_index, report_id,
-                                              cli_data->input_report[current_index],
-                                              cli_data->sensor_virt_addr[current_index]);
+               report_size = get_input_report(current_index, sensor_index, report_id, in_data);
                if (report_size)
                        hid_input_report(cli_data->hid_sensor_hubs[current_index],
                                         cli_data->report_type[current_index],
-                                        cli_data->input_report[current_index], report_size, 0);
+                                        in_data->input_report[current_index], report_size, 0);
                else
                        pr_err("AMDSFH: Invalid report size\n");
        }
@@ -119,45 +117,54 @@ static void amd_sfh_work(struct work_struct *work)
 static void amd_sfh_work_buffer(struct work_struct *work)
 {
        struct amdtp_cl_data *cli_data = container_of(work, struct amdtp_cl_data, work_buffer.work);
+       struct amd_input_data *in_data = cli_data->in_data;
        u8 report_size;
        int i;
 
        for (i = 0; i < cli_data->num_hid_devices; i++) {
-               report_size = get_input_report(cli_data->sensor_idx[i], cli_data->report_id[i],
-                                              cli_data->input_report[i],
-                                              cli_data->sensor_virt_addr[i]);
-               hid_input_report(cli_data->hid_sensor_hubs[i], HID_INPUT_REPORT,
-                                cli_data->input_report[i], report_size, 0);
+               if (cli_data->sensor_sts[i] == SENSOR_ENABLED) {
+                       report_size = get_input_report
+                               (i, cli_data->sensor_idx[i], cli_data->report_id[i], in_data);
+                       hid_input_report(cli_data->hid_sensor_hubs[i], HID_INPUT_REPORT,
+                                        in_data->input_report[i], report_size, 0);
+               }
        }
        schedule_delayed_work(&cli_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP));
 }
 
+u32 amd_sfh_wait_for_response(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_sts)
+{
+       if (mp2->mp2_ops->response)
+               sensor_sts = mp2->mp2_ops->response(mp2, sid, sensor_sts);
+
+       return sensor_sts;
+}
+
 int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
 {
+       struct amd_input_data *in_data = &privdata->in_data;
        struct amdtp_cl_data *cl_data = privdata->cl_data;
        struct amd_mp2_sensor_info info;
        struct device *dev;
        u32 feature_report_size;
        u32 input_report_size;
+       int rc, i, status;
        u8 cl_idx;
-       int rc, i;
 
        dev = &privdata->pdev->dev;
-       cl_data = devm_kzalloc(dev, sizeof(*cl_data), GFP_KERNEL);
-       if (!cl_data)
-               return -ENOMEM;
 
        cl_data->num_hid_devices = amd_mp2_get_sensor_num(privdata, &cl_data->sensor_idx[0]);
 
        INIT_DELAYED_WORK(&cl_data->work, amd_sfh_work);
        INIT_DELAYED_WORK(&cl_data->work_buffer, amd_sfh_work_buffer);
        INIT_LIST_HEAD(&req_list.list);
+       cl_data->in_data = in_data;
 
        for (i = 0; i < cl_data->num_hid_devices; i++) {
-               cl_data->sensor_virt_addr[i] = dma_alloc_coherent(dev, sizeof(int) * 8,
+               in_data->sensor_virt_addr[i] = dma_alloc_coherent(dev, sizeof(int) * 8,
                                                                  &cl_data->sensor_dma_addr[i],
                                                                  GFP_KERNEL);
-               cl_data->sensor_sts[i] = 0;
+               cl_data->sensor_sts[i] = SENSOR_DISABLED;
                cl_data->sensor_requested_cnt[i] = 0;
                cl_data->cur_hid_dev = i;
                cl_idx = cl_data->sensor_idx[i];
@@ -181,12 +188,12 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
                        rc = -ENOMEM;
                        goto cleanup;
                }
-               cl_data->input_report[i] = devm_kzalloc(dev, input_report_size, GFP_KERNEL);
-               if (!cl_data->input_report[i]) {
+               in_data->input_report[i] = devm_kzalloc(dev, input_report_size, GFP_KERNEL);
+               if (!in_data->input_report[i]) {
                        rc = -ENOMEM;
                        goto cleanup;
                }
-               info.period = msecs_to_jiffies(AMD_SFH_IDLE_LOOP);
+               info.period = AMD_SFH_IDLE_LOOP;
                info.sensor_idx = cl_idx;
                info.dma_address = cl_data->sensor_dma_addr[i];
 
@@ -199,47 +206,69 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
                rc = get_report_descriptor(cl_idx, cl_data->report_descr[i]);
                if (rc)
                        return rc;
-               rc = amdtp_hid_probe(cl_data->cur_hid_dev, cl_data);
-               if (rc)
-                       return rc;
-               amd_start_sensor(privdata, info);
-               cl_data->sensor_sts[i] = 1;
+               privdata->mp2_ops->start(privdata, info);
+               status = amd_sfh_wait_for_response
+                               (privdata, cl_data->sensor_idx[i], SENSOR_ENABLED);
+               if (status == SENSOR_ENABLED) {
+                       cl_data->sensor_sts[i] = SENSOR_ENABLED;
+                       rc = amdtp_hid_probe(cl_data->cur_hid_dev, cl_data);
+                       if (rc) {
+                               privdata->mp2_ops->stop(privdata, cl_data->sensor_idx[i]);
+                               status = amd_sfh_wait_for_response
+                                       (privdata, cl_data->sensor_idx[i], SENSOR_DISABLED);
+                               if (status != SENSOR_ENABLED)
+                                       cl_data->sensor_sts[i] = SENSOR_DISABLED;
+                               dev_dbg(dev, "sid 0x%x status 0x%x\n",
+                                       cl_data->sensor_idx[i], cl_data->sensor_sts[i]);
+                               goto cleanup;
+                       }
+               }
+               dev_dbg(dev, "sid 0x%x status 0x%x\n",
+                       cl_data->sensor_idx[i], cl_data->sensor_sts[i]);
        }
-       privdata->cl_data = cl_data;
        schedule_delayed_work(&cl_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP));
        return 0;
 
 cleanup:
        for (i = 0; i < cl_data->num_hid_devices; i++) {
-               if (cl_data->sensor_virt_addr[i]) {
+               if (in_data->sensor_virt_addr[i]) {
                        dma_free_coherent(&privdata->pdev->dev, 8 * sizeof(int),
-                                         cl_data->sensor_virt_addr[i],
+                                         in_data->sensor_virt_addr[i],
                                          cl_data->sensor_dma_addr[i]);
                }
                devm_kfree(dev, cl_data->feature_report[i]);
-               devm_kfree(dev, cl_data->input_report[i]);
+               devm_kfree(dev, in_data->input_report[i]);
                devm_kfree(dev, cl_data->report_descr[i]);
        }
-       devm_kfree(dev, cl_data);
        return rc;
 }
 
 int amd_sfh_hid_client_deinit(struct amd_mp2_dev *privdata)
 {
        struct amdtp_cl_data *cl_data = privdata->cl_data;
-       int i;
+       struct amd_input_data *in_data = cl_data->in_data;
+       int i, status;
 
-       for (i = 0; i < cl_data->num_hid_devices; i++)
-               amd_stop_sensor(privdata, i);
+       for (i = 0; i < cl_data->num_hid_devices; i++) {
+               if (cl_data->sensor_sts[i] == SENSOR_ENABLED) {
+                       privdata->mp2_ops->stop(privdata, cl_data->sensor_idx[i]);
+                       status = amd_sfh_wait_for_response
+                                       (privdata, cl_data->sensor_idx[i], SENSOR_DISABLED);
+                       if (status != SENSOR_ENABLED)
+                               cl_data->sensor_sts[i] = SENSOR_DISABLED;
+                       dev_dbg(&privdata->pdev->dev, "stopping sid 0x%x status 0x%x\n",
+                               cl_data->sensor_idx[i], cl_data->sensor_sts[i]);
+               }
+       }
 
        cancel_delayed_work_sync(&cl_data->work);
        cancel_delayed_work_sync(&cl_data->work_buffer);
        amdtp_hid_remove(cl_data);
 
        for (i = 0; i < cl_data->num_hid_devices; i++) {
-               if (cl_data->sensor_virt_addr[i]) {
+               if (in_data->sensor_virt_addr[i]) {
                        dma_free_coherent(&privdata->pdev->dev, 8 * sizeof(int),
-                                         cl_data->sensor_virt_addr[i],
+                                         in_data->sensor_virt_addr[i],
                                          cl_data->sensor_dma_addr[i]);
                }
        }