Merge tag 'drm-msm-next-2022-05-09' of https://gitlab.freedesktop.org/drm/msm into...
[linux-2.6-microblaze.git] / drivers / gpu / drm / msm / msm_gem.c
index a4f6197..97d5b4d 100644 (file)
@@ -376,39 +376,40 @@ put_iova_vmas(struct drm_gem_object *obj)
        }
 }
 
-static int get_iova_locked(struct drm_gem_object *obj,
-               struct msm_gem_address_space *aspace, uint64_t *iova,
+static struct msm_gem_vma *get_vma_locked(struct drm_gem_object *obj,
+               struct msm_gem_address_space *aspace,
                u64 range_start, u64 range_end)
 {
        struct msm_gem_vma *vma;
-       int ret = 0;
 
        GEM_WARN_ON(!msm_gem_is_locked(obj));
 
        vma = lookup_vma(obj, aspace);
 
        if (!vma) {
+               int ret;
+
                vma = add_vma(obj, aspace);
                if (IS_ERR(vma))
-                       return PTR_ERR(vma);
+                       return vma;
 
-               ret = msm_gem_init_vma(aspace, vma, obj->size >> PAGE_SHIFT,
+               ret = msm_gem_init_vma(aspace, vma, obj->size,
                        range_start, range_end);
                if (ret) {
                        del_vma(vma);
-                       return ret;
+                       return ERR_PTR(ret);
                }
+       } else {
+               GEM_WARN_ON(vma->iova < range_start);
+               GEM_WARN_ON((vma->iova + obj->size) > range_end);
        }
 
-       *iova = vma->iova;
-       return 0;
+       return vma;
 }
 
-static int msm_gem_pin_iova(struct drm_gem_object *obj,
-               struct msm_gem_address_space *aspace)
+int msm_gem_pin_vma_locked(struct drm_gem_object *obj, struct msm_gem_vma *vma)
 {
        struct msm_gem_object *msm_obj = to_msm_bo(obj);
-       struct msm_gem_vma *vma;
        struct page **pages;
        int ret, prot = IOMMU_READ;
 
@@ -426,16 +427,11 @@ static int msm_gem_pin_iova(struct drm_gem_object *obj,
        if (GEM_WARN_ON(msm_obj->madv != MSM_MADV_WILLNEED))
                return -EBUSY;
 
-       vma = lookup_vma(obj, aspace);
-       if (GEM_WARN_ON(!vma))
-               return -EINVAL;
-
        pages = get_pages(obj);
        if (IS_ERR(pages))
                return PTR_ERR(pages);
 
-       ret = msm_gem_map_vma(aspace, vma, prot,
-                       msm_obj->sgt, obj->size >> PAGE_SHIFT);
+       ret = msm_gem_map_vma(vma->aspace, vma, prot, msm_obj->sgt, obj->size);
 
        if (!ret)
                msm_obj->pin_count++;
@@ -443,23 +439,42 @@ static int msm_gem_pin_iova(struct drm_gem_object *obj,
        return ret;
 }
 
+void msm_gem_unpin_vma_locked(struct drm_gem_object *obj, struct msm_gem_vma *vma)
+{
+       struct msm_gem_object *msm_obj = to_msm_bo(obj);
+
+       GEM_WARN_ON(!msm_gem_is_locked(obj));
+
+       msm_gem_unpin_vma(vma);
+
+       msm_obj->pin_count--;
+       GEM_WARN_ON(msm_obj->pin_count < 0);
+
+       update_inactive(msm_obj);
+}
+
+struct msm_gem_vma *msm_gem_get_vma_locked(struct drm_gem_object *obj,
+                                          struct msm_gem_address_space *aspace)
+{
+       return get_vma_locked(obj, aspace, 0, U64_MAX);
+}
+
 static int get_and_pin_iova_range_locked(struct drm_gem_object *obj,
                struct msm_gem_address_space *aspace, uint64_t *iova,
                u64 range_start, u64 range_end)
 {
-       u64 local;
+       struct msm_gem_vma *vma;
        int ret;
 
        GEM_WARN_ON(!msm_gem_is_locked(obj));
 
-       ret = get_iova_locked(obj, aspace, &local,
-               range_start, range_end);
-
-       if (!ret)
-               ret = msm_gem_pin_iova(obj, aspace);
+       vma = get_vma_locked(obj, aspace, range_start, range_end);
+       if (IS_ERR(vma))
+               return PTR_ERR(vma);
 
+       ret = msm_gem_pin_vma_locked(obj, vma);
        if (!ret)
-               *iova = local;
+               *iova = vma->iova;
 
        return ret;
 }
@@ -481,12 +496,6 @@ int msm_gem_get_and_pin_iova_range(struct drm_gem_object *obj,
        return ret;
 }
 
-int msm_gem_get_and_pin_iova_locked(struct drm_gem_object *obj,
-               struct msm_gem_address_space *aspace, uint64_t *iova)
-{
-       return get_and_pin_iova_range_locked(obj, aspace, iova, 0, U64_MAX);
-}
-
 /* get iova and pin it. Should have a matching put */
 int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
                struct msm_gem_address_space *aspace, uint64_t *iova)
@@ -501,52 +510,67 @@ int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
 int msm_gem_get_iova(struct drm_gem_object *obj,
                struct msm_gem_address_space *aspace, uint64_t *iova)
 {
-       int ret;
+       struct msm_gem_vma *vma;
+       int ret = 0;
 
        msm_gem_lock(obj);
-       ret = get_iova_locked(obj, aspace, iova, 0, U64_MAX);
+       vma = get_vma_locked(obj, aspace, 0, U64_MAX);
+       if (IS_ERR(vma)) {
+               ret = PTR_ERR(vma);
+       } else {
+               *iova = vma->iova;
+       }
        msm_gem_unlock(obj);
 
        return ret;
 }
 
-/* get iova without taking a reference, used in places where you have
- * already done a 'msm_gem_get_and_pin_iova' or 'msm_gem_get_iova'
- */
-uint64_t msm_gem_iova(struct drm_gem_object *obj,
-               struct msm_gem_address_space *aspace)
+static int clear_iova(struct drm_gem_object *obj,
+                     struct msm_gem_address_space *aspace)
 {
-       struct msm_gem_vma *vma;
+       struct msm_gem_vma *vma = lookup_vma(obj, aspace);
 
-       msm_gem_lock(obj);
-       vma = lookup_vma(obj, aspace);
-       msm_gem_unlock(obj);
-       GEM_WARN_ON(!vma);
+       if (!vma)
+               return 0;
+
+       if (msm_gem_vma_inuse(vma))
+               return -EBUSY;
 
-       return vma ? vma->iova : 0;
+       msm_gem_purge_vma(vma->aspace, vma);
+       msm_gem_close_vma(vma->aspace, vma);
+       del_vma(vma);
+
+       return 0;
 }
 
 /*
- * Locked variant of msm_gem_unpin_iova()
+ * Get the requested iova but don't pin it.  Fails if the requested iova is
+ * not available.  Doesn't need a put because iovas are currently valid for
+ * the life of the object.
+ *
+ * Setting an iova of zero will clear the vma.
  */
-void msm_gem_unpin_iova_locked(struct drm_gem_object *obj,
-               struct msm_gem_address_space *aspace)
+int msm_gem_set_iova(struct drm_gem_object *obj,
+                    struct msm_gem_address_space *aspace, uint64_t iova)
 {
-       struct msm_gem_object *msm_obj = to_msm_bo(obj);
-       struct msm_gem_vma *vma;
-
-       GEM_WARN_ON(!msm_gem_is_locked(obj));
-
-       vma = lookup_vma(obj, aspace);
-
-       if (!GEM_WARN_ON(!vma)) {
-               msm_gem_unmap_vma(aspace, vma);
-
-               msm_obj->pin_count--;
-               GEM_WARN_ON(msm_obj->pin_count < 0);
+       int ret = 0;
 
-               update_inactive(msm_obj);
+       msm_gem_lock(obj);
+       if (!iova) {
+               ret = clear_iova(obj, aspace);
+       } else {
+               struct msm_gem_vma *vma;
+               vma = get_vma_locked(obj, aspace, iova, iova + obj->size);
+               if (IS_ERR(vma)) {
+                       ret = PTR_ERR(vma);
+               } else if (GEM_WARN_ON(vma->iova != iova)) {
+                       clear_iova(obj, aspace);
+                       ret = -EBUSY;
+               }
        }
+       msm_gem_unlock(obj);
+
+       return ret;
 }
 
 /*
@@ -557,8 +581,13 @@ void msm_gem_unpin_iova_locked(struct drm_gem_object *obj,
 void msm_gem_unpin_iova(struct drm_gem_object *obj,
                struct msm_gem_address_space *aspace)
 {
+       struct msm_gem_vma *vma;
+
        msm_gem_lock(obj);
-       msm_gem_unpin_iova_locked(obj, aspace);
+       vma = lookup_vma(obj, aspace);
+       if (!GEM_WARN_ON(!vma)) {
+               msm_gem_unpin_vma_locked(obj, vma);
+       }
        msm_gem_unlock(obj);
 }
 
@@ -848,7 +877,8 @@ int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout)
                op & MSM_PREP_NOSYNC ? 0 : timeout_to_jiffies(timeout);
        long ret;
 
-       ret = dma_resv_wait_timeout(obj->resv, write, true,  remain);
+       ret = dma_resv_wait_timeout(obj->resv, dma_resv_usage_rw(write),
+                                   true,  remain);
        if (ret == 0)
                return remain == 0 ? -EBUSY : -ETIMEDOUT;
        else if (ret < 0)
@@ -938,7 +968,7 @@ void msm_gem_describe(struct drm_gem_object *obj, struct seq_file *m,
                                name, comm ? ":" : "", comm ? comm : "",
                                vma->aspace, vma->iova,
                                vma->mapped ? "mapped" : "unmapped",
-                               vma->inuse);
+                               msm_gem_vma_inuse(vma));
                        kfree(comm);
                }