drm/amdgpu: print what method we are using for runtime pm
[linux-2.6-microblaze.git] / drivers / gpu / drm / amd / amdgpu / amdgpu_kms.c
index 4145480..b16b327 100644 (file)
@@ -29,7 +29,6 @@
 #include "amdgpu.h"
 #include <drm/drm_debugfs.h>
 #include <drm/amdgpu_drm.h>
-#include "amdgpu_sched.h"
 #include "amdgpu_uvd.h"
 #include "amdgpu_vce.h"
 #include "atom.h"
@@ -78,7 +77,7 @@ void amdgpu_unregister_gpu_instance(struct amdgpu_device *adev)
  */
 void amdgpu_driver_unload_kms(struct drm_device *dev)
 {
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
 
        if (adev == NULL)
                return;
@@ -86,7 +85,7 @@ void amdgpu_driver_unload_kms(struct drm_device *dev)
        amdgpu_unregister_gpu_instance(adev);
 
        if (adev->rmmio == NULL)
-               goto done_free;
+               return;
 
        if (adev->runpm) {
                pm_runtime_get_sync(dev->dev);
@@ -94,12 +93,7 @@ void amdgpu_driver_unload_kms(struct drm_device *dev)
        }
 
        amdgpu_acpi_fini(adev);
-
        amdgpu_device_fini(adev);
-
-done_free:
-       kfree(adev);
-       dev->dev_private = NULL;
 }
 
 void amdgpu_register_gpu_instance(struct amdgpu_device *adev)
@@ -130,22 +124,19 @@ void amdgpu_register_gpu_instance(struct amdgpu_device *adev)
 /**
  * amdgpu_driver_load_kms - Main load function for KMS.
  *
- * @dev: drm dev pointer
+ * @adev: pointer to struct amdgpu_device
  * @flags: device flags
  *
  * This is the main load function for KMS (all asics).
  * Returns 0 on success, error on failure.
  */
-int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
+int amdgpu_driver_load_kms(struct amdgpu_device *adev, unsigned long flags)
 {
-       struct amdgpu_device *adev;
+       struct drm_device *dev;
+       struct pci_dev *parent;
        int r, acpi_status;
 
-       adev = kzalloc(sizeof(struct amdgpu_device), GFP_KERNEL);
-       if (adev == NULL) {
-               return -ENOMEM;
-       }
-       dev->dev_private = (void *)adev;
+       dev = adev_to_drm(adev);
 
        if (amdgpu_has_atpx() &&
            (amdgpu_is_atpx_hybrid() ||
@@ -154,28 +145,32 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
            !pci_is_thunderbolt_attached(dev->pdev))
                flags |= AMD_IS_PX;
 
+       parent = pci_upstream_bridge(adev->pdev);
+       adev->has_pr3 = parent ? pci_pr3_present(parent) : false;
+
        /* amdgpu_device_init should report only fatal error
         * like memory allocation failure or iomapping failure,
         * or memory manager initialization failure, it must
         * properly initialize the GPU MC controller and permit
         * VRAM allocation
         */
-       r = amdgpu_device_init(adev, dev, dev->pdev, flags);
+       r = amdgpu_device_init(adev, flags);
        if (r) {
                dev_err(&dev->pdev->dev, "Fatal error during GPU init\n");
                goto out;
        }
 
-       if (amdgpu_device_supports_boco(dev) &&
-           (amdgpu_runtime_pm != 0)) { /* enable runpm by default for boco */
+       if (amdgpu_device_supports_atpx(dev) &&
+           (amdgpu_runtime_pm != 0)) { /* enable runpm by default for atpx */
+               adev->runpm = true;
+               dev_info(adev->dev, "Using ATPX for runtime pm\n");
+       } else if (amdgpu_device_supports_boco(dev) &&
+                  (amdgpu_runtime_pm != 0)) { /* enable runpm by default for boco */
                adev->runpm = true;
+               dev_info(adev->dev, "Using BOCO for runtime pm\n");
        } else if (amdgpu_device_supports_baco(dev) &&
                   (amdgpu_runtime_pm != 0)) {
                switch (adev->asic_type) {
-#ifdef CONFIG_DRM_AMDGPU_CIK
-               case CHIP_BONAIRE:
-               case CHIP_HAWAII:
-#endif
                case CHIP_VEGA20:
                case CHIP_ARCTURUS:
                case CHIP_SIENNA_CICHLID:
@@ -186,14 +181,16 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
                        break;
                case CHIP_VEGA10:
                        /* turn runpm on if noretry=0 */
-                       if (!amdgpu_noretry)
+                       if (!adev->gmc.noretry)
                                adev->runpm = true;
                        break;
                default:
-                       /* enable runpm on VI+ */
+                       /* enable runpm on CI+ */
                        adev->runpm = true;
                        break;
                }
+               if (adev->runpm)
+                       dev_info(adev->dev, "Using BACO for runtime pm\n");
        }
 
        /* Call ACPI methods: require modeset init
@@ -206,7 +203,7 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
 
        if (adev->runpm) {
                /* only need to skip on ATPX */
-               if (amdgpu_device_supports_boco(dev) &&
+               if (amdgpu_device_supports_atpx(dev) &&
                    !amdgpu_is_atpx_hybrid())
                        dev_pm_set_driver_flags(dev->dev, DPM_FLAG_NO_DIRECT_COMPLETE);
                pm_runtime_use_autosuspend(dev->dev);
@@ -291,14 +288,25 @@ static int amdgpu_firmware_info(struct drm_amdgpu_info_firmware *fw_info,
                fw_info->feature = 0;
                break;
        case AMDGPU_INFO_FW_TA:
-               if (query_fw->index > 1)
-                       return -EINVAL;
-               if (query_fw->index == 0) {
+               switch (query_fw->index) {
+               case 0:
                        fw_info->ver = adev->psp.ta_fw_version;
                        fw_info->feature = adev->psp.ta_xgmi_ucode_version;
-               } else {
+                       break;
+               case 1:
                        fw_info->ver = adev->psp.ta_fw_version;
                        fw_info->feature = adev->psp.ta_ras_ucode_version;
+                       break;
+               case 2:
+                       fw_info->ver = adev->psp.ta_fw_version;
+                       fw_info->feature = adev->psp.ta_hdcp_ucode_version;
+                       break;
+               case 3:
+                       fw_info->ver = adev->psp.ta_fw_version;
+                       fw_info->feature = adev->psp.ta_dtm_ucode_version;
+                       break;
+               default:
+                       return -EINVAL;
                }
                break;
        case AMDGPU_INFO_FW_SDMA:
@@ -323,6 +331,10 @@ static int amdgpu_firmware_info(struct drm_amdgpu_info_firmware *fw_info,
                fw_info->ver = adev->dm.dmcub_fw_version;
                fw_info->feature = 0;
                break;
+       case AMDGPU_INFO_FW_TOC:
+               fw_info->ver = adev->psp.toc_fw_version;
+               fw_info->feature = adev->psp.toc_feature_version;
+               break;
        default:
                return -EINVAL;
        }
@@ -469,7 +481,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,
 /**
  * amdgpu_info_ioctl - answer a device specific request.
  *
- * @adev: amdgpu device pointer
+ * @dev: drm device pointer
  * @data: request object
  * @filp: drm filp
  *
@@ -478,9 +490,9 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,
  * etc. (all asics).
  * Returns 0 on success, -EINVAL on failure.
  */
-static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
+int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
 {
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        struct drm_amdgpu_info *info = data;
        struct amdgpu_mode_info *minfo = &adev->mode_info;
        void __user *out = (void __user *)(uintptr_t)info->return_pointer;
@@ -595,13 +607,13 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                ui64 = atomic64_read(&adev->num_vram_cpu_page_faults);
                return copy_to_user(out, &ui64, min(size, 8u)) ? -EFAULT : 0;
        case AMDGPU_INFO_VRAM_USAGE:
-               ui64 = amdgpu_vram_mgr_usage(&adev->mman.bdev.man[TTM_PL_VRAM]);
+               ui64 = amdgpu_vram_mgr_usage(ttm_manager_type(&adev->mman.bdev, TTM_PL_VRAM));
                return copy_to_user(out, &ui64, min(size, 8u)) ? -EFAULT : 0;
        case AMDGPU_INFO_VIS_VRAM_USAGE:
-               ui64 = amdgpu_vram_mgr_vis_usage(&adev->mman.bdev.man[TTM_PL_VRAM]);
+               ui64 = amdgpu_vram_mgr_vis_usage(ttm_manager_type(&adev->mman.bdev, TTM_PL_VRAM));
                return copy_to_user(out, &ui64, min(size, 8u)) ? -EFAULT : 0;
        case AMDGPU_INFO_GTT_USAGE:
-               ui64 = amdgpu_gtt_mgr_usage(&adev->mman.bdev.man[TTM_PL_TT]);
+               ui64 = amdgpu_gtt_mgr_usage(ttm_manager_type(&adev->mman.bdev, TTM_PL_TT));
                return copy_to_user(out, &ui64, min(size, 8u)) ? -EFAULT : 0;
        case AMDGPU_INFO_GDS_CONFIG: {
                struct drm_amdgpu_info_gds gds_info;
@@ -624,7 +636,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                        min(adev->gmc.visible_vram_size -
                            atomic64_read(&adev->visible_pin_size),
                            vram_gtt.vram_size);
-               vram_gtt.gtt_size = adev->mman.bdev.man[TTM_PL_TT].size;
+               vram_gtt.gtt_size = ttm_manager_type(&adev->mman.bdev, TTM_PL_TT)->size;
                vram_gtt.gtt_size *= PAGE_SIZE;
                vram_gtt.gtt_size -= atomic64_read(&adev->gart_pin_size);
                return copy_to_user(out, &vram_gtt,
@@ -632,14 +644,17 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
        }
        case AMDGPU_INFO_MEMORY: {
                struct drm_amdgpu_memory_info mem;
-
+               struct ttm_resource_manager *vram_man =
+                       ttm_manager_type(&adev->mman.bdev, TTM_PL_VRAM);
+               struct ttm_resource_manager *gtt_man =
+                       ttm_manager_type(&adev->mman.bdev, TTM_PL_TT);
                memset(&mem, 0, sizeof(mem));
                mem.vram.total_heap_size = adev->gmc.real_vram_size;
                mem.vram.usable_heap_size = adev->gmc.real_vram_size -
                        atomic64_read(&adev->vram_pin_size) -
                        AMDGPU_VM_RESERVED_VRAM;
                mem.vram.heap_usage =
-                       amdgpu_vram_mgr_usage(&adev->mman.bdev.man[TTM_PL_VRAM]);
+                       amdgpu_vram_mgr_usage(vram_man);
                mem.vram.max_allocation = mem.vram.usable_heap_size * 3 / 4;
 
                mem.cpu_accessible_vram.total_heap_size =
@@ -649,16 +664,16 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                            atomic64_read(&adev->visible_pin_size),
                            mem.vram.usable_heap_size);
                mem.cpu_accessible_vram.heap_usage =
-                       amdgpu_vram_mgr_vis_usage(&adev->mman.bdev.man[TTM_PL_VRAM]);
+                       amdgpu_vram_mgr_vis_usage(vram_man);
                mem.cpu_accessible_vram.max_allocation =
                        mem.cpu_accessible_vram.usable_heap_size * 3 / 4;
 
-               mem.gtt.total_heap_size = adev->mman.bdev.man[TTM_PL_TT].size;
+               mem.gtt.total_heap_size = gtt_man->size;
                mem.gtt.total_heap_size *= PAGE_SIZE;
                mem.gtt.usable_heap_size = mem.gtt.total_heap_size -
                        atomic64_read(&adev->gart_pin_size);
                mem.gtt.heap_usage =
-                       amdgpu_gtt_mgr_usage(&adev->mman.bdev.man[TTM_PL_TT]);
+                       amdgpu_gtt_mgr_usage(gtt_man);
                mem.gtt.max_allocation = mem.gtt.usable_heap_size * 3 / 4;
 
                return copy_to_user(out, &mem,
@@ -712,36 +727,42 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                return n ? -EFAULT : 0;
        }
        case AMDGPU_INFO_DEV_INFO: {
-               struct drm_amdgpu_info_device dev_info;
+               struct drm_amdgpu_info_device *dev_info;
                uint64_t vm_size;
+               int ret;
+
+               dev_info = kzalloc(sizeof(*dev_info), GFP_KERNEL);
+               if (!dev_info)
+                       return -ENOMEM;
 
-               memset(&dev_info, 0, sizeof(dev_info));
-               dev_info.device_id = dev->pdev->device;
-               dev_info.chip_rev = adev->rev_id;
-               dev_info.external_rev = adev->external_rev_id;
-               dev_info.pci_rev = dev->pdev->revision;
-               dev_info.family = adev->family;
-               dev_info.num_shader_engines = adev->gfx.config.max_shader_engines;
-               dev_info.num_shader_arrays_per_engine = adev->gfx.config.max_sh_per_se;
+               dev_info->device_id = dev->pdev->device;
+               dev_info->chip_rev = adev->rev_id;
+               dev_info->external_rev = adev->external_rev_id;
+               dev_info->pci_rev = dev->pdev->revision;
+               dev_info->family = adev->family;
+               dev_info->num_shader_engines = adev->gfx.config.max_shader_engines;
+               dev_info->num_shader_arrays_per_engine = adev->gfx.config.max_sh_per_se;
                /* return all clocks in KHz */
-               dev_info.gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10;
+               dev_info->gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10;
                if (adev->pm.dpm_enabled) {
-                       dev_info.max_engine_clock = amdgpu_dpm_get_sclk(adev, false) * 10;
-                       dev_info.max_memory_clock = amdgpu_dpm_get_mclk(adev, false) * 10;
+                       dev_info->max_engine_clock = amdgpu_dpm_get_sclk(adev, false) * 10;
+                       dev_info->max_memory_clock = amdgpu_dpm_get_mclk(adev, false) * 10;
                } else {
-                       dev_info.max_engine_clock = adev->clock.default_sclk * 10;
-                       dev_info.max_memory_clock = adev->clock.default_mclk * 10;
+                       dev_info->max_engine_clock = adev->clock.default_sclk * 10;
+                       dev_info->max_memory_clock = adev->clock.default_mclk * 10;
                }
-               dev_info.enabled_rb_pipes_mask = adev->gfx.config.backend_enable_mask;
-               dev_info.num_rb_pipes = adev->gfx.config.max_backends_per_se *
+               dev_info->enabled_rb_pipes_mask = adev->gfx.config.backend_enable_mask;
+               dev_info->num_rb_pipes = adev->gfx.config.max_backends_per_se *
                        adev->gfx.config.max_shader_engines;
-               dev_info.num_hw_gfx_contexts = adev->gfx.config.max_hw_contexts;
-               dev_info._pad = 0;
-               dev_info.ids_flags = 0;
+               dev_info->num_hw_gfx_contexts = adev->gfx.config.max_hw_contexts;
+               dev_info->_pad = 0;
+               dev_info->ids_flags = 0;
                if (adev->flags & AMD_IS_APU)
-                       dev_info.ids_flags |= AMDGPU_IDS_FLAGS_FUSION;
+                       dev_info->ids_flags |= AMDGPU_IDS_FLAGS_FUSION;
                if (amdgpu_mcbp || amdgpu_sriov_vf(adev))
-                       dev_info.ids_flags |= AMDGPU_IDS_FLAGS_PREEMPTION;
+                       dev_info->ids_flags |= AMDGPU_IDS_FLAGS_PREEMPTION;
+               if (amdgpu_is_tmz(adev))
+                       dev_info->ids_flags |= AMDGPU_IDS_FLAGS_TMZ;
 
                vm_size = adev->vm_manager.max_pfn * AMDGPU_GPU_PAGE_SIZE;
                vm_size -= AMDGPU_VA_RESERVED_SIZE;
@@ -751,45 +772,47 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                    adev->vce.fw_version < AMDGPU_VCE_FW_53_45)
                        vm_size = min(vm_size, 1ULL << 40);
 
-               dev_info.virtual_address_offset = AMDGPU_VA_RESERVED_SIZE;
-               dev_info.virtual_address_max =
+               dev_info->virtual_address_offset = AMDGPU_VA_RESERVED_SIZE;
+               dev_info->virtual_address_max =
                        min(vm_size, AMDGPU_GMC_HOLE_START);
 
                if (vm_size > AMDGPU_GMC_HOLE_START) {
-                       dev_info.high_va_offset = AMDGPU_GMC_HOLE_END;
-                       dev_info.high_va_max = AMDGPU_GMC_HOLE_END | vm_size;
+                       dev_info->high_va_offset = AMDGPU_GMC_HOLE_END;
+                       dev_info->high_va_max = AMDGPU_GMC_HOLE_END | vm_size;
                }
-               dev_info.virtual_address_alignment = max((int)PAGE_SIZE, AMDGPU_GPU_PAGE_SIZE);
-               dev_info.pte_fragment_size = (1 << adev->vm_manager.fragment_size) * AMDGPU_GPU_PAGE_SIZE;
-               dev_info.gart_page_size = AMDGPU_GPU_PAGE_SIZE;
-               dev_info.cu_active_number = adev->gfx.cu_info.number;
-               dev_info.cu_ao_mask = adev->gfx.cu_info.ao_cu_mask;
-               dev_info.ce_ram_size = adev->gfx.ce_ram_size;
-               memcpy(&dev_info.cu_ao_bitmap[0], &adev->gfx.cu_info.ao_cu_bitmap[0],
+               dev_info->virtual_address_alignment = max((int)PAGE_SIZE, AMDGPU_GPU_PAGE_SIZE);
+               dev_info->pte_fragment_size = (1 << adev->vm_manager.fragment_size) * AMDGPU_GPU_PAGE_SIZE;
+               dev_info->gart_page_size = AMDGPU_GPU_PAGE_SIZE;
+               dev_info->cu_active_number = adev->gfx.cu_info.number;
+               dev_info->cu_ao_mask = adev->gfx.cu_info.ao_cu_mask;
+               dev_info->ce_ram_size = adev->gfx.ce_ram_size;
+               memcpy(&dev_info->cu_ao_bitmap[0], &adev->gfx.cu_info.ao_cu_bitmap[0],
                       sizeof(adev->gfx.cu_info.ao_cu_bitmap));
-               memcpy(&dev_info.cu_bitmap[0], &adev->gfx.cu_info.bitmap[0],
+               memcpy(&dev_info->cu_bitmap[0], &adev->gfx.cu_info.bitmap[0],
                       sizeof(adev->gfx.cu_info.bitmap));
-               dev_info.vram_type = adev->gmc.vram_type;
-               dev_info.vram_bit_width = adev->gmc.vram_width;
-               dev_info.vce_harvest_config = adev->vce.harvest_config;
-               dev_info.gc_double_offchip_lds_buf =
+               dev_info->vram_type = adev->gmc.vram_type;
+               dev_info->vram_bit_width = adev->gmc.vram_width;
+               dev_info->vce_harvest_config = adev->vce.harvest_config;
+               dev_info->gc_double_offchip_lds_buf =
                        adev->gfx.config.double_offchip_lds_buf;
-               dev_info.wave_front_size = adev->gfx.cu_info.wave_front_size;
-               dev_info.num_shader_visible_vgprs = adev->gfx.config.max_gprs;
-               dev_info.num_cu_per_sh = adev->gfx.config.max_cu_per_sh;
-               dev_info.num_tcc_blocks = adev->gfx.config.max_texture_channel_caches;
-               dev_info.gs_vgt_table_depth = adev->gfx.config.gs_vgt_table_depth;
-               dev_info.gs_prim_buffer_depth = adev->gfx.config.gs_prim_buffer_depth;
-               dev_info.max_gs_waves_per_vgt = adev->gfx.config.max_gs_threads;
+               dev_info->wave_front_size = adev->gfx.cu_info.wave_front_size;
+               dev_info->num_shader_visible_vgprs = adev->gfx.config.max_gprs;
+               dev_info->num_cu_per_sh = adev->gfx.config.max_cu_per_sh;
+               dev_info->num_tcc_blocks = adev->gfx.config.max_texture_channel_caches;
+               dev_info->gs_vgt_table_depth = adev->gfx.config.gs_vgt_table_depth;
+               dev_info->gs_prim_buffer_depth = adev->gfx.config.gs_prim_buffer_depth;
+               dev_info->max_gs_waves_per_vgt = adev->gfx.config.max_gs_threads;
 
                if (adev->family >= AMDGPU_FAMILY_NV)
-                       dev_info.pa_sc_tile_steering_override =
+                       dev_info->pa_sc_tile_steering_override =
                                adev->gfx.config.pa_sc_tile_steering_override;
 
-               dev_info.tcc_disabled_mask = adev->gfx.config.tcc_disabled_mask;
+               dev_info->tcc_disabled_mask = adev->gfx.config.tcc_disabled_mask;
 
-               return copy_to_user(out, &dev_info,
-                                   min((size_t)size, sizeof(dev_info))) ? -EFAULT : 0;
+               ret = copy_to_user(out, dev_info,
+                                  min((size_t)size, sizeof(*dev_info))) ? -EFAULT : 0;
+               kfree(dev_info);
+               return ret;
        }
        case AMDGPU_INFO_VCE_CLOCK_TABLE: {
                unsigned i;
@@ -995,7 +1018,7 @@ void amdgpu_driver_lastclose_kms(struct drm_device *dev)
  */
 int amdgpu_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv)
 {
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        struct amdgpu_fpriv *fpriv;
        int r, pasid;
 
@@ -1080,11 +1103,11 @@ pm_put:
 void amdgpu_driver_postclose_kms(struct drm_device *dev,
                                 struct drm_file *file_priv)
 {
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        struct amdgpu_fpriv *fpriv = file_priv->driver_priv;
        struct amdgpu_bo_list *list;
        struct amdgpu_bo *pd;
-       unsigned int pasid;
+       u32 pasid;
        int handle;
 
        if (!fpriv)
@@ -1145,7 +1168,7 @@ u32 amdgpu_get_vblank_counter_kms(struct drm_crtc *crtc)
 {
        struct drm_device *dev = crtc->dev;
        unsigned int pipe = crtc->index;
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        int vpos, hpos, stat;
        u32 count;
 
@@ -1213,7 +1236,7 @@ int amdgpu_enable_vblank_kms(struct drm_crtc *crtc)
 {
        struct drm_device *dev = crtc->dev;
        unsigned int pipe = crtc->index;
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        int idx = amdgpu_display_crtc_idx_to_irq_type(adev, pipe);
 
        return amdgpu_irq_get(adev, &adev->crtc_irq, idx);
@@ -1230,33 +1253,12 @@ void amdgpu_disable_vblank_kms(struct drm_crtc *crtc)
 {
        struct drm_device *dev = crtc->dev;
        unsigned int pipe = crtc->index;
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        int idx = amdgpu_display_crtc_idx_to_irq_type(adev, pipe);
 
        amdgpu_irq_put(adev, &adev->crtc_irq, idx);
 }
 
-const struct drm_ioctl_desc amdgpu_ioctls_kms[] = {
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_CREATE, amdgpu_gem_create_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_CTX, amdgpu_ctx_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_VM, amdgpu_vm_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_SCHED, amdgpu_sched_ioctl, DRM_MASTER),
-       DRM_IOCTL_DEF_DRV(AMDGPU_BO_LIST, amdgpu_bo_list_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_FENCE_TO_HANDLE, amdgpu_cs_fence_to_handle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       /* KMS */
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_MMAP, amdgpu_gem_mmap_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_WAIT_IDLE, amdgpu_gem_wait_idle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_CS, amdgpu_cs_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_INFO, amdgpu_info_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_WAIT_CS, amdgpu_cs_wait_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_WAIT_FENCES, amdgpu_cs_wait_fences_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_METADATA, amdgpu_gem_metadata_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_VA, amdgpu_gem_va_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_OP, amdgpu_gem_op_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-       DRM_IOCTL_DEF_DRV(AMDGPU_GEM_USERPTR, amdgpu_gem_userptr_ioctl, DRM_AUTH|DRM_RENDER_ALLOW)
-};
-const int amdgpu_max_kms_ioctl = ARRAY_SIZE(amdgpu_ioctls_kms);
-
 /*
  * Debugfs info
  */
@@ -1266,7 +1268,7 @@ static int amdgpu_debugfs_firmware_info(struct seq_file *m, void *data)
 {
        struct drm_info_node *node = (struct drm_info_node *) m->private;
        struct drm_device *dev = node->minor->dev;
-       struct amdgpu_device *adev = dev->dev_private;
+       struct amdgpu_device *adev = drm_to_adev(dev);
        struct drm_amdgpu_info_firmware fw_info;
        struct drm_amdgpu_query_fw query_fw;
        struct atom_context *ctx = adev->mode_info.atom_context;
@@ -1389,13 +1391,31 @@ static int amdgpu_debugfs_firmware_info(struct seq_file *m, void *data)
                   fw_info.feature, fw_info.ver);
 
        query_fw.fw_type = AMDGPU_INFO_FW_TA;
-       for (i = 0; i < 2; i++) {
+       for (i = 0; i < 4; i++) {
                query_fw.index = i;
                ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);
                if (ret)
                        continue;
-               seq_printf(m, "TA %s feature version: %u, firmware version: 0x%08x\n",
-                               i ? "RAS" : "XGMI", fw_info.feature, fw_info.ver);
+               switch (query_fw.index) {
+               case 0:
+                       seq_printf(m, "TA %s feature version: 0x%08x, firmware version: 0x%08x\n",
+                                       "RAS", fw_info.feature, fw_info.ver);
+                       break;
+               case 1:
+                       seq_printf(m, "TA %s feature version: 0x%08x, firmware version: 0x%08x\n",
+                                       "XGMI", fw_info.feature, fw_info.ver);
+                       break;
+               case 2:
+                       seq_printf(m, "TA %s feature version: 0x%08x, firmware version: 0x%08x\n",
+                                       "HDCP", fw_info.feature, fw_info.ver);
+                       break;
+               case 3:
+                       seq_printf(m, "TA %s feature version: 0x%08x, firmware version: 0x%08x\n",
+                                       "DTM", fw_info.feature, fw_info.ver);
+                       break;
+               default:
+                       return -EINVAL;
+               }
        }
 
        /* SMC */
@@ -1441,6 +1461,13 @@ static int amdgpu_debugfs_firmware_info(struct seq_file *m, void *data)
        seq_printf(m, "DMCUB feature version: %u, firmware version: 0x%08x\n",
                   fw_info.feature, fw_info.ver);
 
+       /* TOC */
+       query_fw.fw_type = AMDGPU_INFO_FW_TOC;
+       ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);
+       if (ret)
+               return ret;
+       seq_printf(m, "TOC feature version: %u, firmware version: 0x%08x\n",
+                  fw_info.feature, fw_info.ver);
 
        seq_printf(m, "VBIOS version: %s\n", ctx->vbios_version);