Merge branch 'RGMII-Internal-delay-common-property'
[linux-2.6-microblaze.git] / drivers / bluetooth / hci_qca.c
index d6e0c99..81c3c38 100644 (file)
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/of_device.h>
+#include <linux/acpi.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
 #include <linux/serdev.h>
+#include <linux/mutex.h>
 #include <asm/unaligned.h>
 
 #include <net/bluetooth/bluetooth.h>
@@ -69,9 +71,13 @@ enum qca_flags {
        QCA_IBS_ENABLED,
        QCA_DROP_VENDOR_EVENT,
        QCA_SUSPENDING,
-       QCA_MEMDUMP_COLLECTION
+       QCA_MEMDUMP_COLLECTION,
+       QCA_HW_ERROR_EVENT
 };
 
+enum qca_capabilities {
+       QCA_CAP_WIDEBAND_SPEECH = BIT(0),
+};
 
 /* HCI_IBS transmit side sleep protocol states */
 enum tx_ibs_states {
@@ -108,6 +114,7 @@ struct qca_memdump_data {
        char *memdump_buf_tail;
        u32 current_seq_no;
        u32 received_dump;
+       u32 ram_dump_size;
 };
 
 struct qca_memdump_event_hdr {
@@ -138,18 +145,19 @@ struct qca_data {
        u32 tx_idle_delay;
        struct timer_list wake_retrans_timer;
        u32 wake_retrans;
-       struct timer_list memdump_timer;
        struct workqueue_struct *workqueue;
        struct work_struct ws_awake_rx;
        struct work_struct ws_awake_device;
        struct work_struct ws_rx_vote_off;
        struct work_struct ws_tx_vote_off;
        struct work_struct ctrl_memdump_evt;
+       struct delayed_work ctrl_memdump_timeout;
        struct qca_memdump_data *qca_memdump;
        unsigned long flags;
        struct completion drop_ev_comp;
        wait_queue_head_t suspend_wait_q;
        enum qca_memdump_states memdump_state;
+       struct mutex hci_memdump_lock;
 
        /* For debugging purpose */
        u64 ibs_sent_wacks;
@@ -183,10 +191,11 @@ struct qca_vreg {
        unsigned int load_uA;
 };
 
-struct qca_vreg_data {
+struct qca_device_data {
        enum qca_btsoc_type soc_type;
        struct qca_vreg *vregs;
        size_t num_vregs;
+       uint32_t capabilities;
 };
 
 /*
@@ -522,23 +531,28 @@ static void hci_ibs_wake_retrans_timeout(struct timer_list *t)
                hci_uart_tx_wakeup(hu);
 }
 
-static void hci_memdump_timeout(struct timer_list *t)
+
+static void qca_controller_memdump_timeout(struct work_struct *work)
 {
-       struct qca_data *qca = from_timer(qca, t, tx_idle_timer);
+       struct qca_data *qca = container_of(work, struct qca_data,
+                                       ctrl_memdump_timeout.work);
        struct hci_uart *hu = qca->hu;
-       struct qca_memdump_data *qca_memdump = qca->qca_memdump;
-       char *memdump_buf = qca_memdump->memdump_buf_tail;
-
-       bt_dev_err(hu->hdev, "clearing allocated memory due to memdump timeout");
-       /* Inject hw error event to reset the device and driver. */
-       hci_reset_dev(hu->hdev);
-       vfree(memdump_buf);
-       kfree(qca_memdump);
-       qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
-       del_timer(&qca->memdump_timer);
-       cancel_work_sync(&qca->ctrl_memdump_evt);
+
+       mutex_lock(&qca->hci_memdump_lock);
+       if (test_bit(QCA_MEMDUMP_COLLECTION, &qca->flags)) {
+               qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
+               if (!test_bit(QCA_HW_ERROR_EVENT, &qca->flags)) {
+                       /* Inject hw error event to reset the device
+                        * and driver.
+                        */
+                       hci_reset_dev(hu->hdev);
+               }
+       }
+
+       mutex_unlock(&qca->hci_memdump_lock);
 }
 
+
 /* Initialize protocol */
 static int qca_open(struct hci_uart *hu)
 {
@@ -558,6 +572,7 @@ static int qca_open(struct hci_uart *hu)
        skb_queue_head_init(&qca->tx_wait_q);
        skb_queue_head_init(&qca->rx_memdump_q);
        spin_lock_init(&qca->hci_ibs_lock);
+       mutex_init(&qca->hci_memdump_lock);
        qca->workqueue = alloc_ordered_workqueue("qca_wq", 0);
        if (!qca->workqueue) {
                BT_ERR("QCA Workqueue not initialized properly");
@@ -570,6 +585,8 @@ static int qca_open(struct hci_uart *hu)
        INIT_WORK(&qca->ws_rx_vote_off, qca_wq_serial_rx_clock_vote_off);
        INIT_WORK(&qca->ws_tx_vote_off, qca_wq_serial_tx_clock_vote_off);
        INIT_WORK(&qca->ctrl_memdump_evt, qca_controller_memdump);
+       INIT_DELAYED_WORK(&qca->ctrl_memdump_timeout,
+                         qca_controller_memdump_timeout);
        init_waitqueue_head(&qca->suspend_wait_q);
 
        qca->hu = hu;
@@ -585,10 +602,12 @@ static int qca_open(struct hci_uart *hu)
 
        if (hu->serdev) {
                qcadev = serdev_device_get_drvdata(hu->serdev);
-               if (qca_is_wcn399x(qcadev->btsoc_type)) {
+
+               if (qca_is_wcn399x(qcadev->btsoc_type))
                        hu->init_speed = qcadev->init_speed;
+
+               if (qcadev->oper_speed)
                        hu->oper_speed = qcadev->oper_speed;
-               }
        }
 
        timer_setup(&qca->wake_retrans_timer, hci_ibs_wake_retrans_timeout, 0);
@@ -596,7 +615,6 @@ static int qca_open(struct hci_uart *hu)
 
        timer_setup(&qca->tx_idle_timer, hci_ibs_tx_idle_timeout, 0);
        qca->tx_idle_delay = IBS_HOST_TX_IDLE_TIMEOUT_MS;
-       timer_setup(&qca->memdump_timer, hci_memdump_timeout, 0);
 
        BT_DBG("HCI_UART_QCA open, tx_idle_delay=%u, wake_retrans=%u",
               qca->tx_idle_delay, qca->wake_retrans);
@@ -677,7 +695,6 @@ static int qca_close(struct hci_uart *hu)
        skb_queue_purge(&qca->rx_memdump_q);
        del_timer(&qca->tx_idle_timer);
        del_timer(&qca->wake_retrans_timer);
-       del_timer(&qca->memdump_timer);
        destroy_workqueue(qca->workqueue);
        qca->hu = NULL;
 
@@ -960,14 +977,25 @@ static void qca_controller_memdump(struct work_struct *work)
        char nullBuff[QCA_DUMP_PACKET_SIZE] = { 0 };
        u16 seq_no;
        u32 dump_size;
+       u32 rx_size;
+       enum qca_btsoc_type soc_type = qca_soc_type(hu);
 
        while ((skb = skb_dequeue(&qca->rx_memdump_q))) {
 
+               mutex_lock(&qca->hci_memdump_lock);
+               /* Skip processing the received packets if timeout detected. */
+               if (qca->memdump_state == QCA_MEMDUMP_TIMEOUT) {
+                       mutex_unlock(&qca->hci_memdump_lock);
+                       return;
+               }
+
                if (!qca_memdump) {
                        qca_memdump = kzalloc(sizeof(struct qca_memdump_data),
                                              GFP_ATOMIC);
-                       if (!qca_memdump)
+                       if (!qca_memdump) {
+                               mutex_unlock(&qca->hci_memdump_lock);
                                return;
+                       }
 
                        qca->qca_memdump = qca_memdump;
                }
@@ -992,16 +1020,20 @@ static void qca_controller_memdump(struct work_struct *work)
                        if (!(dump_size)) {
                                bt_dev_err(hu->hdev, "Rx invalid memdump size");
                                kfree_skb(skb);
+                               mutex_unlock(&qca->hci_memdump_lock);
                                return;
                        }
 
                        bt_dev_info(hu->hdev, "QCA collecting dump of size:%u",
                                    dump_size);
-                       mod_timer(&qca->memdump_timer, (jiffies +
-                                 msecs_to_jiffies(MEMDUMP_TIMEOUT_MS)));
+                       queue_delayed_work(qca->workqueue,
+                                          &qca->ctrl_memdump_timeout,
+                                          msecs_to_jiffies(MEMDUMP_TIMEOUT_MS)
+                                         );
 
                        skb_pull(skb, sizeof(dump_size));
                        memdump_buf = vmalloc(dump_size);
+                       qca_memdump->ram_dump_size = dump_size;
                        qca_memdump->memdump_buf_head = memdump_buf;
                        qca_memdump->memdump_buf_tail = memdump_buf;
                }
@@ -1016,6 +1048,7 @@ static void qca_controller_memdump(struct work_struct *work)
                        kfree(qca_memdump);
                        kfree_skb(skb);
                        qca->qca_memdump = NULL;
+                       mutex_unlock(&qca->hci_memdump_lock);
                        return;
                }
 
@@ -1023,39 +1056,74 @@ static void qca_controller_memdump(struct work_struct *work)
                 * the controller. In such cases let us store the dummy
                 * packets in the buffer.
                 */
+               /* For QCA6390, controller does not lost packets but
+                * sequence number field of packat sometimes has error
+                * bits, so skip this checking for missing packet.
+                */
                while ((seq_no > qca_memdump->current_seq_no + 1) &&
-                       seq_no != QCA_LAST_SEQUENCE_NUM) {
+                      (soc_type != QCA_QCA6390) &&
+                      seq_no != QCA_LAST_SEQUENCE_NUM) {
                        bt_dev_err(hu->hdev, "QCA controller missed packet:%d",
                                   qca_memdump->current_seq_no);
+                       rx_size = qca_memdump->received_dump;
+                       rx_size += QCA_DUMP_PACKET_SIZE;
+                       if (rx_size > qca_memdump->ram_dump_size) {
+                               bt_dev_err(hu->hdev,
+                                          "QCA memdump received %d, no space for missed packet",
+                                          qca_memdump->received_dump);
+                               break;
+                       }
                        memcpy(memdump_buf, nullBuff, QCA_DUMP_PACKET_SIZE);
                        memdump_buf = memdump_buf + QCA_DUMP_PACKET_SIZE;
                        qca_memdump->received_dump += QCA_DUMP_PACKET_SIZE;
                        qca_memdump->current_seq_no++;
                }
 
-               memcpy(memdump_buf, (unsigned char *) skb->data, skb->len);
-               memdump_buf = memdump_buf + skb->len;
-               qca_memdump->memdump_buf_tail = memdump_buf;
-               qca_memdump->current_seq_no = seq_no + 1;
-               qca_memdump->received_dump += skb->len;
+               rx_size = qca_memdump->received_dump + skb->len;
+               if (rx_size <= qca_memdump->ram_dump_size) {
+                       if ((seq_no != QCA_LAST_SEQUENCE_NUM) &&
+                           (seq_no != qca_memdump->current_seq_no))
+                               bt_dev_err(hu->hdev,
+                                          "QCA memdump unexpected packet %d",
+                                          seq_no);
+                       bt_dev_dbg(hu->hdev,
+                                  "QCA memdump packet %d with length %d",
+                                  seq_no, skb->len);
+                       memcpy(memdump_buf, (unsigned char *)skb->data,
+                              skb->len);
+                       memdump_buf = memdump_buf + skb->len;
+                       qca_memdump->memdump_buf_tail = memdump_buf;
+                       qca_memdump->current_seq_no = seq_no + 1;
+                       qca_memdump->received_dump += skb->len;
+               } else {
+                       bt_dev_err(hu->hdev,
+                                  "QCA memdump received %d, no space for packet %d",
+                                  qca_memdump->received_dump, seq_no);
+               }
                qca->qca_memdump = qca_memdump;
                kfree_skb(skb);
                if (seq_no == QCA_LAST_SEQUENCE_NUM) {
-                       bt_dev_info(hu->hdev, "QCA writing crash dump of size %d bytes",
-                                  qca_memdump->received_dump);
+                       bt_dev_info(hu->hdev,
+                                   "QCA memdump Done, received %d, total %d",
+                                   qca_memdump->received_dump,
+                                   qca_memdump->ram_dump_size);
                        memdump_buf = qca_memdump->memdump_buf_head;
                        dev_coredumpv(&hu->serdev->dev, memdump_buf,
                                      qca_memdump->received_dump, GFP_KERNEL);
-                       del_timer(&qca->memdump_timer);
+                       cancel_delayed_work(&qca->ctrl_memdump_timeout);
                        kfree(qca->qca_memdump);
                        qca->qca_memdump = NULL;
                        qca->memdump_state = QCA_MEMDUMP_COLLECTED;
+                       clear_bit(QCA_MEMDUMP_COLLECTION, &qca->flags);
                }
+
+               mutex_unlock(&qca->hci_memdump_lock);
        }
 
 }
 
-int qca_controller_memdump_event(struct hci_dev *hdev, struct sk_buff *skb)
+static int qca_controller_memdump_event(struct hci_dev *hdev,
+                                       struct sk_buff *skb)
 {
        struct hci_uart *hu = hci_get_drvdata(hdev);
        struct qca_data *qca = hu->priv;
@@ -1406,30 +1474,21 @@ static void qca_wait_for_dump_collection(struct hci_dev *hdev)
 {
        struct hci_uart *hu = hci_get_drvdata(hdev);
        struct qca_data *qca = hu->priv;
-       struct qca_memdump_data *qca_memdump = qca->qca_memdump;
-       char *memdump_buf = NULL;
 
        wait_on_bit_timeout(&qca->flags, QCA_MEMDUMP_COLLECTION,
                            TASK_UNINTERRUPTIBLE, MEMDUMP_TIMEOUT_MS);
 
        clear_bit(QCA_MEMDUMP_COLLECTION, &qca->flags);
-       if (qca->memdump_state == QCA_MEMDUMP_IDLE) {
-               bt_dev_err(hu->hdev, "Clearing the buffers due to timeout");
-               if (qca_memdump)
-                       memdump_buf = qca_memdump->memdump_buf_tail;
-               vfree(memdump_buf);
-               kfree(qca_memdump);
-               qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
-               del_timer(&qca->memdump_timer);
-               cancel_work_sync(&qca->ctrl_memdump_evt);
-       }
 }
 
 static void qca_hw_error(struct hci_dev *hdev, u8 code)
 {
        struct hci_uart *hu = hci_get_drvdata(hdev);
        struct qca_data *qca = hu->priv;
+       struct qca_memdump_data *qca_memdump = qca->qca_memdump;
+       char *memdump_buf = NULL;
 
+       set_bit(QCA_HW_ERROR_EVENT, &qca->flags);
        bt_dev_info(hdev, "mem_dump_status: %d", qca->memdump_state);
 
        if (qca->memdump_state == QCA_MEMDUMP_IDLE) {
@@ -1449,6 +1508,23 @@ static void qca_hw_error(struct hci_dev *hdev, u8 code)
                bt_dev_info(hdev, "waiting for dump to complete");
                qca_wait_for_dump_collection(hdev);
        }
+
+       if (qca->memdump_state != QCA_MEMDUMP_COLLECTED) {
+               bt_dev_err(hu->hdev, "clearing allocated memory due to memdump timeout");
+               mutex_lock(&qca->hci_memdump_lock);
+               if (qca_memdump)
+                       memdump_buf = qca_memdump->memdump_buf_head;
+               vfree(memdump_buf);
+               kfree(qca_memdump);
+               qca->qca_memdump = NULL;
+               qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
+               cancel_delayed_work(&qca->ctrl_memdump_timeout);
+               skb_queue_purge(&qca->rx_memdump_q);
+               mutex_unlock(&qca->hci_memdump_lock);
+               cancel_work_sync(&qca->ctrl_memdump_evt);
+       }
+
+       clear_bit(QCA_HW_ERROR_EVENT, &qca->flags);
 }
 
 static void qca_cmd_timeout(struct hci_dev *hdev)
@@ -1529,9 +1605,11 @@ static int qca_power_on(struct hci_dev *hdev)
                ret = qca_wcn3990_init(hu);
        } else {
                qcadev = serdev_device_get_drvdata(hu->serdev);
-               gpiod_set_value_cansleep(qcadev->bt_en, 1);
-               /* Controller needs time to bootup. */
-               msleep(150);
+               if (qcadev->bt_en) {
+                       gpiod_set_value_cansleep(qcadev->bt_en, 1);
+                       /* Controller needs time to bootup. */
+                       msleep(150);
+               }
        }
 
        return ret;
@@ -1561,7 +1639,7 @@ static int qca_setup(struct hci_uart *hu)
        set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
 
        bt_dev_info(hdev, "setting up %s",
-               qca_is_wcn399x(soc_type) ? "wcn399x" : "ROME");
+               qca_is_wcn399x(soc_type) ? "wcn399x" : "ROME/QCA6390");
 
 retry:
        ret = qca_power_on(hdev);
@@ -1630,10 +1708,10 @@ retry:
        }
 
        /* Setup bdaddr */
-       if (qca_is_wcn399x(soc_type))
-               hu->hdev->set_bdaddr = qca_set_bdaddr;
-       else
+       if (soc_type == QCA_ROME)
                hu->hdev->set_bdaddr = qca_set_bdaddr_rome;
+       else
+               hu->hdev->set_bdaddr = qca_set_bdaddr;
 
        return ret;
 }
@@ -1653,7 +1731,7 @@ static const struct hci_uart_proto qca_proto = {
        .dequeue        = qca_dequeue,
 };
 
-static const struct qca_vreg_data qca_soc_data_wcn3990 = {
+static const struct qca_device_data qca_soc_data_wcn3990 = {
        .soc_type = QCA_WCN3990,
        .vregs = (struct qca_vreg []) {
                { "vddio", 15000  },
@@ -1664,7 +1742,7 @@ static const struct qca_vreg_data qca_soc_data_wcn3990 = {
        .num_vregs = 4,
 };
 
-static const struct qca_vreg_data qca_soc_data_wcn3991 = {
+static const struct qca_device_data qca_soc_data_wcn3991 = {
        .soc_type = QCA_WCN3991,
        .vregs = (struct qca_vreg []) {
                { "vddio", 15000  },
@@ -1673,9 +1751,10 @@ static const struct qca_vreg_data qca_soc_data_wcn3991 = {
                { "vddch0", 450000 },
        },
        .num_vregs = 4,
+       .capabilities = QCA_CAP_WIDEBAND_SPEECH,
 };
 
-static const struct qca_vreg_data qca_soc_data_wcn3998 = {
+static const struct qca_device_data qca_soc_data_wcn3998 = {
        .soc_type = QCA_WCN3998,
        .vregs = (struct qca_vreg []) {
                { "vddio", 10000  },
@@ -1686,6 +1765,11 @@ static const struct qca_vreg_data qca_soc_data_wcn3998 = {
        .num_vregs = 4,
 };
 
+static const struct qca_device_data qca_soc_data_qca6390 = {
+       .soc_type = QCA_QCA6390,
+       .num_vregs = 0,
+};
+
 static void qca_power_shutdown(struct hci_uart *hu)
 {
        struct qca_serdev *qcadev;
@@ -1717,7 +1801,7 @@ static void qca_power_shutdown(struct hci_uart *hu)
                host_set_baudrate(hu, 2400);
                qca_send_power_pulse(hu, false);
                qca_regulator_disable(qcadev);
-       } else {
+       } else if (qcadev->bt_en) {
                gpiod_set_value_cansleep(qcadev->bt_en, 0);
        }
 }
@@ -1726,9 +1810,11 @@ static int qca_power_off(struct hci_dev *hdev)
 {
        struct hci_uart *hu = hci_get_drvdata(hdev);
        struct qca_data *qca = hu->priv;
+       enum qca_btsoc_type soc_type = qca_soc_type(hu);
 
        /* Stop sending shutdown command if soc crashes. */
-       if (qca->memdump_state == QCA_MEMDUMP_IDLE) {
+       if (soc_type != QCA_ROME
+               && qca->memdump_state == QCA_MEMDUMP_IDLE) {
                qca_send_pre_shutdown_cmd(hdev);
                usleep_range(8000, 10000);
        }
@@ -1755,7 +1841,11 @@ static int qca_regulator_enable(struct qca_serdev *qcadev)
 
        power->vregs_on = true;
 
-       return 0;
+       ret = clk_prepare_enable(qcadev->susclk);
+       if (ret)
+               qca_regulator_disable(qcadev);
+
+       return ret;
 }
 
 static void qca_regulator_disable(struct qca_serdev *qcadev)
@@ -1773,6 +1863,8 @@ static void qca_regulator_disable(struct qca_serdev *qcadev)
 
        regulator_bulk_disable(power->num_vregs, power->vreg_bulk);
        power->vregs_on = false;
+
+       clk_disable_unprepare(qcadev->susclk);
 }
 
 static int qca_init_regulators(struct qca_power *qca,
@@ -1809,8 +1901,9 @@ static int qca_serdev_probe(struct serdev_device *serdev)
 {
        struct qca_serdev *qcadev;
        struct hci_dev *hdev;
-       const struct qca_vreg_data *data;
+       const struct qca_device_data *data;
        int err;
+       bool power_ctrl_enabled = true;
 
        qcadev = devm_kzalloc(&serdev->dev, sizeof(*qcadev), GFP_KERNEL);
        if (!qcadev)
@@ -1821,6 +1914,11 @@ static int qca_serdev_probe(struct serdev_device *serdev)
        serdev_device_set_drvdata(serdev, qcadev);
        device_property_read_string(&serdev->dev, "firmware-name",
                                         &qcadev->firmware_name);
+       device_property_read_u32(&serdev->dev, "max-speed",
+                                &qcadev->oper_speed);
+       if (!qcadev->oper_speed)
+               BT_DBG("UART will pick default operating speed");
+
        if (data && qca_is_wcn399x(data->soc_type)) {
                qcadev->btsoc_type = data->soc_type;
                qcadev->bt_power = devm_kzalloc(&serdev->dev,
@@ -1839,10 +1937,11 @@ static int qca_serdev_probe(struct serdev_device *serdev)
 
                qcadev->bt_power->vregs_on = false;
 
-               device_property_read_u32(&serdev->dev, "max-speed",
-                                        &qcadev->oper_speed);
-               if (!qcadev->oper_speed)
-                       BT_DBG("UART will pick default operating speed");
+               qcadev->susclk = devm_clk_get_optional(&serdev->dev, NULL);
+               if (IS_ERR(qcadev->susclk)) {
+                       dev_err(&serdev->dev, "failed to acquire clk\n");
+                       return PTR_ERR(qcadev->susclk);
+               }
 
                err = hci_uart_register_device(&qcadev->serdev_hu, &qca_proto);
                if (err) {
@@ -1850,39 +1949,52 @@ static int qca_serdev_probe(struct serdev_device *serdev)
                        return err;
                }
        } else {
-               qcadev->btsoc_type = QCA_ROME;
-               qcadev->bt_en = devm_gpiod_get(&serdev->dev, "enable",
-                                              GPIOD_OUT_LOW);
-               if (IS_ERR(qcadev->bt_en)) {
-                       dev_err(&serdev->dev, "failed to acquire enable gpio\n");
-                       return PTR_ERR(qcadev->bt_en);
-               }
+               if (data)
+                       qcadev->btsoc_type = data->soc_type;
+               else
+                       qcadev->btsoc_type = QCA_ROME;
 
-               qcadev->susclk = devm_clk_get(&serdev->dev, NULL);
-               if (IS_ERR(qcadev->susclk)) {
-                       dev_err(&serdev->dev, "failed to acquire clk\n");
-                       return PTR_ERR(qcadev->susclk);
+               qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
+                                              GPIOD_OUT_LOW);
+               if (!qcadev->bt_en) {
+                       dev_warn(&serdev->dev, "failed to acquire enable gpio\n");
+                       power_ctrl_enabled = false;
                }
 
-               err = clk_set_rate(qcadev->susclk, SUSCLK_RATE_32KHZ);
-               if (err)
-                       return err;
+               qcadev->susclk = devm_clk_get_optional(&serdev->dev, NULL);
+               if (!qcadev->susclk) {
+                       dev_warn(&serdev->dev, "failed to acquire clk\n");
+               } else {
+                       err = clk_set_rate(qcadev->susclk, SUSCLK_RATE_32KHZ);
+                       if (err)
+                               return err;
 
-               err = clk_prepare_enable(qcadev->susclk);
-               if (err)
-                       return err;
+                       err = clk_prepare_enable(qcadev->susclk);
+                       if (err)
+                               return err;
+               }
 
                err = hci_uart_register_device(&qcadev->serdev_hu, &qca_proto);
                if (err) {
                        BT_ERR("Rome serdev registration failed");
-                       clk_disable_unprepare(qcadev->susclk);
+                       if (qcadev->susclk)
+                               clk_disable_unprepare(qcadev->susclk);
                        return err;
                }
        }
 
        hdev = qcadev->serdev_hu.hdev;
-       set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
-       hdev->shutdown = qca_power_off;
+
+       if (power_ctrl_enabled) {
+               set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
+               hdev->shutdown = qca_power_off;
+       }
+
+       /* Wideband speech support must be set per driver since it can't be
+        * queried via hci.
+        */
+       if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH))
+               set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 
        return 0;
 }
@@ -1893,16 +2005,49 @@ static void qca_serdev_remove(struct serdev_device *serdev)
 
        if (qca_is_wcn399x(qcadev->btsoc_type))
                qca_power_shutdown(&qcadev->serdev_hu);
-       else
+       else if (qcadev->susclk)
                clk_disable_unprepare(qcadev->susclk);
 
        hci_uart_unregister_device(&qcadev->serdev_hu);
 }
 
+static void qca_serdev_shutdown(struct device *dev)
+{
+       int ret;
+       int timeout = msecs_to_jiffies(CMD_TRANS_TIMEOUT_MS);
+       struct serdev_device *serdev = to_serdev_device(dev);
+       struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+       const u8 ibs_wake_cmd[] = { 0xFD };
+       const u8 edl_reset_soc_cmd[] = { 0x01, 0x00, 0xFC, 0x01, 0x05 };
+
+       if (qcadev->btsoc_type == QCA_QCA6390) {
+               serdev_device_write_flush(serdev);
+               ret = serdev_device_write_buf(serdev, ibs_wake_cmd,
+                                             sizeof(ibs_wake_cmd));
+               if (ret < 0) {
+                       BT_ERR("QCA send IBS_WAKE_IND error: %d", ret);
+                       return;
+               }
+               serdev_device_wait_until_sent(serdev, timeout);
+               usleep_range(8000, 10000);
+
+               serdev_device_write_flush(serdev);
+               ret = serdev_device_write_buf(serdev, edl_reset_soc_cmd,
+                                             sizeof(edl_reset_soc_cmd));
+               if (ret < 0) {
+                       BT_ERR("QCA send EDL_RESET_REQ error: %d", ret);
+                       return;
+               }
+               serdev_device_wait_until_sent(serdev, timeout);
+               usleep_range(8000, 10000);
+       }
+}
+
 static int __maybe_unused qca_suspend(struct device *dev)
 {
-       struct hci_dev *hdev = container_of(dev, struct hci_dev, dev);
-       struct hci_uart *hu = hci_get_drvdata(hdev);
+       struct serdev_device *serdev = to_serdev_device(dev);
+       struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+       struct hci_uart *hu = &qcadev->serdev_hu;
        struct qca_data *qca = hu->priv;
        unsigned long flags;
        int ret = 0;
@@ -1981,8 +2126,9 @@ error:
 
 static int __maybe_unused qca_resume(struct device *dev)
 {
-       struct hci_dev *hdev = container_of(dev, struct hci_dev, dev);
-       struct hci_uart *hu = hci_get_drvdata(hdev);
+       struct serdev_device *serdev = to_serdev_device(dev);
+       struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+       struct hci_uart *hu = &qcadev->serdev_hu;
        struct qca_data *qca = hu->priv;
 
        clear_bit(QCA_SUSPENDING, &qca->flags);
@@ -1992,21 +2138,39 @@ static int __maybe_unused qca_resume(struct device *dev)
 
 static SIMPLE_DEV_PM_OPS(qca_pm_ops, qca_suspend, qca_resume);
 
+#ifdef CONFIG_OF
 static const struct of_device_id qca_bluetooth_of_match[] = {
        { .compatible = "qcom,qca6174-bt" },
+       { .compatible = "qcom,qca6390-bt", .data = &qca_soc_data_qca6390},
+       { .compatible = "qcom,qca9377-bt" },
        { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data_wcn3990},
        { .compatible = "qcom,wcn3991-bt", .data = &qca_soc_data_wcn3991},
        { .compatible = "qcom,wcn3998-bt", .data = &qca_soc_data_wcn3998},
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match);
+#endif
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id qca_bluetooth_acpi_match[] = {
+       { "QCOM6390", (kernel_ulong_t)&qca_soc_data_qca6390 },
+       { "DLA16390", (kernel_ulong_t)&qca_soc_data_qca6390 },
+       { "DLB16390", (kernel_ulong_t)&qca_soc_data_qca6390 },
+       { "DLB26390", (kernel_ulong_t)&qca_soc_data_qca6390 },
+       { },
+};
+MODULE_DEVICE_TABLE(acpi, qca_bluetooth_acpi_match);
+#endif
+
 
 static struct serdev_device_driver qca_serdev_driver = {
        .probe = qca_serdev_probe,
        .remove = qca_serdev_remove,
        .driver = {
                .name = "hci_uart_qca",
-               .of_match_table = qca_bluetooth_of_match,
+               .of_match_table = of_match_ptr(qca_bluetooth_of_match),
+               .acpi_match_table = ACPI_PTR(qca_bluetooth_acpi_match),
+               .shutdown = qca_serdev_shutdown,
                .pm = &qca_pm_ops,
        },
 };