platform-msi: Simplify platform device MSI code

[linux-2.6-microblaze.git] / drivers / base / platform-msi.c

diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index 01c897c..296ea67 100644 (file)
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -246,6 +246,8 @@ void *platform_msi_get_host_data(struct irq_domain *domain)
        return data->host_data;
 }
 
+static struct lock_class_key platform_device_msi_lock_class;
+
 /**
  * __platform_msi_create_device_domain - Create a platform-msi device domain
  *
@@ -278,6 +280,13 @@ __platform_msi_create_device_domain(struct device *dev,
        if (err)
                return NULL;
 
+       /*
+        * Use a separate lock class for the MSI descriptor mutex on
+        * platform MSI device domains because the descriptor mutex nests
+        * into the domain mutex. See alloc/free below.
+        */
+       lockdep_set_class(&dev->msi.data->mutex, &platform_device_msi_lock_class);
+
        data = dev->msi.data->platform_data;
        data->host_data = host_data;
        domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
@@ -300,75 +309,23 @@ free_priv:
        return NULL;
 }
 
-static void platform_msi_free_descs(struct device *dev, int base, int nvec)
-{
-       struct msi_desc *desc, *tmp;
-
-       list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-               if (desc->msi_index >= base &&
-                   desc->msi_index < (base + nvec)) {
-                       list_del(&desc->list);
-                       free_msi_entry(desc);
-               }
-       }
-}
-
-static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
-                                            int nvec)
-{
-       struct msi_desc *desc;
-       int i, base = 0;
-
-       if (!list_empty(dev_to_msi_list(dev))) {
-               desc = list_last_entry(dev_to_msi_list(dev),
-                                      struct msi_desc, list);
-               base = desc->msi_index + 1;
-       }
-
-       for (i = 0; i < nvec; i++) {
-               desc = alloc_msi_entry(dev, 1, NULL);
-               if (!desc)
-                       break;
-
-               desc->msi_index = base + i;
-               desc->irq = virq + i;
-
-               list_add_tail(&desc->list, dev_to_msi_list(dev));
-       }
-
-       if (i != nvec) {
-               /* Clean up the mess */
-               platform_msi_free_descs(dev, base, nvec);
-               return -ENOMEM;
-       }
-
-       return 0;
-}
-
 /**
  * platform_msi_device_domain_free - Free interrupts associated with a platform-msi
  *                                  device domain
  *
  * @domain:    The platform-msi device domain
  * @virq:      The base irq from which to perform the free operation
- * @nvec:      How many interrupts to free from @virq
+ * @nr_irqs:   How many interrupts to free from @virq
  */
 void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
-                                    unsigned int nvec)
+                                    unsigned int nr_irqs)
 {
        struct platform_msi_priv_data *data = domain->host_data;
-       struct msi_desc *desc, *tmp;
 
-       for_each_msi_entry_safe(desc, tmp, data->dev) {
-               if (WARN_ON(!desc->irq || desc->nvec_used != 1))
-                       return;
-               if (!(desc->irq >= virq && desc->irq < (virq + nvec)))
-                       continue;
-
-               irq_domain_free_irqs_common(domain, desc->irq, 1);
-               list_del(&desc->list);
-               free_msi_entry(desc);
-       }
+       msi_lock_descs(data->dev);
+       irq_domain_free_irqs_common(domain, virq, nr_irqs);
+       msi_free_msi_descs_range(data->dev, MSI_DESC_ALL, virq, virq + nr_irqs - 1);
+       msi_unlock_descs(data->dev);
 }
 
 /**
@@ -377,7 +334,7 @@ void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int vir
  *
  * @domain:    The platform-msi device domain
  * @virq:      The base irq from which to perform the allocate operation
- * @nr_irqs:   How many interrupts to free from @virq
+ * @nr_irqs:   How many interrupts to allocate from @virq
  *
  * Return 0 on success, or an error code on failure. Must be called
  * with irq_domain_mutex held (which can only be done as part of a
@@ -387,16 +344,7 @@ int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int vir
                                     unsigned int nr_irqs)
 {
        struct platform_msi_priv_data *data = domain->host_data;
-       int err;
-
-       err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs);
-       if (err)
-               return err;
-
-       err = msi_domain_populate_irqs(domain->parent, data->dev,
-                                      virq, nr_irqs, &data->arg);
-       if (err)
-               platform_msi_device_domain_free(domain, virq, nr_irqs);
+       struct device *dev = data->dev;
 
-       return err;
+       return msi_domain_populate_irqs(domain->parent, dev, virq, nr_irqs, &data->arg);
 }