[PATCH] uml: const more data
[linux-2.6-microblaze.git] / arch / um / drivers / line.c
index da81d22..563ce76 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
  * Copyright (C) 2001, 2002 Jeff Dike (jdike@karaya.com)
  * Licensed under the GPL
  */
@@ -8,7 +8,6 @@
 #include "linux/list.h"
 #include "linux/kd.h"
 #include "linux/interrupt.h"
-#include "linux/devfs_fs_kernel.h"
 #include "asm/uaccess.h"
 #include "chan_kern.h"
 #include "irq_user.h"
@@ -23,8 +22,9 @@
 
 static irqreturn_t line_interrupt(int irq, void *data, struct pt_regs *unused)
 {
-       struct tty_struct *tty = data;
-       struct line *line = tty->driver_data;
+       struct chan *chan = data;
+       struct line *line = chan->line;
+       struct tty_struct *tty = line->tty;
 
        if (line)
                chan_interrupt(&line->chan_list, &line->task, tty, irq);
@@ -33,10 +33,11 @@ static irqreturn_t line_interrupt(int irq, void *data, struct pt_regs *unused)
 
 static void line_timer_cb(void *arg)
 {
-       struct tty_struct *tty = arg;
-       struct line *line = tty->driver_data;
+       struct line *line = arg;
 
-       line_interrupt(line->driver->read_irq, arg, NULL);
+       if(!line->throttled)
+               chan_interrupt(&line->chan_list, &line->task, line->tty,
+                              line->driver->read_irq);
 }
 
 /* Returns the free space inside the ring buffer of this line.
@@ -250,7 +251,7 @@ void line_set_termios(struct tty_struct *tty, struct termios * old)
        /* nothing */
 }
 
-static struct {
+static const struct {
        int  cmd;
        char *level;
        char *name;
@@ -339,15 +340,40 @@ int line_ioctl(struct tty_struct *tty, struct file * file,
        return ret;
 }
 
+void line_throttle(struct tty_struct *tty)
+{
+       struct line *line = tty->driver_data;
+
+       deactivate_chan(&line->chan_list, line->driver->read_irq);
+       line->throttled = 1;
+}
+
+void line_unthrottle(struct tty_struct *tty)
+{
+       struct line *line = tty->driver_data;
+
+       line->throttled = 0;
+       chan_interrupt(&line->chan_list, &line->task, tty,
+                      line->driver->read_irq);
+
+       /* Maybe there is enough stuff pending that calling the interrupt
+        * throttles us again.  In this case, line->throttled will be 1
+        * again and we shouldn't turn the interrupt back on.
+        */
+       if(!line->throttled)
+               reactivate_chan(&line->chan_list, line->driver->read_irq);
+}
+
 static irqreturn_t line_write_interrupt(int irq, void *data,
                                        struct pt_regs *unused)
 {
-       struct tty_struct *tty = data;
-       struct line *line = tty->driver_data;
+       struct chan *chan = data;
+       struct line *line = chan->line;
+       struct tty_struct *tty = line->tty;
        int err;
 
        /* Interrupts are enabled here because we registered the interrupt with
-        * SA_INTERRUPT (see line_setup_irq).*/
+        * IRQF_DISABLED (see line_setup_irq).*/
 
        spin_lock_irq(&line->lock);
        err = flush_buffer(line);
@@ -365,7 +391,7 @@ static irqreturn_t line_write_interrupt(int irq, void *data,
        if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
           (tty->ldisc.write_wakeup != NULL))
                (tty->ldisc.write_wakeup)(tty);
-       
+
        /* BLOCKING mode
         * In blocking mode, everything sleeps on tty->write_wait.
         * Sleeping in the console driver would break non-blocking
@@ -377,52 +403,29 @@ static irqreturn_t line_write_interrupt(int irq, void *data,
        return IRQ_HANDLED;
 }
 
-int line_setup_irq(int fd, int input, int output, struct tty_struct *tty)
+int line_setup_irq(int fd, int input, int output, struct line *line, void *data)
 {
-       struct line *line = tty->driver_data;
-       struct line_driver *driver = line->driver;
-       int err = 0, flags = SA_INTERRUPT | SA_SHIRQ | SA_SAMPLE_RANDOM;
+       const struct line_driver *driver = line->driver;
+       int err = 0, flags = IRQF_DISABLED | IRQF_SHARED | IRQF_SAMPLE_RANDOM;
 
        if (input)
                err = um_request_irq(driver->read_irq, fd, IRQ_READ,
                                       line_interrupt, flags,
-                                      driver->read_irq_name, tty);
+                                      driver->read_irq_name, data);
        if (err)
                return err;
        if (output)
                err = um_request_irq(driver->write_irq, fd, IRQ_WRITE,
                                        line_write_interrupt, flags,
-                                       driver->write_irq_name, tty);
+                                       driver->write_irq_name, data);
        line->have_irq = 1;
        return err;
 }
 
-void line_disable(struct tty_struct *tty, int current_irq)
-{
-       struct line *line = tty->driver_data;
-
-       if(!line->have_irq)
-               return;
-
-       if(line->driver->read_irq == current_irq)
-               free_irq_later(line->driver->read_irq, tty);
-       else {
-               free_irq(line->driver->read_irq, tty);
-       }
-
-       if(line->driver->write_irq == current_irq)
-               free_irq_later(line->driver->write_irq, tty);
-       else {
-               free_irq(line->driver->write_irq, tty);
-       }
-
-       line->have_irq = 0;
-}
-
 int line_open(struct line *lines, struct tty_struct *tty)
 {
        struct line *line;
-       int err = 0;
+       int err = -ENODEV;
 
        line = &lines[tty->index];
        tty->driver_data = line;
@@ -430,29 +433,29 @@ int line_open(struct line *lines, struct tty_struct *tty)
        /* The IRQ which takes this lock is not yet enabled and won't be run
         * before the end, so we don't need to use spin_lock_irq.*/
        spin_lock(&line->lock);
-       if (tty->count == 1) {
-               if (!line->valid) {
-                       err = -ENODEV;
-                       goto out;
-               }
 
-               err = open_chan(&line->chan_list);
-               if(err)
-                       goto out;
-
-               /* Here the interrupt is registered.*/
-               enable_chan(&line->chan_list, tty);
-               INIT_WORK(&line->task, line_timer_cb, tty);
-       }
+       tty->driver_data = line;
+       line->tty = tty;
+       if(!line->valid)
+               goto out;
+
+       if(tty->count == 1){
+               /* Here the device is opened, if necessary, and interrupt
+                * is registered.
+                */
+               enable_chan(line);
+               INIT_WORK(&line->task, line_timer_cb, line);
+
+               if(!line->sigio){
+                       chan_enable_winch(&line->chan_list, tty);
+                       line->sigio = 1;
+               }
 
-       if(!line->sigio){
-               chan_enable_winch(&line->chan_list, tty);
-               line->sigio = 1;
+               chan_window_size(&line->chan_list, &tty->winsize.ws_row,
+                                &tty->winsize.ws_col);
        }
-       chan_window_size(&line->chan_list, &tty->winsize.ws_row,
-                        &tty->winsize.ws_col);
-       line->count++;
 
+       err = 0;
 out:
        spin_unlock(&line->lock);
        return err;
@@ -472,15 +475,14 @@ void line_close(struct tty_struct *tty, struct file * filp)
        /* We ignore the error anyway! */
        flush_buffer(line);
 
-       line->count--;
-       if (tty->count == 1) {
-               line_disable(tty, -1);
+       if(tty->count == 1){
+               line->tty = NULL;
                tty->driver_data = NULL;
-       }
 
-        if((line->count == 0) && line->sigio){
-                unregister_winch(tty);
-                line->sigio = 0;
+               if(line->sigio){
+                       unregister_winch(tty);
+                       line->sigio = 0;
+               }
         }
 
        spin_unlock_irq(&line->lock);
@@ -491,7 +493,7 @@ void close_lines(struct line *lines, int nlines)
        int i;
 
        for(i = 0; i < nlines; i++)
-               close_chan(&lines[i].chan_list);
+               close_chan(&lines[i].chan_list, 0);
 }
 
 /* Common setup code for both startup command line and mconsole initialization.
@@ -526,7 +528,7 @@ int line_setup(struct line *lines, unsigned int num, char *init)
                return 0;
        }
        else if (n >= 0){
-               if (lines[n].count > 0) {
+               if (lines[n].tty != NULL) {
                        printk("line_setup - device %d is open\n", n);
                        return 0;
                }
@@ -537,7 +539,7 @@ int line_setup(struct line *lines, unsigned int num, char *init)
                        else {
                                lines[n].init_str = init;
                                lines[n].valid = 1;
-                       }       
+                       }
                }
        }
        else {
@@ -556,7 +558,7 @@ int line_setup(struct line *lines, unsigned int num, char *init)
 }
 
 int line_config(struct line *lines, unsigned int num, char *str,
-               struct chan_opts *opts)
+               const struct chan_opts *opts)
 {
        struct line *line;
        char *new;
@@ -578,7 +580,7 @@ int line_config(struct line *lines, unsigned int num, char *str,
                return 1;
 
        line = &lines[n];
-       return parse_chan_pair(line->init_str, &line->chan_list, n, opts);
+       return parse_chan_pair(line->init_str, line, n, opts);
 }
 
 int line_get_config(char *name, struct line *lines, unsigned int num, char *str,
@@ -604,7 +606,7 @@ int line_get_config(char *name, struct line *lines, unsigned int num, char *str,
        spin_lock(&line->lock);
        if(!line->valid)
                CONFIG_CHUNK(str, size, n, "none", 1);
-       else if(line->count == 0)
+       else if(line->tty == NULL)
                CONFIG_CHUNK(str, size, n, line->init_str, 1);
        else n = chan_config_string(&line->chan_list, str, size, error_out);
        spin_unlock(&line->lock);
@@ -652,7 +654,6 @@ struct tty_driver *line_register_devfs(struct lines *set,
 
        driver->driver_name = line_driver->name;
        driver->name = line_driver->device_name;
-       driver->devfs_name = line_driver->devfs_name;
        driver->major = line_driver->major;
        driver->minor_start = line_driver->minor_start;
        driver->type = line_driver->type;
@@ -696,7 +697,7 @@ void lines_init(struct line *lines, int nlines, struct chan_opts *opts)
                if(line->init_str == NULL)
                        printk("lines_init - kstrdup returned NULL\n");
 
-               if(parse_chan_pair(line->init_str, &line->chan_list, i, opts)){
+               if(parse_chan_pair(line->init_str, line, i, opts)){
                        printk("parse_chan_pair failed for device %d\n", i);
                        line->valid = 0;
                }
@@ -711,7 +712,7 @@ struct winch {
        struct tty_struct *tty;
 };
 
-irqreturn_t winch_interrupt(int irq, void *data, struct pt_regs *unused)
+static irqreturn_t winch_interrupt(int irq, void *data, struct pt_regs *unused)
 {
        struct winch *winch = data;
        struct tty_struct *tty;
@@ -766,60 +767,54 @@ void register_winch_irq(int fd, int tty_fd, int pid, struct tty_struct *tty)
        spin_unlock(&winch_handler_lock);
 
        if(um_request_irq(WINCH_IRQ, fd, IRQ_READ, winch_interrupt,
-                         SA_INTERRUPT | SA_SHIRQ | SA_SAMPLE_RANDOM,
+                         IRQF_DISABLED | IRQF_SHARED | IRQF_SAMPLE_RANDOM,
                          "winch", winch) < 0)
                printk("register_winch_irq - failed to register IRQ\n");
 }
 
+static void free_winch(struct winch *winch)
+{
+       list_del(&winch->list);
+
+       if(winch->pid != -1)
+               os_kill_process(winch->pid, 1);
+       if(winch->fd != -1)
+               os_close_file(winch->fd);
+
+       free_irq(WINCH_IRQ, winch);
+       kfree(winch);
+}
+
 static void unregister_winch(struct tty_struct *tty)
 {
        struct list_head *ele;
-       struct winch *winch, *found = NULL;
+       struct winch *winch;
 
        spin_lock(&winch_handler_lock);
+
        list_for_each(ele, &winch_handlers){
                winch = list_entry(ele, struct winch, list);
                 if(winch->tty == tty){
-                        found = winch;
-                        break;
+                       free_winch(winch);
+                       break;
                 }
         }
-        if(found == NULL)
-               goto err;
-
-       list_del(&winch->list);
-       spin_unlock(&winch_handler_lock);
-
-        if(winch->pid != -1)
-                os_kill_process(winch->pid, 1);
-
-        free_irq(WINCH_IRQ, winch);
-        kfree(winch);
-
-       return;
-err:
        spin_unlock(&winch_handler_lock);
 }
 
-/* XXX: No lock as it's an exitcall... is this valid? Depending on cleanup
- * order... are we sure that nothing else is done on the list? */
 static void winch_cleanup(void)
 {
-       struct list_head *ele;
+       struct list_head *ele, *next;
        struct winch *winch;
 
-       list_for_each(ele, &winch_handlers){
+       spin_lock(&winch_handler_lock);
+
+       list_for_each_safe(ele, next, &winch_handlers){
                winch = list_entry(ele, struct winch, list);
-               if(winch->fd != -1){
-                       /* Why is this different from the above free_irq(),
-                        * which deactivates SIGIO? This searches the FD
-                        * somewhere else and removes it from the list... */
-                       deactivate_fd(winch->fd, WINCH_IRQ);
-                       os_close_file(winch->fd);
-               }
-               if(winch->pid != -1)
-                       os_kill_process(winch->pid, 1);
+               free_winch(winch);
        }
+
+       spin_unlock(&winch_handler_lock);
 }
 __uml_exitcall(winch_cleanup);
 
@@ -828,10 +823,10 @@ char *add_xterm_umid(char *base)
        char *umid, *title;
        int len;
 
-       umid = get_umid(1);
-       if(umid == NULL)
+       umid = get_umid();
+       if(*umid == '\0')
                return base;
-       
+
        len = strlen(base) + strlen(" ()") + strlen(umid) + 1;
        title = kmalloc(len, GFP_KERNEL);
        if(title == NULL){