net/dsa/port.c

   1 // SPDX-License-Identifier: GPL-2.0-or-later
   2 /*
   3  * Handling of a single switch port
   4  *
   5  * Copyright (c) 2017 Savoir-faire Linux Inc.
   6  *      Vivien Didelot <vivien.didelot@savoirfairelinux.com>
   7  */
   8
   9 #include <linux/if_bridge.h>
  10 #include <linux/notifier.h>
  11 #include <linux/of_mdio.h>
  12 #include <linux/of_net.h>
  13
  14 #include "dsa_priv.h"
  15
  16 /**
  17  * dsa_port_notify - Notify the switching fabric of changes to a port
  18  * @dp: port on which change occurred
  19  * @e: event, must be of type DSA_NOTIFIER_*
  20  * @v: event-specific value.
  21  *
  22  * Notify all switches in the DSA tree that this port's switch belongs to,
  23  * including this switch itself, of an event. Allows the other switches to
  24  * reconfigure themselves for cross-chip operations. Can also be used to
  25  * reconfigure ports without net_devices (CPU ports, DSA links) whenever
  26  * a user port's state changes.
  27  */
  28 static int dsa_port_notify(const struct dsa_port *dp, unsigned long e, void *v)
  29 {
  30         return dsa_tree_notify(dp->ds->dst, e, v);
  31 }
  32
  33 static void dsa_port_notify_bridge_fdb_flush(const struct dsa_port *dp)
  34 {
  35         struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
  36         struct switchdev_notifier_fdb_info info = {
  37                 /* flush all VLANs */
  38                 .vid = 0,
  39         };
  40
  41         /* When the port becomes standalone it has already left the bridge.
  42          * Don't notify the bridge in that case.
  43          */
  44         if (!brport_dev)
  45                 return;
  46
  47         call_switchdev_notifiers(SWITCHDEV_FDB_FLUSH_TO_BRIDGE,
  48                                  brport_dev, &info.info, NULL);
  49 }
  50
  51 static void dsa_port_fast_age(const struct dsa_port *dp)
  52 {
  53         struct dsa_switch *ds = dp->ds;
  54
  55         if (!ds->ops->port_fast_age)
  56                 return;
  57
  58         ds->ops->port_fast_age(ds, dp->index);
  59
  60         dsa_port_notify_bridge_fdb_flush(dp);
  61 }
  62
  63 static bool dsa_port_can_configure_learning(struct dsa_port *dp)
  64 {
  65         struct switchdev_brport_flags flags = {
  66                 .mask = BR_LEARNING,
  67         };
  68         struct dsa_switch *ds = dp->ds;
  69         int err;
  70
  71         if (!ds->ops->port_bridge_flags || !ds->ops->port_pre_bridge_flags)
  72                 return false;
  73
  74         err = ds->ops->port_pre_bridge_flags(ds, dp->index, flags, NULL);
  75         return !err;
  76 }
  77
  78 int dsa_port_set_state(struct dsa_port *dp, u8 state, bool do_fast_age)
  79 {
  80         struct dsa_switch *ds = dp->ds;
  81         int port = dp->index;
  82
  83         if (!ds->ops->port_stp_state_set)
  84                 return -EOPNOTSUPP;
  85
  86         ds->ops->port_stp_state_set(ds, port, state);
  87
  88         if (!dsa_port_can_configure_learning(dp) ||
  89             (do_fast_age && dp->learning)) {
  90                 /* Fast age FDB entries or flush appropriate forwarding database
  91                  * for the given port, if we are moving it from Learning or
  92                  * Forwarding state, to Disabled or Blocking or Listening state.
  93                  * Ports that were standalone before the STP state change don't
  94                  * need to fast age the FDB, since address learning is off in
  95                  * standalone mode.
  96                  */
  97
  98                 if ((dp->stp_state == BR_STATE_LEARNING ||
  99                      dp->stp_state == BR_STATE_FORWARDING) &&
 100                     (state == BR_STATE_DISABLED ||
 101                      state == BR_STATE_BLOCKING ||
 102                      state == BR_STATE_LISTENING))
 103                         dsa_port_fast_age(dp);
 104         }
 105
 106         dp->stp_state = state;
 107
 108         return 0;
 109 }
 110
 111 static void dsa_port_set_state_now(struct dsa_port *dp, u8 state,
 112                                    bool do_fast_age)
 113 {
 114         int err;
 115
 116         err = dsa_port_set_state(dp, state, do_fast_age);
 117         if (err)
 118                 pr_err("DSA: failed to set STP state %u (%d)\n", state, err);
 119 }
 120
 121 int dsa_port_enable_rt(struct dsa_port *dp, struct phy_device *phy)
 122 {
 123         struct dsa_switch *ds = dp->ds;
 124         int port = dp->index;
 125         int err;
 126
 127         if (ds->ops->port_enable) {
 128                 err = ds->ops->port_enable(ds, port, phy);
 129                 if (err)
 130                         return err;
 131         }
 132
 133         if (!dp->bridge_dev)
 134                 dsa_port_set_state_now(dp, BR_STATE_FORWARDING, false);
 135
 136         if (dp->pl)
 137                 phylink_start(dp->pl);
 138
 139         return 0;
 140 }
 141
 142 int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy)
 143 {
 144         int err;
 145
 146         rtnl_lock();
 147         err = dsa_port_enable_rt(dp, phy);
 148         rtnl_unlock();
 149
 150         return err;
 151 }
 152
 153 void dsa_port_disable_rt(struct dsa_port *dp)
 154 {
 155         struct dsa_switch *ds = dp->ds;
 156         int port = dp->index;
 157
 158         if (dp->pl)
 159                 phylink_stop(dp->pl);
 160
 161         if (!dp->bridge_dev)
 162                 dsa_port_set_state_now(dp, BR_STATE_DISABLED, false);
 163
 164         if (ds->ops->port_disable)
 165                 ds->ops->port_disable(ds, port);
 166 }
 167
 168 void dsa_port_disable(struct dsa_port *dp)
 169 {
 170         rtnl_lock();
 171         dsa_port_disable_rt(dp);
 172         rtnl_unlock();
 173 }
 174
 175 static int dsa_port_inherit_brport_flags(struct dsa_port *dp,
 176                                          struct netlink_ext_ack *extack)
 177 {
 178         const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
 179                                    BR_BCAST_FLOOD;
 180         struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
 181         int flag, err;
 182
 183         for_each_set_bit(flag, &mask, 32) {
 184                 struct switchdev_brport_flags flags = {0};
 185
 186                 flags.mask = BIT(flag);
 187
 188                 if (br_port_flag_is_set(brport_dev, BIT(flag)))
 189                         flags.val = BIT(flag);
 190
 191                 err = dsa_port_bridge_flags(dp, flags, extack);
 192                 if (err && err != -EOPNOTSUPP)
 193                         return err;
 194         }
 195
 196         return 0;
 197 }
 198
 199 static void dsa_port_clear_brport_flags(struct dsa_port *dp)
 200 {
 201         const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
 202         const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
 203                                    BR_BCAST_FLOOD;
 204         int flag, err;
 205
 206         for_each_set_bit(flag, &mask, 32) {
 207                 struct switchdev_brport_flags flags = {0};
 208
 209                 flags.mask = BIT(flag);
 210                 flags.val = val & BIT(flag);
 211
 212                 err = dsa_port_bridge_flags(dp, flags, NULL);
 213                 if (err && err != -EOPNOTSUPP)
 214                         dev_err(dp->ds->dev,
 215                                 "failed to clear bridge port flag %lu: %pe\n",
 216                                 flags.val, ERR_PTR(err));
 217         }
 218 }
 219
 220 static int dsa_port_switchdev_sync_attrs(struct dsa_port *dp,
 221                                          struct netlink_ext_ack *extack)
 222 {
 223         struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
 224         struct net_device *br = dp->bridge_dev;
 225         int err;
 226
 227         err = dsa_port_inherit_brport_flags(dp, extack);
 228         if (err)
 229                 return err;
 230
 231         err = dsa_port_set_state(dp, br_port_get_stp_state(brport_dev), false);
 232         if (err && err != -EOPNOTSUPP)
 233                 return err;
 234
 235         err = dsa_port_vlan_filtering(dp, br_vlan_enabled(br), extack);
 236         if (err && err != -EOPNOTSUPP)
 237                 return err;
 238
 239         err = dsa_port_ageing_time(dp, br_get_ageing_time(br));
 240         if (err && err != -EOPNOTSUPP)
 241                 return err;
 242
 243         return 0;
 244 }
 245
 246 static void dsa_port_switchdev_unsync_attrs(struct dsa_port *dp)
 247 {
 248         /* Configure the port for standalone mode (no address learning,
 249          * flood everything).
 250          * The bridge only emits SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS events
 251          * when the user requests it through netlink or sysfs, but not
 252          * automatically at port join or leave, so we need to handle resetting
 253          * the brport flags ourselves. But we even prefer it that way, because
 254          * otherwise, some setups might never get the notification they need,
 255          * for example, when a port leaves a LAG that offloads the bridge,
 256          * it becomes standalone, but as far as the bridge is concerned, no
 257          * port ever left.
 258          */
 259         dsa_port_clear_brport_flags(dp);
 260
 261         /* Port left the bridge, put in BR_STATE_DISABLED by the bridge layer,
 262          * so allow it to be in BR_STATE_FORWARDING to be kept functional
 263          */
 264         dsa_port_set_state_now(dp, BR_STATE_FORWARDING, true);
 265
 266         /* VLAN filtering is handled by dsa_switch_bridge_leave */
 267
 268         /* Ageing time may be global to the switch chip, so don't change it
 269          * here because we have no good reason (or value) to change it to.
 270          */
 271 }
 272
 273 static int dsa_tree_find_bridge_num(struct dsa_switch_tree *dst,
 274                                     struct net_device *bridge_dev)
 275 {
 276         struct dsa_port *dp;
 277
 278         /* When preparing the offload for a port, it will have a valid
 279          * dp->bridge_dev pointer but a not yet valid dp->bridge_num.
 280          * However there might be other ports having the same dp->bridge_dev
 281          * and a valid dp->bridge_num, so just ignore this port.
 282          */
 283         list_for_each_entry(dp, &dst->ports, list)
 284                 if (dp->bridge_dev == bridge_dev && dp->bridge_num != -1)
 285                         return dp->bridge_num;
 286
 287         return -1;
 288 }
 289
 290 static void dsa_port_bridge_tx_fwd_unoffload(struct dsa_port *dp,
 291                                              struct net_device *bridge_dev)
 292 {
 293         struct dsa_switch_tree *dst = dp->ds->dst;
 294         int bridge_num = dp->bridge_num;
 295         struct dsa_switch *ds = dp->ds;
 296
 297         /* No bridge TX forwarding offload => do nothing */
 298         if (!ds->ops->port_bridge_tx_fwd_unoffload || dp->bridge_num == -1)
 299                 return;
 300
 301         dp->bridge_num = -1;
 302
 303         /* Check if the bridge is still in use, otherwise it is time
 304          * to clean it up so we can reuse this bridge_num later.
 305          */
 306         if (!dsa_tree_find_bridge_num(dst, bridge_dev))
 307                 clear_bit(bridge_num, &dst->fwd_offloading_bridges);
 308
 309         /* Notify the chips only once the offload has been deactivated, so
 310          * that they can update their configuration accordingly.
 311          */
 312         ds->ops->port_bridge_tx_fwd_unoffload(ds, dp->index, bridge_dev,
 313                                               bridge_num);
 314 }
 315
 316 static bool dsa_port_bridge_tx_fwd_offload(struct dsa_port *dp,
 317                                            struct net_device *bridge_dev)
 318 {
 319         struct dsa_switch_tree *dst = dp->ds->dst;
 320         struct dsa_switch *ds = dp->ds;
 321         int bridge_num, err;
 322
 323         if (!ds->ops->port_bridge_tx_fwd_offload)
 324                 return false;
 325
 326         bridge_num = dsa_tree_find_bridge_num(dst, bridge_dev);
 327         if (bridge_num < 0) {
 328                 /* First port that offloads TX forwarding for this bridge */
 329                 bridge_num = find_first_zero_bit(&dst->fwd_offloading_bridges,
 330                                                  DSA_MAX_NUM_OFFLOADING_BRIDGES);
 331                 if (bridge_num >= ds->num_fwd_offloading_bridges)
 332                         return false;
 333
 334                 set_bit(bridge_num, &dst->fwd_offloading_bridges);
 335         }
 336
 337         dp->bridge_num = bridge_num;
 338
 339         /* Notify the driver */
 340         err = ds->ops->port_bridge_tx_fwd_offload(ds, dp->index, bridge_dev,
 341                                                   bridge_num);
 342         if (err) {
 343                 dsa_port_bridge_tx_fwd_unoffload(dp, bridge_dev);
 344                 return false;
 345         }
 346
 347         return true;
 348 }
 349
 350 int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br,
 351                          struct netlink_ext_ack *extack)
 352 {
 353         struct dsa_notifier_bridge_info info = {
 354                 .tree_index = dp->ds->dst->index,
 355                 .sw_index = dp->ds->index,
 356                 .port = dp->index,
 357                 .br = br,
 358         };
 359         struct net_device *dev = dp->slave;
 360         struct net_device *brport_dev;
 361         bool tx_fwd_offload;
 362         int err;
 363
 364         /* Here the interface is already bridged. Reflect the current
 365          * configuration so that drivers can program their chips accordingly.
 366          */
 367         dp->bridge_dev = br;
 368
 369         brport_dev = dsa_port_to_bridge_port(dp);
 370
 371         err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_JOIN, &info);
 372         if (err)
 373                 goto out_rollback;
 374
 375         tx_fwd_offload = dsa_port_bridge_tx_fwd_offload(dp, br);
 376
 377         err = switchdev_bridge_port_offload(brport_dev, dev, dp,
 378                                             &dsa_slave_switchdev_notifier,
 379                                             &dsa_slave_switchdev_blocking_notifier,
 380                                             tx_fwd_offload, extack);
 381         if (err)
 382                 goto out_rollback_unbridge;
 383
 384         err = dsa_port_switchdev_sync_attrs(dp, extack);
 385         if (err)
 386                 goto out_rollback_unoffload;
 387
 388         return 0;
 389
 390 out_rollback_unoffload:
 391         switchdev_bridge_port_unoffload(brport_dev, dp,
 392                                         &dsa_slave_switchdev_notifier,
 393                                         &dsa_slave_switchdev_blocking_notifier);
 394 out_rollback_unbridge:
 395         dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
 396 out_rollback:
 397         dp->bridge_dev = NULL;
 398         return err;
 399 }
 400
 401 void dsa_port_pre_bridge_leave(struct dsa_port *dp, struct net_device *br)
 402 {
 403         struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
 404
 405         switchdev_bridge_port_unoffload(brport_dev, dp,
 406                                         &dsa_slave_switchdev_notifier,
 407                                         &dsa_slave_switchdev_blocking_notifier);
 408 }
 409
 410 void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br)
 411 {
 412         struct dsa_notifier_bridge_info info = {
 413                 .tree_index = dp->ds->dst->index,
 414                 .sw_index = dp->ds->index,
 415                 .port = dp->index,
 416                 .br = br,
 417         };
 418         int err;
 419
 420         /* Here the port is already unbridged. Reflect the current configuration
 421          * so that drivers can program their chips accordingly.
 422          */
 423         dp->bridge_dev = NULL;
 424
 425         dsa_port_bridge_tx_fwd_unoffload(dp, br);
 426
 427         err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
 428         if (err)
 429                 pr_err("DSA: failed to notify DSA_NOTIFIER_BRIDGE_LEAVE\n");
 430
 431         dsa_port_switchdev_unsync_attrs(dp);
 432 }
 433
 434 int dsa_port_lag_change(struct dsa_port *dp,
 435                         struct netdev_lag_lower_state_info *linfo)
 436 {
 437         struct dsa_notifier_lag_info info = {
 438                 .sw_index = dp->ds->index,
 439                 .port = dp->index,
 440         };
 441         bool tx_enabled;
 442
 443         if (!dp->lag_dev)
 444                 return 0;
 445
 446         /* On statically configured aggregates (e.g. loadbalance
 447          * without LACP) ports will always be tx_enabled, even if the
 448          * link is down. Thus we require both link_up and tx_enabled
 449          * in order to include it in the tx set.
 450          */
 451         tx_enabled = linfo->link_up && linfo->tx_enabled;
 452
 453         if (tx_enabled == dp->lag_tx_enabled)
 454                 return 0;
 455
 456         dp->lag_tx_enabled = tx_enabled;
 457
 458         return dsa_port_notify(dp, DSA_NOTIFIER_LAG_CHANGE, &info);
 459 }
 460
 461 int dsa_port_lag_join(struct dsa_port *dp, struct net_device *lag,
 462                       struct netdev_lag_upper_info *uinfo,
 463                       struct netlink_ext_ack *extack)
 464 {
 465         struct dsa_notifier_lag_info info = {
 466                 .sw_index = dp->ds->index,
 467                 .port = dp->index,
 468                 .lag = lag,
 469                 .info = uinfo,
 470         };
 471         struct net_device *bridge_dev;
 472         int err;
 473
 474         dsa_lag_map(dp->ds->dst, lag);
 475         dp->lag_dev = lag;
 476
 477         err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_JOIN, &info);
 478         if (err)
 479                 goto err_lag_join;
 480
 481         bridge_dev = netdev_master_upper_dev_get(lag);
 482         if (!bridge_dev || !netif_is_bridge_master(bridge_dev))
 483                 return 0;
 484
 485         err = dsa_port_bridge_join(dp, bridge_dev, extack);
 486         if (err)
 487                 goto err_bridge_join;
 488
 489         return 0;
 490
 491 err_bridge_join:
 492         dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
 493 err_lag_join:
 494         dp->lag_dev = NULL;
 495         dsa_lag_unmap(dp->ds->dst, lag);
 496         return err;
 497 }
 498
 499 void dsa_port_pre_lag_leave(struct dsa_port *dp, struct net_device *lag)
 500 {
 501         if (dp->bridge_dev)
 502                 dsa_port_pre_bridge_leave(dp, dp->bridge_dev);
 503 }
 504
 505 void dsa_port_lag_leave(struct dsa_port *dp, struct net_device *lag)
 506 {
 507         struct dsa_notifier_lag_info info = {
 508                 .sw_index = dp->ds->index,
 509                 .port = dp->index,
 510                 .lag = lag,
 511         };
 512         int err;
 513
 514         if (!dp->lag_dev)
 515                 return;
 516
 517         /* Port might have been part of a LAG that in turn was
 518          * attached to a bridge.
 519          */
 520         if (dp->bridge_dev)
 521                 dsa_port_bridge_leave(dp, dp->bridge_dev);
 522
 523         dp->lag_tx_enabled = false;
 524         dp->lag_dev = NULL;
 525
 526         err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
 527         if (err)
 528                 pr_err("DSA: failed to notify DSA_NOTIFIER_LAG_LEAVE: %d\n",
 529                        err);
 530
 531         dsa_lag_unmap(dp->ds->dst, lag);
 532 }
 533
 534 /* Must be called under rcu_read_lock() */
 535 static bool dsa_port_can_apply_vlan_filtering(struct dsa_port *dp,
 536                                               bool vlan_filtering,
 537                                               struct netlink_ext_ack *extack)
 538 {
 539         struct dsa_switch *ds = dp->ds;
 540         int err, i;
 541
 542         /* VLAN awareness was off, so the question is "can we turn it on".
 543          * We may have had 8021q uppers, those need to go. Make sure we don't
 544          * enter an inconsistent state: deny changing the VLAN awareness state
 545          * as long as we have 8021q uppers.
 546          */
 547         if (vlan_filtering && dsa_is_user_port(ds, dp->index)) {
 548                 struct net_device *upper_dev, *slave = dp->slave;
 549                 struct net_device *br = dp->bridge_dev;
 550                 struct list_head *iter;
 551
 552                 netdev_for_each_upper_dev_rcu(slave, upper_dev, iter) {
 553                         struct bridge_vlan_info br_info;
 554                         u16 vid;
 555
 556                         if (!is_vlan_dev(upper_dev))
 557                                 continue;
 558
 559                         vid = vlan_dev_vlan_id(upper_dev);
 560
 561                         /* br_vlan_get_info() returns -EINVAL or -ENOENT if the
 562                          * device, respectively the VID is not found, returning
 563                          * 0 means success, which is a failure for us here.
 564                          */
 565                         err = br_vlan_get_info(br, vid, &br_info);
 566                         if (err == 0) {
 567                                 NL_SET_ERR_MSG_MOD(extack,
 568                                                    "Must first remove VLAN uppers having VIDs also present in bridge");
 569                                 return false;
 570                         }
 571                 }
 572         }
 573
 574         if (!ds->vlan_filtering_is_global)
 575                 return true;
 576
 577         /* For cases where enabling/disabling VLAN awareness is global to the
 578          * switch, we need to handle the case where multiple bridges span
 579          * different ports of the same switch device and one of them has a
 580          * different setting than what is being requested.
 581          */
 582         for (i = 0; i < ds->num_ports; i++) {
 583                 struct net_device *other_bridge;
 584
 585                 other_bridge = dsa_to_port(ds, i)->bridge_dev;
 586                 if (!other_bridge)
 587                         continue;
 588                 /* If it's the same bridge, it also has same
 589                  * vlan_filtering setting => no need to check
 590                  */
 591                 if (other_bridge == dp->bridge_dev)
 592                         continue;
 593                 if (br_vlan_enabled(other_bridge) != vlan_filtering) {
 594                         NL_SET_ERR_MSG_MOD(extack,
 595                                            "VLAN filtering is a global setting");
 596                         return false;
 597                 }
 598         }
 599         return true;
 600 }
 601
 602 int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
 603                             struct netlink_ext_ack *extack)
 604 {
 605         struct dsa_switch *ds = dp->ds;
 606         bool apply;
 607         int err;
 608
 609         if (!ds->ops->port_vlan_filtering)
 610                 return -EOPNOTSUPP;
 611
 612         /* We are called from dsa_slave_switchdev_blocking_event(),
 613          * which is not under rcu_read_lock(), unlike
 614          * dsa_slave_switchdev_event().
 615          */
 616         rcu_read_lock();
 617         apply = dsa_port_can_apply_vlan_filtering(dp, vlan_filtering, extack);
 618         rcu_read_unlock();
 619         if (!apply)
 620                 return -EINVAL;
 621
 622         if (dsa_port_is_vlan_filtering(dp) == vlan_filtering)
 623                 return 0;
 624
 625         err = ds->ops->port_vlan_filtering(ds, dp->index, vlan_filtering,
 626                                            extack);
 627         if (err)
 628                 return err;
 629
 630         if (ds->vlan_filtering_is_global)
 631                 ds->vlan_filtering = vlan_filtering;
 632         else
 633                 dp->vlan_filtering = vlan_filtering;
 634
 635         return 0;
 636 }
 637
 638 /* This enforces legacy behavior for switch drivers which assume they can't
 639  * receive VLAN configuration when enslaved to a bridge with vlan_filtering=0
 640  */
 641 bool dsa_port_skip_vlan_configuration(struct dsa_port *dp)
 642 {
 643         struct dsa_switch *ds = dp->ds;
 644
 645         if (!dp->bridge_dev)
 646                 return false;
 647
 648         return (!ds->configure_vlan_while_not_filtering &&
 649                 !br_vlan_enabled(dp->bridge_dev));
 650 }
 651
 652 int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock)
 653 {
 654         unsigned long ageing_jiffies = clock_t_to_jiffies(ageing_clock);
 655         unsigned int ageing_time = jiffies_to_msecs(ageing_jiffies);
 656         struct dsa_notifier_ageing_time_info info;
 657         int err;
 658
 659         info.ageing_time = ageing_time;
 660
 661         err = dsa_port_notify(dp, DSA_NOTIFIER_AGEING_TIME, &info);
 662         if (err)
 663                 return err;
 664
 665         dp->ageing_time = ageing_time;
 666
 667         return 0;
 668 }
 669
 670 int dsa_port_pre_bridge_flags(const struct dsa_port *dp,
 671                               struct switchdev_brport_flags flags,
 672                               struct netlink_ext_ack *extack)
 673 {
 674         struct dsa_switch *ds = dp->ds;
 675
 676         if (!ds->ops->port_pre_bridge_flags)
 677                 return -EINVAL;
 678
 679         return ds->ops->port_pre_bridge_flags(ds, dp->index, flags, extack);
 680 }
 681
 682 int dsa_port_bridge_flags(struct dsa_port *dp,
 683                           struct switchdev_brport_flags flags,
 684                           struct netlink_ext_ack *extack)
 685 {
 686         struct dsa_switch *ds = dp->ds;
 687         int err;
 688
 689         if (!ds->ops->port_bridge_flags)
 690                 return -EOPNOTSUPP;
 691
 692         err = ds->ops->port_bridge_flags(ds, dp->index, flags, extack);
 693         if (err)
 694                 return err;
 695
 696         if (flags.mask & BR_LEARNING) {
 697                 bool learning = flags.val & BR_LEARNING;
 698
 699                 if (learning == dp->learning)
 700                         return 0;
 701
 702                 if (dp->learning && !learning)
 703                         dsa_port_fast_age(dp);
 704
 705                 dp->learning = learning;
 706         }
 707
 708         return 0;
 709 }
 710
 711 int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu,
 712                         bool targeted_match)
 713 {
 714         struct dsa_notifier_mtu_info info = {
 715                 .sw_index = dp->ds->index,
 716                 .targeted_match = targeted_match,
 717                 .port = dp->index,
 718                 .mtu = new_mtu,
 719         };
 720
 721         return dsa_port_notify(dp, DSA_NOTIFIER_MTU, &info);
 722 }
 723
 724 int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr,
 725                      u16 vid)
 726 {
 727         struct dsa_notifier_fdb_info info = {
 728                 .sw_index = dp->ds->index,
 729                 .port = dp->index,
 730                 .addr = addr,
 731                 .vid = vid,
 732         };
 733
 734         return dsa_port_notify(dp, DSA_NOTIFIER_FDB_ADD, &info);
 735 }
 736
 737 int dsa_port_fdb_del(struct dsa_port *dp, const unsigned char *addr,
 738                      u16 vid)
 739 {
 740         struct dsa_notifier_fdb_info info = {
 741                 .sw_index = dp->ds->index,
 742                 .port = dp->index,
 743                 .addr = addr,
 744                 .vid = vid,
 745
 746         };
 747
 748         return dsa_port_notify(dp, DSA_NOTIFIER_FDB_DEL, &info);
 749 }
 750
 751 int dsa_port_host_fdb_add(struct dsa_port *dp, const unsigned char *addr,
 752                           u16 vid)
 753 {
 754         struct dsa_notifier_fdb_info info = {
 755                 .sw_index = dp->ds->index,
 756                 .port = dp->index,
 757                 .addr = addr,
 758                 .vid = vid,
 759         };
 760         struct dsa_port *cpu_dp = dp->cpu_dp;
 761         int err;
 762
 763         err = dev_uc_add(cpu_dp->master, addr);
 764         if (err)
 765                 return err;
 766
 767         return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_ADD, &info);
 768 }
 769
 770 int dsa_port_host_fdb_del(struct dsa_port *dp, const unsigned char *addr,
 771                           u16 vid)
 772 {
 773         struct dsa_notifier_fdb_info info = {
 774                 .sw_index = dp->ds->index,
 775                 .port = dp->index,
 776                 .addr = addr,
 777                 .vid = vid,
 778         };
 779         struct dsa_port *cpu_dp = dp->cpu_dp;
 780         int err;
 781
 782         err = dev_uc_del(cpu_dp->master, addr);
 783         if (err)
 784                 return err;
 785
 786         return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_DEL, &info);
 787 }
 788
 789 int dsa_port_fdb_dump(struct dsa_port *dp, dsa_fdb_dump_cb_t *cb, void *data)
 790 {
 791         struct dsa_switch *ds = dp->ds;
 792         int port = dp->index;
 793
 794         if (!ds->ops->port_fdb_dump)
 795                 return -EOPNOTSUPP;
 796
 797         return ds->ops->port_fdb_dump(ds, port, cb, data);
 798 }
 799
 800 int dsa_port_mdb_add(const struct dsa_port *dp,
 801                      const struct switchdev_obj_port_mdb *mdb)
 802 {
 803         struct dsa_notifier_mdb_info info = {
 804                 .sw_index = dp->ds->index,
 805                 .port = dp->index,
 806                 .mdb = mdb,
 807         };
 808
 809         return dsa_port_notify(dp, DSA_NOTIFIER_MDB_ADD, &info);
 810 }
 811
 812 int dsa_port_mdb_del(const struct dsa_port *dp,
 813                      const struct switchdev_obj_port_mdb *mdb)
 814 {
 815         struct dsa_notifier_mdb_info info = {
 816                 .sw_index = dp->ds->index,
 817                 .port = dp->index,
 818                 .mdb = mdb,
 819         };
 820
 821         return dsa_port_notify(dp, DSA_NOTIFIER_MDB_DEL, &info);
 822 }
 823
 824 int dsa_port_host_mdb_add(const struct dsa_port *dp,
 825                           const struct switchdev_obj_port_mdb *mdb)
 826 {
 827         struct dsa_notifier_mdb_info info = {
 828                 .sw_index = dp->ds->index,
 829                 .port = dp->index,
 830                 .mdb = mdb,
 831         };
 832         struct dsa_port *cpu_dp = dp->cpu_dp;
 833         int err;
 834
 835         err = dev_mc_add(cpu_dp->master, mdb->addr);
 836         if (err)
 837                 return err;
 838
 839         return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_ADD, &info);
 840 }
 841
 842 int dsa_port_host_mdb_del(const struct dsa_port *dp,
 843                           const struct switchdev_obj_port_mdb *mdb)
 844 {
 845         struct dsa_notifier_mdb_info info = {
 846                 .sw_index = dp->ds->index,
 847                 .port = dp->index,
 848                 .mdb = mdb,
 849         };
 850         struct dsa_port *cpu_dp = dp->cpu_dp;
 851         int err;
 852
 853         err = dev_mc_del(cpu_dp->master, mdb->addr);
 854         if (err)
 855                 return err;
 856
 857         return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_DEL, &info);
 858 }
 859
 860 int dsa_port_vlan_add(struct dsa_port *dp,
 861                       const struct switchdev_obj_port_vlan *vlan,
 862                       struct netlink_ext_ack *extack)
 863 {
 864         struct dsa_notifier_vlan_info info = {
 865                 .sw_index = dp->ds->index,
 866                 .port = dp->index,
 867                 .vlan = vlan,
 868                 .extack = extack,
 869         };
 870
 871         return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_ADD, &info);
 872 }
 873
 874 int dsa_port_vlan_del(struct dsa_port *dp,
 875                       const struct switchdev_obj_port_vlan *vlan)
 876 {
 877         struct dsa_notifier_vlan_info info = {
 878                 .sw_index = dp->ds->index,
 879                 .port = dp->index,
 880                 .vlan = vlan,
 881         };
 882
 883         return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_DEL, &info);
 884 }
 885
 886 int dsa_port_mrp_add(const struct dsa_port *dp,
 887                      const struct switchdev_obj_mrp *mrp)
 888 {
 889         struct dsa_notifier_mrp_info info = {
 890                 .sw_index = dp->ds->index,
 891                 .port = dp->index,
 892                 .mrp = mrp,
 893         };
 894
 895         return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD, &info);
 896 }
 897
 898 int dsa_port_mrp_del(const struct dsa_port *dp,
 899                      const struct switchdev_obj_mrp *mrp)
 900 {
 901         struct dsa_notifier_mrp_info info = {
 902                 .sw_index = dp->ds->index,
 903                 .port = dp->index,
 904                 .mrp = mrp,
 905         };
 906
 907         return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL, &info);
 908 }
 909
 910 int dsa_port_mrp_add_ring_role(const struct dsa_port *dp,
 911                                const struct switchdev_obj_ring_role_mrp *mrp)
 912 {
 913         struct dsa_notifier_mrp_ring_role_info info = {
 914                 .sw_index = dp->ds->index,
 915                 .port = dp->index,
 916                 .mrp = mrp,
 917         };
 918
 919         return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD_RING_ROLE, &info);
 920 }
 921
 922 int dsa_port_mrp_del_ring_role(const struct dsa_port *dp,
 923                                const struct switchdev_obj_ring_role_mrp *mrp)
 924 {
 925         struct dsa_notifier_mrp_ring_role_info info = {
 926                 .sw_index = dp->ds->index,
 927                 .port = dp->index,
 928                 .mrp = mrp,
 929         };
 930
 931         return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL_RING_ROLE, &info);
 932 }
 933
 934 void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp,
 935                                const struct dsa_device_ops *tag_ops)
 936 {
 937         cpu_dp->rcv = tag_ops->rcv;
 938         cpu_dp->tag_ops = tag_ops;
 939 }
 940
 941 static struct phy_device *dsa_port_get_phy_device(struct dsa_port *dp)
 942 {
 943         struct device_node *phy_dn;
 944         struct phy_device *phydev;
 945
 946         phy_dn = of_parse_phandle(dp->dn, "phy-handle", 0);
 947         if (!phy_dn)
 948                 return NULL;
 949
 950         phydev = of_phy_find_device(phy_dn);
 951         if (!phydev) {
 952                 of_node_put(phy_dn);
 953                 return ERR_PTR(-EPROBE_DEFER);
 954         }
 955
 956         of_node_put(phy_dn);
 957         return phydev;
 958 }
 959
 960 static void dsa_port_phylink_validate(struct phylink_config *config,
 961                                       unsigned long *supported,
 962                                       struct phylink_link_state *state)
 963 {
 964         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
 965         struct dsa_switch *ds = dp->ds;
 966
 967         if (!ds->ops->phylink_validate)
 968                 return;
 969
 970         ds->ops->phylink_validate(ds, dp->index, supported, state);
 971 }
 972
 973 static void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
 974                                                struct phylink_link_state *state)
 975 {
 976         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
 977         struct dsa_switch *ds = dp->ds;
 978         int err;
 979
 980         /* Only called for inband modes */
 981         if (!ds->ops->phylink_mac_link_state) {
 982                 state->link = 0;
 983                 return;
 984         }
 985
 986         err = ds->ops->phylink_mac_link_state(ds, dp->index, state);
 987         if (err < 0) {
 988                 dev_err(ds->dev, "p%d: phylink_mac_link_state() failed: %d\n",
 989                         dp->index, err);
 990                 state->link = 0;
 991         }
 992 }
 993
 994 static void dsa_port_phylink_mac_config(struct phylink_config *config,
 995                                         unsigned int mode,
 996                                         const struct phylink_link_state *state)
 997 {
 998         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
 999         struct dsa_switch *ds = dp->ds;
1000
1001         if (!ds->ops->phylink_mac_config)
1002                 return;
1003
1004         ds->ops->phylink_mac_config(ds, dp->index, mode, state);
1005 }
1006
1007 static void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
1008 {
1009         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1010         struct dsa_switch *ds = dp->ds;
1011
1012         if (!ds->ops->phylink_mac_an_restart)
1013                 return;
1014
1015         ds->ops->phylink_mac_an_restart(ds, dp->index);
1016 }
1017
1018 static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
1019                                            unsigned int mode,
1020                                            phy_interface_t interface)
1021 {
1022         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1023         struct phy_device *phydev = NULL;
1024         struct dsa_switch *ds = dp->ds;
1025
1026         if (dsa_is_user_port(ds, dp->index))
1027                 phydev = dp->slave->phydev;
1028
1029         if (!ds->ops->phylink_mac_link_down) {
1030                 if (ds->ops->adjust_link && phydev)
1031                         ds->ops->adjust_link(ds, dp->index, phydev);
1032                 return;
1033         }
1034
1035         ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
1036 }
1037
1038 static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
1039                                          struct phy_device *phydev,
1040                                          unsigned int mode,
1041                                          phy_interface_t interface,
1042                                          int speed, int duplex,
1043                                          bool tx_pause, bool rx_pause)
1044 {
1045         struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1046         struct dsa_switch *ds = dp->ds;
1047
1048         if (!ds->ops->phylink_mac_link_up) {
1049                 if (ds->ops->adjust_link && phydev)
1050                         ds->ops->adjust_link(ds, dp->index, phydev);
1051                 return;
1052         }
1053
1054         ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev,
1055                                      speed, duplex, tx_pause, rx_pause);
1056 }
1057
1058 const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
1059         .validate = dsa_port_phylink_validate,
1060         .mac_pcs_get_state = dsa_port_phylink_mac_pcs_get_state,
1061         .mac_config = dsa_port_phylink_mac_config,
1062         .mac_an_restart = dsa_port_phylink_mac_an_restart,
1063         .mac_link_down = dsa_port_phylink_mac_link_down,
1064         .mac_link_up = dsa_port_phylink_mac_link_up,
1065 };
1066
1067 static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)
1068 {
1069         struct dsa_switch *ds = dp->ds;
1070         struct phy_device *phydev;
1071         int port = dp->index;
1072         int err = 0;
1073
1074         phydev = dsa_port_get_phy_device(dp);
1075         if (!phydev)
1076                 return 0;
1077
1078         if (IS_ERR(phydev))
1079                 return PTR_ERR(phydev);
1080
1081         if (enable) {
1082                 err = genphy_resume(phydev);
1083                 if (err < 0)
1084                         goto err_put_dev;
1085
1086                 err = genphy_read_status(phydev);
1087                 if (err < 0)
1088                         goto err_put_dev;
1089         } else {
1090                 err = genphy_suspend(phydev);
1091                 if (err < 0)
1092                         goto err_put_dev;
1093         }
1094
1095         if (ds->ops->adjust_link)
1096                 ds->ops->adjust_link(ds, port, phydev);
1097
1098         dev_dbg(ds->dev, "enabled port's phy: %s", phydev_name(phydev));
1099
1100 err_put_dev:
1101         put_device(&phydev->mdio.dev);
1102         return err;
1103 }
1104
1105 static int dsa_port_fixed_link_register_of(struct dsa_port *dp)
1106 {
1107         struct device_node *dn = dp->dn;
1108         struct dsa_switch *ds = dp->ds;
1109         struct phy_device *phydev;
1110         int port = dp->index;
1111         phy_interface_t mode;
1112         int err;
1113
1114         err = of_phy_register_fixed_link(dn);
1115         if (err) {
1116                 dev_err(ds->dev,
1117                         "failed to register the fixed PHY of port %d\n",
1118                         port);
1119                 return err;
1120         }
1121
1122         phydev = of_phy_find_device(dn);
1123
1124         err = of_get_phy_mode(dn, &mode);
1125         if (err)
1126                 mode = PHY_INTERFACE_MODE_NA;
1127         phydev->interface = mode;
1128
1129         genphy_read_status(phydev);
1130
1131         if (ds->ops->adjust_link)
1132                 ds->ops->adjust_link(ds, port, phydev);
1133
1134         put_device(&phydev->mdio.dev);
1135
1136         return 0;
1137 }
1138
1139 static int dsa_port_phylink_register(struct dsa_port *dp)
1140 {
1141         struct dsa_switch *ds = dp->ds;
1142         struct device_node *port_dn = dp->dn;
1143         phy_interface_t mode;
1144         int err;
1145
1146         err = of_get_phy_mode(port_dn, &mode);
1147         if (err)
1148                 mode = PHY_INTERFACE_MODE_NA;
1149
1150         dp->pl_config.dev = ds->dev;
1151         dp->pl_config.type = PHYLINK_DEV;
1152         dp->pl_config.pcs_poll = ds->pcs_poll;
1153
1154         dp->pl = phylink_create(&dp->pl_config, of_fwnode_handle(port_dn),
1155                                 mode, &dsa_port_phylink_mac_ops);
1156         if (IS_ERR(dp->pl)) {
1157                 pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
1158                 return PTR_ERR(dp->pl);
1159         }
1160
1161         err = phylink_of_phy_connect(dp->pl, port_dn, 0);
1162         if (err && err != -ENODEV) {
1163                 pr_err("could not attach to PHY: %d\n", err);
1164                 goto err_phy_connect;
1165         }
1166
1167         return 0;
1168
1169 err_phy_connect:
1170         phylink_destroy(dp->pl);
1171         return err;
1172 }
1173
1174 int dsa_port_link_register_of(struct dsa_port *dp)
1175 {
1176         struct dsa_switch *ds = dp->ds;
1177         struct device_node *phy_np;
1178         int port = dp->index;
1179
1180         if (!ds->ops->adjust_link) {
1181                 phy_np = of_parse_phandle(dp->dn, "phy-handle", 0);
1182                 if (of_phy_is_fixed_link(dp->dn) || phy_np) {
1183                         if (ds->ops->phylink_mac_link_down)
1184                                 ds->ops->phylink_mac_link_down(ds, port,
1185                                         MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
1186                         return dsa_port_phylink_register(dp);
1187                 }
1188                 return 0;
1189         }
1190
1191         dev_warn(ds->dev,
1192                  "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n");
1193
1194         if (of_phy_is_fixed_link(dp->dn))
1195                 return dsa_port_fixed_link_register_of(dp);
1196         else
1197                 return dsa_port_setup_phy_of(dp, true);
1198 }
1199
1200 void dsa_port_link_unregister_of(struct dsa_port *dp)
1201 {
1202         struct dsa_switch *ds = dp->ds;
1203
1204         if (!ds->ops->adjust_link && dp->pl) {
1205                 rtnl_lock();
1206                 phylink_disconnect_phy(dp->pl);
1207                 rtnl_unlock();
1208                 phylink_destroy(dp->pl);
1209                 dp->pl = NULL;
1210                 return;
1211         }
1212
1213         if (of_phy_is_fixed_link(dp->dn))
1214                 of_phy_deregister_fixed_link(dp->dn);
1215         else
1216                 dsa_port_setup_phy_of(dp, false);
1217 }
1218
1219 int dsa_port_get_phy_strings(struct dsa_port *dp, uint8_t *data)
1220 {
1221         struct phy_device *phydev;
1222         int ret = -EOPNOTSUPP;
1223
1224         if (of_phy_is_fixed_link(dp->dn))
1225                 return ret;
1226
1227         phydev = dsa_port_get_phy_device(dp);
1228         if (IS_ERR_OR_NULL(phydev))
1229                 return ret;
1230
1231         ret = phy_ethtool_get_strings(phydev, data);
1232         put_device(&phydev->mdio.dev);
1233
1234         return ret;
1235 }
1236 EXPORT_SYMBOL_GPL(dsa_port_get_phy_strings);
1237
1238 int dsa_port_get_ethtool_phy_stats(struct dsa_port *dp, uint64_t *data)
1239 {
1240         struct phy_device *phydev;
1241         int ret = -EOPNOTSUPP;
1242
1243         if (of_phy_is_fixed_link(dp->dn))
1244                 return ret;
1245
1246         phydev = dsa_port_get_phy_device(dp);
1247         if (IS_ERR_OR_NULL(phydev))
1248                 return ret;
1249
1250         ret = phy_ethtool_get_stats(phydev, NULL, data);
1251         put_device(&phydev->mdio.dev);
1252
1253         return ret;
1254 }
1255 EXPORT_SYMBOL_GPL(dsa_port_get_ethtool_phy_stats);
1256
1257 int dsa_port_get_phy_sset_count(struct dsa_port *dp)
1258 {
1259         struct phy_device *phydev;
1260         int ret = -EOPNOTSUPP;
1261
1262         if (of_phy_is_fixed_link(dp->dn))
1263                 return ret;
1264
1265         phydev = dsa_port_get_phy_device(dp);
1266         if (IS_ERR_OR_NULL(phydev))
1267                 return ret;
1268
1269         ret = phy_ethtool_get_sset_count(phydev);
1270         put_device(&phydev->mdio.dev);
1271
1272         return ret;
1273 }
1274 EXPORT_SYMBOL_GPL(dsa_port_get_phy_sset_count);
1275
1276 int dsa_port_hsr_join(struct dsa_port *dp, struct net_device *hsr)
1277 {
1278         struct dsa_notifier_hsr_info info = {
1279                 .sw_index = dp->ds->index,
1280                 .port = dp->index,
1281                 .hsr = hsr,
1282         };
1283         int err;
1284
1285         dp->hsr_dev = hsr;
1286
1287         err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_JOIN, &info);
1288         if (err)
1289                 dp->hsr_dev = NULL;
1290
1291         return err;
1292 }
1293
1294 void dsa_port_hsr_leave(struct dsa_port *dp, struct net_device *hsr)
1295 {
1296         struct dsa_notifier_hsr_info info = {
1297                 .sw_index = dp->ds->index,
1298                 .port = dp->index,
1299                 .hsr = hsr,
1300         };
1301         int err;
1302
1303         dp->hsr_dev = NULL;
1304
1305         err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_LEAVE, &info);
1306         if (err)
1307                 pr_err("DSA: failed to notify DSA_NOTIFIER_HSR_LEAVE\n");
1308 }
1309
1310 int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid)
1311 {
1312         struct dsa_notifier_tag_8021q_vlan_info info = {
1313                 .tree_index = dp->ds->dst->index,
1314                 .sw_index = dp->ds->index,
1315                 .port = dp->index,
1316                 .vid = vid,
1317         };
1318
1319         return dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_ADD, &info);
1320 }
1321
1322 void dsa_port_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid)
1323 {
1324         struct dsa_notifier_tag_8021q_vlan_info info = {
1325                 .tree_index = dp->ds->dst->index,
1326                 .sw_index = dp->ds->index,
1327                 .port = dp->index,
1328                 .vid = vid,
1329         };
1330         int err;
1331
1332         err = dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_DEL, &info);
1333         if (err)
1334                 pr_err("DSA: failed to notify tag_8021q VLAN deletion: %pe\n",
1335                        ERR_PTR(err));
1336 }