1 // SPDX-License-Identifier: GPL-2.0
3 * Copyright (C) 2015-2017 Broadcom
6 #include "bcm-phy-lib.h"
7 #include <linux/bitfield.h>
8 #include <linux/brcmphy.h>
9 #include <linux/export.h>
10 #include <linux/mdio.h>
11 #include <linux/module.h>
12 #include <linux/phy.h>
13 #include <linux/ethtool.h>
14 #include <linux/ethtool_netlink.h>
16 #define MII_BCM_CHANNEL_WIDTH 0x2000
17 #define BCM_CL45VEN_EEE_ADV 0x3c
19 int __bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val)
23 rc = __phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
27 return __phy_write(phydev, MII_BCM54XX_EXP_DATA, val);
29 EXPORT_SYMBOL_GPL(__bcm_phy_write_exp);
31 int bcm_phy_write_exp(struct phy_device *phydev, u16 reg, u16 val)
35 phy_lock_mdio_bus(phydev);
36 rc = __bcm_phy_write_exp(phydev, reg, val);
37 phy_unlock_mdio_bus(phydev);
41 EXPORT_SYMBOL_GPL(bcm_phy_write_exp);
43 int __bcm_phy_read_exp(struct phy_device *phydev, u16 reg)
47 val = __phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
51 val = __phy_read(phydev, MII_BCM54XX_EXP_DATA);
53 /* Restore default value. It's O.K. if this write fails. */
54 __phy_write(phydev, MII_BCM54XX_EXP_SEL, 0);
58 EXPORT_SYMBOL_GPL(__bcm_phy_read_exp);
60 int bcm_phy_read_exp(struct phy_device *phydev, u16 reg)
64 phy_lock_mdio_bus(phydev);
65 rc = __bcm_phy_read_exp(phydev, reg);
66 phy_unlock_mdio_bus(phydev);
70 EXPORT_SYMBOL_GPL(bcm_phy_read_exp);
72 int __bcm_phy_modify_exp(struct phy_device *phydev, u16 reg, u16 mask, u16 set)
76 ret = __phy_write(phydev, MII_BCM54XX_EXP_SEL, reg);
80 ret = __phy_read(phydev, MII_BCM54XX_EXP_DATA);
84 new = (ret & ~mask) | set;
88 return __phy_write(phydev, MII_BCM54XX_EXP_DATA, new);
90 EXPORT_SYMBOL_GPL(__bcm_phy_modify_exp);
92 int bcm_phy_modify_exp(struct phy_device *phydev, u16 reg, u16 mask, u16 set)
96 phy_lock_mdio_bus(phydev);
97 ret = __bcm_phy_modify_exp(phydev, reg, mask, set);
98 phy_unlock_mdio_bus(phydev);
102 EXPORT_SYMBOL_GPL(bcm_phy_modify_exp);
104 int bcm54xx_auxctl_read(struct phy_device *phydev, u16 regnum)
106 /* The register must be written to both the Shadow Register Select and
107 * the Shadow Read Register Selector
109 phy_write(phydev, MII_BCM54XX_AUX_CTL, MII_BCM54XX_AUXCTL_SHDWSEL_MASK |
110 regnum << MII_BCM54XX_AUXCTL_SHDWSEL_READ_SHIFT);
111 return phy_read(phydev, MII_BCM54XX_AUX_CTL);
113 EXPORT_SYMBOL_GPL(bcm54xx_auxctl_read);
115 int bcm54xx_auxctl_write(struct phy_device *phydev, u16 regnum, u16 val)
117 return phy_write(phydev, MII_BCM54XX_AUX_CTL, regnum | val);
119 EXPORT_SYMBOL(bcm54xx_auxctl_write);
121 int bcm_phy_write_misc(struct phy_device *phydev,
122 u16 reg, u16 chl, u16 val)
127 rc = phy_write(phydev, MII_BCM54XX_AUX_CTL,
128 MII_BCM54XX_AUXCTL_SHDWSEL_MISC);
132 tmp = phy_read(phydev, MII_BCM54XX_AUX_CTL);
133 tmp |= MII_BCM54XX_AUXCTL_ACTL_SMDSP_ENA;
134 rc = phy_write(phydev, MII_BCM54XX_AUX_CTL, tmp);
138 tmp = (chl * MII_BCM_CHANNEL_WIDTH) | reg;
139 rc = bcm_phy_write_exp(phydev, tmp, val);
143 EXPORT_SYMBOL_GPL(bcm_phy_write_misc);
145 int bcm_phy_read_misc(struct phy_device *phydev,
151 rc = phy_write(phydev, MII_BCM54XX_AUX_CTL,
152 MII_BCM54XX_AUXCTL_SHDWSEL_MISC);
156 tmp = phy_read(phydev, MII_BCM54XX_AUX_CTL);
157 tmp |= MII_BCM54XX_AUXCTL_ACTL_SMDSP_ENA;
158 rc = phy_write(phydev, MII_BCM54XX_AUX_CTL, tmp);
162 tmp = (chl * MII_BCM_CHANNEL_WIDTH) | reg;
163 rc = bcm_phy_read_exp(phydev, tmp);
167 EXPORT_SYMBOL_GPL(bcm_phy_read_misc);
169 int bcm_phy_ack_intr(struct phy_device *phydev)
173 /* Clear pending interrupts. */
174 reg = phy_read(phydev, MII_BCM54XX_ISR);
180 EXPORT_SYMBOL_GPL(bcm_phy_ack_intr);
182 int bcm_phy_config_intr(struct phy_device *phydev)
186 reg = phy_read(phydev, MII_BCM54XX_ECR);
190 if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
191 err = bcm_phy_ack_intr(phydev);
195 reg &= ~MII_BCM54XX_ECR_IM;
196 err = phy_write(phydev, MII_BCM54XX_ECR, reg);
198 reg |= MII_BCM54XX_ECR_IM;
199 err = phy_write(phydev, MII_BCM54XX_ECR, reg);
203 err = bcm_phy_ack_intr(phydev);
207 EXPORT_SYMBOL_GPL(bcm_phy_config_intr);
209 irqreturn_t bcm_phy_handle_interrupt(struct phy_device *phydev)
211 int irq_status, irq_mask;
213 irq_status = phy_read(phydev, MII_BCM54XX_ISR);
214 if (irq_status < 0) {
219 /* If a bit from the Interrupt Mask register is set, the corresponding
220 * bit from the Interrupt Status register is masked. So read the IMR
221 * and then flip the bits to get the list of possible interrupt
224 irq_mask = phy_read(phydev, MII_BCM54XX_IMR);
229 irq_mask = ~irq_mask;
231 if (!(irq_status & irq_mask))
234 phy_trigger_machine(phydev);
238 EXPORT_SYMBOL_GPL(bcm_phy_handle_interrupt);
240 int bcm_phy_read_shadow(struct phy_device *phydev, u16 shadow)
242 phy_write(phydev, MII_BCM54XX_SHD, MII_BCM54XX_SHD_VAL(shadow));
243 return MII_BCM54XX_SHD_DATA(phy_read(phydev, MII_BCM54XX_SHD));
245 EXPORT_SYMBOL_GPL(bcm_phy_read_shadow);
247 int bcm_phy_write_shadow(struct phy_device *phydev, u16 shadow,
250 return phy_write(phydev, MII_BCM54XX_SHD,
251 MII_BCM54XX_SHD_WRITE |
252 MII_BCM54XX_SHD_VAL(shadow) |
253 MII_BCM54XX_SHD_DATA(val));
255 EXPORT_SYMBOL_GPL(bcm_phy_write_shadow);
257 int __bcm_phy_read_rdb(struct phy_device *phydev, u16 rdb)
261 val = __phy_write(phydev, MII_BCM54XX_RDB_ADDR, rdb);
265 return __phy_read(phydev, MII_BCM54XX_RDB_DATA);
267 EXPORT_SYMBOL_GPL(__bcm_phy_read_rdb);
269 int bcm_phy_read_rdb(struct phy_device *phydev, u16 rdb)
273 phy_lock_mdio_bus(phydev);
274 ret = __bcm_phy_read_rdb(phydev, rdb);
275 phy_unlock_mdio_bus(phydev);
279 EXPORT_SYMBOL_GPL(bcm_phy_read_rdb);
281 int __bcm_phy_write_rdb(struct phy_device *phydev, u16 rdb, u16 val)
285 ret = __phy_write(phydev, MII_BCM54XX_RDB_ADDR, rdb);
289 return __phy_write(phydev, MII_BCM54XX_RDB_DATA, val);
291 EXPORT_SYMBOL_GPL(__bcm_phy_write_rdb);
293 int bcm_phy_write_rdb(struct phy_device *phydev, u16 rdb, u16 val)
297 phy_lock_mdio_bus(phydev);
298 ret = __bcm_phy_write_rdb(phydev, rdb, val);
299 phy_unlock_mdio_bus(phydev);
303 EXPORT_SYMBOL_GPL(bcm_phy_write_rdb);
305 int __bcm_phy_modify_rdb(struct phy_device *phydev, u16 rdb, u16 mask, u16 set)
309 ret = __phy_write(phydev, MII_BCM54XX_RDB_ADDR, rdb);
313 ret = __phy_read(phydev, MII_BCM54XX_RDB_DATA);
317 new = (ret & ~mask) | set;
321 return __phy_write(phydev, MII_BCM54XX_RDB_DATA, new);
323 EXPORT_SYMBOL_GPL(__bcm_phy_modify_rdb);
325 int bcm_phy_modify_rdb(struct phy_device *phydev, u16 rdb, u16 mask, u16 set)
329 phy_lock_mdio_bus(phydev);
330 ret = __bcm_phy_modify_rdb(phydev, rdb, mask, set);
331 phy_unlock_mdio_bus(phydev);
335 EXPORT_SYMBOL_GPL(bcm_phy_modify_rdb);
337 int bcm_phy_enable_apd(struct phy_device *phydev, bool dll_pwr_down)
342 val = bcm_phy_read_shadow(phydev, BCM54XX_SHD_SCR3);
346 val |= BCM54XX_SHD_SCR3_DLLAPD_DIS;
347 bcm_phy_write_shadow(phydev, BCM54XX_SHD_SCR3, val);
350 val = bcm_phy_read_shadow(phydev, BCM54XX_SHD_APD);
355 val &= BCM_APD_CLR_MASK;
357 if (phydev->autoneg == AUTONEG_ENABLE)
358 val |= BCM54XX_SHD_APD_EN;
360 val |= BCM_NO_ANEG_APD_EN;
362 /* Enable energy detect single link pulse for easy wakeup */
363 val |= BCM_APD_SINGLELP_EN;
365 /* Enable Auto Power-Down (APD) for the PHY */
366 return bcm_phy_write_shadow(phydev, BCM54XX_SHD_APD, val);
368 EXPORT_SYMBOL_GPL(bcm_phy_enable_apd);
370 int bcm_phy_set_eee(struct phy_device *phydev, bool enable)
374 /* Enable EEE at PHY level */
375 val = phy_read_mmd(phydev, MDIO_MMD_AN, BRCM_CL45VEN_EEE_CONTROL);
380 val |= LPI_FEATURE_EN | LPI_FEATURE_EN_DIG1000X;
382 val &= ~(LPI_FEATURE_EN | LPI_FEATURE_EN_DIG1000X);
384 phy_write_mmd(phydev, MDIO_MMD_AN, BRCM_CL45VEN_EEE_CONTROL, (u32)val);
387 val = phy_read_mmd(phydev, MDIO_MMD_AN, BCM_CL45VEN_EEE_ADV);
391 if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
393 mask |= MDIO_EEE_1000T;
394 if (linkmode_test_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT,
396 mask |= MDIO_EEE_100TX;
403 phy_write_mmd(phydev, MDIO_MMD_AN, BCM_CL45VEN_EEE_ADV, (u32)val);
407 EXPORT_SYMBOL_GPL(bcm_phy_set_eee);
409 int bcm_phy_downshift_get(struct phy_device *phydev, u8 *count)
413 val = bcm54xx_auxctl_read(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_MISC);
417 /* Check if wirespeed is enabled or not */
418 if (!(val & MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN)) {
419 *count = DOWNSHIFT_DEV_DISABLE;
423 val = bcm_phy_read_shadow(phydev, BCM54XX_SHD_SCR2);
427 /* Downgrade after one link attempt */
428 if (val & BCM54XX_SHD_SCR2_WSPD_RTRY_DIS) {
431 /* Downgrade after configured retry count */
432 val >>= BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_SHIFT;
433 val &= BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_MASK;
434 *count = val + BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_OFFSET;
439 EXPORT_SYMBOL_GPL(bcm_phy_downshift_get);
441 int bcm_phy_downshift_set(struct phy_device *phydev, u8 count)
443 int val = 0, ret = 0;
445 /* Range check the number given */
446 if (count - BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_OFFSET >
447 BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_MASK &&
448 count != DOWNSHIFT_DEV_DEFAULT_COUNT) {
452 val = bcm54xx_auxctl_read(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_MISC);
456 /* Se the write enable bit */
457 val |= MII_BCM54XX_AUXCTL_MISC_WREN;
459 if (count == DOWNSHIFT_DEV_DISABLE) {
460 val &= ~MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN;
461 return bcm54xx_auxctl_write(phydev,
462 MII_BCM54XX_AUXCTL_SHDWSEL_MISC,
465 val |= MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN;
466 ret = bcm54xx_auxctl_write(phydev,
467 MII_BCM54XX_AUXCTL_SHDWSEL_MISC,
473 val = bcm_phy_read_shadow(phydev, BCM54XX_SHD_SCR2);
474 val &= ~(BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_MASK <<
475 BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_SHIFT |
476 BCM54XX_SHD_SCR2_WSPD_RTRY_DIS);
480 val |= BCM54XX_SHD_SCR2_WSPD_RTRY_DIS;
482 case DOWNSHIFT_DEV_DEFAULT_COUNT:
483 val |= 1 << BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_SHIFT;
486 val |= (count - BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_OFFSET) <<
487 BCM54XX_SHD_SCR2_WSPD_RTRY_LMT_SHIFT;
491 return bcm_phy_write_shadow(phydev, BCM54XX_SHD_SCR2, val);
493 EXPORT_SYMBOL_GPL(bcm_phy_downshift_set);
495 struct bcm_phy_hw_stat {
502 /* Counters freeze at either 0xffff or 0xff, better than nothing */
503 static const struct bcm_phy_hw_stat bcm_phy_hw_stats[] = {
504 { "phy_receive_errors", MII_BRCM_CORE_BASE12, 0, 16 },
505 { "phy_serdes_ber_errors", MII_BRCM_CORE_BASE13, 8, 8 },
506 { "phy_false_carrier_sense_errors", MII_BRCM_CORE_BASE13, 0, 8 },
507 { "phy_local_rcvr_nok", MII_BRCM_CORE_BASE14, 8, 8 },
508 { "phy_remote_rcv_nok", MII_BRCM_CORE_BASE14, 0, 8 },
511 int bcm_phy_get_sset_count(struct phy_device *phydev)
513 return ARRAY_SIZE(bcm_phy_hw_stats);
515 EXPORT_SYMBOL_GPL(bcm_phy_get_sset_count);
517 void bcm_phy_get_strings(struct phy_device *phydev, u8 *data)
521 for (i = 0; i < ARRAY_SIZE(bcm_phy_hw_stats); i++)
522 strlcpy(data + i * ETH_GSTRING_LEN,
523 bcm_phy_hw_stats[i].string, ETH_GSTRING_LEN);
525 EXPORT_SYMBOL_GPL(bcm_phy_get_strings);
527 /* Caller is supposed to provide appropriate storage for the library code to
528 * access the shadow copy
530 static u64 bcm_phy_get_stat(struct phy_device *phydev, u64 *shadow,
533 struct bcm_phy_hw_stat stat = bcm_phy_hw_stats[i];
537 val = phy_read(phydev, stat.reg);
542 val = val & ((1 << stat.bits) - 1);
550 void bcm_phy_get_stats(struct phy_device *phydev, u64 *shadow,
551 struct ethtool_stats *stats, u64 *data)
555 for (i = 0; i < ARRAY_SIZE(bcm_phy_hw_stats); i++)
556 data[i] = bcm_phy_get_stat(phydev, shadow, i);
558 EXPORT_SYMBOL_GPL(bcm_phy_get_stats);
560 void bcm_phy_r_rc_cal_reset(struct phy_device *phydev)
562 /* Reset R_CAL/RC_CAL Engine */
563 bcm_phy_write_exp_sel(phydev, 0x00b0, 0x0010);
565 /* Disable Reset R_AL/RC_CAL Engine */
566 bcm_phy_write_exp_sel(phydev, 0x00b0, 0x0000);
568 EXPORT_SYMBOL_GPL(bcm_phy_r_rc_cal_reset);
570 int bcm_phy_28nm_a0b0_afe_config_init(struct phy_device *phydev)
572 /* Increase VCO range to prevent unlocking problem of PLL at low
575 bcm_phy_write_misc(phydev, PLL_PLLCTRL_1, 0x0048);
577 /* Change Ki to 011 */
578 bcm_phy_write_misc(phydev, PLL_PLLCTRL_2, 0x021b);
580 /* Disable loading of TVCO buffer to bandgap, set bandgap trim
583 bcm_phy_write_misc(phydev, PLL_PLLCTRL_4, 0x0e20);
585 /* Adjust bias current trim by -3 */
586 bcm_phy_write_misc(phydev, DSP_TAP10, 0x690b);
588 /* Switch to CORE_BASE1E */
589 phy_write(phydev, MII_BRCM_CORE_BASE1E, 0xd);
591 bcm_phy_r_rc_cal_reset(phydev);
593 /* write AFE_RXCONFIG_0 */
594 bcm_phy_write_misc(phydev, AFE_RXCONFIG_0, 0xeb19);
596 /* write AFE_RXCONFIG_1 */
597 bcm_phy_write_misc(phydev, AFE_RXCONFIG_1, 0x9a3f);
599 /* write AFE_RX_LP_COUNTER */
600 bcm_phy_write_misc(phydev, AFE_RX_LP_COUNTER, 0x7fc0);
602 /* write AFE_HPF_TRIM_OTHERS */
603 bcm_phy_write_misc(phydev, AFE_HPF_TRIM_OTHERS, 0x000b);
605 /* write AFTE_TX_CONFIG */
606 bcm_phy_write_misc(phydev, AFE_TX_CONFIG, 0x0800);
610 EXPORT_SYMBOL_GPL(bcm_phy_28nm_a0b0_afe_config_init);
612 int bcm_phy_enable_jumbo(struct phy_device *phydev)
616 ret = bcm54xx_auxctl_read(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL);
620 /* Enable extended length packet reception */
621 ret = bcm54xx_auxctl_write(phydev, MII_BCM54XX_AUXCTL_SHDWSEL_AUXCTL,
622 ret | MII_BCM54XX_AUXCTL_ACTL_EXT_PKT_LEN);
626 /* Enable the elastic FIFO for raising the transmission limit from
627 * 4.5KB to 10KB, at the expense of an additional 16 ns in propagation
630 return phy_set_bits(phydev, MII_BCM54XX_ECR, MII_BCM54XX_ECR_FIFOE);
632 EXPORT_SYMBOL_GPL(bcm_phy_enable_jumbo);
634 static int __bcm_phy_enable_rdb_access(struct phy_device *phydev)
636 return __bcm_phy_write_exp(phydev, BCM54XX_EXP_REG7E, 0);
639 static int __bcm_phy_enable_legacy_access(struct phy_device *phydev)
641 return __bcm_phy_write_rdb(phydev, BCM54XX_RDB_REG0087,
642 BCM54XX_ACCESS_MODE_LEGACY_EN);
645 static int _bcm_phy_cable_test_start(struct phy_device *phydev, bool is_rdb)
650 /* Auto-negotiation must be enabled for cable diagnostics to work, but
651 * don't advertise any capabilities.
653 phy_write(phydev, MII_BMCR, BMCR_ANENABLE);
654 phy_write(phydev, MII_ADVERTISE, ADVERTISE_CSMA);
655 phy_write(phydev, MII_CTRL1000, 0);
657 phy_lock_mdio_bus(phydev);
659 ret = __bcm_phy_enable_legacy_access(phydev);
664 mask = BCM54XX_ECD_CTRL_CROSS_SHORT_DIS | BCM54XX_ECD_CTRL_UNIT_MASK;
665 set = BCM54XX_ECD_CTRL_RUN | BCM54XX_ECD_CTRL_BREAK_LINK |
666 FIELD_PREP(BCM54XX_ECD_CTRL_UNIT_MASK,
667 BCM54XX_ECD_CTRL_UNIT_CM);
669 ret = __bcm_phy_modify_exp(phydev, BCM54XX_EXP_ECD_CTRL, mask, set);
672 /* re-enable the RDB access even if there was an error */
674 ret = __bcm_phy_enable_rdb_access(phydev) ? : ret;
676 phy_unlock_mdio_bus(phydev);
681 static int bcm_phy_cable_test_report_trans(int result)
684 case BCM54XX_ECD_FAULT_TYPE_OK:
685 return ETHTOOL_A_CABLE_RESULT_CODE_OK;
686 case BCM54XX_ECD_FAULT_TYPE_OPEN:
687 return ETHTOOL_A_CABLE_RESULT_CODE_OPEN;
688 case BCM54XX_ECD_FAULT_TYPE_SAME_SHORT:
689 return ETHTOOL_A_CABLE_RESULT_CODE_SAME_SHORT;
690 case BCM54XX_ECD_FAULT_TYPE_CROSS_SHORT:
691 return ETHTOOL_A_CABLE_RESULT_CODE_CROSS_SHORT;
692 case BCM54XX_ECD_FAULT_TYPE_INVALID:
693 case BCM54XX_ECD_FAULT_TYPE_BUSY:
695 return ETHTOOL_A_CABLE_RESULT_CODE_UNSPEC;
699 static bool bcm_phy_distance_valid(int result)
702 case BCM54XX_ECD_FAULT_TYPE_OPEN:
703 case BCM54XX_ECD_FAULT_TYPE_SAME_SHORT:
704 case BCM54XX_ECD_FAULT_TYPE_CROSS_SHORT:
710 static int bcm_phy_report_length(struct phy_device *phydev, int pair)
714 val = __bcm_phy_read_exp(phydev,
715 BCM54XX_EXP_ECD_PAIR_A_LENGTH_RESULTS + pair);
719 if (val == BCM54XX_ECD_LENGTH_RESULTS_INVALID)
722 ethnl_cable_test_fault_length(phydev, pair, val);
727 static int _bcm_phy_cable_test_get_status(struct phy_device *phydev,
728 bool *finished, bool is_rdb)
730 int pair_a, pair_b, pair_c, pair_d, ret;
734 phy_lock_mdio_bus(phydev);
737 ret = __bcm_phy_enable_legacy_access(phydev);
742 ret = __bcm_phy_read_exp(phydev, BCM54XX_EXP_ECD_CTRL);
746 if (ret & BCM54XX_ECD_CTRL_IN_PROGRESS) {
751 ret = __bcm_phy_read_exp(phydev, BCM54XX_EXP_ECD_FAULT_TYPE);
755 pair_a = FIELD_GET(BCM54XX_ECD_FAULT_TYPE_PAIR_A_MASK, ret);
756 pair_b = FIELD_GET(BCM54XX_ECD_FAULT_TYPE_PAIR_B_MASK, ret);
757 pair_c = FIELD_GET(BCM54XX_ECD_FAULT_TYPE_PAIR_C_MASK, ret);
758 pair_d = FIELD_GET(BCM54XX_ECD_FAULT_TYPE_PAIR_D_MASK, ret);
760 ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
761 bcm_phy_cable_test_report_trans(pair_a));
762 ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_B,
763 bcm_phy_cable_test_report_trans(pair_b));
764 ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_C,
765 bcm_phy_cable_test_report_trans(pair_c));
766 ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_D,
767 bcm_phy_cable_test_report_trans(pair_d));
769 if (bcm_phy_distance_valid(pair_a))
770 bcm_phy_report_length(phydev, 0);
771 if (bcm_phy_distance_valid(pair_b))
772 bcm_phy_report_length(phydev, 1);
773 if (bcm_phy_distance_valid(pair_c))
774 bcm_phy_report_length(phydev, 2);
775 if (bcm_phy_distance_valid(pair_d))
776 bcm_phy_report_length(phydev, 3);
781 /* re-enable the RDB access even if there was an error */
783 ret = __bcm_phy_enable_rdb_access(phydev) ? : ret;
785 phy_unlock_mdio_bus(phydev);
790 int bcm_phy_cable_test_start(struct phy_device *phydev)
792 return _bcm_phy_cable_test_start(phydev, false);
794 EXPORT_SYMBOL_GPL(bcm_phy_cable_test_start);
796 int bcm_phy_cable_test_get_status(struct phy_device *phydev, bool *finished)
798 return _bcm_phy_cable_test_get_status(phydev, finished, false);
800 EXPORT_SYMBOL_GPL(bcm_phy_cable_test_get_status);
802 /* We assume that all PHYs which support RDB access can be switched to legacy
803 * mode. If, in the future, this is not true anymore, we have to re-implement
804 * this with RDB access.
806 int bcm_phy_cable_test_start_rdb(struct phy_device *phydev)
808 return _bcm_phy_cable_test_start(phydev, true);
810 EXPORT_SYMBOL_GPL(bcm_phy_cable_test_start_rdb);
812 int bcm_phy_cable_test_get_status_rdb(struct phy_device *phydev,
815 return _bcm_phy_cable_test_get_status(phydev, finished, true);
817 EXPORT_SYMBOL_GPL(bcm_phy_cable_test_get_status_rdb);
819 MODULE_DESCRIPTION("Broadcom PHY Library");
820 MODULE_LICENSE("GPL v2");
821 MODULE_AUTHOR("Broadcom Corporation");