drivers/media/i2c/ov7251.c

   1 // SPDX-License-Identifier: GPL-2.0
   2 /*
   3  * Driver for the OV7251 camera sensor.
   4  *
   5  * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
   6  * Copyright (c) 2017-2018, Linaro Ltd.
   7  */
   8
   9 #include <linux/bitops.h>
  10 #include <linux/clk.h>
  11 #include <linux/delay.h>
  12 #include <linux/device.h>
  13 #include <linux/gpio/consumer.h>
  14 #include <linux/i2c.h>
  15 #include <linux/init.h>
  16 #include <linux/module.h>
  17 #include <linux/mod_devicetable.h>
  18 #include <linux/pm_runtime.h>
  19 #include <linux/regulator/consumer.h>
  20 #include <linux/slab.h>
  21 #include <linux/types.h>
  22 #include <media/v4l2-ctrls.h>
  23 #include <media/v4l2-fwnode.h>
  24 #include <media/v4l2-subdev.h>
  25
  26 #define OV7251_SC_MODE_SELECT           0x0100
  27 #define OV7251_SC_MODE_SELECT_SW_STANDBY        0x0
  28 #define OV7251_SC_MODE_SELECT_STREAMING         0x1
  29
  30 #define OV7251_CHIP_ID_HIGH             0x300a
  31 #define OV7251_CHIP_ID_HIGH_BYTE        0x77
  32 #define OV7251_CHIP_ID_LOW              0x300b
  33 #define OV7251_CHIP_ID_LOW_BYTE         0x50
  34 #define OV7251_SC_GP_IO_IN1             0x3029
  35 #define OV7251_AEC_EXPO_0               0x3500
  36 #define OV7251_AEC_EXPO_1               0x3501
  37 #define OV7251_AEC_EXPO_2               0x3502
  38 #define OV7251_AEC_AGC_ADJ_0            0x350a
  39 #define OV7251_AEC_AGC_ADJ_1            0x350b
  40 #define OV7251_TIMING_FORMAT1           0x3820
  41 #define OV7251_TIMING_FORMAT1_VFLIP     BIT(2)
  42 #define OV7251_TIMING_FORMAT2           0x3821
  43 #define OV7251_TIMING_FORMAT2_MIRROR    BIT(2)
  44 #define OV7251_PRE_ISP_00               0x5e00
  45 #define OV7251_PRE_ISP_00_TEST_PATTERN  BIT(7)
  46 #define OV7251_PLL1_PRE_DIV_REG         0x30b4
  47 #define OV7251_PLL1_MULT_REG            0x30b3
  48 #define OV7251_PLL1_DIVIDER_REG         0x30b1
  49 #define OV7251_PLL1_PIX_DIV_REG         0x30b0
  50 #define OV7251_PLL1_MIPI_DIV_REG        0x30b5
  51 #define OV7251_PLL2_PRE_DIV_REG         0x3098
  52 #define OV7251_PLL2_MULT_REG            0x3099
  53 #define OV7251_PLL2_DIVIDER_REG         0x309d
  54 #define OV7251_PLL2_SYS_DIV_REG         0x309a
  55 #define OV7251_PLL2_ADC_DIV_REG         0x309b
  56
  57 #define OV7251_NATIVE_WIDTH             656
  58 #define OV7251_NATIVE_HEIGHT            496
  59 #define OV7251_ACTIVE_START_LEFT        4
  60 #define OV7251_ACTIVE_START_TOP         4
  61 #define OV7251_ACTIVE_WIDTH             648
  62 #define OV7251_ACTIVE_HEIGHT            488
  63
  64 #define OV7251_FIXED_PPL                928
  65 #define OV7251_TIMING_VTS_REG           0x380e
  66 #define OV7251_TIMING_MIN_VTS           1
  67 #define OV7251_TIMING_MAX_VTS           0xffff
  68 #define OV7251_INTEGRATION_MARGIN       20
  69
  70 struct reg_value {
  71         u16 reg;
  72         u8 val;
  73 };
  74
  75 struct ov7251_mode_info {
  76         u32 width;
  77         u32 height;
  78         u32 vts;
  79         const struct reg_value *data;
  80         u32 data_size;
  81         u32 pixel_clock;
  82         u32 link_freq;
  83         u16 exposure_max;
  84         u16 exposure_def;
  85         struct v4l2_fract timeperframe;
  86 };
  87
  88 struct ov7251_pll1_cfg {
  89         unsigned int pre_div;
  90         unsigned int mult;
  91         unsigned int div;
  92         unsigned int pix_div;
  93         unsigned int mipi_div;
  94 };
  95
  96 struct ov7251_pll2_cfg {
  97         unsigned int pre_div;
  98         unsigned int mult;
  99         unsigned int div;
 100         unsigned int sys_div;
 101         unsigned int adc_div;
 102 };
 103
 104 /*
 105  * Rubbish ordering, but only PLL1 needs to have a separate configuration per
 106  * link frequency and the array member needs to be last.
 107  */
 108 struct ov7251_pll_cfgs {
 109         const struct ov7251_pll2_cfg *pll2;
 110         const struct ov7251_pll1_cfg *pll1[];
 111 };
 112
 113 enum xclk_rate {
 114         OV7251_19_2_MHZ,
 115         OV7251_24_MHZ,
 116         OV7251_NUM_SUPPORTED_RATES
 117 };
 118
 119 enum supported_link_freqs {
 120         OV7251_LINK_FREQ_240_MHZ,
 121         OV7251_LINK_FREQ_319_2_MHZ,
 122         OV7251_NUM_SUPPORTED_LINK_FREQS
 123 };
 124
 125 struct ov7251 {
 126         struct i2c_client *i2c_client;
 127         struct device *dev;
 128         struct v4l2_subdev sd;
 129         struct media_pad pad;
 130         struct v4l2_fwnode_endpoint ep;
 131         struct v4l2_mbus_framefmt fmt;
 132         struct v4l2_rect crop;
 133         struct clk *xclk;
 134         u32 xclk_freq;
 135
 136         struct regulator *io_regulator;
 137         struct regulator *core_regulator;
 138         struct regulator *analog_regulator;
 139
 140         const struct ov7251_pll_cfgs *pll_cfgs;
 141         enum supported_link_freqs link_freq_idx;
 142         const struct ov7251_mode_info *current_mode;
 143
 144         struct v4l2_ctrl_handler ctrls;
 145         struct v4l2_ctrl *pixel_clock;
 146         struct v4l2_ctrl *link_freq;
 147         struct v4l2_ctrl *exposure;
 148         struct v4l2_ctrl *gain;
 149         struct v4l2_ctrl *hblank;
 150         struct v4l2_ctrl *vblank;
 151
 152         /* Cached register values */
 153         u8 aec_pk_manual;
 154         u8 pre_isp_00;
 155         u8 timing_format1;
 156         u8 timing_format2;
 157
 158         struct mutex lock; /* lock to protect power state, ctrls and mode */
 159         bool power_on;
 160
 161         struct gpio_desc *enable_gpio;
 162 };
 163
 164 static inline struct ov7251 *to_ov7251(struct v4l2_subdev *sd)
 165 {
 166         return container_of(sd, struct ov7251, sd);
 167 }
 168
 169 static const struct ov7251_pll1_cfg ov7251_pll1_cfg_19_2_mhz_240_mhz = {
 170         .pre_div = 0x03,
 171         .mult = 0x4b,
 172         .div = 0x01,
 173         .pix_div = 0x0a,
 174         .mipi_div = 0x05,
 175 };
 176
 177 static const struct ov7251_pll1_cfg ov7251_pll1_cfg_19_2_mhz_319_2_mhz = {
 178         .pre_div = 0x01,
 179         .mult = 0x85,
 180         .div = 0x04,
 181         .pix_div = 0x0a,
 182         .mipi_div = 0x05,
 183 };
 184
 185 static const struct ov7251_pll1_cfg ov7251_pll1_cfg_24_mhz_240_mhz = {
 186         .pre_div = 0x03,
 187         .mult = 0x64,
 188         .div = 0x01,
 189         .pix_div = 0x0a,
 190         .mipi_div = 0x05,
 191 };
 192
 193 static const struct ov7251_pll1_cfg ov7251_pll1_cfg_24_mhz_319_2_mhz = {
 194         .pre_div = 0x05,
 195         .mult = 0x85,
 196         .div = 0x02,
 197         .pix_div = 0x0a,
 198         .mipi_div = 0x05,
 199 };
 200
 201 static const struct ov7251_pll2_cfg ov7251_pll2_cfg_19_2_mhz = {
 202         .pre_div = 0x04,
 203         .mult = 0x32,
 204         .div = 0x00,
 205         .sys_div = 0x05,
 206         .adc_div = 0x04,
 207 };
 208
 209 static const struct ov7251_pll2_cfg ov7251_pll2_cfg_24_mhz = {
 210         .pre_div = 0x04,
 211         .mult = 0x28,
 212         .div = 0x00,
 213         .sys_div = 0x05,
 214         .adc_div = 0x04,
 215 };
 216
 217 static const struct ov7251_pll_cfgs ov7251_pll_cfgs_19_2_mhz = {
 218         .pll2 = &ov7251_pll2_cfg_19_2_mhz,
 219         .pll1 = {
 220                 [OV7251_LINK_FREQ_240_MHZ] = &ov7251_pll1_cfg_19_2_mhz_240_mhz,
 221                 [OV7251_LINK_FREQ_319_2_MHZ] = &ov7251_pll1_cfg_19_2_mhz_319_2_mhz,
 222         },
 223 };
 224
 225 static const struct ov7251_pll_cfgs ov7251_pll_cfgs_24_mhz = {
 226         .pll2 = &ov7251_pll2_cfg_24_mhz,
 227         .pll1 = {
 228                 [OV7251_LINK_FREQ_240_MHZ] = &ov7251_pll1_cfg_24_mhz_240_mhz,
 229                 [OV7251_LINK_FREQ_319_2_MHZ] = &ov7251_pll1_cfg_24_mhz_319_2_mhz,
 230         },
 231 };
 232
 233 static const struct ov7251_pll_cfgs *ov7251_pll_cfgs[] = {
 234         [OV7251_19_2_MHZ] = &ov7251_pll_cfgs_19_2_mhz,
 235         [OV7251_24_MHZ] = &ov7251_pll_cfgs_24_mhz,
 236 };
 237
 238 static const struct reg_value ov7251_global_init_setting[] = {
 239         { 0x0103, 0x01 },
 240         { 0x303b, 0x02 },
 241 };
 242
 243 static const struct reg_value ov7251_setting_vga_30fps[] = {
 244         { 0x3005, 0x00 },
 245         { 0x3012, 0xc0 },
 246         { 0x3013, 0xd2 },
 247         { 0x3014, 0x04 },
 248         { 0x3016, 0xf0 },
 249         { 0x3017, 0xf0 },
 250         { 0x3018, 0xf0 },
 251         { 0x301a, 0xf0 },
 252         { 0x301b, 0xf0 },
 253         { 0x301c, 0xf0 },
 254         { 0x3023, 0x05 },
 255         { 0x3037, 0xf0 },
 256         { 0x3106, 0xda },
 257         { 0x3503, 0x07 },
 258         { 0x3509, 0x10 },
 259         { 0x3600, 0x1c },
 260         { 0x3602, 0x62 },
 261         { 0x3620, 0xb7 },
 262         { 0x3622, 0x04 },
 263         { 0x3626, 0x21 },
 264         { 0x3627, 0x30 },
 265         { 0x3630, 0x44 },
 266         { 0x3631, 0x35 },
 267         { 0x3634, 0x60 },
 268         { 0x3636, 0x00 },
 269         { 0x3662, 0x01 },
 270         { 0x3663, 0x70 },
 271         { 0x3664, 0x50 },
 272         { 0x3666, 0x0a },
 273         { 0x3669, 0x1a },
 274         { 0x366a, 0x00 },
 275         { 0x366b, 0x50 },
 276         { 0x3673, 0x01 },
 277         { 0x3674, 0xff },
 278         { 0x3675, 0x03 },
 279         { 0x3705, 0xc1 },
 280         { 0x3709, 0x40 },
 281         { 0x373c, 0x08 },
 282         { 0x3742, 0x00 },
 283         { 0x3757, 0xb3 },
 284         { 0x3788, 0x00 },
 285         { 0x37a8, 0x01 },
 286         { 0x37a9, 0xc0 },
 287         { 0x3800, 0x00 },
 288         { 0x3801, 0x04 },
 289         { 0x3802, 0x00 },
 290         { 0x3803, 0x04 },
 291         { 0x3804, 0x02 },
 292         { 0x3805, 0x8b },
 293         { 0x3806, 0x01 },
 294         { 0x3807, 0xeb },
 295         { 0x3808, 0x02 }, /* width high */
 296         { 0x3809, 0x80 }, /* width low */
 297         { 0x380a, 0x01 }, /* height high */
 298         { 0x380b, 0xe0 }, /* height low */
 299         { 0x380c, 0x03 }, /* total horiz timing high */
 300         { 0x380d, 0xa0 }, /* total horiz timing low */
 301         { 0x380e, 0x06 }, /* total vertical timing high */
 302         { 0x380f, 0xbc }, /* total vertical timing low */
 303         { 0x3810, 0x00 },
 304         { 0x3811, 0x04 },
 305         { 0x3812, 0x00 },
 306         { 0x3813, 0x05 },
 307         { 0x3814, 0x11 },
 308         { 0x3815, 0x11 },
 309         { 0x3820, 0x40 },
 310         { 0x3821, 0x00 },
 311         { 0x382f, 0x0e },
 312         { 0x3832, 0x00 },
 313         { 0x3833, 0x05 },
 314         { 0x3834, 0x00 },
 315         { 0x3835, 0x0c },
 316         { 0x3837, 0x00 },
 317         { 0x3b80, 0x00 },
 318         { 0x3b81, 0xa5 },
 319         { 0x3b82, 0x10 },
 320         { 0x3b83, 0x00 },
 321         { 0x3b84, 0x08 },
 322         { 0x3b85, 0x00 },
 323         { 0x3b86, 0x01 },
 324         { 0x3b87, 0x00 },
 325         { 0x3b88, 0x00 },
 326         { 0x3b89, 0x00 },
 327         { 0x3b8a, 0x00 },
 328         { 0x3b8b, 0x05 },
 329         { 0x3b8c, 0x00 },
 330         { 0x3b8d, 0x00 },
 331         { 0x3b8e, 0x00 },
 332         { 0x3b8f, 0x1a },
 333         { 0x3b94, 0x05 },
 334         { 0x3b95, 0xf2 },
 335         { 0x3b96, 0x40 },
 336         { 0x3c00, 0x89 },
 337         { 0x3c01, 0x63 },
 338         { 0x3c02, 0x01 },
 339         { 0x3c03, 0x00 },
 340         { 0x3c04, 0x00 },
 341         { 0x3c05, 0x03 },
 342         { 0x3c06, 0x00 },
 343         { 0x3c07, 0x06 },
 344         { 0x3c0c, 0x01 },
 345         { 0x3c0d, 0xd0 },
 346         { 0x3c0e, 0x02 },
 347         { 0x3c0f, 0x0a },
 348         { 0x4001, 0x42 },
 349         { 0x4004, 0x04 },
 350         { 0x4005, 0x00 },
 351         { 0x404e, 0x01 },
 352         { 0x4300, 0xff },
 353         { 0x4301, 0x00 },
 354         { 0x4315, 0x00 },
 355         { 0x4501, 0x48 },
 356         { 0x4600, 0x00 },
 357         { 0x4601, 0x4e },
 358         { 0x4801, 0x0f },
 359         { 0x4806, 0x0f },
 360         { 0x4819, 0xaa },
 361         { 0x4823, 0x3e },
 362         { 0x4837, 0x19 },
 363         { 0x4a0d, 0x00 },
 364         { 0x4a47, 0x7f },
 365         { 0x4a49, 0xf0 },
 366         { 0x4a4b, 0x30 },
 367         { 0x5000, 0x85 },
 368         { 0x5001, 0x80 },
 369 };
 370
 371 static const struct reg_value ov7251_setting_vga_60fps[] = {
 372         { 0x3005, 0x00 },
 373         { 0x3012, 0xc0 },
 374         { 0x3013, 0xd2 },
 375         { 0x3014, 0x04 },
 376         { 0x3016, 0x10 },
 377         { 0x3017, 0x00 },
 378         { 0x3018, 0x00 },
 379         { 0x301a, 0x00 },
 380         { 0x301b, 0x00 },
 381         { 0x301c, 0x00 },
 382         { 0x3023, 0x05 },
 383         { 0x3037, 0xf0 },
 384         { 0x3106, 0xda },
 385         { 0x3503, 0x07 },
 386         { 0x3509, 0x10 },
 387         { 0x3600, 0x1c },
 388         { 0x3602, 0x62 },
 389         { 0x3620, 0xb7 },
 390         { 0x3622, 0x04 },
 391         { 0x3626, 0x21 },
 392         { 0x3627, 0x30 },
 393         { 0x3630, 0x44 },
 394         { 0x3631, 0x35 },
 395         { 0x3634, 0x60 },
 396         { 0x3636, 0x00 },
 397         { 0x3662, 0x01 },
 398         { 0x3663, 0x70 },
 399         { 0x3664, 0x50 },
 400         { 0x3666, 0x0a },
 401         { 0x3669, 0x1a },
 402         { 0x366a, 0x00 },
 403         { 0x366b, 0x50 },
 404         { 0x3673, 0x01 },
 405         { 0x3674, 0xff },
 406         { 0x3675, 0x03 },
 407         { 0x3705, 0xc1 },
 408         { 0x3709, 0x40 },
 409         { 0x373c, 0x08 },
 410         { 0x3742, 0x00 },
 411         { 0x3757, 0xb3 },
 412         { 0x3788, 0x00 },
 413         { 0x37a8, 0x01 },
 414         { 0x37a9, 0xc0 },
 415         { 0x3800, 0x00 },
 416         { 0x3801, 0x04 },
 417         { 0x3802, 0x00 },
 418         { 0x3803, 0x04 },
 419         { 0x3804, 0x02 },
 420         { 0x3805, 0x8b },
 421         { 0x3806, 0x01 },
 422         { 0x3807, 0xeb },
 423         { 0x3808, 0x02 }, /* width high */
 424         { 0x3809, 0x80 }, /* width low */
 425         { 0x380a, 0x01 }, /* height high */
 426         { 0x380b, 0xe0 }, /* height low */
 427         { 0x380c, 0x03 }, /* total horiz timing high */
 428         { 0x380d, 0xa0 }, /* total horiz timing low */
 429         { 0x380e, 0x03 }, /* total vertical timing high */
 430         { 0x380f, 0x5c }, /* total vertical timing low */
 431         { 0x3810, 0x00 },
 432         { 0x3811, 0x04 },
 433         { 0x3812, 0x00 },
 434         { 0x3813, 0x05 },
 435         { 0x3814, 0x11 },
 436         { 0x3815, 0x11 },
 437         { 0x3820, 0x40 },
 438         { 0x3821, 0x00 },
 439         { 0x382f, 0x0e },
 440         { 0x3832, 0x00 },
 441         { 0x3833, 0x05 },
 442         { 0x3834, 0x00 },
 443         { 0x3835, 0x0c },
 444         { 0x3837, 0x00 },
 445         { 0x3b80, 0x00 },
 446         { 0x3b81, 0xa5 },
 447         { 0x3b82, 0x10 },
 448         { 0x3b83, 0x00 },
 449         { 0x3b84, 0x08 },
 450         { 0x3b85, 0x00 },
 451         { 0x3b86, 0x01 },
 452         { 0x3b87, 0x00 },
 453         { 0x3b88, 0x00 },
 454         { 0x3b89, 0x00 },
 455         { 0x3b8a, 0x00 },
 456         { 0x3b8b, 0x05 },
 457         { 0x3b8c, 0x00 },
 458         { 0x3b8d, 0x00 },
 459         { 0x3b8e, 0x00 },
 460         { 0x3b8f, 0x1a },
 461         { 0x3b94, 0x05 },
 462         { 0x3b95, 0xf2 },
 463         { 0x3b96, 0x40 },
 464         { 0x3c00, 0x89 },
 465         { 0x3c01, 0x63 },
 466         { 0x3c02, 0x01 },
 467         { 0x3c03, 0x00 },
 468         { 0x3c04, 0x00 },
 469         { 0x3c05, 0x03 },
 470         { 0x3c06, 0x00 },
 471         { 0x3c07, 0x06 },
 472         { 0x3c0c, 0x01 },
 473         { 0x3c0d, 0xd0 },
 474         { 0x3c0e, 0x02 },
 475         { 0x3c0f, 0x0a },
 476         { 0x4001, 0x42 },
 477         { 0x4004, 0x04 },
 478         { 0x4005, 0x00 },
 479         { 0x404e, 0x01 },
 480         { 0x4300, 0xff },
 481         { 0x4301, 0x00 },
 482         { 0x4315, 0x00 },
 483         { 0x4501, 0x48 },
 484         { 0x4600, 0x00 },
 485         { 0x4601, 0x4e },
 486         { 0x4801, 0x0f },
 487         { 0x4806, 0x0f },
 488         { 0x4819, 0xaa },
 489         { 0x4823, 0x3e },
 490         { 0x4837, 0x19 },
 491         { 0x4a0d, 0x00 },
 492         { 0x4a47, 0x7f },
 493         { 0x4a49, 0xf0 },
 494         { 0x4a4b, 0x30 },
 495         { 0x5000, 0x85 },
 496         { 0x5001, 0x80 },
 497 };
 498
 499 static const struct reg_value ov7251_setting_vga_90fps[] = {
 500         { 0x3005, 0x00 },
 501         { 0x3012, 0xc0 },
 502         { 0x3013, 0xd2 },
 503         { 0x3014, 0x04 },
 504         { 0x3016, 0x10 },
 505         { 0x3017, 0x00 },
 506         { 0x3018, 0x00 },
 507         { 0x301a, 0x00 },
 508         { 0x301b, 0x00 },
 509         { 0x301c, 0x00 },
 510         { 0x3023, 0x05 },
 511         { 0x3037, 0xf0 },
 512         { 0x3106, 0xda },
 513         { 0x3503, 0x07 },
 514         { 0x3509, 0x10 },
 515         { 0x3600, 0x1c },
 516         { 0x3602, 0x62 },
 517         { 0x3620, 0xb7 },
 518         { 0x3622, 0x04 },
 519         { 0x3626, 0x21 },
 520         { 0x3627, 0x30 },
 521         { 0x3630, 0x44 },
 522         { 0x3631, 0x35 },
 523         { 0x3634, 0x60 },
 524         { 0x3636, 0x00 },
 525         { 0x3662, 0x01 },
 526         { 0x3663, 0x70 },
 527         { 0x3664, 0x50 },
 528         { 0x3666, 0x0a },
 529         { 0x3669, 0x1a },
 530         { 0x366a, 0x00 },
 531         { 0x366b, 0x50 },
 532         { 0x3673, 0x01 },
 533         { 0x3674, 0xff },
 534         { 0x3675, 0x03 },
 535         { 0x3705, 0xc1 },
 536         { 0x3709, 0x40 },
 537         { 0x373c, 0x08 },
 538         { 0x3742, 0x00 },
 539         { 0x3757, 0xb3 },
 540         { 0x3788, 0x00 },
 541         { 0x37a8, 0x01 },
 542         { 0x37a9, 0xc0 },
 543         { 0x3800, 0x00 },
 544         { 0x3801, 0x04 },
 545         { 0x3802, 0x00 },
 546         { 0x3803, 0x04 },
 547         { 0x3804, 0x02 },
 548         { 0x3805, 0x8b },
 549         { 0x3806, 0x01 },
 550         { 0x3807, 0xeb },
 551         { 0x3808, 0x02 }, /* width high */
 552         { 0x3809, 0x80 }, /* width low */
 553         { 0x380a, 0x01 }, /* height high */
 554         { 0x380b, 0xe0 }, /* height low */
 555         { 0x380c, 0x03 }, /* total horiz timing high */
 556         { 0x380d, 0xa0 }, /* total horiz timing low */
 557         { 0x380e, 0x02 }, /* total vertical timing high */
 558         { 0x380f, 0x3c }, /* total vertical timing low */
 559         { 0x3810, 0x00 },
 560         { 0x3811, 0x04 },
 561         { 0x3812, 0x00 },
 562         { 0x3813, 0x05 },
 563         { 0x3814, 0x11 },
 564         { 0x3815, 0x11 },
 565         { 0x3820, 0x40 },
 566         { 0x3821, 0x00 },
 567         { 0x382f, 0x0e },
 568         { 0x3832, 0x00 },
 569         { 0x3833, 0x05 },
 570         { 0x3834, 0x00 },
 571         { 0x3835, 0x0c },
 572         { 0x3837, 0x00 },
 573         { 0x3b80, 0x00 },
 574         { 0x3b81, 0xa5 },
 575         { 0x3b82, 0x10 },
 576         { 0x3b83, 0x00 },
 577         { 0x3b84, 0x08 },
 578         { 0x3b85, 0x00 },
 579         { 0x3b86, 0x01 },
 580         { 0x3b87, 0x00 },
 581         { 0x3b88, 0x00 },
 582         { 0x3b89, 0x00 },
 583         { 0x3b8a, 0x00 },
 584         { 0x3b8b, 0x05 },
 585         { 0x3b8c, 0x00 },
 586         { 0x3b8d, 0x00 },
 587         { 0x3b8e, 0x00 },
 588         { 0x3b8f, 0x1a },
 589         { 0x3b94, 0x05 },
 590         { 0x3b95, 0xf2 },
 591         { 0x3b96, 0x40 },
 592         { 0x3c00, 0x89 },
 593         { 0x3c01, 0x63 },
 594         { 0x3c02, 0x01 },
 595         { 0x3c03, 0x00 },
 596         { 0x3c04, 0x00 },
 597         { 0x3c05, 0x03 },
 598         { 0x3c06, 0x00 },
 599         { 0x3c07, 0x06 },
 600         { 0x3c0c, 0x01 },
 601         { 0x3c0d, 0xd0 },
 602         { 0x3c0e, 0x02 },
 603         { 0x3c0f, 0x0a },
 604         { 0x4001, 0x42 },
 605         { 0x4004, 0x04 },
 606         { 0x4005, 0x00 },
 607         { 0x404e, 0x01 },
 608         { 0x4300, 0xff },
 609         { 0x4301, 0x00 },
 610         { 0x4315, 0x00 },
 611         { 0x4501, 0x48 },
 612         { 0x4600, 0x00 },
 613         { 0x4601, 0x4e },
 614         { 0x4801, 0x0f },
 615         { 0x4806, 0x0f },
 616         { 0x4819, 0xaa },
 617         { 0x4823, 0x3e },
 618         { 0x4837, 0x19 },
 619         { 0x4a0d, 0x00 },
 620         { 0x4a47, 0x7f },
 621         { 0x4a49, 0xf0 },
 622         { 0x4a4b, 0x30 },
 623         { 0x5000, 0x85 },
 624         { 0x5001, 0x80 },
 625 };
 626
 627 static const unsigned long supported_xclk_rates[] = {
 628         [OV7251_19_2_MHZ] = 19200000,
 629         [OV7251_24_MHZ] = 24000000,
 630 };
 631
 632 static const s64 link_freq[] = {
 633         [OV7251_LINK_FREQ_240_MHZ] = 240000000,
 634         [OV7251_LINK_FREQ_319_2_MHZ] = 319200000,
 635 };
 636
 637 static const s64 pixel_rates[] = {
 638         [OV7251_LINK_FREQ_240_MHZ] = 48000000,
 639         [OV7251_LINK_FREQ_319_2_MHZ] = 63840000,
 640 };
 641
 642 static const struct ov7251_mode_info ov7251_mode_info_data[] = {
 643         {
 644                 .width = 640,
 645                 .height = 480,
 646                 .vts = 1724,
 647                 .data = ov7251_setting_vga_30fps,
 648                 .data_size = ARRAY_SIZE(ov7251_setting_vga_30fps),
 649                 .exposure_max = 1704,
 650                 .exposure_def = 504,
 651                 .timeperframe = {
 652                         .numerator = 100,
 653                         .denominator = 3000
 654                 }
 655         },
 656         {
 657                 .width = 640,
 658                 .height = 480,
 659                 .vts = 860,
 660                 .data = ov7251_setting_vga_60fps,
 661                 .data_size = ARRAY_SIZE(ov7251_setting_vga_60fps),
 662                 .exposure_max = 840,
 663                 .exposure_def = 504,
 664                 .timeperframe = {
 665                         .numerator = 100,
 666                         .denominator = 6014
 667                 }
 668         },
 669         {
 670                 .width = 640,
 671                 .height = 480,
 672                 .vts = 572,
 673                 .data = ov7251_setting_vga_90fps,
 674                 .data_size = ARRAY_SIZE(ov7251_setting_vga_90fps),
 675                 .exposure_max = 552,
 676                 .exposure_def = 504,
 677                 .timeperframe = {
 678                         .numerator = 100,
 679                         .denominator = 9043
 680                 }
 681         },
 682 };
 683
 684 static int ov7251_regulators_enable(struct ov7251 *ov7251)
 685 {
 686         int ret;
 687
 688         /* OV7251 power up sequence requires core regulator
 689          * to be enabled not earlier than io regulator
 690          */
 691
 692         ret = regulator_enable(ov7251->io_regulator);
 693         if (ret < 0) {
 694                 dev_err(ov7251->dev, "set io voltage failed\n");
 695                 return ret;
 696         }
 697
 698         ret = regulator_enable(ov7251->analog_regulator);
 699         if (ret) {
 700                 dev_err(ov7251->dev, "set analog voltage failed\n");
 701                 goto err_disable_io;
 702         }
 703
 704         ret = regulator_enable(ov7251->core_regulator);
 705         if (ret) {
 706                 dev_err(ov7251->dev, "set core voltage failed\n");
 707                 goto err_disable_analog;
 708         }
 709
 710         return 0;
 711
 712 err_disable_analog:
 713         regulator_disable(ov7251->analog_regulator);
 714
 715 err_disable_io:
 716         regulator_disable(ov7251->io_regulator);
 717
 718         return ret;
 719 }
 720
 721 static void ov7251_regulators_disable(struct ov7251 *ov7251)
 722 {
 723         int ret;
 724
 725         ret = regulator_disable(ov7251->core_regulator);
 726         if (ret < 0)
 727                 dev_err(ov7251->dev, "core regulator disable failed\n");
 728
 729         ret = regulator_disable(ov7251->analog_regulator);
 730         if (ret < 0)
 731                 dev_err(ov7251->dev, "analog regulator disable failed\n");
 732
 733         ret = regulator_disable(ov7251->io_regulator);
 734         if (ret < 0)
 735                 dev_err(ov7251->dev, "io regulator disable failed\n");
 736 }
 737
 738 static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val)
 739 {
 740         u8 regbuf[3];
 741         int ret;
 742
 743         regbuf[0] = reg >> 8;
 744         regbuf[1] = reg & 0xff;
 745         regbuf[2] = val;
 746
 747         ret = i2c_master_send(ov7251->i2c_client, regbuf, 3);
 748         if (ret < 0) {
 749                 dev_err(ov7251->dev, "%s: write reg error %d: reg=%x, val=%x\n",
 750                         __func__, ret, reg, val);
 751                 return ret;
 752         }
 753
 754         return 0;
 755 }
 756
 757 static int ov7251_write_seq_regs(struct ov7251 *ov7251, u16 reg, u8 *val,
 758                                  u8 num)
 759 {
 760         u8 regbuf[5];
 761         u8 nregbuf = sizeof(reg) + num * sizeof(*val);
 762         int ret = 0;
 763
 764         if (nregbuf > sizeof(regbuf))
 765                 return -EINVAL;
 766
 767         regbuf[0] = reg >> 8;
 768         regbuf[1] = reg & 0xff;
 769
 770         memcpy(regbuf + 2, val, num);
 771
 772         ret = i2c_master_send(ov7251->i2c_client, regbuf, nregbuf);
 773         if (ret < 0) {
 774                 dev_err(ov7251->dev,
 775                         "%s: write seq regs error %d: first reg=%x\n",
 776                         __func__, ret, reg);
 777                 return ret;
 778         }
 779
 780         return 0;
 781 }
 782
 783 static int ov7251_read_reg(struct ov7251 *ov7251, u16 reg, u8 *val)
 784 {
 785         u8 regbuf[2];
 786         int ret;
 787
 788         regbuf[0] = reg >> 8;
 789         regbuf[1] = reg & 0xff;
 790
 791         ret = i2c_master_send(ov7251->i2c_client, regbuf, 2);
 792         if (ret < 0) {
 793                 dev_err(ov7251->dev, "%s: write reg error %d: reg=%x\n",
 794                         __func__, ret, reg);
 795                 return ret;
 796         }
 797
 798         ret = i2c_master_recv(ov7251->i2c_client, val, 1);
 799         if (ret < 0) {
 800                 dev_err(ov7251->dev, "%s: read reg error %d: reg=%x\n",
 801                         __func__, ret, reg);
 802                 return ret;
 803         }
 804
 805         return 0;
 806 }
 807
 808 static int ov7251_pll_configure(struct ov7251 *ov7251)
 809 {
 810         const struct ov7251_pll_cfgs *configs;
 811         int ret;
 812
 813         configs = ov7251->pll_cfgs;
 814
 815         ret = ov7251_write_reg(ov7251, OV7251_PLL1_PRE_DIV_REG,
 816                                configs->pll1[ov7251->link_freq_idx]->pre_div);
 817         if (ret < 0)
 818                 return ret;
 819
 820         ret = ov7251_write_reg(ov7251, OV7251_PLL1_MULT_REG,
 821                                configs->pll1[ov7251->link_freq_idx]->mult);
 822         if (ret < 0)
 823                 return ret;
 824         ret = ov7251_write_reg(ov7251, OV7251_PLL1_DIVIDER_REG,
 825                                configs->pll1[ov7251->link_freq_idx]->div);
 826         if (ret < 0)
 827                 return ret;
 828
 829         ret = ov7251_write_reg(ov7251, OV7251_PLL1_PIX_DIV_REG,
 830                                configs->pll1[ov7251->link_freq_idx]->pix_div);
 831         if (ret < 0)
 832                 return ret;
 833
 834         ret = ov7251_write_reg(ov7251, OV7251_PLL1_MIPI_DIV_REG,
 835                                configs->pll1[ov7251->link_freq_idx]->mipi_div);
 836         if (ret < 0)
 837                 return ret;
 838
 839         ret = ov7251_write_reg(ov7251, OV7251_PLL2_PRE_DIV_REG,
 840                                configs->pll2->pre_div);
 841         if (ret < 0)
 842                 return ret;
 843
 844         ret = ov7251_write_reg(ov7251, OV7251_PLL2_MULT_REG,
 845                                configs->pll2->mult);
 846         if (ret < 0)
 847                 return ret;
 848
 849         ret = ov7251_write_reg(ov7251, OV7251_PLL2_DIVIDER_REG,
 850                                configs->pll2->div);
 851         if (ret < 0)
 852                 return ret;
 853
 854         ret = ov7251_write_reg(ov7251, OV7251_PLL2_SYS_DIV_REG,
 855                                configs->pll2->sys_div);
 856         if (ret < 0)
 857                 return ret;
 858
 859         ret = ov7251_write_reg(ov7251, OV7251_PLL2_ADC_DIV_REG,
 860                                configs->pll2->adc_div);
 861
 862         return ret;
 863 }
 864
 865 static int ov7251_set_exposure(struct ov7251 *ov7251, s32 exposure)
 866 {
 867         u16 reg;
 868         u8 val[3];
 869
 870         reg = OV7251_AEC_EXPO_0;
 871         val[0] = (exposure & 0xf000) >> 12; /* goes to OV7251_AEC_EXPO_0 */
 872         val[1] = (exposure & 0x0ff0) >> 4;  /* goes to OV7251_AEC_EXPO_1 */
 873         val[2] = (exposure & 0x000f) << 4;  /* goes to OV7251_AEC_EXPO_2 */
 874
 875         return ov7251_write_seq_regs(ov7251, reg, val, 3);
 876 }
 877
 878 static int ov7251_set_gain(struct ov7251 *ov7251, s32 gain)
 879 {
 880         u16 reg;
 881         u8 val[2];
 882
 883         reg = OV7251_AEC_AGC_ADJ_0;
 884         val[0] = (gain & 0x0300) >> 8; /* goes to OV7251_AEC_AGC_ADJ_0 */
 885         val[1] = gain & 0xff;          /* goes to OV7251_AEC_AGC_ADJ_1 */
 886
 887         return ov7251_write_seq_regs(ov7251, reg, val, 2);
 888 }
 889
 890 static int ov7251_set_register_array(struct ov7251 *ov7251,
 891                                      const struct reg_value *settings,
 892                                      unsigned int num_settings)
 893 {
 894         unsigned int i;
 895         int ret;
 896
 897         for (i = 0; i < num_settings; ++i, ++settings) {
 898                 ret = ov7251_write_reg(ov7251, settings->reg, settings->val);
 899                 if (ret < 0)
 900                         return ret;
 901         }
 902
 903         return 0;
 904 }
 905
 906 static int ov7251_set_power_on(struct device *dev)
 907 {
 908         struct i2c_client *client = container_of(dev, struct i2c_client, dev);
 909         struct v4l2_subdev *sd = i2c_get_clientdata(client);
 910         struct ov7251 *ov7251 = to_ov7251(sd);
 911         int ret;
 912         u32 wait_us;
 913
 914         ret = ov7251_regulators_enable(ov7251);
 915         if (ret < 0)
 916                 return ret;
 917
 918         ret = clk_prepare_enable(ov7251->xclk);
 919         if (ret < 0) {
 920                 dev_err(ov7251->dev, "clk prepare enable failed\n");
 921                 ov7251_regulators_disable(ov7251);
 922                 return ret;
 923         }
 924
 925         gpiod_set_value_cansleep(ov7251->enable_gpio, 1);
 926
 927         /* wait at least 65536 external clock cycles */
 928         wait_us = DIV_ROUND_UP(65536 * 1000,
 929                                DIV_ROUND_UP(ov7251->xclk_freq, 1000));
 930         usleep_range(wait_us, wait_us + 1000);
 931
 932         ret = ov7251_set_register_array(ov7251,
 933                                         ov7251_global_init_setting,
 934                                         ARRAY_SIZE(ov7251_global_init_setting));
 935         if (ret < 0) {
 936                 dev_err(ov7251->dev, "error during global init\n");
 937                 gpiod_set_value_cansleep(ov7251->enable_gpio, 0);
 938                 clk_disable_unprepare(ov7251->xclk);
 939                 ov7251_regulators_disable(ov7251);
 940                 return ret;
 941         }
 942
 943         return ret;
 944 }
 945
 946 static int ov7251_set_power_off(struct device *dev)
 947 {
 948         struct i2c_client *client = container_of(dev, struct i2c_client, dev);
 949         struct v4l2_subdev *sd = i2c_get_clientdata(client);
 950         struct ov7251 *ov7251 = to_ov7251(sd);
 951
 952         clk_disable_unprepare(ov7251->xclk);
 953         gpiod_set_value_cansleep(ov7251->enable_gpio, 0);
 954         ov7251_regulators_disable(ov7251);
 955
 956         return 0;
 957 }
 958
 959 static int ov7251_set_hflip(struct ov7251 *ov7251, s32 value)
 960 {
 961         u8 val = ov7251->timing_format2;
 962         int ret;
 963
 964         if (value)
 965                 val |= OV7251_TIMING_FORMAT2_MIRROR;
 966         else
 967                 val &= ~OV7251_TIMING_FORMAT2_MIRROR;
 968
 969         ret = ov7251_write_reg(ov7251, OV7251_TIMING_FORMAT2, val);
 970         if (!ret)
 971                 ov7251->timing_format2 = val;
 972
 973         return ret;
 974 }
 975
 976 static int ov7251_set_vflip(struct ov7251 *ov7251, s32 value)
 977 {
 978         u8 val = ov7251->timing_format1;
 979         int ret;
 980
 981         if (value)
 982                 val |= OV7251_TIMING_FORMAT1_VFLIP;
 983         else
 984                 val &= ~OV7251_TIMING_FORMAT1_VFLIP;
 985
 986         ret = ov7251_write_reg(ov7251, OV7251_TIMING_FORMAT1, val);
 987         if (!ret)
 988                 ov7251->timing_format1 = val;
 989
 990         return ret;
 991 }
 992
 993 static int ov7251_set_test_pattern(struct ov7251 *ov7251, s32 value)
 994 {
 995         u8 val = ov7251->pre_isp_00;
 996         int ret;
 997
 998         if (value)
 999                 val |= OV7251_PRE_ISP_00_TEST_PATTERN;
1000         else
1001                 val &= ~OV7251_PRE_ISP_00_TEST_PATTERN;
1002
1003         ret = ov7251_write_reg(ov7251, OV7251_PRE_ISP_00, val);
1004         if (!ret)
1005                 ov7251->pre_isp_00 = val;
1006
1007         return ret;
1008 }
1009
1010 static const char * const ov7251_test_pattern_menu[] = {
1011         "Disabled",
1012         "Vertical Pattern Bars",
1013 };
1014
1015 static int ov7251_vts_configure(struct ov7251 *ov7251, s32 vblank)
1016 {
1017         u8 vts[2];
1018
1019         vts[0] = ((ov7251->current_mode->height + vblank) & 0xff00) >> 8;
1020         vts[1] = ((ov7251->current_mode->height + vblank) & 0x00ff);
1021
1022         return ov7251_write_seq_regs(ov7251, OV7251_TIMING_VTS_REG, vts, 2);
1023 }
1024
1025 static int ov7251_s_ctrl(struct v4l2_ctrl *ctrl)
1026 {
1027         struct ov7251 *ov7251 = container_of(ctrl->handler,
1028                                              struct ov7251, ctrls);
1029         int ret;
1030
1031         /* If VBLANK is altered we need to update exposure to compensate */
1032         if (ctrl->id == V4L2_CID_VBLANK) {
1033                 int exposure_max;
1034
1035                 exposure_max = ov7251->current_mode->height + ctrl->val -
1036                                OV7251_INTEGRATION_MARGIN;
1037                 __v4l2_ctrl_modify_range(ov7251->exposure,
1038                                          ov7251->exposure->minimum,
1039                                          exposure_max,
1040                                          ov7251->exposure->step,
1041                                          min(ov7251->exposure->val,
1042                                              exposure_max));
1043         }
1044
1045         /* v4l2_ctrl_lock() locks our mutex */
1046
1047         if (!pm_runtime_get_if_in_use(ov7251->dev))
1048                 return 0;
1049
1050         switch (ctrl->id) {
1051         case V4L2_CID_EXPOSURE:
1052                 ret = ov7251_set_exposure(ov7251, ctrl->val);
1053                 break;
1054         case V4L2_CID_GAIN:
1055                 ret = ov7251_set_gain(ov7251, ctrl->val);
1056                 break;
1057         case V4L2_CID_TEST_PATTERN:
1058                 ret = ov7251_set_test_pattern(ov7251, ctrl->val);
1059                 break;
1060         case V4L2_CID_HFLIP:
1061                 ret = ov7251_set_hflip(ov7251, ctrl->val);
1062                 break;
1063         case V4L2_CID_VFLIP:
1064                 ret = ov7251_set_vflip(ov7251, ctrl->val);
1065                 break;
1066         case V4L2_CID_VBLANK:
1067                 ret = ov7251_vts_configure(ov7251, ctrl->val);
1068                 break;
1069         default:
1070                 ret = -EINVAL;
1071                 break;
1072         }
1073
1074         pm_runtime_put(ov7251->dev);
1075
1076         return ret;
1077 }
1078
1079 static const struct v4l2_ctrl_ops ov7251_ctrl_ops = {
1080         .s_ctrl = ov7251_s_ctrl,
1081 };
1082
1083 static int ov7251_enum_mbus_code(struct v4l2_subdev *sd,
1084                                  struct v4l2_subdev_state *sd_state,
1085                                  struct v4l2_subdev_mbus_code_enum *code)
1086 {
1087         if (code->index > 0)
1088                 return -EINVAL;
1089
1090         code->code = MEDIA_BUS_FMT_Y10_1X10;
1091
1092         return 0;
1093 }
1094
1095 static int ov7251_enum_frame_size(struct v4l2_subdev *subdev,
1096                                   struct v4l2_subdev_state *sd_state,
1097                                   struct v4l2_subdev_frame_size_enum *fse)
1098 {
1099         if (fse->code != MEDIA_BUS_FMT_Y10_1X10)
1100                 return -EINVAL;
1101
1102         if (fse->index >= ARRAY_SIZE(ov7251_mode_info_data))
1103                 return -EINVAL;
1104
1105         fse->min_width = ov7251_mode_info_data[fse->index].width;
1106         fse->max_width = ov7251_mode_info_data[fse->index].width;
1107         fse->min_height = ov7251_mode_info_data[fse->index].height;
1108         fse->max_height = ov7251_mode_info_data[fse->index].height;
1109
1110         return 0;
1111 }
1112
1113 static int ov7251_enum_frame_ival(struct v4l2_subdev *subdev,
1114                                   struct v4l2_subdev_state *sd_state,
1115                                   struct v4l2_subdev_frame_interval_enum *fie)
1116 {
1117         unsigned int index = fie->index;
1118         unsigned int i;
1119
1120         for (i = 0; i < ARRAY_SIZE(ov7251_mode_info_data); i++) {
1121                 if (fie->width != ov7251_mode_info_data[i].width ||
1122                     fie->height != ov7251_mode_info_data[i].height)
1123                         continue;
1124
1125                 if (index-- == 0) {
1126                         fie->interval = ov7251_mode_info_data[i].timeperframe;
1127                         return 0;
1128                 }
1129         }
1130
1131         return -EINVAL;
1132 }
1133
1134 static struct v4l2_mbus_framefmt *
1135 __ov7251_get_pad_format(struct ov7251 *ov7251,
1136                         struct v4l2_subdev_state *sd_state,
1137                         unsigned int pad,
1138                         enum v4l2_subdev_format_whence which)
1139 {
1140         switch (which) {
1141         case V4L2_SUBDEV_FORMAT_TRY:
1142                 return v4l2_subdev_get_try_format(&ov7251->sd, sd_state, pad);
1143         case V4L2_SUBDEV_FORMAT_ACTIVE:
1144                 return &ov7251->fmt;
1145         default:
1146                 return NULL;
1147         }
1148 }
1149
1150 static int ov7251_get_format(struct v4l2_subdev *sd,
1151                              struct v4l2_subdev_state *sd_state,
1152                              struct v4l2_subdev_format *format)
1153 {
1154         struct ov7251 *ov7251 = to_ov7251(sd);
1155
1156         mutex_lock(&ov7251->lock);
1157         format->format = *__ov7251_get_pad_format(ov7251, sd_state,
1158                                                   format->pad,
1159                                                   format->which);
1160         mutex_unlock(&ov7251->lock);
1161
1162         return 0;
1163 }
1164
1165 static struct v4l2_rect *
1166 __ov7251_get_pad_crop(struct ov7251 *ov7251,
1167                       struct v4l2_subdev_state *sd_state,
1168                       unsigned int pad, enum v4l2_subdev_format_whence which)
1169 {
1170         switch (which) {
1171         case V4L2_SUBDEV_FORMAT_TRY:
1172                 return v4l2_subdev_get_try_crop(&ov7251->sd, sd_state, pad);
1173         case V4L2_SUBDEV_FORMAT_ACTIVE:
1174                 return &ov7251->crop;
1175         default:
1176                 return NULL;
1177         }
1178 }
1179
1180 static inline u32 avg_fps(const struct v4l2_fract *t)
1181 {
1182         return (t->denominator + (t->numerator >> 1)) / t->numerator;
1183 }
1184
1185 static const struct ov7251_mode_info *
1186 ov7251_find_mode_by_ival(struct ov7251 *ov7251, struct v4l2_fract *timeperframe)
1187 {
1188         const struct ov7251_mode_info *mode = ov7251->current_mode;
1189         unsigned int fps_req = avg_fps(timeperframe);
1190         unsigned int max_dist_match = (unsigned int) -1;
1191         unsigned int i, n = 0;
1192
1193         for (i = 0; i < ARRAY_SIZE(ov7251_mode_info_data); i++) {
1194                 unsigned int dist;
1195                 unsigned int fps_tmp;
1196
1197                 if (mode->width != ov7251_mode_info_data[i].width ||
1198                     mode->height != ov7251_mode_info_data[i].height)
1199                         continue;
1200
1201                 fps_tmp = avg_fps(&ov7251_mode_info_data[i].timeperframe);
1202
1203                 dist = abs(fps_req - fps_tmp);
1204
1205                 if (dist < max_dist_match) {
1206                         n = i;
1207                         max_dist_match = dist;
1208                 }
1209         }
1210
1211         return &ov7251_mode_info_data[n];
1212 }
1213
1214 static int ov7251_set_format(struct v4l2_subdev *sd,
1215                              struct v4l2_subdev_state *sd_state,
1216                              struct v4l2_subdev_format *format)
1217 {
1218         struct ov7251 *ov7251 = to_ov7251(sd);
1219         struct v4l2_mbus_framefmt *__format;
1220         int vblank_max, vblank_def;
1221         struct v4l2_rect *__crop;
1222         const struct ov7251_mode_info *new_mode;
1223         int ret = 0;
1224
1225         mutex_lock(&ov7251->lock);
1226
1227         __crop = __ov7251_get_pad_crop(ov7251, sd_state, format->pad,
1228                                        format->which);
1229
1230         new_mode = v4l2_find_nearest_size(ov7251_mode_info_data,
1231                                 ARRAY_SIZE(ov7251_mode_info_data),
1232                                 width, height,
1233                                 format->format.width, format->format.height);
1234
1235         __crop->width = new_mode->width;
1236         __crop->height = new_mode->height;
1237
1238         if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
1239                 ret = __v4l2_ctrl_modify_range(ov7251->exposure,
1240                                                1, new_mode->exposure_max,
1241                                                1, new_mode->exposure_def);
1242                 if (ret < 0)
1243                         goto exit;
1244
1245                 ret = __v4l2_ctrl_s_ctrl(ov7251->exposure,
1246                                          new_mode->exposure_def);
1247                 if (ret < 0)
1248                         goto exit;
1249
1250                 ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16);
1251                 if (ret < 0)
1252                         goto exit;
1253
1254                 vblank_max = OV7251_TIMING_MAX_VTS - new_mode->height;
1255                 vblank_def = new_mode->vts - new_mode->height;
1256                 ret = __v4l2_ctrl_modify_range(ov7251->vblank,
1257                                                OV7251_TIMING_MIN_VTS,
1258                                                vblank_max, 1, vblank_def);
1259                 if (ret < 0)
1260                         goto exit;
1261
1262                 ov7251->current_mode = new_mode;
1263         }
1264
1265         __format = __ov7251_get_pad_format(ov7251, sd_state, format->pad,
1266                                            format->which);
1267         __format->width = __crop->width;
1268         __format->height = __crop->height;
1269         __format->code = MEDIA_BUS_FMT_Y10_1X10;
1270         __format->field = V4L2_FIELD_NONE;
1271         __format->colorspace = V4L2_COLORSPACE_SRGB;
1272         __format->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(__format->colorspace);
1273         __format->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
1274                                 __format->colorspace, __format->ycbcr_enc);
1275         __format->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(__format->colorspace);
1276
1277         format->format = *__format;
1278
1279 exit:
1280         mutex_unlock(&ov7251->lock);
1281
1282         return ret;
1283 }
1284
1285 static int ov7251_entity_init_cfg(struct v4l2_subdev *subdev,
1286                                   struct v4l2_subdev_state *sd_state)
1287 {
1288         struct v4l2_subdev_format fmt = {
1289                 .which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
1290                 : V4L2_SUBDEV_FORMAT_ACTIVE,
1291                 .format = {
1292                         .width = 640,
1293                         .height = 480
1294                 }
1295         };
1296
1297         ov7251_set_format(subdev, sd_state, &fmt);
1298
1299         return 0;
1300 }
1301
1302 static int ov7251_get_selection(struct v4l2_subdev *sd,
1303                                 struct v4l2_subdev_state *sd_state,
1304                                 struct v4l2_subdev_selection *sel)
1305 {
1306         struct ov7251 *ov7251 = to_ov7251(sd);
1307
1308         switch (sel->target) {
1309         case V4L2_SEL_TGT_CROP_DEFAULT:
1310         case V4L2_SEL_TGT_CROP:
1311         mutex_lock(&ov7251->lock);
1312                 sel->r = *__ov7251_get_pad_crop(ov7251, sd_state, sel->pad,
1313                                                 sel->which);
1314                 mutex_unlock(&ov7251->lock);
1315                 break;
1316         case V4L2_SEL_TGT_NATIVE_SIZE:
1317                 sel->r.top = 0;
1318                 sel->r.left = 0;
1319                 sel->r.width = OV7251_NATIVE_WIDTH;
1320                 sel->r.height = OV7251_NATIVE_HEIGHT;
1321                 break;
1322         case V4L2_SEL_TGT_CROP_BOUNDS:
1323                 sel->r.top = OV7251_ACTIVE_START_TOP;
1324                 sel->r.left = OV7251_ACTIVE_START_LEFT;
1325                 sel->r.width = OV7251_ACTIVE_WIDTH;
1326                 sel->r.height = OV7251_ACTIVE_HEIGHT;
1327                 break;
1328         default:
1329                 return -EINVAL;
1330         }
1331
1332         return 0;
1333 }
1334
1335 static int ov7251_s_stream(struct v4l2_subdev *subdev, int enable)
1336 {
1337         struct ov7251 *ov7251 = to_ov7251(subdev);
1338         int ret;
1339
1340         mutex_lock(&ov7251->lock);
1341
1342         if (enable) {
1343                 ret = pm_runtime_get_sync(ov7251->dev);
1344                 if (ret < 0)
1345                         goto err_power_down;
1346
1347                 ret = ov7251_pll_configure(ov7251);
1348                 if (ret) {
1349                         dev_err(ov7251->dev, "error configuring PLLs\n");
1350                         goto err_power_down;
1351                 }
1352
1353                 ret = ov7251_set_register_array(ov7251,
1354                                         ov7251->current_mode->data,
1355                                         ov7251->current_mode->data_size);
1356                 if (ret < 0) {
1357                         dev_err(ov7251->dev, "could not set mode %dx%d\n",
1358                                 ov7251->current_mode->width,
1359                                 ov7251->current_mode->height);
1360                         goto err_power_down;
1361                 }
1362                 ret = __v4l2_ctrl_handler_setup(&ov7251->ctrls);
1363                 if (ret < 0) {
1364                         dev_err(ov7251->dev, "could not sync v4l2 controls\n");
1365                         goto err_power_down;
1366                 }
1367                 ret = ov7251_write_reg(ov7251, OV7251_SC_MODE_SELECT,
1368                                        OV7251_SC_MODE_SELECT_STREAMING);
1369                 if (ret)
1370                         goto err_power_down;
1371         } else {
1372                 ret = ov7251_write_reg(ov7251, OV7251_SC_MODE_SELECT,
1373                                        OV7251_SC_MODE_SELECT_SW_STANDBY);
1374                 pm_runtime_put(ov7251->dev);
1375         }
1376
1377         mutex_unlock(&ov7251->lock);
1378         return ret;
1379
1380 err_power_down:
1381         pm_runtime_put(ov7251->dev);
1382         mutex_unlock(&ov7251->lock);
1383         return ret;
1384 }
1385
1386 static int ov7251_get_frame_interval(struct v4l2_subdev *subdev,
1387                                      struct v4l2_subdev_frame_interval *fi)
1388 {
1389         struct ov7251 *ov7251 = to_ov7251(subdev);
1390
1391         mutex_lock(&ov7251->lock);
1392         fi->interval = ov7251->current_mode->timeperframe;
1393         mutex_unlock(&ov7251->lock);
1394
1395         return 0;
1396 }
1397
1398 static int ov7251_set_frame_interval(struct v4l2_subdev *subdev,
1399                                      struct v4l2_subdev_frame_interval *fi)
1400 {
1401         struct ov7251 *ov7251 = to_ov7251(subdev);
1402         const struct ov7251_mode_info *new_mode;
1403         int ret = 0;
1404
1405         mutex_lock(&ov7251->lock);
1406         new_mode = ov7251_find_mode_by_ival(ov7251, &fi->interval);
1407
1408         if (new_mode != ov7251->current_mode) {
1409                 ret = __v4l2_ctrl_modify_range(ov7251->exposure,
1410                                                1, new_mode->exposure_max,
1411                                                1, new_mode->exposure_def);
1412                 if (ret < 0)
1413                         goto exit;
1414
1415                 ret = __v4l2_ctrl_s_ctrl(ov7251->exposure,
1416                                          new_mode->exposure_def);
1417                 if (ret < 0)
1418                         goto exit;
1419
1420                 ret = __v4l2_ctrl_s_ctrl(ov7251->gain, 16);
1421                 if (ret < 0)
1422                         goto exit;
1423
1424                 ov7251->current_mode = new_mode;
1425         }
1426
1427         fi->interval = ov7251->current_mode->timeperframe;
1428
1429 exit:
1430         mutex_unlock(&ov7251->lock);
1431
1432         return ret;
1433 }
1434
1435 static const struct v4l2_subdev_video_ops ov7251_video_ops = {
1436         .s_stream = ov7251_s_stream,
1437         .g_frame_interval = ov7251_get_frame_interval,
1438         .s_frame_interval = ov7251_set_frame_interval,
1439 };
1440
1441 static const struct v4l2_subdev_pad_ops ov7251_subdev_pad_ops = {
1442         .init_cfg = ov7251_entity_init_cfg,
1443         .enum_mbus_code = ov7251_enum_mbus_code,
1444         .enum_frame_size = ov7251_enum_frame_size,
1445         .enum_frame_interval = ov7251_enum_frame_ival,
1446         .get_fmt = ov7251_get_format,
1447         .set_fmt = ov7251_set_format,
1448         .get_selection = ov7251_get_selection,
1449 };
1450
1451 static const struct v4l2_subdev_ops ov7251_subdev_ops = {
1452         .video = &ov7251_video_ops,
1453         .pad = &ov7251_subdev_pad_ops,
1454 };
1455
1456 static int ov7251_check_hwcfg(struct ov7251 *ov7251)
1457 {
1458         struct fwnode_handle *fwnode = dev_fwnode(ov7251->dev);
1459         struct v4l2_fwnode_endpoint bus_cfg = {
1460                 .bus_type = V4L2_MBUS_CSI2_DPHY,
1461         };
1462         struct fwnode_handle *endpoint;
1463         unsigned int i, j;
1464         int ret;
1465
1466         endpoint = fwnode_graph_get_next_endpoint(fwnode, NULL);
1467         if (!endpoint)
1468                 return -EPROBE_DEFER; /* could be provided by cio2-bridge */
1469
1470         ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, &bus_cfg);
1471         fwnode_handle_put(endpoint);
1472         if (ret)
1473                 return dev_err_probe(ov7251->dev, ret,
1474                                      "parsing endpoint node failed\n");
1475
1476         if (!bus_cfg.nr_of_link_frequencies) {
1477                 ret = dev_err_probe(ov7251->dev, -EINVAL,
1478                                     "no link frequencies defined\n");
1479                 goto out_free_bus_cfg;
1480         }
1481
1482         for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++) {
1483                 for (j = 0; j < ARRAY_SIZE(link_freq); j++)
1484                         if (bus_cfg.link_frequencies[i] == link_freq[j])
1485                                 break;
1486
1487                 if (j < ARRAY_SIZE(link_freq))
1488                         break;
1489         }
1490
1491         if (i == bus_cfg.nr_of_link_frequencies) {
1492                 ret = dev_err_probe(ov7251->dev, -EINVAL,
1493                                     "no supported link freq found\n");
1494                 goto out_free_bus_cfg;
1495         }
1496
1497         ov7251->link_freq_idx = i;
1498
1499 out_free_bus_cfg:
1500         v4l2_fwnode_endpoint_free(&bus_cfg);
1501
1502         return ret;
1503 }
1504
1505 static int ov7251_detect_chip(struct ov7251 *ov7251)
1506 {
1507         u8 chip_id_high, chip_id_low, chip_rev;
1508         int ret;
1509
1510         ret = ov7251_read_reg(ov7251, OV7251_CHIP_ID_HIGH, &chip_id_high);
1511         if (ret < 0 || chip_id_high != OV7251_CHIP_ID_HIGH_BYTE)
1512                 return dev_err_probe(ov7251->dev, -ENODEV,
1513                                      "could not read ID high\n");
1514
1515         ret = ov7251_read_reg(ov7251, OV7251_CHIP_ID_LOW, &chip_id_low);
1516         if (ret < 0 || chip_id_low != OV7251_CHIP_ID_LOW_BYTE)
1517                 return dev_err_probe(ov7251->dev, -ENODEV,
1518                                      "could not read ID low\n");
1519
1520         ret = ov7251_read_reg(ov7251, OV7251_SC_GP_IO_IN1, &chip_rev);
1521         if (ret < 0)
1522                 return dev_err_probe(ov7251->dev, -ENODEV,
1523                                      "could not read revision\n");
1524         chip_rev >>= 4;
1525
1526         dev_info(ov7251->dev,
1527                  "OV7251 revision %x (%s) detected at address 0x%02x\n",
1528                  chip_rev,
1529                  chip_rev == 0x4 ? "1A / 1B" :
1530                  chip_rev == 0x5 ? "1C / 1D" :
1531                  chip_rev == 0x6 ? "1E" :
1532                  chip_rev == 0x7 ? "1F" : "unknown",
1533                  ov7251->i2c_client->addr);
1534
1535         return 0;
1536 }
1537
1538 static int ov7251_init_ctrls(struct ov7251 *ov7251)
1539 {
1540         int vblank_max, vblank_def;
1541         s64 pixel_rate;
1542         int hblank;
1543
1544         v4l2_ctrl_handler_init(&ov7251->ctrls, 7);
1545         ov7251->ctrls.lock = &ov7251->lock;
1546
1547         v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1548                           V4L2_CID_HFLIP, 0, 1, 1, 0);
1549         v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1550                           V4L2_CID_VFLIP, 0, 1, 1, 0);
1551         ov7251->exposure = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1552                                              V4L2_CID_EXPOSURE, 1, 32, 1, 32);
1553         ov7251->gain = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1554                                          V4L2_CID_GAIN, 16, 1023, 1, 16);
1555         v4l2_ctrl_new_std_menu_items(&ov7251->ctrls, &ov7251_ctrl_ops,
1556                                      V4L2_CID_TEST_PATTERN,
1557                                      ARRAY_SIZE(ov7251_test_pattern_menu) - 1,
1558                                      0, 0, ov7251_test_pattern_menu);
1559
1560         pixel_rate = pixel_rates[ov7251->link_freq_idx];
1561         ov7251->pixel_clock = v4l2_ctrl_new_std(&ov7251->ctrls,
1562                                                 &ov7251_ctrl_ops,
1563                                                 V4L2_CID_PIXEL_RATE,
1564                                                 pixel_rate, INT_MAX,
1565                                                 pixel_rate, pixel_rate);
1566         ov7251->link_freq = v4l2_ctrl_new_int_menu(&ov7251->ctrls,
1567                                                    &ov7251_ctrl_ops,
1568                                                    V4L2_CID_LINK_FREQ,
1569                                                    ARRAY_SIZE(link_freq) - 1,
1570                                                    ov7251->link_freq_idx,
1571                                                    link_freq);
1572         if (ov7251->link_freq)
1573                 ov7251->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
1574         if (ov7251->pixel_clock)
1575                 ov7251->pixel_clock->flags |= V4L2_CTRL_FLAG_READ_ONLY;
1576
1577         hblank = OV7251_FIXED_PPL - ov7251->current_mode->width;
1578         ov7251->hblank = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1579                                            V4L2_CID_HBLANK, hblank, hblank, 1,
1580                                            hblank);
1581         if (ov7251->hblank)
1582                 ov7251->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
1583
1584         vblank_max = OV7251_TIMING_MAX_VTS - ov7251->current_mode->height;
1585         vblank_def = ov7251->current_mode->vts - ov7251->current_mode->height;
1586         ov7251->vblank = v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
1587                                            V4L2_CID_VBLANK,
1588                                            OV7251_TIMING_MIN_VTS, vblank_max, 1,
1589                                            vblank_def);
1590
1591         ov7251->sd.ctrl_handler = &ov7251->ctrls;
1592
1593         if (ov7251->ctrls.error) {
1594                 v4l2_ctrl_handler_free(&ov7251->ctrls);
1595                 return ov7251->ctrls.error;
1596         }
1597
1598         return 0;
1599 }
1600
1601 static int ov7251_probe(struct i2c_client *client)
1602 {
1603         struct device *dev = &client->dev;
1604         struct ov7251 *ov7251;
1605         unsigned int rate = 0, clk_rate = 0;
1606         int ret;
1607         int i;
1608
1609         ov7251 = devm_kzalloc(dev, sizeof(struct ov7251), GFP_KERNEL);
1610         if (!ov7251)
1611                 return -ENOMEM;
1612
1613         ov7251->i2c_client = client;
1614         ov7251->dev = dev;
1615
1616         ret = ov7251_check_hwcfg(ov7251);
1617         if (ret)
1618                 return ret;
1619
1620         /* get system clock (xclk) */
1621         ov7251->xclk = devm_clk_get_optional(dev, NULL);
1622         if (IS_ERR(ov7251->xclk))
1623                 return dev_err_probe(dev, PTR_ERR(ov7251->xclk),
1624                                      "could not get xclk");
1625
1626         /*
1627          * We could have either a 24MHz or 19.2MHz clock rate from either DT or
1628          * ACPI. We also need to support the IPU3 case which will have both an
1629          * external clock AND a clock-frequency property.
1630          */
1631         ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
1632                                        &rate);
1633         if (ret && !ov7251->xclk)
1634                 return dev_err_probe(dev, ret, "invalid clock config\n");
1635
1636         clk_rate = clk_get_rate(ov7251->xclk);
1637         ov7251->xclk_freq = clk_rate ? clk_rate : rate;
1638
1639         if (ov7251->xclk_freq == 0)
1640                 return dev_err_probe(dev, -EINVAL, "invalid clock frequency\n");
1641
1642         if (!ret && ov7251->xclk) {
1643                 ret = clk_set_rate(ov7251->xclk, rate);
1644                 if (ret)
1645                         return dev_err_probe(dev, ret,
1646                                              "failed to set clock rate\n");
1647         }
1648
1649         for (i = 0; i < ARRAY_SIZE(supported_xclk_rates); i++)
1650                 if (ov7251->xclk_freq == supported_xclk_rates[i])
1651                         break;
1652
1653         if (i == ARRAY_SIZE(supported_xclk_rates))
1654                 return dev_err_probe(dev, -EINVAL,
1655                                      "clock rate %u Hz is unsupported\n",
1656                                      ov7251->xclk_freq);
1657
1658         ov7251->pll_cfgs = ov7251_pll_cfgs[i];
1659
1660         ov7251->io_regulator = devm_regulator_get(dev, "vdddo");
1661         if (IS_ERR(ov7251->io_regulator)) {
1662                 dev_err(dev, "cannot get io regulator\n");
1663                 return PTR_ERR(ov7251->io_regulator);
1664         }
1665
1666         ov7251->core_regulator = devm_regulator_get(dev, "vddd");
1667         if (IS_ERR(ov7251->core_regulator)) {
1668                 dev_err(dev, "cannot get core regulator\n");
1669                 return PTR_ERR(ov7251->core_regulator);
1670         }
1671
1672         ov7251->analog_regulator = devm_regulator_get(dev, "vdda");
1673         if (IS_ERR(ov7251->analog_regulator)) {
1674                 dev_err(dev, "cannot get analog regulator\n");
1675                 return PTR_ERR(ov7251->analog_regulator);
1676         }
1677
1678         ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH);
1679         if (IS_ERR(ov7251->enable_gpio)) {
1680                 dev_err(dev, "cannot get enable gpio\n");
1681                 return PTR_ERR(ov7251->enable_gpio);
1682         }
1683
1684         mutex_init(&ov7251->lock);
1685
1686         ov7251->current_mode = &ov7251_mode_info_data[0];
1687         ret = ov7251_init_ctrls(ov7251);
1688         if (ret) {
1689                 dev_err_probe(dev, ret, "error during v4l2 ctrl init\n");
1690                 goto destroy_mutex;
1691         }
1692
1693         v4l2_i2c_subdev_init(&ov7251->sd, client, &ov7251_subdev_ops);
1694         ov7251->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
1695         ov7251->pad.flags = MEDIA_PAD_FL_SOURCE;
1696         ov7251->sd.dev = &client->dev;
1697         ov7251->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
1698
1699         ret = media_entity_pads_init(&ov7251->sd.entity, 1, &ov7251->pad);
1700         if (ret < 0) {
1701                 dev_err(dev, "could not register media entity\n");
1702                 goto free_ctrl;
1703         }
1704
1705         ret = ov7251_set_power_on(ov7251->dev);
1706         if (ret)
1707                 goto free_entity;
1708
1709         ret = ov7251_detect_chip(ov7251);
1710         if (ret)
1711                 goto power_down;
1712
1713         pm_runtime_set_active(&client->dev);
1714         pm_runtime_get_noresume(&client->dev);
1715         pm_runtime_enable(&client->dev);
1716
1717         ret = ov7251_read_reg(ov7251, OV7251_PRE_ISP_00,
1718                               &ov7251->pre_isp_00);
1719         if (ret < 0) {
1720                 dev_err(dev, "could not read test pattern value\n");
1721                 ret = -ENODEV;
1722                 goto err_pm_runtime;
1723         }
1724
1725         ret = ov7251_read_reg(ov7251, OV7251_TIMING_FORMAT1,
1726                               &ov7251->timing_format1);
1727         if (ret < 0) {
1728                 dev_err(dev, "could not read vflip value\n");
1729                 ret = -ENODEV;
1730                 goto err_pm_runtime;
1731         }
1732
1733         ret = ov7251_read_reg(ov7251, OV7251_TIMING_FORMAT2,
1734                               &ov7251->timing_format2);
1735         if (ret < 0) {
1736                 dev_err(dev, "could not read hflip value\n");
1737                 ret = -ENODEV;
1738                 goto err_pm_runtime;
1739         }
1740
1741         pm_runtime_set_autosuspend_delay(&client->dev, 1000);
1742         pm_runtime_use_autosuspend(&client->dev);
1743         pm_runtime_put_autosuspend(&client->dev);
1744
1745         ret = v4l2_async_register_subdev(&ov7251->sd);
1746         if (ret < 0) {
1747                 dev_err(dev, "could not register v4l2 device\n");
1748                 goto free_entity;
1749         }
1750
1751         ov7251_entity_init_cfg(&ov7251->sd, NULL);
1752
1753         return 0;
1754
1755 err_pm_runtime:
1756         pm_runtime_disable(ov7251->dev);
1757         pm_runtime_put_noidle(ov7251->dev);
1758 power_down:
1759         ov7251_set_power_off(ov7251->dev);
1760 free_entity:
1761         media_entity_cleanup(&ov7251->sd.entity);
1762 free_ctrl:
1763         v4l2_ctrl_handler_free(&ov7251->ctrls);
1764 destroy_mutex:
1765         mutex_destroy(&ov7251->lock);
1766
1767         return ret;
1768 }
1769
1770 static void ov7251_remove(struct i2c_client *client)
1771 {
1772         struct v4l2_subdev *sd = i2c_get_clientdata(client);
1773         struct ov7251 *ov7251 = to_ov7251(sd);
1774
1775         v4l2_async_unregister_subdev(&ov7251->sd);
1776         media_entity_cleanup(&ov7251->sd.entity);
1777         v4l2_ctrl_handler_free(&ov7251->ctrls);
1778         mutex_destroy(&ov7251->lock);
1779
1780         pm_runtime_disable(ov7251->dev);
1781         if (!pm_runtime_status_suspended(ov7251->dev))
1782                 ov7251_set_power_off(ov7251->dev);
1783         pm_runtime_set_suspended(ov7251->dev);
1784 }
1785
1786 static const struct dev_pm_ops ov7251_pm_ops = {
1787         SET_RUNTIME_PM_OPS(ov7251_set_power_off, ov7251_set_power_on, NULL)
1788 };
1789
1790 static const struct of_device_id ov7251_of_match[] = {
1791         { .compatible = "ovti,ov7251" },
1792         { /* sentinel */ }
1793 };
1794 MODULE_DEVICE_TABLE(of, ov7251_of_match);
1795
1796 static const struct acpi_device_id ov7251_acpi_match[] = {
1797         { "INT347E" },
1798         { }
1799 };
1800 MODULE_DEVICE_TABLE(acpi, ov7251_acpi_match);
1801
1802 static struct i2c_driver ov7251_i2c_driver = {
1803         .driver = {
1804                 .of_match_table = ov7251_of_match,
1805                 .acpi_match_table = ov7251_acpi_match,
1806                 .name  = "ov7251",
1807                 .pm = &ov7251_pm_ops,
1808         },
1809         .probe = ov7251_probe,
1810         .remove = ov7251_remove,
1811 };
1812
1813 module_i2c_driver(ov7251_i2c_driver);
1814
1815 MODULE_DESCRIPTION("Omnivision OV7251 Camera Driver");
1816 MODULE_AUTHOR("Todor Tomov <todor.tomov@linaro.org>");
1817 MODULE_LICENSE("GPL v2");