1 // SPDX-License-Identifier: GPL-2.0-only
3 * Copyright (C) 2014 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 * Author: Vinay Simha <vinaysimha@inforcecomputing.com>
8 #include <drm/drm_crtc.h>
9 #include <drm/drm_probe_helper.h>
13 struct mdp4_lcdc_encoder {
14 struct drm_encoder base;
15 struct device_node *panel_node;
16 struct drm_panel *panel;
18 unsigned long int pixclock;
19 struct regulator *regs[3];
23 #define to_mdp4_lcdc_encoder(x) container_of(x, struct mdp4_lcdc_encoder, base)
25 static struct mdp4_kms *get_kms(struct drm_encoder *encoder)
27 struct msm_drm_private *priv = encoder->dev->dev_private;
28 return to_mdp4_kms(to_mdp_kms(priv->kms));
31 #ifdef DOWNSTREAM_CONFIG_MSM_BUS_SCALING
32 #include <mach/board.h>
33 static void bs_init(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder)
35 struct drm_device *dev = mdp4_lcdc_encoder->base.dev;
36 struct lcdc_platform_data *lcdc_pdata = mdp4_find_pdata("lvds.0");
39 DRM_DEV_ERROR(dev->dev, "could not find lvds pdata\n");
43 if (lcdc_pdata->bus_scale_table) {
44 mdp4_lcdc_encoder->bsc = msm_bus_scale_register_client(
45 lcdc_pdata->bus_scale_table);
46 DBG("lvds : bus scale client: %08x", mdp4_lcdc_encoder->bsc);
50 static void bs_fini(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder)
52 if (mdp4_lcdc_encoder->bsc) {
53 msm_bus_scale_unregister_client(mdp4_lcdc_encoder->bsc);
54 mdp4_lcdc_encoder->bsc = 0;
58 static void bs_set(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder, int idx)
60 if (mdp4_lcdc_encoder->bsc) {
61 DBG("set bus scaling: %d", idx);
62 msm_bus_scale_client_update_request(mdp4_lcdc_encoder->bsc, idx);
66 static void bs_init(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder) {}
67 static void bs_fini(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder) {}
68 static void bs_set(struct mdp4_lcdc_encoder *mdp4_lcdc_encoder, int idx) {}
71 static void mdp4_lcdc_encoder_destroy(struct drm_encoder *encoder)
73 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
74 to_mdp4_lcdc_encoder(encoder);
75 bs_fini(mdp4_lcdc_encoder);
76 drm_encoder_cleanup(encoder);
77 kfree(mdp4_lcdc_encoder);
80 static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = {
81 .destroy = mdp4_lcdc_encoder_destroy,
84 /* this should probably be a helper: */
85 static struct drm_connector *get_connector(struct drm_encoder *encoder)
87 struct drm_device *dev = encoder->dev;
88 struct drm_connector *connector;
90 list_for_each_entry(connector, &dev->mode_config.connector_list, head)
91 if (connector->encoder == encoder)
97 static void setup_phy(struct drm_encoder *encoder)
99 struct drm_device *dev = encoder->dev;
100 struct drm_connector *connector = get_connector(encoder);
101 struct mdp4_kms *mdp4_kms = get_kms(encoder);
102 uint32_t lvds_intf = 0, lvds_phy_cfg0 = 0;
103 int bpp, nchan, swap;
108 bpp = 3 * connector->display_info.bpc;
113 /* TODO, these should come from panel somehow: */
119 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(0),
120 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x08) |
121 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x05) |
122 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x04) |
123 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x03));
124 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(0),
125 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x02) |
126 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x01) |
127 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x00));
128 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(1),
129 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x11) |
130 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x10) |
131 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x0d) |
132 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x0c));
133 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(1),
134 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x0b) |
135 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x0a) |
136 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x09));
137 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(2),
138 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x1a) |
139 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x19) |
140 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x18) |
141 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x15));
142 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(2),
143 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x14) |
144 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x13) |
145 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x12));
146 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(3),
147 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x1b) |
148 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x17) |
149 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x16) |
150 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x0f));
151 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(3),
152 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x0e) |
153 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x07) |
154 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x06));
156 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE3_EN |
157 MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE2_EN |
158 MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE1_EN |
159 MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE0_EN |
160 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE3_EN |
161 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE2_EN |
162 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE1_EN |
163 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE0_EN;
165 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE3_EN |
166 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE2_EN |
167 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE1_EN |
168 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE0_EN;
173 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(0),
174 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x0a) |
175 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x07) |
176 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x06) |
177 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x05));
178 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(0),
179 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x04) |
180 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x03) |
181 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x02));
182 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(1),
183 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x13) |
184 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x12) |
185 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x0f) |
186 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x0e));
187 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(1),
188 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x0d) |
189 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x0c) |
190 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x0b));
191 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_3_TO_0(2),
192 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT0(0x1a) |
193 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT1(0x19) |
194 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT2(0x18) |
195 MDP4_LCDC_LVDS_MUX_CTL_3_TO_0_BIT3(0x17));
196 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_MUX_CTL_6_TO_4(2),
197 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT4(0x16) |
198 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT5(0x15) |
199 MDP4_LCDC_LVDS_MUX_CTL_6_TO_4_BIT6(0x14));
201 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE2_EN |
202 MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE1_EN |
203 MDP4_LCDC_LVDS_INTF_CTL_CH2_DATA_LANE0_EN |
204 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE2_EN |
205 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE1_EN |
206 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE0_EN;
208 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE2_EN |
209 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE1_EN |
210 MDP4_LCDC_LVDS_INTF_CTL_CH1_DATA_LANE0_EN;
212 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_RGB_OUT;
216 DRM_DEV_ERROR(dev->dev, "unknown bpp: %d\n", bpp);
222 lvds_phy_cfg0 = MDP4_LVDS_PHY_CFG0_CHANNEL0;
223 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH1_CLK_LANE_EN |
224 MDP4_LCDC_LVDS_INTF_CTL_MODE_SEL;
227 lvds_phy_cfg0 = MDP4_LVDS_PHY_CFG0_CHANNEL0 |
228 MDP4_LVDS_PHY_CFG0_CHANNEL1;
229 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH2_CLK_LANE_EN |
230 MDP4_LCDC_LVDS_INTF_CTL_CH1_CLK_LANE_EN;
233 DRM_DEV_ERROR(dev->dev, "unknown # of channels: %d\n", nchan);
238 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_CH_SWAP;
240 lvds_intf |= MDP4_LCDC_LVDS_INTF_CTL_ENABLE;
242 mdp4_write(mdp4_kms, REG_MDP4_LVDS_PHY_CFG0, lvds_phy_cfg0);
243 mdp4_write(mdp4_kms, REG_MDP4_LCDC_LVDS_INTF_CTL, lvds_intf);
244 mdp4_write(mdp4_kms, REG_MDP4_LVDS_PHY_CFG2, 0x30);
248 lvds_phy_cfg0 |= MDP4_LVDS_PHY_CFG0_SERIALIZATION_ENBLE;
249 mdp4_write(mdp4_kms, REG_MDP4_LVDS_PHY_CFG0, lvds_phy_cfg0);
252 static void mdp4_lcdc_encoder_mode_set(struct drm_encoder *encoder,
253 struct drm_display_mode *mode,
254 struct drm_display_mode *adjusted_mode)
256 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
257 to_mdp4_lcdc_encoder(encoder);
258 struct mdp4_kms *mdp4_kms = get_kms(encoder);
259 uint32_t lcdc_hsync_skew, vsync_period, vsync_len, ctrl_pol;
260 uint32_t display_v_start, display_v_end;
261 uint32_t hsync_start_x, hsync_end_x;
263 mode = adjusted_mode;
265 DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
267 mdp4_lcdc_encoder->pixclock = mode->clock * 1000;
269 DBG("pixclock=%lu", mdp4_lcdc_encoder->pixclock);
272 if (mode->flags & DRM_MODE_FLAG_NHSYNC)
273 ctrl_pol |= MDP4_LCDC_CTRL_POLARITY_HSYNC_LOW;
274 if (mode->flags & DRM_MODE_FLAG_NVSYNC)
275 ctrl_pol |= MDP4_LCDC_CTRL_POLARITY_VSYNC_LOW;
276 /* probably need to get DATA_EN polarity from panel.. */
278 lcdc_hsync_skew = 0; /* get this from panel? */
280 hsync_start_x = (mode->htotal - mode->hsync_start);
281 hsync_end_x = mode->htotal - (mode->hsync_start - mode->hdisplay) - 1;
283 vsync_period = mode->vtotal * mode->htotal;
284 vsync_len = (mode->vsync_end - mode->vsync_start) * mode->htotal;
285 display_v_start = (mode->vtotal - mode->vsync_start) * mode->htotal + lcdc_hsync_skew;
286 display_v_end = vsync_period - ((mode->vsync_start - mode->vdisplay) * mode->htotal) + lcdc_hsync_skew - 1;
288 mdp4_write(mdp4_kms, REG_MDP4_LCDC_HSYNC_CTRL,
289 MDP4_LCDC_HSYNC_CTRL_PULSEW(mode->hsync_end - mode->hsync_start) |
290 MDP4_LCDC_HSYNC_CTRL_PERIOD(mode->htotal));
291 mdp4_write(mdp4_kms, REG_MDP4_LCDC_VSYNC_PERIOD, vsync_period);
292 mdp4_write(mdp4_kms, REG_MDP4_LCDC_VSYNC_LEN, vsync_len);
293 mdp4_write(mdp4_kms, REG_MDP4_LCDC_DISPLAY_HCTRL,
294 MDP4_LCDC_DISPLAY_HCTRL_START(hsync_start_x) |
295 MDP4_LCDC_DISPLAY_HCTRL_END(hsync_end_x));
296 mdp4_write(mdp4_kms, REG_MDP4_LCDC_DISPLAY_VSTART, display_v_start);
297 mdp4_write(mdp4_kms, REG_MDP4_LCDC_DISPLAY_VEND, display_v_end);
298 mdp4_write(mdp4_kms, REG_MDP4_LCDC_BORDER_CLR, 0);
299 mdp4_write(mdp4_kms, REG_MDP4_LCDC_UNDERFLOW_CLR,
300 MDP4_LCDC_UNDERFLOW_CLR_ENABLE_RECOVERY |
301 MDP4_LCDC_UNDERFLOW_CLR_COLOR(0xff));
302 mdp4_write(mdp4_kms, REG_MDP4_LCDC_HSYNC_SKEW, lcdc_hsync_skew);
303 mdp4_write(mdp4_kms, REG_MDP4_LCDC_CTRL_POLARITY, ctrl_pol);
304 mdp4_write(mdp4_kms, REG_MDP4_LCDC_ACTIVE_HCTL,
305 MDP4_LCDC_ACTIVE_HCTL_START(0) |
306 MDP4_LCDC_ACTIVE_HCTL_END(0));
307 mdp4_write(mdp4_kms, REG_MDP4_LCDC_ACTIVE_VSTART, 0);
308 mdp4_write(mdp4_kms, REG_MDP4_LCDC_ACTIVE_VEND, 0);
311 static void mdp4_lcdc_encoder_disable(struct drm_encoder *encoder)
313 struct drm_device *dev = encoder->dev;
314 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
315 to_mdp4_lcdc_encoder(encoder);
316 struct mdp4_kms *mdp4_kms = get_kms(encoder);
317 struct drm_panel *panel;
320 if (WARN_ON(!mdp4_lcdc_encoder->enabled))
323 mdp4_write(mdp4_kms, REG_MDP4_LCDC_ENABLE, 0);
325 panel = of_drm_find_panel(mdp4_lcdc_encoder->panel_node);
326 if (!IS_ERR(panel)) {
327 drm_panel_disable(panel);
328 drm_panel_unprepare(panel);
332 * Wait for a vsync so we know the ENABLE=0 latched before
333 * the (connector) source of the vsync's gets disabled,
334 * otherwise we end up in a funny state if we re-enable
335 * before the disable latches, which results that some of
336 * the settings changes for the new modeset (like new
337 * scanout buffer) don't latch properly..
339 mdp_irq_wait(&mdp4_kms->base, MDP4_IRQ_PRIMARY_VSYNC);
341 clk_disable_unprepare(mdp4_lcdc_encoder->lcdc_clk);
343 for (i = 0; i < ARRAY_SIZE(mdp4_lcdc_encoder->regs); i++) {
344 ret = regulator_disable(mdp4_lcdc_encoder->regs[i]);
346 DRM_DEV_ERROR(dev->dev, "failed to disable regulator: %d\n", ret);
349 bs_set(mdp4_lcdc_encoder, 0);
351 mdp4_lcdc_encoder->enabled = false;
354 static void mdp4_lcdc_encoder_enable(struct drm_encoder *encoder)
356 struct drm_device *dev = encoder->dev;
357 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
358 to_mdp4_lcdc_encoder(encoder);
359 unsigned long pc = mdp4_lcdc_encoder->pixclock;
360 struct mdp4_kms *mdp4_kms = get_kms(encoder);
361 struct drm_panel *panel;
365 if (WARN_ON(mdp4_lcdc_encoder->enabled))
368 /* TODO: hard-coded for 18bpp: */
370 MDP4_DMA_CONFIG_R_BPC(BPC6) |
371 MDP4_DMA_CONFIG_G_BPC(BPC6) |
372 MDP4_DMA_CONFIG_B_BPC(BPC6) |
373 MDP4_DMA_CONFIG_PACK(0x21) |
374 MDP4_DMA_CONFIG_DEFLKR_EN |
375 MDP4_DMA_CONFIG_DITHER_EN;
377 if (!of_property_read_bool(dev->dev->of_node, "qcom,lcdc-align-lsb"))
378 config |= MDP4_DMA_CONFIG_PACK_ALIGN_MSB;
380 mdp4_crtc_set_config(encoder->crtc, config);
381 mdp4_crtc_set_intf(encoder->crtc, INTF_LCDC_DTV, 0);
383 bs_set(mdp4_lcdc_encoder, 1);
385 for (i = 0; i < ARRAY_SIZE(mdp4_lcdc_encoder->regs); i++) {
386 ret = regulator_enable(mdp4_lcdc_encoder->regs[i]);
388 DRM_DEV_ERROR(dev->dev, "failed to enable regulator: %d\n", ret);
391 DBG("setting lcdc_clk=%lu", pc);
392 ret = clk_set_rate(mdp4_lcdc_encoder->lcdc_clk, pc);
394 DRM_DEV_ERROR(dev->dev, "failed to configure lcdc_clk: %d\n", ret);
395 ret = clk_prepare_enable(mdp4_lcdc_encoder->lcdc_clk);
397 DRM_DEV_ERROR(dev->dev, "failed to enable lcdc_clk: %d\n", ret);
399 panel = of_drm_find_panel(mdp4_lcdc_encoder->panel_node);
400 if (!IS_ERR(panel)) {
401 drm_panel_prepare(panel);
402 drm_panel_enable(panel);
407 mdp4_write(mdp4_kms, REG_MDP4_LCDC_ENABLE, 1);
409 mdp4_lcdc_encoder->enabled = true;
412 static const struct drm_encoder_helper_funcs mdp4_lcdc_encoder_helper_funcs = {
413 .mode_set = mdp4_lcdc_encoder_mode_set,
414 .disable = mdp4_lcdc_encoder_disable,
415 .enable = mdp4_lcdc_encoder_enable,
418 long mdp4_lcdc_round_pixclk(struct drm_encoder *encoder, unsigned long rate)
420 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder =
421 to_mdp4_lcdc_encoder(encoder);
422 return clk_round_rate(mdp4_lcdc_encoder->lcdc_clk, rate);
425 /* initialize encoder */
426 struct drm_encoder *mdp4_lcdc_encoder_init(struct drm_device *dev,
427 struct device_node *panel_node)
429 struct drm_encoder *encoder = NULL;
430 struct mdp4_lcdc_encoder *mdp4_lcdc_encoder;
431 struct regulator *reg;
434 mdp4_lcdc_encoder = kzalloc(sizeof(*mdp4_lcdc_encoder), GFP_KERNEL);
435 if (!mdp4_lcdc_encoder) {
440 mdp4_lcdc_encoder->panel_node = panel_node;
442 encoder = &mdp4_lcdc_encoder->base;
444 drm_encoder_init(dev, encoder, &mdp4_lcdc_encoder_funcs,
445 DRM_MODE_ENCODER_LVDS, NULL);
446 drm_encoder_helper_add(encoder, &mdp4_lcdc_encoder_helper_funcs);
448 /* TODO: do we need different pll in other cases? */
449 mdp4_lcdc_encoder->lcdc_clk = mpd4_lvds_pll_init(dev);
450 if (IS_ERR(mdp4_lcdc_encoder->lcdc_clk)) {
451 DRM_DEV_ERROR(dev->dev, "failed to get lvds_clk\n");
452 ret = PTR_ERR(mdp4_lcdc_encoder->lcdc_clk);
456 /* TODO: different regulators in other cases? */
457 reg = devm_regulator_get(dev->dev, "lvds-vccs-3p3v");
460 DRM_DEV_ERROR(dev->dev, "failed to get lvds-vccs-3p3v: %d\n", ret);
463 mdp4_lcdc_encoder->regs[0] = reg;
465 reg = devm_regulator_get(dev->dev, "lvds-pll-vdda");
468 DRM_DEV_ERROR(dev->dev, "failed to get lvds-pll-vdda: %d\n", ret);
471 mdp4_lcdc_encoder->regs[1] = reg;
473 reg = devm_regulator_get(dev->dev, "lvds-vdda");
476 DRM_DEV_ERROR(dev->dev, "failed to get lvds-vdda: %d\n", ret);
479 mdp4_lcdc_encoder->regs[2] = reg;
481 bs_init(mdp4_lcdc_encoder);
487 mdp4_lcdc_encoder_destroy(encoder);