2 * SPDX-License-Identifier: MIT
4 * Copyright © 2014-2018 Intel Corporation
8 #include "intel_context.h"
9 #include "intel_engine_pm.h"
11 #include "intel_ring.h"
12 #include "intel_workarounds.h"
15 * DOC: Hardware workarounds
17 * This file is intended as a central place to implement most [1]_ of the
18 * required workarounds for hardware to work as originally intended. They fall
19 * in five basic categories depending on how/when they are applied:
21 * - Workarounds that touch registers that are saved/restored to/from the HW
22 * context image. The list is emitted (via Load Register Immediate commands)
23 * everytime a new context is created.
24 * - GT workarounds. The list of these WAs is applied whenever these registers
25 * revert to default values (on GPU reset, suspend/resume [2]_, etc..).
26 * - Display workarounds. The list is applied during display clock-gating
28 * - Workarounds that whitelist a privileged register, so that UMDs can manage
29 * them directly. This is just a special case of a MMMIO workaround (as we
30 * write the list of these to/be-whitelisted registers to some special HW
32 * - Workaround batchbuffers, that get executed automatically by the hardware
33 * on every HW context restore.
35 * .. [1] Please notice that there are other WAs that, due to their nature,
36 * cannot be applied from a central place. Those are peppered around the rest
37 * of the code, as needed.
39 * .. [2] Technically, some registers are powercontext saved & restored, so they
40 * survive a suspend/resume. In practice, writing them again is not too
41 * costly and simplifies things. We can revisit this in the future.
46 * Keep things in this file ordered by WA type, as per the above (context, GT,
47 * display, register whitelist, batchbuffer). Then, inside each type, keep the
50 * - Infrastructure functions and macros
51 * - WAs per platform in standard gen/chrono order
52 * - Public functions to init or apply the given workaround type.
55 static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
58 wal->engine_name = engine_name;
61 #define WA_LIST_CHUNK (1 << 4)
63 static void wa_init_finish(struct i915_wa_list *wal)
65 /* Trim unused entries. */
66 if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
67 struct i915_wa *list = kmemdup(wal->list,
68 wal->count * sizeof(*list),
80 DRM_DEBUG_DRIVER("Initialized %u %s workarounds on %s\n",
81 wal->wa_count, wal->name, wal->engine_name);
84 static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
86 unsigned int addr = i915_mmio_reg_offset(wa->reg);
87 unsigned int start = 0, end = wal->count;
88 const unsigned int grow = WA_LIST_CHUNK;
91 GEM_BUG_ON(!is_power_of_2(grow));
93 if (IS_ALIGNED(wal->count, grow)) { /* Either uninitialized or full. */
96 list = kmalloc_array(ALIGN(wal->count + 1, grow), sizeof(*wa),
99 DRM_ERROR("No space for workaround init!\n");
104 memcpy(list, wal->list, sizeof(*wa) * wal->count);
109 while (start < end) {
110 unsigned int mid = start + (end - start) / 2;
112 if (i915_mmio_reg_offset(wal->list[mid].reg) < addr) {
114 } else if (i915_mmio_reg_offset(wal->list[mid].reg) > addr) {
117 wa_ = &wal->list[mid];
119 if ((wa->clr | wa_->clr) && !(wa->clr & ~wa_->clr)) {
120 DRM_ERROR("Discarding overwritten w/a for reg %04x (clear: %08x, set: %08x)\n",
121 i915_mmio_reg_offset(wa_->reg),
124 wa_->set &= ~wa->clr;
130 wa_->read |= wa->read;
136 wa_ = &wal->list[wal->count++];
139 while (wa_-- > wal->list) {
140 GEM_BUG_ON(i915_mmio_reg_offset(wa_[0].reg) ==
141 i915_mmio_reg_offset(wa_[1].reg));
142 if (i915_mmio_reg_offset(wa_[1].reg) >
143 i915_mmio_reg_offset(wa_[0].reg))
146 swap(wa_[1], wa_[0]);
150 static void wa_add(struct i915_wa_list *wal, i915_reg_t reg,
151 u32 clear, u32 set, u32 read_mask)
153 struct i915_wa wa = {
164 wa_write_masked_or(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
166 wa_add(wal, reg, clear, set, clear);
170 wa_write(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
172 wa_write_masked_or(wal, reg, ~0, set);
176 wa_write_or(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
178 wa_write_masked_or(wal, reg, set, set);
182 wa_write_clr(struct i915_wa_list *wal, i915_reg_t reg, u32 clr)
184 wa_write_masked_or(wal, reg, clr, 0);
188 wa_masked_en(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
190 wa_add(wal, reg, 0, _MASKED_BIT_ENABLE(val), val);
194 wa_masked_dis(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
196 wa_add(wal, reg, 0, _MASKED_BIT_DISABLE(val), val);
199 #define WA_SET_BIT_MASKED(addr, mask) \
200 wa_masked_en(wal, (addr), (mask))
202 #define WA_CLR_BIT_MASKED(addr, mask) \
203 wa_masked_dis(wal, (addr), (mask))
205 #define WA_SET_FIELD_MASKED(addr, mask, value) \
206 wa_write_masked_or(wal, (addr), 0, _MASKED_FIELD((mask), (value)))
208 static void gen8_ctx_workarounds_init(struct intel_engine_cs *engine,
209 struct i915_wa_list *wal)
211 WA_SET_BIT_MASKED(INSTPM, INSTPM_FORCE_ORDERING);
213 /* WaDisableAsyncFlipPerfMode:bdw,chv */
214 WA_SET_BIT_MASKED(MI_MODE, ASYNC_FLIP_PERF_DISABLE);
216 /* WaDisablePartialInstShootdown:bdw,chv */
217 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN,
218 PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
220 /* Use Force Non-Coherent whenever executing a 3D context. This is a
221 * workaround for for a possible hang in the unlikely event a TLB
222 * invalidation occurs during a PSD flush.
224 /* WaForceEnableNonCoherent:bdw,chv */
225 /* WaHdcDisableFetchWhenMasked:bdw,chv */
226 WA_SET_BIT_MASKED(HDC_CHICKEN0,
227 HDC_DONOT_FETCH_MEM_WHEN_MASKED |
228 HDC_FORCE_NON_COHERENT);
230 /* From the Haswell PRM, Command Reference: Registers, CACHE_MODE_0:
231 * "The Hierarchical Z RAW Stall Optimization allows non-overlapping
232 * polygons in the same 8x4 pixel/sample area to be processed without
233 * stalling waiting for the earlier ones to write to Hierarchical Z
236 * This optimization is off by default for BDW and CHV; turn it on.
238 WA_CLR_BIT_MASKED(CACHE_MODE_0_GEN7, HIZ_RAW_STALL_OPT_DISABLE);
240 /* Wa4x4STCOptimizationDisable:bdw,chv */
241 WA_SET_BIT_MASKED(CACHE_MODE_1, GEN8_4x4_STC_OPTIMIZATION_DISABLE);
244 * BSpec recommends 8x4 when MSAA is used,
245 * however in practice 16x4 seems fastest.
247 * Note that PS/WM thread counts depend on the WIZ hashing
248 * disable bit, which we don't touch here, but it's good
249 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
251 WA_SET_FIELD_MASKED(GEN7_GT_MODE,
252 GEN6_WIZ_HASHING_MASK,
253 GEN6_WIZ_HASHING_16x4);
256 static void bdw_ctx_workarounds_init(struct intel_engine_cs *engine,
257 struct i915_wa_list *wal)
259 struct drm_i915_private *i915 = engine->i915;
261 gen8_ctx_workarounds_init(engine, wal);
263 /* WaDisableThreadStallDopClockGating:bdw (pre-production) */
264 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
266 /* WaDisableDopClockGating:bdw
268 * Also see the related UCGTCL1 write in bdw_init_clock_gating()
269 * to disable EUTC clock gating.
271 WA_SET_BIT_MASKED(GEN7_ROW_CHICKEN2,
272 DOP_CLOCK_GATING_DISABLE);
274 WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
275 GEN8_SAMPLER_POWER_BYPASS_DIS);
277 WA_SET_BIT_MASKED(HDC_CHICKEN0,
278 /* WaForceContextSaveRestoreNonCoherent:bdw */
279 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
280 /* WaDisableFenceDestinationToSLM:bdw (pre-prod) */
281 (IS_BDW_GT3(i915) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
284 static void chv_ctx_workarounds_init(struct intel_engine_cs *engine,
285 struct i915_wa_list *wal)
287 gen8_ctx_workarounds_init(engine, wal);
289 /* WaDisableThreadStallDopClockGating:chv */
290 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
292 /* Improve HiZ throughput on CHV. */
293 WA_SET_BIT_MASKED(HIZ_CHICKEN, CHV_HZ_8X8_MODE_IN_1X);
296 static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
297 struct i915_wa_list *wal)
299 struct drm_i915_private *i915 = engine->i915;
302 /* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
304 * Must match Display Engine. See
305 * WaCompressedResourceDisplayNewHashMode.
307 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
308 GEN9_PBE_COMPRESSED_HASH_SELECTION);
309 WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
310 GEN9_SAMPLER_HASH_COMPRESSED_READ_ADDR);
313 /* WaClearFlowControlGpgpuContextSave:skl,bxt,kbl,glk,cfl */
314 /* WaDisablePartialInstShootdown:skl,bxt,kbl,glk,cfl */
315 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN,
316 FLOW_CONTROL_ENABLE |
317 PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
319 /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
320 /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
321 WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
322 GEN9_ENABLE_YV12_BUGFIX |
323 GEN9_ENABLE_GPGPU_PREEMPTION);
325 /* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk,cfl */
326 /* WaDisablePartialResolveInVc:skl,bxt,kbl,cfl */
327 WA_SET_BIT_MASKED(CACHE_MODE_1,
328 GEN8_4x4_STC_OPTIMIZATION_DISABLE |
329 GEN9_PARTIAL_RESOLVE_IN_VC_DISABLE);
331 /* WaCcsTlbPrefetchDisable:skl,bxt,kbl,glk,cfl */
332 WA_CLR_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN5,
333 GEN9_CCS_TLB_PREFETCH_ENABLE);
335 /* WaForceContextSaveRestoreNonCoherent:skl,bxt,kbl,cfl */
336 WA_SET_BIT_MASKED(HDC_CHICKEN0,
337 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
338 HDC_FORCE_CSR_NON_COHERENT_OVR_DISABLE);
340 /* WaForceEnableNonCoherent and WaDisableHDCInvalidation are
341 * both tied to WaForceContextSaveRestoreNonCoherent
342 * in some hsds for skl. We keep the tie for all gen9. The
343 * documentation is a bit hazy and so we want to get common behaviour,
344 * even though there is no clear evidence we would need both on kbl/bxt.
345 * This area has been source of system hangs so we play it safe
346 * and mimic the skl regardless of what bspec says.
348 * Use Force Non-Coherent whenever executing a 3D context. This
349 * is a workaround for a possible hang in the unlikely event
350 * a TLB invalidation occurs during a PSD flush.
353 /* WaForceEnableNonCoherent:skl,bxt,kbl,cfl */
354 WA_SET_BIT_MASKED(HDC_CHICKEN0,
355 HDC_FORCE_NON_COHERENT);
357 /* WaDisableSamplerPowerBypassForSOPingPong:skl,bxt,kbl,cfl */
358 if (IS_SKYLAKE(i915) || IS_KABYLAKE(i915) || IS_COFFEELAKE(i915))
359 WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3,
360 GEN8_SAMPLER_POWER_BYPASS_DIS);
362 /* WaDisableSTUnitPowerOptimization:skl,bxt,kbl,glk,cfl */
363 WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN2, GEN8_ST_PO_DISABLE);
366 * Supporting preemption with fine-granularity requires changes in the
367 * batch buffer programming. Since we can't break old userspace, we
368 * need to set our default preemption level to safe value. Userspace is
369 * still able to use more fine-grained preemption levels, since in
370 * WaEnablePreemptionGranularityControlByUMD we're whitelisting the
371 * per-ctx register. As such, WaDisable{3D,GPGPU}MidCmdPreemption are
372 * not real HW workarounds, but merely a way to start using preemption
373 * while maintaining old contract with userspace.
376 /* WaDisable3DMidCmdPreemption:skl,bxt,glk,cfl,[cnl] */
377 WA_CLR_BIT_MASKED(GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
379 /* WaDisableGPGPUMidCmdPreemption:skl,bxt,blk,cfl,[cnl] */
380 WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
381 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
382 GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);
384 /* WaClearHIZ_WM_CHICKEN3:bxt,glk */
385 if (IS_GEN9_LP(i915))
386 WA_SET_BIT_MASKED(GEN9_WM_CHICKEN3, GEN9_FACTOR_IN_CLR_VAL_HIZ);
389 static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
390 struct i915_wa_list *wal)
392 struct drm_i915_private *i915 = engine->i915;
393 u8 vals[3] = { 0, 0, 0 };
396 for (i = 0; i < 3; i++) {
400 * Only consider slices where one, and only one, subslice has 7
403 if (!is_power_of_2(RUNTIME_INFO(i915)->sseu.subslice_7eu[i]))
407 * subslice_7eu[i] != 0 (because of the check above) and
408 * ss_max == 4 (maximum number of subslices possible per slice)
412 ss = ffs(RUNTIME_INFO(i915)->sseu.subslice_7eu[i]) - 1;
416 if (vals[0] == 0 && vals[1] == 0 && vals[2] == 0)
419 /* Tune IZ hashing. See intel_device_info_runtime_init() */
420 WA_SET_FIELD_MASKED(GEN7_GT_MODE,
421 GEN9_IZ_HASHING_MASK(2) |
422 GEN9_IZ_HASHING_MASK(1) |
423 GEN9_IZ_HASHING_MASK(0),
424 GEN9_IZ_HASHING(2, vals[2]) |
425 GEN9_IZ_HASHING(1, vals[1]) |
426 GEN9_IZ_HASHING(0, vals[0]));
429 static void skl_ctx_workarounds_init(struct intel_engine_cs *engine,
430 struct i915_wa_list *wal)
432 gen9_ctx_workarounds_init(engine, wal);
433 skl_tune_iz_hashing(engine, wal);
436 static void bxt_ctx_workarounds_init(struct intel_engine_cs *engine,
437 struct i915_wa_list *wal)
439 gen9_ctx_workarounds_init(engine, wal);
441 /* WaDisableThreadStallDopClockGating:bxt */
442 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN,
443 STALL_DOP_GATING_DISABLE);
445 /* WaToEnableHwFixForPushConstHWBug:bxt */
446 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
447 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
450 static void kbl_ctx_workarounds_init(struct intel_engine_cs *engine,
451 struct i915_wa_list *wal)
453 struct drm_i915_private *i915 = engine->i915;
455 gen9_ctx_workarounds_init(engine, wal);
457 /* WaToEnableHwFixForPushConstHWBug:kbl */
458 if (IS_KBL_REVID(i915, KBL_REVID_C0, REVID_FOREVER))
459 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
460 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
462 /* WaDisableSbeCacheDispatchPortSharing:kbl */
463 WA_SET_BIT_MASKED(GEN7_HALF_SLICE_CHICKEN1,
464 GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
467 static void glk_ctx_workarounds_init(struct intel_engine_cs *engine,
468 struct i915_wa_list *wal)
470 gen9_ctx_workarounds_init(engine, wal);
472 /* WaToEnableHwFixForPushConstHWBug:glk */
473 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
474 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
477 static void cfl_ctx_workarounds_init(struct intel_engine_cs *engine,
478 struct i915_wa_list *wal)
480 gen9_ctx_workarounds_init(engine, wal);
482 /* WaToEnableHwFixForPushConstHWBug:cfl */
483 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
484 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
486 /* WaDisableSbeCacheDispatchPortSharing:cfl */
487 WA_SET_BIT_MASKED(GEN7_HALF_SLICE_CHICKEN1,
488 GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
491 static void cnl_ctx_workarounds_init(struct intel_engine_cs *engine,
492 struct i915_wa_list *wal)
494 /* WaForceContextSaveRestoreNonCoherent:cnl */
495 WA_SET_BIT_MASKED(CNL_HDC_CHICKEN0,
496 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT);
498 /* WaDisableReplayBufferBankArbitrationOptimization:cnl */
499 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
500 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
502 /* WaPushConstantDereferenceHoldDisable:cnl */
503 WA_SET_BIT_MASKED(GEN7_ROW_CHICKEN2, PUSH_CONSTANT_DEREF_DISABLE);
505 /* FtrEnableFastAnisoL1BankingFix:cnl */
506 WA_SET_BIT_MASKED(HALF_SLICE_CHICKEN3, CNL_FAST_ANISO_L1_BANKING_FIX);
508 /* WaDisable3DMidCmdPreemption:cnl */
509 WA_CLR_BIT_MASKED(GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
511 /* WaDisableGPGPUMidCmdPreemption:cnl */
512 WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
513 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
514 GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);
516 /* WaDisableEarlyEOT:cnl */
517 WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN, DISABLE_EARLY_EOT);
520 static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
521 struct i915_wa_list *wal)
523 struct drm_i915_private *i915 = engine->i915;
525 /* WaDisableBankHangMode:icl */
528 intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
531 /* Wa_1604370585:icl (pre-prod)
532 * Formerly known as WaPushConstantDereferenceHoldDisable
534 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
535 WA_SET_BIT_MASKED(GEN7_ROW_CHICKEN2,
536 PUSH_CONSTANT_DEREF_DISABLE);
538 /* WaForceEnableNonCoherent:icl
539 * This is not the same workaround as in early Gen9 platforms, where
540 * lacking this could cause system hangs, but coherency performance
541 * overhead is high and only a few compute workloads really need it
542 * (the register is whitelisted in hardware now, so UMDs can opt in
543 * for coherency if they have a good reason).
545 WA_SET_BIT_MASKED(ICL_HDC_MODE, HDC_FORCE_NON_COHERENT);
547 /* Wa_2006611047:icl (pre-prod)
548 * Formerly known as WaDisableImprovedTdlClkGating
550 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
551 WA_SET_BIT_MASKED(GEN7_ROW_CHICKEN2,
552 GEN11_TDL_CLOCK_GATING_FIX_DISABLE);
554 /* Wa_2006665173:icl (pre-prod) */
555 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
556 WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
557 GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC);
559 /* WaEnableFloatBlendOptimization:icl */
560 wa_write_masked_or(wal,
562 0, /* write-only, so skip validation */
563 _MASKED_BIT_ENABLE(FLOAT_BLEND_OPTIMIZATION_ENABLE));
565 /* WaDisableGPGPUMidThreadPreemption:icl */
566 WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
567 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
568 GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
570 /* allow headerless messages for preemptible GPGPU context */
571 WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE,
572 GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
574 /* Wa_1604278689:icl,ehl */
575 wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
576 wa_write_masked_or(wal, IVB_FBC_RT_BASE_UPPER,
577 0, /* write-only register; skip validation */
580 /* Wa_1406306137:icl,ehl */
581 wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN11_DIS_PICK_2ND_EU);
584 static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
585 struct i915_wa_list *wal)
596 WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
597 GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
600 * Wa_1604555607:gen12 and Wa_1608008084:gen12
601 * FF_MODE2 register will return the wrong value when read. The default
602 * value for this register is zero for all fields and there are no bit
603 * masks. So instead of doing a RMW we should just write the TDS timer
604 * value for Wa_1604555607.
606 wa_add(wal, FF_MODE2, FF_MODE2_TDS_TIMER_MASK,
607 FF_MODE2_TDS_TIMER_128, 0);
609 /* WaDisableGPGPUMidThreadPreemption:tgl */
610 WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
611 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
612 GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
616 __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
617 struct i915_wa_list *wal,
620 struct drm_i915_private *i915 = engine->i915;
622 if (engine->class != RENDER_CLASS)
625 wa_init_start(wal, name, engine->name);
627 if (IS_GEN(i915, 12))
628 tgl_ctx_workarounds_init(engine, wal);
629 else if (IS_GEN(i915, 11))
630 icl_ctx_workarounds_init(engine, wal);
631 else if (IS_CANNONLAKE(i915))
632 cnl_ctx_workarounds_init(engine, wal);
633 else if (IS_COFFEELAKE(i915))
634 cfl_ctx_workarounds_init(engine, wal);
635 else if (IS_GEMINILAKE(i915))
636 glk_ctx_workarounds_init(engine, wal);
637 else if (IS_KABYLAKE(i915))
638 kbl_ctx_workarounds_init(engine, wal);
639 else if (IS_BROXTON(i915))
640 bxt_ctx_workarounds_init(engine, wal);
641 else if (IS_SKYLAKE(i915))
642 skl_ctx_workarounds_init(engine, wal);
643 else if (IS_CHERRYVIEW(i915))
644 chv_ctx_workarounds_init(engine, wal);
645 else if (IS_BROADWELL(i915))
646 bdw_ctx_workarounds_init(engine, wal);
647 else if (INTEL_GEN(i915) < 8)
650 MISSING_CASE(INTEL_GEN(i915));
655 void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
657 __intel_engine_init_ctx_wa(engine, &engine->ctx_wa_list, "context");
660 int intel_engine_emit_ctx_wa(struct i915_request *rq)
662 struct i915_wa_list *wal = &rq->engine->ctx_wa_list;
671 ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
675 cs = intel_ring_begin(rq, (wal->count * 2 + 2));
679 *cs++ = MI_LOAD_REGISTER_IMM(wal->count);
680 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
681 *cs++ = i915_mmio_reg_offset(wa->reg);
686 intel_ring_advance(rq, cs);
688 ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
696 snb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
698 /* WaDisableHiZPlanesWhenMSAAEnabled:snb */
701 _3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB);
703 /* WaDisable_RenderCache_OperationalFlush:snb */
704 wa_masked_dis(wal, CACHE_MODE_0, RC_OP_FLUSH_ENABLE);
707 * BSpec recommends 8x4 when MSAA is used,
708 * however in practice 16x4 seems fastest.
710 * Note that PS/WM thread counts depend on the WIZ hashing
711 * disable bit, which we don't touch here, but it's good
712 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
716 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
717 GEN6_WIZ_HASHING_16x4);
719 wa_masked_dis(wal, CACHE_MODE_0, CM0_STC_EVICT_DISABLE_LRA_SNB);
723 /* WaStripsFansDisableFastClipPerformanceFix:snb */
724 _3D_CHICKEN3_SF_DISABLE_FASTCLIP_CULL |
727 * "This bit must be set if 3DSTATE_CLIP clip mode is set
728 * to normal and 3DSTATE_SF number of SF output attributes
731 _3D_CHICKEN3_SF_DISABLE_PIPELINED_ATTR_FETCH);
735 ivb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
737 /* WaDisableEarlyCull:ivb */
738 wa_masked_en(wal, _3D_CHICKEN3, _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);
740 /* WaDisablePSDDualDispatchEnable:ivb */
741 if (IS_IVB_GT1(i915))
743 GEN7_HALF_SLICE_CHICKEN1,
744 GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
746 /* WaDisable_RenderCache_OperationalFlush:ivb */
747 wa_masked_dis(wal, CACHE_MODE_0_GEN7, RC_OP_FLUSH_ENABLE);
749 /* Apply the WaDisableRHWOOptimizationForRenderHang:ivb workaround. */
751 GEN7_COMMON_SLICE_CHICKEN1,
752 GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC);
754 /* WaApplyL3ControlAndL3ChickenMode:ivb */
755 wa_write(wal, GEN7_L3CNTLREG1, GEN7_WA_FOR_GEN7_L3_CONTROL);
756 wa_write(wal, GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE);
758 /* WaForceL3Serialization:ivb */
759 wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);
762 * WaVSThreadDispatchOverride:ivb,vlv
764 * This actually overrides the dispatch
765 * mode for all thread types.
767 wa_write_masked_or(wal, GEN7_FF_THREAD_MODE,
769 GEN7_FF_TS_SCHED_HW |
770 GEN7_FF_VS_SCHED_HW |
771 GEN7_FF_DS_SCHED_HW);
773 if (0) { /* causes HiZ corruption on ivb:gt1 */
774 /* enable HiZ Raw Stall Optimization */
775 wa_masked_dis(wal, CACHE_MODE_0_GEN7, HIZ_RAW_STALL_OPT_DISABLE);
778 /* WaDisable4x2SubspanOptimization:ivb */
779 wa_masked_en(wal, CACHE_MODE_1, PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
782 * BSpec recommends 8x4 when MSAA is used,
783 * however in practice 16x4 seems fastest.
785 * Note that PS/WM thread counts depend on the WIZ hashing
786 * disable bit, which we don't touch here, but it's good
787 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
789 wa_add(wal, GEN7_GT_MODE, 0,
790 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
791 GEN6_WIZ_HASHING_16x4);
795 vlv_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
797 /* WaDisableEarlyCull:vlv */
798 wa_masked_en(wal, _3D_CHICKEN3, _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);
800 /* WaPsdDispatchEnable:vlv */
801 /* WaDisablePSDDualDispatchEnable:vlv */
803 GEN7_HALF_SLICE_CHICKEN1,
804 GEN7_MAX_PS_THREAD_DEP |
805 GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
807 /* WaDisable_RenderCache_OperationalFlush:vlv */
808 wa_masked_dis(wal, CACHE_MODE_0_GEN7, RC_OP_FLUSH_ENABLE);
810 /* WaForceL3Serialization:vlv */
811 wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);
814 * WaVSThreadDispatchOverride:ivb,vlv
816 * This actually overrides the dispatch
817 * mode for all thread types.
819 wa_write_masked_or(wal,
822 GEN7_FF_TS_SCHED_HW |
823 GEN7_FF_VS_SCHED_HW |
824 GEN7_FF_DS_SCHED_HW);
827 * BSpec says this must be set, even though
828 * WaDisable4x2SubspanOptimization isn't listed for VLV.
830 wa_masked_en(wal, CACHE_MODE_1, PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
833 * BSpec recommends 8x4 when MSAA is used,
834 * however in practice 16x4 seems fastest.
836 * Note that PS/WM thread counts depend on the WIZ hashing
837 * disable bit, which we don't touch here, but it's good
838 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
840 wa_add(wal, GEN7_GT_MODE, 0,
841 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
842 GEN6_WIZ_HASHING_16x4);
845 * WaIncreaseL3CreditsForVLVB0:vlv
846 * This is the hardware default actually.
848 wa_write(wal, GEN7_L3SQCREG1, VLV_B0_WA_L3SQCREG1_VALUE);
852 hsw_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
854 /* L3 caching of data atomics doesn't work -- disable it. */
855 wa_write(wal, HSW_SCRATCH1, HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE);
859 _MASKED_BIT_ENABLE(HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE),
860 0 /* XXX does this reg exist? */);
862 /* WaVSRefCountFullforceMissDisable:hsw */
863 wa_write_clr(wal, GEN7_FF_THREAD_MODE, GEN7_FF_VS_REF_CNT_FFME);
867 /* WaDisable_RenderCache_OperationalFlush:hsw */
869 /* enable HiZ Raw Stall Optimization */
870 HIZ_RAW_STALL_OPT_DISABLE);
872 /* WaDisable4x2SubspanOptimization:hsw */
873 wa_masked_en(wal, CACHE_MODE_1, PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
876 * BSpec recommends 8x4 when MSAA is used,
877 * however in practice 16x4 seems fastest.
879 * Note that PS/WM thread counts depend on the WIZ hashing
880 * disable bit, which we don't touch here, but it's good
881 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
883 wa_add(wal, GEN7_GT_MODE, 0,
884 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
885 GEN6_WIZ_HASHING_16x4);
887 /* WaSampleCChickenBitEnable:hsw */
888 wa_masked_en(wal, HALF_SLICE_CHICKEN3, HSW_SAMPLE_C_PERFORMANCE);
892 gen9_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
894 /* WaDisableKillLogic:bxt,skl,kbl */
895 if (!IS_COFFEELAKE(i915))
901 /* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
903 * Must match Display Engine. See
904 * WaCompressedResourceDisplayNewHashMode.
908 MMCD_PCLA | MMCD_HOTSPOT_EN);
911 /* WaDisableHDCInvalidation:skl,bxt,kbl,cfl */
914 BDW_DISABLE_HDC_INVALIDATION);
918 skl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
920 gen9_gt_workarounds_init(i915, wal);
922 /* WaDisableGafsUnitClkGating:skl */
925 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
927 /* WaInPlaceDecompressionHang:skl */
928 if (IS_SKL_REVID(i915, SKL_REVID_H0, REVID_FOREVER))
930 GEN9_GAMT_ECO_REG_RW_IA,
931 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
935 bxt_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
937 gen9_gt_workarounds_init(i915, wal);
939 /* WaInPlaceDecompressionHang:bxt */
941 GEN9_GAMT_ECO_REG_RW_IA,
942 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
946 kbl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
948 gen9_gt_workarounds_init(i915, wal);
950 /* WaDisableDynamicCreditSharing:kbl */
951 if (IS_KBL_REVID(i915, 0, KBL_REVID_B0))
954 GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
956 /* WaDisableGafsUnitClkGating:kbl */
959 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
961 /* WaInPlaceDecompressionHang:kbl */
963 GEN9_GAMT_ECO_REG_RW_IA,
964 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
968 glk_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
970 gen9_gt_workarounds_init(i915, wal);
974 cfl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
976 gen9_gt_workarounds_init(i915, wal);
978 /* WaDisableGafsUnitClkGating:cfl */
981 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
983 /* WaInPlaceDecompressionHang:cfl */
985 GEN9_GAMT_ECO_REG_RW_IA,
986 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
990 wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
992 const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
993 unsigned int slice, subslice;
994 u32 l3_en, mcr, mcr_mask;
996 GEM_BUG_ON(INTEL_GEN(i915) < 10);
999 * WaProgramMgsrForL3BankSpecificMmioReads: cnl,icl
1000 * L3Banks could be fused off in single slice scenario. If that is
1001 * the case, we might need to program MCR select to a valid L3Bank
1002 * by default, to make sure we correctly read certain registers
1003 * later on (in the range 0xB100 - 0xB3FF).
1005 * WaProgramMgsrForCorrectSliceSpecificMmioReads:cnl,icl
1006 * Before any MMIO read into slice/subslice specific registers, MCR
1007 * packet control register needs to be programmed to point to any
1008 * enabled s/ss pair. Otherwise, incorrect values will be returned.
1009 * This means each subsequent MMIO read will be forwarded to an
1010 * specific s/ss combination, but this is OK since these registers
1011 * are consistent across s/ss in almost all cases. In the rare
1012 * occasions, such as INSTDONE, where this value is dependent
1013 * on s/ss combo, the read should be done with read_subslice_reg.
1015 * Since GEN8_MCR_SELECTOR contains dual-purpose bits which select both
1016 * to which subslice, or to which L3 bank, the respective mmio reads
1017 * will go, we have to find a common index which works for both
1020 * Case where we cannot find a common index fortunately should not
1021 * happen in production hardware, so we only emit a warning instead of
1022 * implementing something more complex that requires checking the range
1023 * of every MMIO read.
1026 if (INTEL_GEN(i915) >= 10 && is_power_of_2(sseu->slice_mask)) {
1028 intel_uncore_read(&i915->uncore, GEN10_MIRROR_FUSE3) &
1031 drm_dbg(&i915->drm, "L3 fuse = %x\n", l3_fuse);
1032 l3_en = ~(l3_fuse << GEN10_L3BANK_PAIR_COUNT | l3_fuse);
1037 slice = fls(sseu->slice_mask) - 1;
1038 subslice = fls(l3_en & intel_sseu_get_subslices(sseu, slice));
1040 drm_warn(&i915->drm,
1041 "No common index found between subslice mask %x and L3 bank mask %x!\n",
1042 intel_sseu_get_subslices(sseu, slice), l3_en);
1043 subslice = fls(l3_en);
1044 drm_WARN_ON(&i915->drm, !subslice);
1048 if (INTEL_GEN(i915) >= 11) {
1049 mcr = GEN11_MCR_SLICE(slice) | GEN11_MCR_SUBSLICE(subslice);
1050 mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
1052 mcr = GEN8_MCR_SLICE(slice) | GEN8_MCR_SUBSLICE(subslice);
1053 mcr_mask = GEN8_MCR_SLICE_MASK | GEN8_MCR_SUBSLICE_MASK;
1056 drm_dbg(&i915->drm, "MCR slice/subslice = %x\n", mcr);
1058 wa_write_masked_or(wal, GEN8_MCR_SELECTOR, mcr_mask, mcr);
1062 cnl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1064 wa_init_mcr(i915, wal);
1066 /* WaInPlaceDecompressionHang:cnl */
1068 GEN9_GAMT_ECO_REG_RW_IA,
1069 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1073 icl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1075 wa_init_mcr(i915, wal);
1077 /* WaInPlaceDecompressionHang:icl */
1079 GEN9_GAMT_ECO_REG_RW_IA,
1080 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1082 /* WaModifyGamTlbPartitioning:icl */
1083 wa_write_masked_or(wal,
1084 GEN11_GACB_PERF_CTRL,
1085 GEN11_HASH_CTRL_MASK,
1086 GEN11_HASH_CTRL_BIT0 | GEN11_HASH_CTRL_BIT4);
1088 /* Wa_1405766107:icl
1089 * Formerly known as WaCL2SFHalfMaxAlloc
1093 GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC |
1094 GEN11_LSN_UNSLCVC_GAFS_HALF_CL2_MAXALLOC);
1097 * Formerly known as WaDisCtxReload
1100 GEN8_GAMW_ECO_DEV_RW_IA,
1101 GAMW_ECO_DEV_CTX_RELOAD_DISABLE);
1103 /* Wa_1405779004:icl (pre-prod) */
1104 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
1106 SLICE_UNIT_LEVEL_CLKGATE,
1107 MSCUNIT_CLKGATE_DIS);
1109 /* Wa_1406838659:icl (pre-prod) */
1110 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
1112 INF_UNIT_LEVEL_CLKGATE,
1115 /* Wa_1406463099:icl
1116 * Formerly known as WaGamTlbPendError
1120 GAMT_CHKN_DISABLE_L3_COH_PIPE);
1122 /* Wa_1607087056:icl,ehl,jsl */
1123 if (IS_ICELAKE(i915) ||
1124 IS_EHL_REVID(i915, EHL_REVID_A0, EHL_REVID_A0)) {
1126 SLICE_UNIT_LEVEL_CLKGATE,
1127 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1132 tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1134 wa_init_mcr(i915, wal);
1136 /* Wa_1409420604:tgl */
1137 if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
1139 SUBSLICE_UNIT_LEVEL_CLKGATE2,
1140 CPSSUNIT_CLKGATE_DIS);
1142 /* Wa_1607087056:tgl also know as BUG:1409180338 */
1143 if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
1145 SLICE_UNIT_LEVEL_CLKGATE,
1146 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1150 gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
1152 if (IS_GEN(i915, 12))
1153 tgl_gt_workarounds_init(i915, wal);
1154 else if (IS_GEN(i915, 11))
1155 icl_gt_workarounds_init(i915, wal);
1156 else if (IS_CANNONLAKE(i915))
1157 cnl_gt_workarounds_init(i915, wal);
1158 else if (IS_COFFEELAKE(i915))
1159 cfl_gt_workarounds_init(i915, wal);
1160 else if (IS_GEMINILAKE(i915))
1161 glk_gt_workarounds_init(i915, wal);
1162 else if (IS_KABYLAKE(i915))
1163 kbl_gt_workarounds_init(i915, wal);
1164 else if (IS_BROXTON(i915))
1165 bxt_gt_workarounds_init(i915, wal);
1166 else if (IS_SKYLAKE(i915))
1167 skl_gt_workarounds_init(i915, wal);
1168 else if (IS_HASWELL(i915))
1169 hsw_gt_workarounds_init(i915, wal);
1170 else if (IS_VALLEYVIEW(i915))
1171 vlv_gt_workarounds_init(i915, wal);
1172 else if (IS_IVYBRIDGE(i915))
1173 ivb_gt_workarounds_init(i915, wal);
1174 else if (IS_GEN(i915, 6))
1175 snb_gt_workarounds_init(i915, wal);
1176 else if (INTEL_GEN(i915) <= 8)
1179 MISSING_CASE(INTEL_GEN(i915));
1182 void intel_gt_init_workarounds(struct drm_i915_private *i915)
1184 struct i915_wa_list *wal = &i915->gt_wa_list;
1186 wa_init_start(wal, "GT", "global");
1187 gt_init_workarounds(i915, wal);
1188 wa_init_finish(wal);
1191 static enum forcewake_domains
1192 wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)
1194 enum forcewake_domains fw = 0;
1198 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1199 fw |= intel_uncore_forcewake_for_reg(uncore,
1208 wa_verify(const struct i915_wa *wa, u32 cur, const char *name, const char *from)
1210 if ((cur ^ wa->set) & wa->read) {
1211 DRM_ERROR("%s workaround lost on %s! (%x=%x/%x, expected %x)\n",
1212 name, from, i915_mmio_reg_offset(wa->reg),
1213 cur, cur & wa->read, wa->set);
1222 wa_list_apply(struct intel_uncore *uncore, const struct i915_wa_list *wal)
1224 enum forcewake_domains fw;
1225 unsigned long flags;
1232 fw = wal_get_fw_for_rmw(uncore, wal);
1234 spin_lock_irqsave(&uncore->lock, flags);
1235 intel_uncore_forcewake_get__locked(uncore, fw);
1237 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1239 intel_uncore_rmw_fw(uncore, wa->reg, wa->clr, wa->set);
1241 intel_uncore_write_fw(uncore, wa->reg, wa->set);
1242 if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
1244 intel_uncore_read_fw(uncore, wa->reg),
1245 wal->name, "application");
1248 intel_uncore_forcewake_put__locked(uncore, fw);
1249 spin_unlock_irqrestore(&uncore->lock, flags);
1252 void intel_gt_apply_workarounds(struct intel_gt *gt)
1254 wa_list_apply(gt->uncore, >->i915->gt_wa_list);
1257 static bool wa_list_verify(struct intel_uncore *uncore,
1258 const struct i915_wa_list *wal,
1265 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1267 intel_uncore_read(uncore, wa->reg),
1273 bool intel_gt_verify_workarounds(struct intel_gt *gt, const char *from)
1275 return wa_list_verify(gt->uncore, >->i915->gt_wa_list, from);
1278 static inline bool is_nonpriv_flags_valid(u32 flags)
1280 /* Check only valid flag bits are set */
1281 if (flags & ~RING_FORCE_TO_NONPRIV_MASK_VALID)
1284 /* NB: Only 3 out of 4 enum values are valid for access field */
1285 if ((flags & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
1286 RING_FORCE_TO_NONPRIV_ACCESS_INVALID)
1293 whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
1295 struct i915_wa wa = {
1299 if (GEM_DEBUG_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
1302 if (GEM_DEBUG_WARN_ON(!is_nonpriv_flags_valid(flags)))
1305 wa.reg.reg |= flags;
1310 whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
1312 whitelist_reg_ext(wal, reg, RING_FORCE_TO_NONPRIV_ACCESS_RW);
1315 static void gen9_whitelist_build(struct i915_wa_list *w)
1317 /* WaVFEStateAfterPipeControlwithMediaStateClear:skl,bxt,glk,cfl */
1318 whitelist_reg(w, GEN9_CTX_PREEMPT_REG);
1320 /* WaEnablePreemptionGranularityControlByUMD:skl,bxt,kbl,cfl,[cnl] */
1321 whitelist_reg(w, GEN8_CS_CHICKEN1);
1323 /* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
1324 whitelist_reg(w, GEN8_HDC_CHICKEN1);
1326 /* WaSendPushConstantsFromMMIO:skl,bxt */
1327 whitelist_reg(w, COMMON_SLICE_CHICKEN2);
1330 static void skl_whitelist_build(struct intel_engine_cs *engine)
1332 struct i915_wa_list *w = &engine->whitelist;
1334 if (engine->class != RENDER_CLASS)
1337 gen9_whitelist_build(w);
1339 /* WaDisableLSQCROPERFforOCL:skl */
1340 whitelist_reg(w, GEN8_L3SQCREG4);
1343 static void bxt_whitelist_build(struct intel_engine_cs *engine)
1345 if (engine->class != RENDER_CLASS)
1348 gen9_whitelist_build(&engine->whitelist);
1351 static void kbl_whitelist_build(struct intel_engine_cs *engine)
1353 struct i915_wa_list *w = &engine->whitelist;
1355 if (engine->class != RENDER_CLASS)
1358 gen9_whitelist_build(w);
1360 /* WaDisableLSQCROPERFforOCL:kbl */
1361 whitelist_reg(w, GEN8_L3SQCREG4);
1364 static void glk_whitelist_build(struct intel_engine_cs *engine)
1366 struct i915_wa_list *w = &engine->whitelist;
1368 if (engine->class != RENDER_CLASS)
1371 gen9_whitelist_build(w);
1373 /* WA #0862: Userspace has to set "Barrier Mode" to avoid hangs. */
1374 whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1377 static void cfl_whitelist_build(struct intel_engine_cs *engine)
1379 struct i915_wa_list *w = &engine->whitelist;
1381 if (engine->class != RENDER_CLASS)
1384 gen9_whitelist_build(w);
1387 * WaAllowPMDepthAndInvocationCountAccessFromUMD:cfl,whl,cml,aml
1389 * This covers 4 register which are next to one another :
1390 * - PS_INVOCATION_COUNT
1391 * - PS_INVOCATION_COUNT_UDW
1393 * - PS_DEPTH_COUNT_UDW
1395 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1396 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1397 RING_FORCE_TO_NONPRIV_RANGE_4);
1400 static void cnl_whitelist_build(struct intel_engine_cs *engine)
1402 struct i915_wa_list *w = &engine->whitelist;
1404 if (engine->class != RENDER_CLASS)
1407 /* WaEnablePreemptionGranularityControlByUMD:cnl */
1408 whitelist_reg(w, GEN8_CS_CHICKEN1);
1411 static void icl_whitelist_build(struct intel_engine_cs *engine)
1413 struct i915_wa_list *w = &engine->whitelist;
1415 switch (engine->class) {
1417 /* WaAllowUMDToModifyHalfSliceChicken7:icl */
1418 whitelist_reg(w, GEN9_HALF_SLICE_CHICKEN7);
1420 /* WaAllowUMDToModifySamplerMode:icl */
1421 whitelist_reg(w, GEN10_SAMPLER_MODE);
1423 /* WaEnableStateCacheRedirectToCS:icl */
1424 whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1427 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
1429 * This covers 4 register which are next to one another :
1430 * - PS_INVOCATION_COUNT
1431 * - PS_INVOCATION_COUNT_UDW
1433 * - PS_DEPTH_COUNT_UDW
1435 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1436 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1437 RING_FORCE_TO_NONPRIV_RANGE_4);
1440 case VIDEO_DECODE_CLASS:
1441 /* hucStatusRegOffset */
1442 whitelist_reg_ext(w, _MMIO(0x2000 + engine->mmio_base),
1443 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1444 /* hucUKernelHdrInfoRegOffset */
1445 whitelist_reg_ext(w, _MMIO(0x2014 + engine->mmio_base),
1446 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1447 /* hucStatus2RegOffset */
1448 whitelist_reg_ext(w, _MMIO(0x23B0 + engine->mmio_base),
1449 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1457 static void tgl_whitelist_build(struct intel_engine_cs *engine)
1459 struct i915_wa_list *w = &engine->whitelist;
1461 switch (engine->class) {
1464 * WaAllowPMDepthAndInvocationCountAccessFromUMD:tgl
1467 * This covers 4 registers which are next to one another :
1468 * - PS_INVOCATION_COUNT
1469 * - PS_INVOCATION_COUNT_UDW
1471 * - PS_DEPTH_COUNT_UDW
1473 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1474 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1475 RING_FORCE_TO_NONPRIV_RANGE_4);
1477 /* Wa_1808121037:tgl */
1478 whitelist_reg(w, GEN7_COMMON_SLICE_CHICKEN1);
1480 /* Wa_1806527549:tgl */
1481 whitelist_reg(w, HIZ_CHICKEN);
1488 void intel_engine_init_whitelist(struct intel_engine_cs *engine)
1490 struct drm_i915_private *i915 = engine->i915;
1491 struct i915_wa_list *w = &engine->whitelist;
1493 wa_init_start(w, "whitelist", engine->name);
1495 if (IS_GEN(i915, 12))
1496 tgl_whitelist_build(engine);
1497 else if (IS_GEN(i915, 11))
1498 icl_whitelist_build(engine);
1499 else if (IS_CANNONLAKE(i915))
1500 cnl_whitelist_build(engine);
1501 else if (IS_COFFEELAKE(i915))
1502 cfl_whitelist_build(engine);
1503 else if (IS_GEMINILAKE(i915))
1504 glk_whitelist_build(engine);
1505 else if (IS_KABYLAKE(i915))
1506 kbl_whitelist_build(engine);
1507 else if (IS_BROXTON(i915))
1508 bxt_whitelist_build(engine);
1509 else if (IS_SKYLAKE(i915))
1510 skl_whitelist_build(engine);
1511 else if (INTEL_GEN(i915) <= 8)
1514 MISSING_CASE(INTEL_GEN(i915));
1519 void intel_engine_apply_whitelist(struct intel_engine_cs *engine)
1521 const struct i915_wa_list *wal = &engine->whitelist;
1522 struct intel_uncore *uncore = engine->uncore;
1523 const u32 base = engine->mmio_base;
1530 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1531 intel_uncore_write(uncore,
1532 RING_FORCE_TO_NONPRIV(base, i),
1533 i915_mmio_reg_offset(wa->reg));
1535 /* And clear the rest just in case of garbage */
1536 for (; i < RING_MAX_NONPRIV_SLOTS; i++)
1537 intel_uncore_write(uncore,
1538 RING_FORCE_TO_NONPRIV(base, i),
1539 i915_mmio_reg_offset(RING_NOPID(base)));
1543 rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
1545 struct drm_i915_private *i915 = engine->i915;
1547 if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0)) {
1553 GEN9_CTX_PREEMPT_REG,
1554 GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
1559 * Wa_1607297627:tgl there is 3 entries for this WA on BSpec, 2
1560 * of then says it is fixed on B0 the other one says it is
1564 GEN6_RC_SLEEP_PSMI_CONTROL,
1565 GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
1566 GEN8_RC_SEMA_IDLE_MSG_DISABLE);
1570 * (see also Wa_1606682166:icl)
1574 GEN7_DISABLE_SAMPLER_PREFETCH);
1576 /* Wa_1407928979:tgl */
1578 GEN7_FF_THREAD_MODE,
1579 GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
1581 /* Wa_1408615072:tgl */
1582 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1583 VSUNIT_CLKGATE_DIS_TGL);
1586 if (IS_TIGERLAKE(i915)) {
1587 /* Wa_1606931601:tgl */
1588 wa_masked_en(wal, GEN7_ROW_CHICKEN2, GEN12_DISABLE_EARLY_READ);
1590 /* Wa_1409804808:tgl */
1591 wa_masked_en(wal, GEN7_ROW_CHICKEN2,
1592 GEN12_PUSH_CONST_DEREF_HOLD_DIS);
1594 /* Wa_1606700617:tgl */
1596 GEN9_CS_DEBUG_MODE1,
1597 FF_DOP_CLOCK_GATE_DISABLE);
1601 * Wa_14010229206:tgl
1603 wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
1606 if (IS_GEN(i915, 11)) {
1607 /* This is not an Wa. Enable for better image quality */
1610 _3D_CHICKEN3_AA_LINE_QUALITY_FIX_ENABLE);
1612 /* WaPipelineFlushCoherentLines:icl */
1615 GEN8_LQSC_FLUSH_COHERENT_LINES);
1619 * Formerly known as WaGAPZPriorityScheme
1623 GEN11_ARBITRATION_PRIO_ORDER_MASK);
1627 * Formerly known as WaL3BankAddressHashing
1629 wa_write_masked_or(wal,
1631 GEN11_HASH_CTRL_EXCL_MASK,
1632 GEN11_HASH_CTRL_EXCL_BIT0);
1633 wa_write_masked_or(wal,
1635 GEN11_BANK_HASH_ADDR_EXCL_MASK,
1636 GEN11_BANK_HASH_ADDR_EXCL_BIT0);
1640 * Formerly known as WaDisableCleanEvicts
1644 GEN11_LQSC_CLEAN_EVICT_DISABLE);
1646 /* WaForwardProgressSoftReset:icl */
1648 GEN10_SCRATCH_LNCF2,
1649 PMFLUSHDONE_LNICRSDROP |
1650 PMFLUSH_GAPL3UNBLOCK |
1651 PMFLUSHDONE_LNEBLK);
1653 /* Wa_1406609255:icl (pre-prod) */
1654 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
1657 GEN7_DISABLE_DEMAND_PREFETCH);
1659 /* Wa_1606682166:icl */
1662 GEN7_DISABLE_SAMPLER_PREFETCH);
1664 /* Wa_1409178092:icl */
1665 wa_write_masked_or(wal,
1667 GEN11_COHERENT_PARTIAL_WRITE_MERGE_ENABLE,
1670 /* WaEnable32PlaneMode:icl */
1671 wa_masked_en(wal, GEN9_CSFE_CHICKEN1_RCS,
1672 GEN11_ENABLE_32_PLANE_MODE);
1675 * Wa_1408615072:icl,ehl (vsunit)
1676 * Wa_1407596294:icl,ehl (hsunit)
1678 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE,
1679 VSUNIT_CLKGATE_DIS | HSUNIT_CLKGATE_DIS);
1681 /* Wa_1407352427:icl,ehl */
1682 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1683 PSDUNIT_CLKGATE_DIS);
1685 /* Wa_1406680159:icl,ehl */
1687 SUBSLICE_UNIT_LEVEL_CLKGATE,
1688 GWUNIT_CLKGATE_DIS);
1691 * Wa_1408767742:icl[a2..forever],ehl[all]
1692 * Wa_1605460711:icl[a0..c0]
1695 GEN7_FF_THREAD_MODE,
1696 GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
1699 if (IS_GEN_RANGE(i915, 9, 12)) {
1700 /* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl,tgl */
1702 GEN7_FF_SLICE_CS_CHICKEN1,
1703 GEN9_FFSC_PERCTX_PREEMPT_CTRL);
1706 if (IS_SKYLAKE(i915) || IS_KABYLAKE(i915) || IS_COFFEELAKE(i915)) {
1707 /* WaEnableGapsTsvCreditFix:skl,kbl,cfl */
1710 GEN9_GAPS_TSV_CREDIT_DISABLE);
1713 if (IS_BROXTON(i915)) {
1714 /* WaDisablePooledEuLoadBalancingFix:bxt */
1716 FF_SLICE_CS_CHICKEN2,
1717 GEN9_POOLED_EU_LOAD_BALANCING_FIX_DISABLE);
1720 if (IS_GEN(i915, 9)) {
1721 /* WaContextSwitchWithConcurrentTLBInvalidate:skl,bxt,kbl,glk,cfl */
1723 GEN9_CSFE_CHICKEN1_RCS,
1724 GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE);
1726 /* WaEnableLbsSlaRetryTimerDecrement:skl,bxt,kbl,glk,cfl */
1729 GEN9_LBS_SLA_RETRY_TIMER_DECREMENT_ENABLE);
1731 /* WaProgramL3SqcReg1DefaultForPerf:bxt,glk */
1732 if (IS_GEN9_LP(i915))
1733 wa_write_masked_or(wal,
1735 L3_PRIO_CREDITS_MASK,
1736 L3_GENERAL_PRIO_CREDITS(62) |
1737 L3_HIGH_PRIO_CREDITS(2));
1739 /* WaOCLCoherentLineFlush:skl,bxt,kbl,cfl */
1742 GEN8_LQSC_FLUSH_COHERENT_LINES);
1745 if (IS_GEN(i915, 7))
1746 /* WaBCSVCSTlbInvalidationMode:ivb,vlv,hsw */
1749 GFX_TLB_INVALIDATE_EXPLICIT | GFX_REPLAY_MODE);
1751 if (IS_GEN_RANGE(i915, 6, 7))
1753 * We need to disable the AsyncFlip performance optimisations in
1754 * order to use MI_WAIT_FOR_EVENT within the CS. It should
1755 * already be programmed to '1' on all products.
1757 * WaDisableAsyncFlipPerfMode:snb,ivb,hsw,vlv
1761 ASYNC_FLIP_PERF_DISABLE);
1763 if (IS_GEN(i915, 6)) {
1765 * Required for the hardware to program scanline values for
1767 * WaEnableFlushTlbInvalidationMode:snb
1771 GFX_TLB_INVALIDATE_EXPLICIT);
1774 * From the Sandybridge PRM, volume 1 part 3, page 24:
1775 * "If this bit is set, STCunit will have LRA as replacement
1776 * policy. [...] This bit must be reset. LRA replacement
1777 * policy is not supported."
1781 CM0_STC_EVICT_DISABLE_LRA_SNB);
1784 if (IS_GEN_RANGE(i915, 4, 6))
1785 /* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */
1786 wa_add(wal, MI_MODE,
1787 0, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH),
1788 /* XXX bit doesn't stick on Broadwater */
1789 IS_I965G(i915) ? 0 : VS_TIMER_DISPATCH);
1793 xcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
1795 struct drm_i915_private *i915 = engine->i915;
1797 /* WaKBLVECSSemaphoreWaitPoll:kbl */
1798 if (IS_KBL_REVID(i915, KBL_REVID_A0, KBL_REVID_E0)) {
1800 RING_SEMA_WAIT_POLL(engine->mmio_base),
1806 engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal)
1808 if (I915_SELFTEST_ONLY(INTEL_GEN(engine->i915) < 4))
1811 if (engine->class == RENDER_CLASS)
1812 rcs_engine_wa_init(engine, wal);
1814 xcs_engine_wa_init(engine, wal);
1817 void intel_engine_init_workarounds(struct intel_engine_cs *engine)
1819 struct i915_wa_list *wal = &engine->wa_list;
1821 if (INTEL_GEN(engine->i915) < 4)
1824 wa_init_start(wal, "engine", engine->name);
1825 engine_init_workarounds(engine, wal);
1826 wa_init_finish(wal);
1829 void intel_engine_apply_workarounds(struct intel_engine_cs *engine)
1831 wa_list_apply(engine->uncore, &engine->wa_list);
1834 static struct i915_vma *
1835 create_scratch(struct i915_address_space *vm, int count)
1837 struct drm_i915_gem_object *obj;
1838 struct i915_vma *vma;
1842 size = round_up(count * sizeof(u32), PAGE_SIZE);
1843 obj = i915_gem_object_create_internal(vm->i915, size);
1845 return ERR_CAST(obj);
1847 i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC);
1849 vma = i915_vma_instance(obj, vm, NULL);
1855 err = i915_vma_pin(vma, 0, 0,
1856 i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);
1863 i915_gem_object_put(obj);
1864 return ERR_PTR(err);
1867 static const struct {
1870 } mcr_ranges_gen8[] = {
1871 { .start = 0x5500, .end = 0x55ff },
1872 { .start = 0x7000, .end = 0x7fff },
1873 { .start = 0x9400, .end = 0x97ff },
1874 { .start = 0xb000, .end = 0xb3ff },
1875 { .start = 0xe000, .end = 0xe7ff },
1879 static bool mcr_range(struct drm_i915_private *i915, u32 offset)
1883 if (INTEL_GEN(i915) < 8)
1887 * Registers in these ranges are affected by the MCR selector
1888 * which only controls CPU initiated MMIO. Routing does not
1889 * work for CS access so we cannot verify them on this path.
1891 for (i = 0; mcr_ranges_gen8[i].start; i++)
1892 if (offset >= mcr_ranges_gen8[i].start &&
1893 offset <= mcr_ranges_gen8[i].end)
1900 wa_list_srm(struct i915_request *rq,
1901 const struct i915_wa_list *wal,
1902 struct i915_vma *vma)
1904 struct drm_i915_private *i915 = rq->i915;
1905 unsigned int i, count = 0;
1906 const struct i915_wa *wa;
1909 srm = MI_STORE_REGISTER_MEM | MI_SRM_LRM_GLOBAL_GTT;
1910 if (INTEL_GEN(i915) >= 8)
1913 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1914 if (!mcr_range(i915, i915_mmio_reg_offset(wa->reg)))
1918 cs = intel_ring_begin(rq, 4 * count);
1922 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1923 u32 offset = i915_mmio_reg_offset(wa->reg);
1925 if (mcr_range(i915, offset))
1930 *cs++ = i915_ggtt_offset(vma) + sizeof(u32) * i;
1933 intel_ring_advance(rq, cs);
1938 static int engine_wa_list_verify(struct intel_context *ce,
1939 const struct i915_wa_list * const wal,
1942 const struct i915_wa *wa;
1943 struct i915_request *rq;
1944 struct i915_vma *vma;
1952 vma = create_scratch(&ce->engine->gt->ggtt->vm, wal->count);
1954 return PTR_ERR(vma);
1956 intel_engine_pm_get(ce->engine);
1957 rq = intel_context_create_request(ce);
1958 intel_engine_pm_put(ce->engine);
1965 err = i915_request_await_object(rq, vma->obj, true);
1967 err = i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
1968 i915_vma_unlock(vma);
1970 i915_request_add(rq);
1974 err = wa_list_srm(rq, wal, vma);
1978 i915_request_get(rq);
1979 i915_request_add(rq);
1980 if (i915_request_wait(rq, 0, HZ / 5) < 0) {
1985 results = i915_gem_object_pin_map(vma->obj, I915_MAP_WB);
1986 if (IS_ERR(results)) {
1987 err = PTR_ERR(results);
1992 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1993 if (mcr_range(rq->i915, i915_mmio_reg_offset(wa->reg)))
1996 if (!wa_verify(wa, results[i], wal->name, from))
2000 i915_gem_object_unpin_map(vma->obj);
2003 i915_request_put(rq);
2005 i915_vma_unpin(vma);
2010 int intel_engine_verify_workarounds(struct intel_engine_cs *engine,
2013 return engine_wa_list_verify(engine->kernel_context,
2018 #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
2019 #include "selftest_workarounds.c"