1 // SPDX-License-Identifier: GPL-2.0-only
3 * Analog Devices ADV7511 HDMI transmitter driver
5 * Copyright 2012 Analog Devices Inc.
9 #include <linux/device.h>
10 #include <linux/gpio/consumer.h>
11 #include <linux/module.h>
13 #include <linux/slab.h>
15 #include <media/cec.h>
17 #include <drm/drm_atomic.h>
18 #include <drm/drm_atomic_helper.h>
19 #include <drm/drm_edid.h>
20 #include <drm/drm_print.h>
21 #include <drm/drm_probe_helper.h>
25 /* ADI recommended values for proper operation. */
26 static const struct reg_sequence adv7511_fixed_registers[] = {
38 /* -----------------------------------------------------------------------------
42 static const uint8_t adv7511_register_defaults[] = {
43 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 00 */
44 0x00, 0x00, 0x01, 0x0e, 0xbc, 0x18, 0x01, 0x13,
45 0x25, 0x37, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 10 */
46 0x46, 0x62, 0x04, 0xa8, 0x00, 0x00, 0x1c, 0x84,
47 0x1c, 0xbf, 0x04, 0xa8, 0x1e, 0x70, 0x02, 0x1e, /* 20 */
48 0x00, 0x00, 0x04, 0xa8, 0x08, 0x12, 0x1b, 0xac,
49 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 30 */
50 0x00, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 0xb0,
51 0x00, 0x50, 0x90, 0x7e, 0x79, 0x70, 0x00, 0x00, /* 40 */
52 0x00, 0xa8, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
53 0x00, 0x00, 0x02, 0x0d, 0x00, 0x00, 0x00, 0x00, /* 50 */
54 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
55 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 60 */
56 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
57 0x01, 0x0a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 70 */
58 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
59 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 80 */
60 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
61 0x00, 0x00, 0x00, 0x00, 0xc0, 0x00, 0x00, 0x00, /* 90 */
62 0x0b, 0x02, 0x00, 0x18, 0x5a, 0x60, 0x00, 0x00,
63 0x00, 0x00, 0x80, 0x80, 0x08, 0x04, 0x00, 0x00, /* a0 */
64 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x40, 0x14,
65 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* b0 */
66 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
67 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* c0 */
68 0x00, 0x03, 0x00, 0x00, 0x02, 0x00, 0x01, 0x04,
69 0x30, 0xff, 0x80, 0x80, 0x80, 0x00, 0x00, 0x00, /* d0 */
70 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x01,
71 0x80, 0x75, 0x00, 0x00, 0x60, 0x00, 0x00, 0x00, /* e0 */
72 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
73 0x00, 0x00, 0x00, 0x00, 0x00, 0x75, 0x11, 0x00, /* f0 */
74 0x00, 0x7c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
77 static bool adv7511_register_volatile(struct device *dev, unsigned int reg)
80 case ADV7511_REG_CHIP_REVISION:
81 case ADV7511_REG_SPDIF_FREQ:
82 case ADV7511_REG_CTS_AUTOMATIC1:
83 case ADV7511_REG_CTS_AUTOMATIC2:
84 case ADV7511_REG_VIC_DETECTED:
85 case ADV7511_REG_VIC_SEND:
86 case ADV7511_REG_AUX_VIC_DETECTED:
87 case ADV7511_REG_STATUS:
88 case ADV7511_REG_GC(1):
89 case ADV7511_REG_INT(0):
90 case ADV7511_REG_INT(1):
91 case ADV7511_REG_PLL_STATUS:
92 case ADV7511_REG_AN(0):
93 case ADV7511_REG_AN(1):
94 case ADV7511_REG_AN(2):
95 case ADV7511_REG_AN(3):
96 case ADV7511_REG_AN(4):
97 case ADV7511_REG_AN(5):
98 case ADV7511_REG_AN(6):
99 case ADV7511_REG_AN(7):
100 case ADV7511_REG_HDCP_STATUS:
101 case ADV7511_REG_BCAPS:
102 case ADV7511_REG_BKSV(0):
103 case ADV7511_REG_BKSV(1):
104 case ADV7511_REG_BKSV(2):
105 case ADV7511_REG_BKSV(3):
106 case ADV7511_REG_BKSV(4):
107 case ADV7511_REG_DDC_STATUS:
108 case ADV7511_REG_EDID_READ_CTRL:
109 case ADV7511_REG_BSTATUS(0):
110 case ADV7511_REG_BSTATUS(1):
111 case ADV7511_REG_CHIP_ID_HIGH:
112 case ADV7511_REG_CHIP_ID_LOW:
119 static const struct regmap_config adv7511_regmap_config = {
123 .max_register = 0xff,
124 .cache_type = REGCACHE_MAPLE,
125 .reg_defaults_raw = adv7511_register_defaults,
126 .num_reg_defaults_raw = ARRAY_SIZE(adv7511_register_defaults),
128 .volatile_reg = adv7511_register_volatile,
131 /* -----------------------------------------------------------------------------
132 * Hardware configuration
135 static void adv7511_set_colormap(struct adv7511 *adv7511, bool enable,
136 const uint16_t *coeff,
137 unsigned int scaling_factor)
141 regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(1),
142 ADV7511_CSC_UPDATE_MODE, ADV7511_CSC_UPDATE_MODE);
145 for (i = 0; i < 12; ++i) {
146 regmap_update_bits(adv7511->regmap,
147 ADV7511_REG_CSC_UPPER(i),
148 0x1f, coeff[i] >> 8);
149 regmap_write(adv7511->regmap,
150 ADV7511_REG_CSC_LOWER(i),
156 regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(0),
157 0xe0, 0x80 | (scaling_factor << 5));
159 regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(0),
162 regmap_update_bits(adv7511->regmap, ADV7511_REG_CSC_UPPER(1),
163 ADV7511_CSC_UPDATE_MODE, 0);
166 static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet)
169 regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
172 if (packet & 0xff00) {
174 regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE1,
181 static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet)
184 regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
187 if (packet & 0xff00) {
189 regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE1,
196 /* Coefficients for adv7511 color space conversion */
197 static const uint16_t adv7511_csc_ycbcr_to_rgb[] = {
198 0x0734, 0x04ad, 0x0000, 0x1c1b,
199 0x1ddc, 0x04ad, 0x1f24, 0x0135,
200 0x0000, 0x04ad, 0x087c, 0x1b77,
203 static void adv7511_set_config_csc(struct adv7511 *adv7511,
204 struct drm_connector *connector,
205 bool rgb, bool hdmi_mode)
207 struct adv7511_video_config config;
208 bool output_format_422, output_format_ycbcr;
210 uint8_t infoframe[17];
212 config.hdmi_mode = hdmi_mode;
214 hdmi_avi_infoframe_init(&config.avi_infoframe);
216 config.avi_infoframe.scan_mode = HDMI_SCAN_MODE_UNDERSCAN;
219 config.csc_enable = false;
220 config.avi_infoframe.colorspace = HDMI_COLORSPACE_RGB;
222 config.csc_scaling_factor = ADV7511_CSC_SCALING_4;
223 config.csc_coefficents = adv7511_csc_ycbcr_to_rgb;
225 if ((connector->display_info.color_formats &
226 DRM_COLOR_FORMAT_YCBCR422) &&
228 config.csc_enable = false;
229 config.avi_infoframe.colorspace =
230 HDMI_COLORSPACE_YUV422;
232 config.csc_enable = true;
233 config.avi_infoframe.colorspace = HDMI_COLORSPACE_RGB;
237 if (config.hdmi_mode) {
238 mode = ADV7511_HDMI_CFG_MODE_HDMI;
240 switch (config.avi_infoframe.colorspace) {
241 case HDMI_COLORSPACE_YUV444:
242 output_format_422 = false;
243 output_format_ycbcr = true;
245 case HDMI_COLORSPACE_YUV422:
246 output_format_422 = true;
247 output_format_ycbcr = true;
250 output_format_422 = false;
251 output_format_ycbcr = false;
255 mode = ADV7511_HDMI_CFG_MODE_DVI;
256 output_format_422 = false;
257 output_format_ycbcr = false;
260 adv7511_packet_disable(adv7511, ADV7511_PACKET_ENABLE_AVI_INFOFRAME);
262 adv7511_set_colormap(adv7511, config.csc_enable,
263 config.csc_coefficents,
264 config.csc_scaling_factor);
266 regmap_update_bits(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG1, 0x81,
267 (output_format_422 << 7) | output_format_ycbcr);
269 regmap_update_bits(adv7511->regmap, ADV7511_REG_HDCP_HDMI_CFG,
270 ADV7511_HDMI_CFG_MODE_MASK, mode);
272 hdmi_avi_infoframe_pack(&config.avi_infoframe, infoframe,
275 /* The AVI infoframe id is not configurable */
276 regmap_bulk_write(adv7511->regmap, ADV7511_REG_AVI_INFOFRAME_VERSION,
277 infoframe + 1, sizeof(infoframe) - 1);
279 adv7511_packet_enable(adv7511, ADV7511_PACKET_ENABLE_AVI_INFOFRAME);
282 static void adv7511_set_link_config(struct adv7511 *adv7511,
283 const struct adv7511_link_config *config)
286 * The input style values documented in the datasheet don't match the
287 * hardware register field values :-(
289 static const unsigned int input_styles[4] = { 0, 2, 1, 3 };
291 unsigned int clock_delay;
292 unsigned int color_depth;
293 unsigned int input_id;
295 clock_delay = (config->clock_delay + 1200) / 400;
296 color_depth = config->input_color_depth == 8 ? 3
297 : (config->input_color_depth == 10 ? 1 : 2);
299 /* TODO Support input ID 6 */
300 if (config->input_colorspace != HDMI_COLORSPACE_YUV422)
301 input_id = config->input_clock == ADV7511_INPUT_CLOCK_DDR
303 else if (config->input_clock == ADV7511_INPUT_CLOCK_DDR)
304 input_id = config->embedded_sync ? 8 : 7;
305 else if (config->input_clock == ADV7511_INPUT_CLOCK_2X)
306 input_id = config->embedded_sync ? 4 : 3;
308 input_id = config->embedded_sync ? 2 : 1;
310 regmap_update_bits(adv7511->regmap, ADV7511_REG_I2C_FREQ_ID_CFG, 0xf,
312 regmap_update_bits(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG1, 0x7e,
314 (input_styles[config->input_style] << 2));
315 regmap_write(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG2,
316 config->input_justification << 3);
317 regmap_write(adv7511->regmap, ADV7511_REG_TIMING_GEN_SEQ,
318 config->sync_pulse << 2);
320 regmap_write(adv7511->regmap, 0xba, clock_delay << 5);
322 adv7511->embedded_sync = config->embedded_sync;
323 adv7511->hsync_polarity = config->hsync_polarity;
324 adv7511->vsync_polarity = config->vsync_polarity;
325 adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB;
328 static void __adv7511_power_on(struct adv7511 *adv7511)
330 adv7511->current_edid_segment = -1;
332 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER,
333 ADV7511_POWER_POWER_DOWN, 0);
334 if (adv7511->i2c_main->irq) {
336 * Documentation says the INT_ENABLE registers are reset in
337 * POWER_DOWN mode. My 7511w preserved the bits, however.
338 * Still, let's be safe and stick to the documentation.
340 regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0),
341 ADV7511_INT0_EDID_READY | ADV7511_INT0_HPD);
342 regmap_update_bits(adv7511->regmap,
343 ADV7511_REG_INT_ENABLE(1),
344 ADV7511_INT1_DDC_ERROR,
345 ADV7511_INT1_DDC_ERROR);
349 * Per spec it is allowed to pulse the HPD signal to indicate that the
350 * EDID information has changed. Some monitors do this when they wakeup
351 * from standby or are enabled. When the HPD goes low the adv7511 is
352 * reset and the outputs are disabled which might cause the monitor to
353 * go to standby again. To avoid this we ignore the HPD pin for the
354 * first few seconds after enabling the output. On the other hand
355 * adv7535 require to enable HPD Override bit for proper HPD.
357 if (adv7511->info->hpd_override_enable)
358 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
359 ADV7535_REG_POWER2_HPD_OVERRIDE,
360 ADV7535_REG_POWER2_HPD_OVERRIDE);
362 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
363 ADV7511_REG_POWER2_HPD_SRC_MASK,
364 ADV7511_REG_POWER2_HPD_SRC_NONE);
367 static void adv7511_power_on(struct adv7511 *adv7511)
369 __adv7511_power_on(adv7511);
372 * Most of the registers are reset during power down or when HPD is low.
374 regcache_sync(adv7511->regmap);
376 if (adv7511->info->has_dsi)
377 adv7533_dsi_power_on(adv7511);
378 adv7511->powered = true;
381 static void __adv7511_power_off(struct adv7511 *adv7511)
383 /* TODO: setup additional power down modes */
384 if (adv7511->info->hpd_override_enable)
385 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
386 ADV7535_REG_POWER2_HPD_OVERRIDE, 0);
388 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER,
389 ADV7511_POWER_POWER_DOWN,
390 ADV7511_POWER_POWER_DOWN);
391 regmap_update_bits(adv7511->regmap,
392 ADV7511_REG_INT_ENABLE(1),
393 ADV7511_INT1_DDC_ERROR, 0);
394 regcache_mark_dirty(adv7511->regmap);
397 static void adv7511_power_off(struct adv7511 *adv7511)
399 __adv7511_power_off(adv7511);
400 if (adv7511->info->has_dsi)
401 adv7533_dsi_power_off(adv7511);
402 adv7511->powered = false;
405 /* -----------------------------------------------------------------------------
406 * Interrupt and hotplug detection
409 static bool adv7511_hpd(struct adv7511 *adv7511)
414 ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0);
418 if (irq0 & ADV7511_INT0_HPD) {
419 regmap_write(adv7511->regmap, ADV7511_REG_INT(0),
427 static void adv7511_hpd_work(struct work_struct *work)
429 struct adv7511 *adv7511 = container_of(work, struct adv7511, hpd_work);
430 enum drm_connector_status status;
434 ret = regmap_read(adv7511->regmap, ADV7511_REG_STATUS, &val);
436 status = connector_status_disconnected;
437 else if (val & ADV7511_STATUS_HPD)
438 status = connector_status_connected;
440 status = connector_status_disconnected;
443 * The bridge resets its registers on unplug. So when we get a plug
444 * event and we're already supposed to be powered, cycle the bridge to
447 if (status == connector_status_connected &&
448 adv7511->connector.status == connector_status_disconnected &&
450 regcache_mark_dirty(adv7511->regmap);
451 adv7511_power_on(adv7511);
454 if (adv7511->connector.status != status) {
455 adv7511->connector.status = status;
457 if (adv7511->connector.dev) {
458 if (status == connector_status_disconnected)
459 cec_phys_addr_invalidate(adv7511->cec_adap);
460 drm_kms_helper_hotplug_event(adv7511->connector.dev);
462 drm_bridge_hpd_notify(&adv7511->bridge, status);
467 static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd)
469 unsigned int irq0, irq1;
472 ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0);
476 ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(1), &irq1);
480 regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0);
481 regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1);
483 if (process_hpd && irq0 & ADV7511_INT0_HPD && adv7511->bridge.encoder)
484 schedule_work(&adv7511->hpd_work);
486 if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) {
487 adv7511->edid_read = true;
489 if (adv7511->i2c_main->irq)
490 wake_up_all(&adv7511->wq);
493 #ifdef CONFIG_DRM_I2C_ADV7511_CEC
494 adv7511_cec_irq_process(adv7511, irq1);
500 static irqreturn_t adv7511_irq_handler(int irq, void *devid)
502 struct adv7511 *adv7511 = devid;
505 ret = adv7511_irq_process(adv7511, true);
506 return ret < 0 ? IRQ_NONE : IRQ_HANDLED;
509 /* -----------------------------------------------------------------------------
513 static int adv7511_wait_for_edid(struct adv7511 *adv7511, int timeout)
517 if (adv7511->i2c_main->irq) {
518 ret = wait_event_interruptible_timeout(adv7511->wq,
519 adv7511->edid_read, msecs_to_jiffies(timeout));
521 for (; timeout > 0; timeout -= 25) {
522 ret = adv7511_irq_process(adv7511, false);
526 if (adv7511->edid_read)
533 return adv7511->edid_read ? 0 : -EIO;
536 static int adv7511_get_edid_block(void *data, u8 *buf, unsigned int block,
539 struct adv7511 *adv7511 = data;
540 struct i2c_msg xfer[2];
548 if (adv7511->current_edid_segment != block / 2) {
551 ret = regmap_read(adv7511->regmap, ADV7511_REG_DDC_STATUS,
557 adv7511->edid_read = false;
558 regmap_write(adv7511->regmap, ADV7511_REG_EDID_SEGMENT,
560 ret = adv7511_wait_for_edid(adv7511, 200);
565 /* Break this apart, hopefully more I2C controllers will
566 * support 64 byte transfers than 256 byte transfers
569 xfer[0].addr = adv7511->i2c_edid->addr;
572 xfer[0].buf = &offset;
573 xfer[1].addr = adv7511->i2c_edid->addr;
574 xfer[1].flags = I2C_M_RD;
576 xfer[1].buf = adv7511->edid_buf;
580 for (i = 0; i < 4; ++i) {
581 ret = i2c_transfer(adv7511->i2c_edid->adapter, xfer,
592 adv7511->current_edid_segment = block / 2;
596 memcpy(buf, adv7511->edid_buf, len);
598 memcpy(buf, adv7511->edid_buf + 128, len);
603 /* -----------------------------------------------------------------------------
607 static const struct drm_edid *adv7511_edid_read(struct adv7511 *adv7511,
608 struct drm_connector *connector)
610 const struct drm_edid *drm_edid;
612 /* Reading the EDID only works if the device is powered */
613 if (!adv7511->powered) {
614 unsigned int edid_i2c_addr =
615 (adv7511->i2c_edid->addr << 1);
617 __adv7511_power_on(adv7511);
619 /* Reset the EDID_I2C_ADDR register as it might be cleared */
620 regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR,
624 drm_edid = drm_edid_read_custom(connector, adv7511_get_edid_block, adv7511);
626 if (!adv7511->powered)
627 __adv7511_power_off(adv7511);
631 * FIXME: The CEC physical address should be set using
632 * cec_s_phys_addr(adap,
633 * connector->display_info.source_physical_address, false) from
634 * a path that has read the EDID and called
635 * drm_edid_connector_update().
637 const struct edid *edid = drm_edid_raw(drm_edid);
639 adv7511_set_config_csc(adv7511, connector, adv7511->rgb,
640 drm_detect_hdmi_monitor(edid));
642 cec_s_phys_addr_from_edid(adv7511->cec_adap, edid);
644 cec_s_phys_addr_from_edid(adv7511->cec_adap, NULL);
650 static int adv7511_get_modes(struct adv7511 *adv7511,
651 struct drm_connector *connector)
653 const struct drm_edid *drm_edid;
656 drm_edid = adv7511_edid_read(adv7511, connector);
658 drm_edid_connector_update(connector, drm_edid);
659 count = drm_edid_connector_add_modes(connector);
661 drm_edid_free(drm_edid);
666 static enum drm_connector_status
667 adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector)
669 enum drm_connector_status status;
674 ret = regmap_read(adv7511->regmap, ADV7511_REG_STATUS, &val);
676 return connector_status_disconnected;
678 if (val & ADV7511_STATUS_HPD)
679 status = connector_status_connected;
681 status = connector_status_disconnected;
683 hpd = adv7511_hpd(adv7511);
685 /* The chip resets itself when the cable is disconnected, so in case
686 * there is a pending HPD interrupt and the cable is connected there was
687 * at least one transition from disconnected to connected and the chip
688 * has to be reinitialized. */
689 if (status == connector_status_connected && hpd && adv7511->powered) {
690 regcache_mark_dirty(adv7511->regmap);
691 adv7511_power_on(adv7511);
693 adv7511_get_modes(adv7511, connector);
694 if (adv7511->status == connector_status_connected)
695 status = connector_status_disconnected;
697 /* Renable HPD sensing */
698 if (adv7511->info->hpd_override_enable)
699 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
700 ADV7535_REG_POWER2_HPD_OVERRIDE,
701 ADV7535_REG_POWER2_HPD_OVERRIDE);
703 regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
704 ADV7511_REG_POWER2_HPD_SRC_MASK,
705 ADV7511_REG_POWER2_HPD_SRC_BOTH);
708 adv7511->status = status;
712 static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511,
713 const struct drm_display_mode *mode)
715 if (mode->clock > 165000)
716 return MODE_CLOCK_HIGH;
721 static void adv7511_mode_set(struct adv7511 *adv7511,
722 const struct drm_display_mode *mode,
723 const struct drm_display_mode *adj_mode)
725 unsigned int low_refresh_rate;
726 unsigned int hsync_polarity = 0;
727 unsigned int vsync_polarity = 0;
729 if (adv7511->embedded_sync) {
730 unsigned int hsync_offset, hsync_len;
731 unsigned int vsync_offset, vsync_len;
733 hsync_offset = adj_mode->crtc_hsync_start -
734 adj_mode->crtc_hdisplay;
735 vsync_offset = adj_mode->crtc_vsync_start -
736 adj_mode->crtc_vdisplay;
737 hsync_len = adj_mode->crtc_hsync_end -
738 adj_mode->crtc_hsync_start;
739 vsync_len = adj_mode->crtc_vsync_end -
740 adj_mode->crtc_vsync_start;
742 /* The hardware vsync generator has a off-by-one bug */
745 regmap_write(adv7511->regmap, ADV7511_REG_HSYNC_PLACEMENT_MSB,
746 ((hsync_offset >> 10) & 0x7) << 5);
747 regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(0),
748 (hsync_offset >> 2) & 0xff);
749 regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(1),
750 ((hsync_offset & 0x3) << 6) |
751 ((hsync_len >> 4) & 0x3f));
752 regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(2),
753 ((hsync_len & 0xf) << 4) |
754 ((vsync_offset >> 6) & 0xf));
755 regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(3),
756 ((vsync_offset & 0x3f) << 2) |
757 ((vsync_len >> 8) & 0x3));
758 regmap_write(adv7511->regmap, ADV7511_REG_SYNC_DECODER(4),
761 hsync_polarity = !(adj_mode->flags & DRM_MODE_FLAG_PHSYNC);
762 vsync_polarity = !(adj_mode->flags & DRM_MODE_FLAG_PVSYNC);
764 enum adv7511_sync_polarity mode_hsync_polarity;
765 enum adv7511_sync_polarity mode_vsync_polarity;
768 * If the input signal is always low or always high we want to
769 * invert or let it passthrough depending on the polarity of the
772 if (adj_mode->flags & DRM_MODE_FLAG_NHSYNC)
773 mode_hsync_polarity = ADV7511_SYNC_POLARITY_LOW;
775 mode_hsync_polarity = ADV7511_SYNC_POLARITY_HIGH;
777 if (adj_mode->flags & DRM_MODE_FLAG_NVSYNC)
778 mode_vsync_polarity = ADV7511_SYNC_POLARITY_LOW;
780 mode_vsync_polarity = ADV7511_SYNC_POLARITY_HIGH;
782 if (adv7511->hsync_polarity != mode_hsync_polarity &&
783 adv7511->hsync_polarity !=
784 ADV7511_SYNC_POLARITY_PASSTHROUGH)
787 if (adv7511->vsync_polarity != mode_vsync_polarity &&
788 adv7511->vsync_polarity !=
789 ADV7511_SYNC_POLARITY_PASSTHROUGH)
793 if (drm_mode_vrefresh(mode) <= 24)
794 low_refresh_rate = ADV7511_LOW_REFRESH_RATE_24HZ;
795 else if (drm_mode_vrefresh(mode) <= 25)
796 low_refresh_rate = ADV7511_LOW_REFRESH_RATE_25HZ;
797 else if (drm_mode_vrefresh(mode) <= 30)
798 low_refresh_rate = ADV7511_LOW_REFRESH_RATE_30HZ;
800 low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
802 if (adv7511->info->type == ADV7511)
803 regmap_update_bits(adv7511->regmap, 0xfb,
804 0x6, low_refresh_rate << 1);
806 regmap_update_bits(adv7511->regmap, 0x4a,
807 0xc, low_refresh_rate << 2);
809 regmap_update_bits(adv7511->regmap, 0x17,
810 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
812 drm_mode_copy(&adv7511->curr_mode, adj_mode);
815 * TODO Test first order 4:2:2 to 4:4:4 up conversion method, which is
816 * supposed to give better results.
819 adv7511->f_tmds = mode->clock;
822 /* -----------------------------------------------------------------------------
823 * DRM Connector Operations
826 static struct adv7511 *connector_to_adv7511(struct drm_connector *connector)
828 return container_of(connector, struct adv7511, connector);
831 static int adv7511_connector_get_modes(struct drm_connector *connector)
833 struct adv7511 *adv = connector_to_adv7511(connector);
835 return adv7511_get_modes(adv, connector);
838 static enum drm_mode_status
839 adv7511_connector_mode_valid(struct drm_connector *connector,
840 struct drm_display_mode *mode)
842 struct adv7511 *adv = connector_to_adv7511(connector);
844 return adv7511_mode_valid(adv, mode);
847 static struct drm_connector_helper_funcs adv7511_connector_helper_funcs = {
848 .get_modes = adv7511_connector_get_modes,
849 .mode_valid = adv7511_connector_mode_valid,
852 static enum drm_connector_status
853 adv7511_connector_detect(struct drm_connector *connector, bool force)
855 struct adv7511 *adv = connector_to_adv7511(connector);
857 return adv7511_detect(adv, connector);
860 static const struct drm_connector_funcs adv7511_connector_funcs = {
861 .fill_modes = drm_helper_probe_single_connector_modes,
862 .detect = adv7511_connector_detect,
863 .destroy = drm_connector_cleanup,
864 .reset = drm_atomic_helper_connector_reset,
865 .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
866 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
869 static int adv7511_connector_init(struct adv7511 *adv)
871 struct drm_bridge *bridge = &adv->bridge;
874 if (!bridge->encoder) {
875 DRM_ERROR("Parent encoder object not found");
879 if (adv->i2c_main->irq)
880 adv->connector.polled = DRM_CONNECTOR_POLL_HPD;
882 adv->connector.polled = DRM_CONNECTOR_POLL_CONNECT |
883 DRM_CONNECTOR_POLL_DISCONNECT;
885 ret = drm_connector_init(bridge->dev, &adv->connector,
886 &adv7511_connector_funcs,
887 DRM_MODE_CONNECTOR_HDMIA);
889 DRM_ERROR("Failed to initialize connector with drm\n");
892 drm_connector_helper_add(&adv->connector,
893 &adv7511_connector_helper_funcs);
894 drm_connector_attach_encoder(&adv->connector, bridge->encoder);
899 /* -----------------------------------------------------------------------------
900 * DRM Bridge Operations
903 static struct adv7511 *bridge_to_adv7511(struct drm_bridge *bridge)
905 return container_of(bridge, struct adv7511, bridge);
908 static void adv7511_bridge_enable(struct drm_bridge *bridge)
910 struct adv7511 *adv = bridge_to_adv7511(bridge);
912 adv7511_power_on(adv);
915 static void adv7511_bridge_disable(struct drm_bridge *bridge)
917 struct adv7511 *adv = bridge_to_adv7511(bridge);
919 adv7511_power_off(adv);
922 static void adv7511_bridge_mode_set(struct drm_bridge *bridge,
923 const struct drm_display_mode *mode,
924 const struct drm_display_mode *adj_mode)
926 struct adv7511 *adv = bridge_to_adv7511(bridge);
928 adv7511_mode_set(adv, mode, adj_mode);
931 static enum drm_mode_status adv7511_bridge_mode_valid(struct drm_bridge *bridge,
932 const struct drm_display_info *info,
933 const struct drm_display_mode *mode)
935 struct adv7511 *adv = bridge_to_adv7511(bridge);
937 if (adv->info->has_dsi)
938 return adv7533_mode_valid(adv, mode);
940 return adv7511_mode_valid(adv, mode);
943 static int adv7511_bridge_attach(struct drm_bridge *bridge,
944 enum drm_bridge_attach_flags flags)
946 struct adv7511 *adv = bridge_to_adv7511(bridge);
949 if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
950 ret = adv7511_connector_init(adv);
955 if (adv->i2c_main->irq)
956 regmap_write(adv->regmap, ADV7511_REG_INT_ENABLE(0),
962 static enum drm_connector_status adv7511_bridge_detect(struct drm_bridge *bridge)
964 struct adv7511 *adv = bridge_to_adv7511(bridge);
966 return adv7511_detect(adv, NULL);
969 static const struct drm_edid *adv7511_bridge_edid_read(struct drm_bridge *bridge,
970 struct drm_connector *connector)
972 struct adv7511 *adv = bridge_to_adv7511(bridge);
974 return adv7511_edid_read(adv, connector);
977 static void adv7511_bridge_hpd_notify(struct drm_bridge *bridge,
978 enum drm_connector_status status)
980 struct adv7511 *adv = bridge_to_adv7511(bridge);
982 if (status == connector_status_disconnected)
983 cec_phys_addr_invalidate(adv->cec_adap);
986 static const struct drm_bridge_funcs adv7511_bridge_funcs = {
987 .enable = adv7511_bridge_enable,
988 .disable = adv7511_bridge_disable,
989 .mode_set = adv7511_bridge_mode_set,
990 .mode_valid = adv7511_bridge_mode_valid,
991 .attach = adv7511_bridge_attach,
992 .detect = adv7511_bridge_detect,
993 .edid_read = adv7511_bridge_edid_read,
994 .hpd_notify = adv7511_bridge_hpd_notify,
997 /* -----------------------------------------------------------------------------
1001 static const char * const adv7511_supply_names[] = {
1009 static const char * const adv7533_supply_names[] = {
1018 static int adv7511_init_regulators(struct adv7511 *adv)
1020 const char * const *supply_names = adv->info->supply_names;
1021 unsigned int num_supplies = adv->info->num_supplies;
1022 struct device *dev = &adv->i2c_main->dev;
1026 adv->supplies = devm_kcalloc(dev, num_supplies,
1027 sizeof(*adv->supplies), GFP_KERNEL);
1031 for (i = 0; i < num_supplies; i++)
1032 adv->supplies[i].supply = supply_names[i];
1034 ret = devm_regulator_bulk_get(dev, num_supplies, adv->supplies);
1038 return regulator_bulk_enable(num_supplies, adv->supplies);
1041 static void adv7511_uninit_regulators(struct adv7511 *adv)
1043 regulator_bulk_disable(adv->info->num_supplies, adv->supplies);
1046 static bool adv7511_cec_register_volatile(struct device *dev, unsigned int reg)
1048 struct i2c_client *i2c = to_i2c_client(dev);
1049 struct adv7511 *adv7511 = i2c_get_clientdata(i2c);
1051 reg -= adv7511->info->reg_cec_offset;
1054 case ADV7511_REG_CEC_RX1_FRAME_HDR:
1055 case ADV7511_REG_CEC_RX1_FRAME_DATA0 ... ADV7511_REG_CEC_RX1_FRAME_DATA0 + 14:
1056 case ADV7511_REG_CEC_RX1_FRAME_LEN:
1057 case ADV7511_REG_CEC_RX2_FRAME_HDR:
1058 case ADV7511_REG_CEC_RX2_FRAME_DATA0 ... ADV7511_REG_CEC_RX2_FRAME_DATA0 + 14:
1059 case ADV7511_REG_CEC_RX2_FRAME_LEN:
1060 case ADV7511_REG_CEC_RX3_FRAME_HDR:
1061 case ADV7511_REG_CEC_RX3_FRAME_DATA0 ... ADV7511_REG_CEC_RX3_FRAME_DATA0 + 14:
1062 case ADV7511_REG_CEC_RX3_FRAME_LEN:
1063 case ADV7511_REG_CEC_RX_STATUS:
1064 case ADV7511_REG_CEC_RX_BUFFERS:
1065 case ADV7511_REG_CEC_TX_LOW_DRV_CNT:
1072 static const struct regmap_config adv7511_cec_regmap_config = {
1076 .max_register = 0xff,
1077 .cache_type = REGCACHE_MAPLE,
1078 .volatile_reg = adv7511_cec_register_volatile,
1081 static int adv7511_init_cec_regmap(struct adv7511 *adv)
1085 adv->i2c_cec = i2c_new_ancillary_device(adv->i2c_main, "cec",
1086 ADV7511_CEC_I2C_ADDR_DEFAULT);
1087 if (IS_ERR(adv->i2c_cec))
1088 return PTR_ERR(adv->i2c_cec);
1090 regmap_write(adv->regmap, ADV7511_REG_CEC_I2C_ADDR,
1091 adv->i2c_cec->addr << 1);
1093 i2c_set_clientdata(adv->i2c_cec, adv);
1095 adv->regmap_cec = devm_regmap_init_i2c(adv->i2c_cec,
1096 &adv7511_cec_regmap_config);
1097 if (IS_ERR(adv->regmap_cec)) {
1098 ret = PTR_ERR(adv->regmap_cec);
1102 if (adv->info->reg_cec_offset == ADV7533_REG_CEC_OFFSET) {
1103 ret = adv7533_patch_cec_registers(adv);
1110 i2c_unregister_device(adv->i2c_cec);
1114 static int adv7511_parse_dt(struct device_node *np,
1115 struct adv7511_link_config *config)
1120 of_property_read_u32(np, "adi,input-depth", &config->input_color_depth);
1121 if (config->input_color_depth != 8 && config->input_color_depth != 10 &&
1122 config->input_color_depth != 12)
1125 ret = of_property_read_string(np, "adi,input-colorspace", &str);
1129 if (!strcmp(str, "rgb"))
1130 config->input_colorspace = HDMI_COLORSPACE_RGB;
1131 else if (!strcmp(str, "yuv422"))
1132 config->input_colorspace = HDMI_COLORSPACE_YUV422;
1133 else if (!strcmp(str, "yuv444"))
1134 config->input_colorspace = HDMI_COLORSPACE_YUV444;
1138 ret = of_property_read_string(np, "adi,input-clock", &str);
1142 if (!strcmp(str, "1x"))
1143 config->input_clock = ADV7511_INPUT_CLOCK_1X;
1144 else if (!strcmp(str, "2x"))
1145 config->input_clock = ADV7511_INPUT_CLOCK_2X;
1146 else if (!strcmp(str, "ddr"))
1147 config->input_clock = ADV7511_INPUT_CLOCK_DDR;
1151 if (config->input_colorspace == HDMI_COLORSPACE_YUV422 ||
1152 config->input_clock != ADV7511_INPUT_CLOCK_1X) {
1153 ret = of_property_read_u32(np, "adi,input-style",
1154 &config->input_style);
1158 if (config->input_style < 1 || config->input_style > 3)
1161 ret = of_property_read_string(np, "adi,input-justification",
1166 if (!strcmp(str, "left"))
1167 config->input_justification =
1168 ADV7511_INPUT_JUSTIFICATION_LEFT;
1169 else if (!strcmp(str, "evenly"))
1170 config->input_justification =
1171 ADV7511_INPUT_JUSTIFICATION_EVENLY;
1172 else if (!strcmp(str, "right"))
1173 config->input_justification =
1174 ADV7511_INPUT_JUSTIFICATION_RIGHT;
1179 config->input_style = 1;
1180 config->input_justification = ADV7511_INPUT_JUSTIFICATION_LEFT;
1183 of_property_read_u32(np, "adi,clock-delay", &config->clock_delay);
1184 if (config->clock_delay < -1200 || config->clock_delay > 1600)
1187 config->embedded_sync = of_property_read_bool(np, "adi,embedded-sync");
1189 /* Hardcode the sync pulse configurations for now. */
1190 config->sync_pulse = ADV7511_INPUT_SYNC_PULSE_NONE;
1191 config->vsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
1192 config->hsync_polarity = ADV7511_SYNC_POLARITY_PASSTHROUGH;
1197 static int adv7511_probe(struct i2c_client *i2c)
1199 struct adv7511_link_config link_config;
1200 struct adv7511 *adv7511;
1201 struct device *dev = &i2c->dev;
1208 adv7511 = devm_kzalloc(dev, sizeof(*adv7511), GFP_KERNEL);
1212 adv7511->i2c_main = i2c;
1213 adv7511->powered = false;
1214 adv7511->status = connector_status_disconnected;
1215 adv7511->info = i2c_get_match_data(i2c);
1217 memset(&link_config, 0, sizeof(link_config));
1219 if (adv7511->info->link_config)
1220 ret = adv7511_parse_dt(dev->of_node, &link_config);
1222 ret = adv7533_parse_dt(dev->of_node, adv7511);
1226 ret = adv7511_init_regulators(adv7511);
1228 return dev_err_probe(dev, ret, "failed to init regulators\n");
1231 * The power down GPIO is optional. If present, toggle it from active to
1232 * inactive to wake up the encoder.
1234 adv7511->gpio_pd = devm_gpiod_get_optional(dev, "pd", GPIOD_OUT_HIGH);
1235 if (IS_ERR(adv7511->gpio_pd)) {
1236 ret = PTR_ERR(adv7511->gpio_pd);
1237 goto uninit_regulators;
1240 if (adv7511->gpio_pd) {
1241 usleep_range(5000, 6000);
1242 gpiod_set_value_cansleep(adv7511->gpio_pd, 0);
1245 adv7511->regmap = devm_regmap_init_i2c(i2c, &adv7511_regmap_config);
1246 if (IS_ERR(adv7511->regmap)) {
1247 ret = PTR_ERR(adv7511->regmap);
1248 goto uninit_regulators;
1251 ret = regmap_read(adv7511->regmap, ADV7511_REG_CHIP_REVISION, &val);
1253 goto uninit_regulators;
1254 dev_dbg(dev, "Rev. %d\n", val);
1256 if (adv7511->info->type == ADV7511)
1257 ret = regmap_register_patch(adv7511->regmap,
1258 adv7511_fixed_registers,
1259 ARRAY_SIZE(adv7511_fixed_registers));
1261 ret = adv7533_patch_registers(adv7511);
1263 goto uninit_regulators;
1265 adv7511_packet_disable(adv7511, 0xffff);
1267 adv7511->i2c_edid = i2c_new_ancillary_device(i2c, "edid",
1268 ADV7511_EDID_I2C_ADDR_DEFAULT);
1269 if (IS_ERR(adv7511->i2c_edid)) {
1270 ret = PTR_ERR(adv7511->i2c_edid);
1271 goto uninit_regulators;
1274 regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR,
1275 adv7511->i2c_edid->addr << 1);
1277 adv7511->i2c_packet = i2c_new_ancillary_device(i2c, "packet",
1278 ADV7511_PACKET_I2C_ADDR_DEFAULT);
1279 if (IS_ERR(adv7511->i2c_packet)) {
1280 ret = PTR_ERR(adv7511->i2c_packet);
1281 goto err_i2c_unregister_edid;
1284 regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR,
1285 adv7511->i2c_packet->addr << 1);
1287 ret = adv7511_init_cec_regmap(adv7511);
1289 goto err_i2c_unregister_packet;
1291 INIT_WORK(&adv7511->hpd_work, adv7511_hpd_work);
1293 adv7511_power_off(adv7511);
1295 i2c_set_clientdata(i2c, adv7511);
1297 if (adv7511->info->link_config)
1298 adv7511_set_link_config(adv7511, &link_config);
1300 ret = adv7511_cec_init(dev, adv7511);
1302 goto err_unregister_cec;
1304 adv7511->bridge.funcs = &adv7511_bridge_funcs;
1305 adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
1306 if (adv7511->i2c_main->irq)
1307 adv7511->bridge.ops |= DRM_BRIDGE_OP_HPD;
1309 adv7511->bridge.of_node = dev->of_node;
1310 adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
1312 drm_bridge_add(&adv7511->bridge);
1314 adv7511_audio_init(dev, adv7511);
1317 init_waitqueue_head(&adv7511->wq);
1319 ret = devm_request_threaded_irq(dev, i2c->irq, NULL,
1320 adv7511_irq_handler,
1321 IRQF_ONESHOT, dev_name(dev),
1324 goto err_unregister_audio;
1327 if (adv7511->info->has_dsi) {
1328 ret = adv7533_attach_dsi(adv7511);
1330 goto err_unregister_audio;
1335 err_unregister_audio:
1336 adv7511_audio_exit(adv7511);
1337 drm_bridge_remove(&adv7511->bridge);
1339 cec_unregister_adapter(adv7511->cec_adap);
1340 i2c_unregister_device(adv7511->i2c_cec);
1341 clk_disable_unprepare(adv7511->cec_clk);
1342 err_i2c_unregister_packet:
1343 i2c_unregister_device(adv7511->i2c_packet);
1344 err_i2c_unregister_edid:
1345 i2c_unregister_device(adv7511->i2c_edid);
1347 adv7511_uninit_regulators(adv7511);
1352 static void adv7511_remove(struct i2c_client *i2c)
1354 struct adv7511 *adv7511 = i2c_get_clientdata(i2c);
1356 adv7511_uninit_regulators(adv7511);
1358 drm_bridge_remove(&adv7511->bridge);
1360 adv7511_audio_exit(adv7511);
1362 cec_unregister_adapter(adv7511->cec_adap);
1363 i2c_unregister_device(adv7511->i2c_cec);
1364 clk_disable_unprepare(adv7511->cec_clk);
1366 i2c_unregister_device(adv7511->i2c_packet);
1367 i2c_unregister_device(adv7511->i2c_edid);
1370 static const struct adv7511_chip_info adv7511_chip_info = {
1372 .supply_names = adv7511_supply_names,
1373 .num_supplies = ARRAY_SIZE(adv7511_supply_names),
1374 .link_config = true,
1377 static const struct adv7511_chip_info adv7533_chip_info = {
1379 .max_mode_clock_khz = 80000,
1380 .max_lane_freq_khz = 800000,
1381 .supply_names = adv7533_supply_names,
1382 .num_supplies = ARRAY_SIZE(adv7533_supply_names),
1383 .reg_cec_offset = ADV7533_REG_CEC_OFFSET,
1387 static const struct adv7511_chip_info adv7535_chip_info = {
1389 .max_mode_clock_khz = 148500,
1390 .max_lane_freq_khz = 891000,
1391 .supply_names = adv7533_supply_names,
1392 .num_supplies = ARRAY_SIZE(adv7533_supply_names),
1393 .reg_cec_offset = ADV7533_REG_CEC_OFFSET,
1395 .hpd_override_enable = true,
1398 static const struct i2c_device_id adv7511_i2c_ids[] = {
1399 { "adv7511", (kernel_ulong_t)&adv7511_chip_info },
1400 { "adv7511w", (kernel_ulong_t)&adv7511_chip_info },
1401 { "adv7513", (kernel_ulong_t)&adv7511_chip_info },
1402 { "adv7533", (kernel_ulong_t)&adv7533_chip_info },
1403 { "adv7535", (kernel_ulong_t)&adv7535_chip_info },
1406 MODULE_DEVICE_TABLE(i2c, adv7511_i2c_ids);
1408 static const struct of_device_id adv7511_of_ids[] = {
1409 { .compatible = "adi,adv7511", .data = &adv7511_chip_info },
1410 { .compatible = "adi,adv7511w", .data = &adv7511_chip_info },
1411 { .compatible = "adi,adv7513", .data = &adv7511_chip_info },
1412 { .compatible = "adi,adv7533", .data = &adv7533_chip_info },
1413 { .compatible = "adi,adv7535", .data = &adv7535_chip_info },
1416 MODULE_DEVICE_TABLE(of, adv7511_of_ids);
1418 static struct mipi_dsi_driver adv7533_dsi_driver = {
1419 .driver.name = "adv7533",
1422 static struct i2c_driver adv7511_driver = {
1425 .of_match_table = adv7511_of_ids,
1427 .id_table = adv7511_i2c_ids,
1428 .probe = adv7511_probe,
1429 .remove = adv7511_remove,
1432 static int __init adv7511_init(void)
1436 if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) {
1437 ret = mipi_dsi_driver_register(&adv7533_dsi_driver);
1442 ret = i2c_add_driver(&adv7511_driver);
1444 if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
1445 mipi_dsi_driver_unregister(&adv7533_dsi_driver);
1450 module_init(adv7511_init);
1452 static void __exit adv7511_exit(void)
1454 i2c_del_driver(&adv7511_driver);
1456 if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
1457 mipi_dsi_driver_unregister(&adv7533_dsi_driver);
1459 module_exit(adv7511_exit);
1461 MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
1462 MODULE_DESCRIPTION("ADV7511 HDMI transmitter driver");
1463 MODULE_LICENSE("GPL");