drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c

   1 /*
   2  * Copyright 2020 Advanced Micro Devices, Inc.
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice shall be included in
  12  * all copies or substantial portions of the Software.
  13  *
  14  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  15  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  16  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  17  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
  18  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
  19  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
  20  * OTHER DEALINGS IN THE SOFTWARE.
  21  */
  22
  23 #define SWSMU_CODE_LAYER_L4
  24
  25 #include "amdgpu.h"
  26 #include "amdgpu_smu.h"
  27 #include "smu_cmn.h"
  28 #include "soc15_common.h"
  29
  30 /*
  31  * DO NOT use these for err/warn/info/debug messages.
  32  * Use dev_err, dev_warn, dev_info and dev_dbg instead.
  33  * They are more MGPU friendly.
  34  */
  35 #undef pr_err
  36 #undef pr_warn
  37 #undef pr_info
  38 #undef pr_debug
  39
  40 /*
  41  * Although these are defined in each ASIC's specific header file.
  42  * They share the same definitions and values. That makes common
  43  * APIs for SMC messages issuing for all ASICs possible.
  44  */
  45 #define mmMP1_SMN_C2PMSG_66                                                                            0x0282
  46 #define mmMP1_SMN_C2PMSG_66_BASE_IDX                                                                   0
  47
  48 #define mmMP1_SMN_C2PMSG_82                                                                            0x0292
  49 #define mmMP1_SMN_C2PMSG_82_BASE_IDX                                                                   0
  50
  51 #define mmMP1_SMN_C2PMSG_90                                                                            0x029a
  52 #define mmMP1_SMN_C2PMSG_90_BASE_IDX                                                                   0
  53
  54 #define MP1_C2PMSG_90__CONTENT_MASK                                                                    0xFFFFFFFFL
  55
  56 #undef __SMU_DUMMY_MAP
  57 #define __SMU_DUMMY_MAP(type)   #type
  58 static const char* __smu_message_names[] = {
  59         SMU_MESSAGE_TYPES
  60 };
  61
  62 static const char *smu_get_message_name(struct smu_context *smu,
  63                                         enum smu_message_type type)
  64 {
  65         if (type < 0 || type >= SMU_MSG_MAX_COUNT)
  66                 return "unknown smu message";
  67
  68         return __smu_message_names[type];
  69 }
  70
  71 static void smu_cmn_send_msg_without_waiting(struct smu_context *smu,
  72                                              uint16_t msg)
  73 {
  74         struct amdgpu_device *adev = smu->adev;
  75
  76         WREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_66, msg);
  77 }
  78
  79 static void smu_cmn_read_arg(struct smu_context *smu,
  80                              uint32_t *arg)
  81 {
  82         struct amdgpu_device *adev = smu->adev;
  83
  84         *arg = RREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_82);
  85 }
  86
  87 static int smu_cmn_wait_for_response(struct smu_context *smu)
  88 {
  89         struct amdgpu_device *adev = smu->adev;
  90         uint32_t cur_value, i, timeout = adev->usec_timeout * 10;
  91
  92         for (i = 0; i < timeout; i++) {
  93                 cur_value = RREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_90);
  94                 if ((cur_value & MP1_C2PMSG_90__CONTENT_MASK) != 0)
  95                         return cur_value == 0x1 ? 0 : -EIO;
  96
  97                 udelay(1);
  98         }
  99
 100         /* timeout means wrong logic */
 101         if (i == timeout)
 102                 return -ETIME;
 103
 104         return RREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_90) == 0x1 ? 0 : -EIO;
 105 }
 106
 107 int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
 108                                     enum smu_message_type msg,
 109                                     uint32_t param,
 110                                     uint32_t *read_arg)
 111 {
 112         struct amdgpu_device *adev = smu->adev;
 113         int ret = 0, index = 0;
 114
 115         if (smu->adev->in_pci_err_recovery)
 116                 return 0;
 117
 118         index = smu_cmn_to_asic_specific_index(smu,
 119                                                CMN2ASIC_MAPPING_MSG,
 120                                                msg);
 121         if (index < 0)
 122                 return index == -EACCES ? 0 : index;
 123
 124         mutex_lock(&smu->message_lock);
 125         ret = smu_cmn_wait_for_response(smu);
 126         if (ret) {
 127                 dev_err(adev->dev, "Msg issuing pre-check failed and "
 128                        "SMU may be not in the right state!\n");
 129                 goto out;
 130         }
 131
 132         WREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_90, 0);
 133
 134         WREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_82, param);
 135
 136         smu_cmn_send_msg_without_waiting(smu, (uint16_t)index);
 137
 138         ret = smu_cmn_wait_for_response(smu);
 139         if (ret) {
 140                 dev_err(adev->dev, "failed send message: %10s (%d) \tparam: 0x%08x response %#x\n",
 141                        smu_get_message_name(smu, msg), index, param, ret);
 142                 goto out;
 143         }
 144
 145         if (read_arg)
 146                 smu_cmn_read_arg(smu, read_arg);
 147
 148 out:
 149         mutex_unlock(&smu->message_lock);
 150         return ret;
 151 }
 152
 153 int smu_cmn_send_smc_msg(struct smu_context *smu,
 154                          enum smu_message_type msg,
 155                          uint32_t *read_arg)
 156 {
 157         return smu_cmn_send_smc_msg_with_param(smu,
 158                                                msg,
 159                                                0,
 160                                                read_arg);
 161 }
 162
 163 int smu_cmn_to_asic_specific_index(struct smu_context *smu,
 164                                    enum smu_cmn2asic_mapping_type type,
 165                                    uint32_t index)
 166 {
 167         struct cmn2asic_msg_mapping msg_mapping;
 168         struct cmn2asic_mapping mapping;
 169
 170         switch (type) {
 171         case CMN2ASIC_MAPPING_MSG:
 172                 if (index >= SMU_MSG_MAX_COUNT ||
 173                     !smu->message_map)
 174                         return -EINVAL;
 175
 176                 msg_mapping = smu->message_map[index];
 177                 if (!msg_mapping.valid_mapping)
 178                         return -EINVAL;
 179
 180                 if (amdgpu_sriov_vf(smu->adev) &&
 181                     !msg_mapping.valid_in_vf)
 182                         return -EACCES;
 183
 184                 return msg_mapping.map_to;
 185
 186         case CMN2ASIC_MAPPING_CLK:
 187                 if (index >= SMU_CLK_COUNT ||
 188                     !smu->clock_map)
 189                         return -EINVAL;
 190
 191                 mapping = smu->clock_map[index];
 192                 if (!mapping.valid_mapping)
 193                         return -EINVAL;
 194
 195                 return mapping.map_to;
 196
 197         case CMN2ASIC_MAPPING_FEATURE:
 198                 if (index >= SMU_FEATURE_COUNT ||
 199                     !smu->feature_map)
 200                         return -EINVAL;
 201
 202                 mapping = smu->feature_map[index];
 203                 if (!mapping.valid_mapping)
 204                         return -EINVAL;
 205
 206                 return mapping.map_to;
 207
 208         case CMN2ASIC_MAPPING_TABLE:
 209                 if (index >= SMU_TABLE_COUNT ||
 210                     !smu->table_map)
 211                         return -EINVAL;
 212
 213                 mapping = smu->table_map[index];
 214                 if (!mapping.valid_mapping)
 215                         return -EINVAL;
 216
 217                 return mapping.map_to;
 218
 219         case CMN2ASIC_MAPPING_PWR:
 220                 if (index >= SMU_POWER_SOURCE_COUNT ||
 221                     !smu->pwr_src_map)
 222                         return -EINVAL;
 223
 224                 mapping = smu->pwr_src_map[index];
 225                 if (!mapping.valid_mapping)
 226                         return -EINVAL;
 227
 228                 return mapping.map_to;
 229
 230         case CMN2ASIC_MAPPING_WORKLOAD:
 231                 if (index > PP_SMC_POWER_PROFILE_CUSTOM ||
 232                     !smu->workload_map)
 233                         return -EINVAL;
 234
 235                 mapping = smu->workload_map[index];
 236                 if (!mapping.valid_mapping)
 237                         return -EINVAL;
 238
 239                 return mapping.map_to;
 240
 241         default:
 242                 return -EINVAL;
 243         }
 244 }
 245
 246 int smu_cmn_feature_is_supported(struct smu_context *smu,
 247                                  enum smu_feature_mask mask)
 248 {
 249         struct smu_feature *feature = &smu->smu_feature;
 250         int feature_id;
 251         int ret = 0;
 252
 253         feature_id = smu_cmn_to_asic_specific_index(smu,
 254                                                     CMN2ASIC_MAPPING_FEATURE,
 255                                                     mask);
 256         if (feature_id < 0)
 257                 return 0;
 258
 259         WARN_ON(feature_id > feature->feature_num);
 260
 261         mutex_lock(&feature->mutex);
 262         ret = test_bit(feature_id, feature->supported);
 263         mutex_unlock(&feature->mutex);
 264
 265         return ret;
 266 }
 267
 268 int smu_cmn_feature_is_enabled(struct smu_context *smu,
 269                                enum smu_feature_mask mask)
 270 {
 271         struct smu_feature *feature = &smu->smu_feature;
 272         int feature_id;
 273         int ret = 0;
 274
 275         if (smu->is_apu)
 276                 return 1;
 277         feature_id = smu_cmn_to_asic_specific_index(smu,
 278                                                     CMN2ASIC_MAPPING_FEATURE,
 279                                                     mask);
 280         if (feature_id < 0)
 281                 return 0;
 282
 283         WARN_ON(feature_id > feature->feature_num);
 284
 285         mutex_lock(&feature->mutex);
 286         ret = test_bit(feature_id, feature->enabled);
 287         mutex_unlock(&feature->mutex);
 288
 289         return ret;
 290 }
 291
 292 bool smu_cmn_clk_dpm_is_enabled(struct smu_context *smu,
 293                                 enum smu_clk_type clk_type)
 294 {
 295         enum smu_feature_mask feature_id = 0;
 296
 297         switch (clk_type) {
 298         case SMU_MCLK:
 299         case SMU_UCLK:
 300                 feature_id = SMU_FEATURE_DPM_UCLK_BIT;
 301                 break;
 302         case SMU_GFXCLK:
 303         case SMU_SCLK:
 304                 feature_id = SMU_FEATURE_DPM_GFXCLK_BIT;
 305                 break;
 306         case SMU_SOCCLK:
 307                 feature_id = SMU_FEATURE_DPM_SOCCLK_BIT;
 308                 break;
 309         default:
 310                 return true;
 311         }
 312
 313         if (!smu_cmn_feature_is_enabled(smu, feature_id))
 314                 return false;
 315
 316         return true;
 317 }
 318
 319 int smu_cmn_get_enabled_mask(struct smu_context *smu,
 320                              uint32_t *feature_mask,
 321                              uint32_t num)
 322 {
 323         uint32_t feature_mask_high = 0, feature_mask_low = 0;
 324         struct smu_feature *feature = &smu->smu_feature;
 325         int ret = 0;
 326
 327         if (!feature_mask || num < 2)
 328                 return -EINVAL;
 329
 330         if (bitmap_empty(feature->enabled, feature->feature_num)) {
 331                 ret = smu_cmn_send_smc_msg(smu, SMU_MSG_GetEnabledSmuFeaturesHigh, &feature_mask_high);
 332                 if (ret)
 333                         return ret;
 334
 335                 ret = smu_cmn_send_smc_msg(smu, SMU_MSG_GetEnabledSmuFeaturesLow, &feature_mask_low);
 336                 if (ret)
 337                         return ret;
 338
 339                 feature_mask[0] = feature_mask_low;
 340                 feature_mask[1] = feature_mask_high;
 341         } else {
 342                 bitmap_copy((unsigned long *)feature_mask, feature->enabled,
 343                              feature->feature_num);
 344         }
 345
 346         return ret;
 347 }
 348
 349 int smu_cmn_feature_update_enable_state(struct smu_context *smu,
 350                                         uint64_t feature_mask,
 351                                         bool enabled)
 352 {
 353         struct smu_feature *feature = &smu->smu_feature;
 354         int ret = 0;
 355
 356         if (enabled) {
 357                 ret = smu_cmn_send_smc_msg_with_param(smu,
 358                                                   SMU_MSG_EnableSmuFeaturesLow,
 359                                                   lower_32_bits(feature_mask),
 360                                                   NULL);
 361                 if (ret)
 362                         return ret;
 363                 ret = smu_cmn_send_smc_msg_with_param(smu,
 364                                                   SMU_MSG_EnableSmuFeaturesHigh,
 365                                                   upper_32_bits(feature_mask),
 366                                                   NULL);
 367                 if (ret)
 368                         return ret;
 369         } else {
 370                 ret = smu_cmn_send_smc_msg_with_param(smu,
 371                                                   SMU_MSG_DisableSmuFeaturesLow,
 372                                                   lower_32_bits(feature_mask),
 373                                                   NULL);
 374                 if (ret)
 375                         return ret;
 376                 ret = smu_cmn_send_smc_msg_with_param(smu,
 377                                                   SMU_MSG_DisableSmuFeaturesHigh,
 378                                                   upper_32_bits(feature_mask),
 379                                                   NULL);
 380                 if (ret)
 381                         return ret;
 382         }
 383
 384         mutex_lock(&feature->mutex);
 385         if (enabled)
 386                 bitmap_or(feature->enabled, feature->enabled,
 387                                 (unsigned long *)(&feature_mask), SMU_FEATURE_MAX);
 388         else
 389                 bitmap_andnot(feature->enabled, feature->enabled,
 390                                 (unsigned long *)(&feature_mask), SMU_FEATURE_MAX);
 391         mutex_unlock(&feature->mutex);
 392
 393         return ret;
 394 }
 395
 396 int smu_cmn_feature_set_enabled(struct smu_context *smu,
 397                                 enum smu_feature_mask mask,
 398                                 bool enable)
 399 {
 400         struct smu_feature *feature = &smu->smu_feature;
 401         int feature_id;
 402
 403         feature_id = smu_cmn_to_asic_specific_index(smu,
 404                                                     CMN2ASIC_MAPPING_FEATURE,
 405                                                     mask);
 406         if (feature_id < 0)
 407                 return -EINVAL;
 408
 409         WARN_ON(feature_id > feature->feature_num);
 410
 411         return smu_cmn_feature_update_enable_state(smu,
 412                                                1ULL << feature_id,
 413                                                enable);
 414 }
 415
 416 #undef __SMU_DUMMY_MAP
 417 #define __SMU_DUMMY_MAP(fea)    #fea
 418 static const char* __smu_feature_names[] = {
 419         SMU_FEATURE_MASKS
 420 };
 421
 422 static const char *smu_get_feature_name(struct smu_context *smu,
 423                                         enum smu_feature_mask feature)
 424 {
 425         if (feature < 0 || feature >= SMU_FEATURE_COUNT)
 426                 return "unknown smu feature";
 427         return __smu_feature_names[feature];
 428 }
 429
 430 size_t smu_cmn_get_pp_feature_mask(struct smu_context *smu,
 431                                    char *buf)
 432 {
 433         uint32_t feature_mask[2] = { 0 };
 434         int feature_index = 0;
 435         uint32_t count = 0;
 436         int8_t sort_feature[SMU_FEATURE_COUNT];
 437         size_t size = 0;
 438         int ret = 0, i;
 439
 440         ret = smu_cmn_get_enabled_mask(smu,
 441                                        feature_mask,
 442                                        2);
 443         if (ret)
 444                 return 0;
 445
 446         size =  sprintf(buf + size, "features high: 0x%08x low: 0x%08x\n",
 447                         feature_mask[1], feature_mask[0]);
 448
 449         memset(sort_feature, -1, sizeof(sort_feature));
 450
 451         for (i = 0; i < SMU_FEATURE_COUNT; i++) {
 452                 feature_index = smu_cmn_to_asic_specific_index(smu,
 453                                                                CMN2ASIC_MAPPING_FEATURE,
 454                                                                i);
 455                 if (feature_index < 0)
 456                         continue;
 457
 458                 sort_feature[feature_index] = i;
 459         }
 460
 461         size += sprintf(buf + size, "%-2s. %-20s  %-3s : %-s\n",
 462                         "No", "Feature", "Bit", "State");
 463
 464         for (i = 0; i < SMU_FEATURE_COUNT; i++) {
 465                 if (sort_feature[i] < 0)
 466                         continue;
 467
 468                 size += sprintf(buf + size, "%02d. %-20s (%2d) : %s\n",
 469                                 count++,
 470                                 smu_get_feature_name(smu, sort_feature[i]),
 471                                 i,
 472                                 !!smu_cmn_feature_is_enabled(smu, sort_feature[i]) ?
 473                                 "enabled" : "disabled");
 474         }
 475
 476         return size;
 477 }
 478
 479 int smu_cmn_set_pp_feature_mask(struct smu_context *smu,
 480                                 uint64_t new_mask)
 481 {
 482         int ret = 0;
 483         uint32_t feature_mask[2] = { 0 };
 484         uint64_t feature_2_enabled = 0;
 485         uint64_t feature_2_disabled = 0;
 486         uint64_t feature_enables = 0;
 487
 488         ret = smu_cmn_get_enabled_mask(smu,
 489                                        feature_mask,
 490                                        2);
 491         if (ret)
 492                 return ret;
 493
 494         feature_enables = ((uint64_t)feature_mask[1] << 32 |
 495                            (uint64_t)feature_mask[0]);
 496
 497         feature_2_enabled  = ~feature_enables & new_mask;
 498         feature_2_disabled = feature_enables & ~new_mask;
 499
 500         if (feature_2_enabled) {
 501                 ret = smu_cmn_feature_update_enable_state(smu,
 502                                                           feature_2_enabled,
 503                                                           true);
 504                 if (ret)
 505                         return ret;
 506         }
 507         if (feature_2_disabled) {
 508                 ret = smu_cmn_feature_update_enable_state(smu,
 509                                                           feature_2_disabled,
 510                                                           false);
 511                 if (ret)
 512                         return ret;
 513         }
 514
 515         return ret;
 516 }
 517
 518 int smu_cmn_disable_all_features_with_exception(struct smu_context *smu,
 519                                                 enum smu_feature_mask mask)
 520 {
 521         uint64_t features_to_disable = U64_MAX;
 522         int skipped_feature_id;
 523
 524         skipped_feature_id = smu_cmn_to_asic_specific_index(smu,
 525                                                             CMN2ASIC_MAPPING_FEATURE,
 526                                                             mask);
 527         if (skipped_feature_id < 0)
 528                 return -EINVAL;
 529
 530         features_to_disable &= ~(1ULL << skipped_feature_id);
 531
 532         return smu_cmn_feature_update_enable_state(smu,
 533                                                    features_to_disable,
 534                                                    0);
 535 }
 536
 537 int smu_cmn_get_smc_version(struct smu_context *smu,
 538                             uint32_t *if_version,
 539                             uint32_t *smu_version)
 540 {
 541         int ret = 0;
 542
 543         if (!if_version && !smu_version)
 544                 return -EINVAL;
 545
 546         if (smu->smc_fw_if_version && smu->smc_fw_version)
 547         {
 548                 if (if_version)
 549                         *if_version = smu->smc_fw_if_version;
 550
 551                 if (smu_version)
 552                         *smu_version = smu->smc_fw_version;
 553
 554                 return 0;
 555         }
 556
 557         if (if_version) {
 558                 ret = smu_cmn_send_smc_msg(smu, SMU_MSG_GetDriverIfVersion, if_version);
 559                 if (ret)
 560                         return ret;
 561
 562                 smu->smc_fw_if_version = *if_version;
 563         }
 564
 565         if (smu_version) {
 566                 ret = smu_cmn_send_smc_msg(smu, SMU_MSG_GetSmuVersion, smu_version);
 567                 if (ret)
 568                         return ret;
 569
 570                 smu->smc_fw_version = *smu_version;
 571         }
 572
 573         return ret;
 574 }
 575
 576 int smu_cmn_update_table(struct smu_context *smu,
 577                          enum smu_table_id table_index,
 578                          int argument,
 579                          void *table_data,
 580                          bool drv2smu)
 581 {
 582         struct smu_table_context *smu_table = &smu->smu_table;
 583         struct amdgpu_device *adev = smu->adev;
 584         struct smu_table *table = &smu_table->driver_table;
 585         int table_id = smu_cmn_to_asic_specific_index(smu,
 586                                                       CMN2ASIC_MAPPING_TABLE,
 587                                                       table_index);
 588         uint32_t table_size;
 589         int ret = 0;
 590         if (!table_data || table_id >= SMU_TABLE_COUNT || table_id < 0)
 591                 return -EINVAL;
 592
 593         table_size = smu_table->tables[table_index].size;
 594
 595         if (drv2smu) {
 596                 memcpy(table->cpu_addr, table_data, table_size);
 597                 /*
 598                  * Flush hdp cache: to guard the content seen by
 599                  * GPU is consitent with CPU.
 600                  */
 601                 amdgpu_asic_flush_hdp(adev, NULL);
 602         }
 603
 604         ret = smu_cmn_send_smc_msg_with_param(smu, drv2smu ?
 605                                           SMU_MSG_TransferTableDram2Smu :
 606                                           SMU_MSG_TransferTableSmu2Dram,
 607                                           table_id | ((argument & 0xFFFF) << 16),
 608                                           NULL);
 609         if (ret)
 610                 return ret;
 611
 612         if (!drv2smu) {
 613                 amdgpu_asic_flush_hdp(adev, NULL);
 614                 memcpy(table_data, table->cpu_addr, table_size);
 615         }
 616
 617         return 0;
 618 }
 619
 620 int smu_cmn_write_watermarks_table(struct smu_context *smu)
 621 {
 622         void *watermarks_table = smu->smu_table.watermarks_table;
 623
 624         if (!watermarks_table)
 625                 return -EINVAL;
 626
 627         return smu_cmn_update_table(smu,
 628                                     SMU_TABLE_WATERMARKS,
 629                                     0,
 630                                     watermarks_table,
 631                                     true);
 632 }
 633
 634 int smu_cmn_write_pptable(struct smu_context *smu)
 635 {
 636         void *pptable = smu->smu_table.driver_pptable;
 637
 638         return smu_cmn_update_table(smu,
 639                                     SMU_TABLE_PPTABLE,
 640                                     0,
 641                                     pptable,
 642                                     true);
 643 }
 644
 645 int smu_cmn_get_metrics_table_locked(struct smu_context *smu,
 646                                      void *metrics_table,
 647                                      bool bypass_cache)
 648 {
 649         struct smu_table_context *smu_table= &smu->smu_table;
 650         uint32_t table_size =
 651                 smu_table->tables[SMU_TABLE_SMU_METRICS].size;
 652         int ret = 0;
 653
 654         if (bypass_cache ||
 655             !smu_table->metrics_time ||
 656             time_after(jiffies, smu_table->metrics_time + msecs_to_jiffies(1))) {
 657                 ret = smu_cmn_update_table(smu,
 658                                        SMU_TABLE_SMU_METRICS,
 659                                        0,
 660                                        smu_table->metrics_table,
 661                                        false);
 662                 if (ret) {
 663                         dev_info(smu->adev->dev, "Failed to export SMU metrics table!\n");
 664                         return ret;
 665                 }
 666                 smu_table->metrics_time = jiffies;
 667         }
 668
 669         if (metrics_table)
 670                 memcpy(metrics_table, smu_table->metrics_table, table_size);
 671
 672         return 0;
 673 }
 674
 675 int smu_cmn_get_metrics_table(struct smu_context *smu,
 676                               void *metrics_table,
 677                               bool bypass_cache)
 678 {
 679         int ret = 0;
 680
 681         mutex_lock(&smu->metrics_lock);
 682         ret = smu_cmn_get_metrics_table_locked(smu,
 683                                                metrics_table,
 684                                                bypass_cache);
 685         mutex_unlock(&smu->metrics_lock);
 686
 687         return ret;
 688 }